From: "Theodore Ts'o" <tytso@mit.edu>
To: "Andrew G. Morgan" <morgan@kernel.org>
Cc: "Cristian Rodríguez" <crrodriguez@opensuse.org>,
"xuyang2018.jy@fujitsu.com" <xuyang2018.jy@fujitsu.com>,
"Florian Weimer" <fweimer@redhat.com>,
"libc-alpha@sourceware.org" <libc-alpha@sourceware.org>,
"fstests@vger.kernel.org" <fstests@vger.kernel.org>
Subject: Re: [PATCH] src/ext4_resize.c: set errno to 0 before the strtoull call
Date: Wed, 19 Jan 2022 15:13:18 -0500 [thread overview]
Message-ID: <Yehw3pm/+2B7JKxR@mit.edu> (raw)
In-Reply-To: <CALQRfL4wBQc_tT3b8daivFh7nxad0kfhG7MM2Nx=_nHJ-myphQ@mail.gmail.com>
On Wed, Jan 19, 2022 at 06:50:41AM -0800, Andrew G. Morgan wrote:
> Thanks for finding this.
>
> Fixed in:
>
> https://git.kernel.org/pub/scm/libs/libcap/libcap.git/commit/?id=f25a1b7e69f7b33e6afb58b3e38f3450b7d2d9a0
Thanks!
FWIW, I agree that we should not have depended on it being initialized
to zero at the beginning program. It was just wierd since it wasn't,
and I was wondering if it was some exotic (musl, dietlibc) C library
that was triggering it --- and then was surprised when it turned out
to be glibc.
The Jon Postel principle of "Be conservaive in what you send, and
liberal in what you accept" is good one to follow, so while it's nice
to some userspace programs that might not be as well-behaved as to not
depend on the status of errno when main() is called, we should fix the
calling program in xfstests as well.
Cheers,
- Ted
next prev parent reply other threads:[~2022-01-19 20:13 UTC|newest]
Thread overview: 21+ messages / expand[flat|nested] mbox.gz Atom feed top
[not found] <1642405014-3287-1-git-send-email-xuyang2018.jy@fujitsu.com>
[not found] ` <YeYmzJG5M0y9BcMc@mit.edu>
[not found] ` <61E6298D.80006@fujitsu.com>
[not found] ` <YeY6Uh8I7RlsCicw@mit.edu>
2022-01-18 5:27 ` xuyang2018.jy
2022-01-18 11:23 ` Adhemerval Zanella
2022-01-18 11:26 ` Florian Weimer
2022-01-18 11:49 ` Adhemerval Zanella
2022-01-18 12:00 ` Florian Weimer
2022-01-18 12:04 ` Andreas Schwab
2022-01-18 12:26 ` Adhemerval Zanella
2022-01-18 14:02 ` Florian Weimer
2022-01-19 6:14 ` xuyang2018.jy
2022-01-19 7:19 ` xuyang2018.jy
2022-01-19 13:57 ` Cristian Rodríguez
2022-01-19 14:07 ` Cristian Rodríguez
2022-01-19 14:50 ` Andrew G. Morgan
2022-01-19 20:13 ` Theodore Ts'o [this message]
2022-01-18 14:22 ` Andreas Schwab
2022-01-18 14:29 ` H.J. Lu
2022-01-18 14:43 ` Yann Droneaud
2022-01-18 14:54 ` H.J. Lu
2022-01-18 15:30 ` Andreas Schwab
2022-01-19 2:07 ` xuyang2018.jy
2022-01-19 8:23 ` Andreas Schwab
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=Yehw3pm/+2B7JKxR@mit.edu \
--to=tytso@mit.edu \
--cc=crrodriguez@opensuse.org \
--cc=fstests@vger.kernel.org \
--cc=fweimer@redhat.com \
--cc=libc-alpha@sourceware.org \
--cc=morgan@kernel.org \
--cc=xuyang2018.jy@fujitsu.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).