From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mail-pj1-x102d.google.com (mail-pj1-x102d.google.com [IPv6:2607:f8b0:4864:20::102d]) by sourceware.org (Postfix) with ESMTPS id 43E9C3864821 for ; Sat, 29 Jan 2022 01:24:17 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.4.1 sourceware.org 43E9C3864821 Received: by mail-pj1-x102d.google.com with SMTP id h12so8110172pjq.3 for ; Fri, 28 Jan 2022 17:24:17 -0800 (PST) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=x-gm-message-state:date:from:to:cc:subject:message-id:references :mime-version:content-disposition:in-reply-to; bh=FRaSuk8mJLoRXbzpVN5KDIBGeoVMMly/DxOOVS4+oXo=; b=0pyJVKEuDyyek9L7KD6ARWK3icqXdWHfBi7JvyFThdI/9ayRQBpGGjNbGpo3yOmGJH yEl6+LoZszROlVG5DRcKZBSE2XFz3KlviBE+95ZMA4QluaBP90wuQMNC4LOKgsmz4kY3 Tg8AgJUqNuiyXPJ8FR9kMgxJnTJ5GBzWVMZm2GaNw8QVfT5C23JxxVoW1QaxVwVZkcJC 5r0/cfFTm9+lYBpUREacMwT29uiq1oFV+US9XJ8Dtg+Ux1m83r4FIc/cVJuzuVz4kMF1 r/90sElirozvq7xArRKjP6BjDPac4knzC2FDqSuTkMwl4InM5+4sjuQtBQk+1gcOAy51 KxQA== X-Gm-Message-State: AOAM531p/OpWm9KwMXbS+o+J2WTPKyO2SocmFlEjMehrGMbHdeaBoa50 SUbhe6BZcYAnWYEcqg0fLC6MlI1BWjk= X-Google-Smtp-Source: ABdhPJzJAYRsd513sQO+TaMzJttSXO5qXmuotLPZlenfPSRjOR6KyQFD8GFzuUaVOCX+L81yiFHpmA== X-Received: by 2002:a17:90b:4b0a:: with SMTP id lx10mr12914168pjb.16.1643419456337; Fri, 28 Jan 2022 17:24:16 -0800 (PST) Received: from squeak.grove.modra.org (158.106.96.58.static.exetel.com.au. [58.96.106.158]) by smtp.gmail.com with ESMTPSA id b22sm11036011pfl.121.2022.01.28.17.24.14 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Fri, 28 Jan 2022 17:24:15 -0800 (PST) Received: by squeak.grove.modra.org (Postfix, from userid 1000) id 91F861140AB2; Sat, 29 Jan 2022 11:54:12 +1030 (ACDT) Date: Sat, 29 Jan 2022 11:54:12 +1030 From: Alan Modra To: Paul E Murphy Cc: libc-alpha@sourceware.org, Tulio Magno Quites Machado Filho Subject: Re: [PowerPC64] Use medium model toc accesses throughout Message-ID: References: <5a44c0d1-9cbd-aac8-e60a-3627e58b023b@linux.ibm.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <5a44c0d1-9cbd-aac8-e60a-3627e58b023b@linux.ibm.com> X-Spam-Status: No, score=-3032.0 required=5.0 tests=BAYES_00, DKIM_SIGNED, DKIM_VALID, DKIM_VALID_AU, DKIM_VALID_EF, FREEMAIL_FROM, RCVD_IN_DNSWL_NONE, SPF_HELO_NONE, SPF_PASS, TXREP, T_SCC_BODY_TEXT_LINE autolearn=ham autolearn_force=no version=3.4.4 X-Spam-Checker-Version: SpamAssassin 3.4.4 (2020-01-24) on server2.sourceware.org X-BeenThere: libc-alpha@sourceware.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Libc-alpha mailing list List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Sat, 29 Jan 2022 01:24:18 -0000 On Fri, Jan 28, 2022 at 11:48:44AM -0600, Paul E Murphy wrote: > > --- a/sysdeps/powerpc/powerpc64/dl-trampoline.S > > +++ b/sysdeps/powerpc/powerpc64/dl-trampoline.S > > @@ -32,6 +32,7 @@ > > because gcc as of 2010/05 doesn't allocate a proper stack frame for > > a function that makes no calls except for __tls_get_addr and we > > might be here resolving the __tls_get_addr call. */ > > + .hidden _dl_runtime_resolve > > #define INT_PARMS FRAME_MIN_SIZE > > ENTRY (_dl_runtime_resolve, 4) > > stdu r1,-FRAME_SIZE(r1) > > @@ -195,6 +196,7 @@ END(_dl_runtime_resolve) > > parm1 (r3) and the index (r0) needs to be converted to an offset > > (index * 24) in parm2 (r4). */ > > #ifndef PROF > > + .hidden _dl_profile_resolve > > ENTRY (_dl_profile_resolve, 4) > > /* Spill r30, r31 to preserve the link_map* and reloc_addr, in case we > > need to call _dl_audit_pltexit. */ > > LGTM (this should wait until after the freeze), though these two changes > seem orthogonal to the commit title. True. It could have been a separate patch. > For my education, why are are small model accesses used in these files? dl-trampoline.S is an old file, from before the linker edited toc-indirect code to toc-pointer relative. Without the link editing small model is more efficient if the toc is small enough. -- Alan Modra Australia Development Lab, IBM