From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <vapier@gentoo.org>
Received: from smtp.gentoo.org (smtp.gentoo.org
 [IPv6:2001:470:ea4a:1:5054:ff:fec7:86e4])
 by sourceware.org (Postfix) with ESMTP id B87FB386EC52
 for <libc-alpha@sourceware.org>; Wed, 23 Mar 2022 01:53:44 +0000 (GMT)
DMARC-Filter: OpenDMARC Filter v1.4.1 sourceware.org B87FB386EC52
Received: by smtp.gentoo.org (Postfix, from userid 559)
 id 1E0AD342CB7; Wed, 23 Mar 2022 01:53:44 +0000 (UTC)
Date: Tue, 22 Mar 2022 21:53:55 -0400
From: Mike Frysinger <vapier@gentoo.org>
To: Sam James <sam@gentoo.org>
Cc: libc-alpha@sourceware.org
Subject: Re: [PATCH v3] configure.ac: fix bashisms in configure.ac
Message-ID: <Yjp9szjH7LPaVifB@vapier>
Mail-Followup-To: Sam James <sam@gentoo.org>, libc-alpha@sourceware.org
References: <20220321230343.2582331-1-sam@gentoo.org>
 <20220322173309.2024872-1-sam@gentoo.org>
MIME-Version: 1.0
Content-Type: multipart/signed; micalg=pgp-sha256;
 protocol="application/pgp-signature"; boundary="XdB552ohdiUDYlBq"
Content-Disposition: inline
In-Reply-To: <20220322173309.2024872-1-sam@gentoo.org>
X-Spam-Status: No, score=-5.6 required=5.0 tests=BAYES_00, KAM_DMARC_STATUS,
 SPF_HELO_PASS, SPF_PASS, TXREP,
 T_SCC_BODY_TEXT_LINE autolearn=ham autolearn_force=no version=3.4.4
X-Spam-Checker-Version: SpamAssassin 3.4.4 (2020-01-24) on
 server2.sourceware.org
X-BeenThere: libc-alpha@sourceware.org
X-Mailman-Version: 2.1.29
Precedence: list
List-Id: Libc-alpha mailing list <libc-alpha.sourceware.org>
List-Unsubscribe: <https://sourceware.org/mailman/options/libc-alpha>,
 <mailto:libc-alpha-request@sourceware.org?subject=unsubscribe>
List-Archive: <https://sourceware.org/pipermail/libc-alpha/>
List-Post: <mailto:libc-alpha@sourceware.org>
List-Help: <mailto:libc-alpha-request@sourceware.org?subject=help>
List-Subscribe: <https://sourceware.org/mailman/listinfo/libc-alpha>,
 <mailto:libc-alpha-request@sourceware.org?subject=subscribe>
X-List-Received-Date: Wed, 23 Mar 2022 01:53:48 -0000


--XdB552ohdiUDYlBq
Content-Type: text/plain; charset=utf-8
Content-Disposition: inline
Content-Transfer-Encoding: quoted-printable

On 22 Mar 2022 17:33, Sam James via Libc-alpha wrote:
> configure scripts need to be runnable with a POSIX-compliant /bin/sh.
>=20
> On many (but not all!) systems, /bin/sh is provided by Bash, so errors
> like this aren't spotted. Notably Debian defaults to /bin/sh provided
> by dash which doesn't tolerate such bashisms as '=3D=3D'.
>=20
> This retains compatibility with bash.
>=20
> Fixes configure warnings/errors like:
> ```
> checking if compiler warns about alias for function with incompatible typ=
es... yes
> /var/tmp/portage/sys-libs/glibc-2.34-r10/work/glibc-2.34/configure: 4209:=
 test: xyes: unexpected operator
> ```

lgtm, pushed!
-mike

--XdB552ohdiUDYlBq
Content-Type: application/pgp-signature; name="signature.asc"

-----BEGIN PGP SIGNATURE-----

iQIzBAABCAAdFiEEuQK1JxMl+JKsJRrUQWM7n+g39YEFAmI6fbMACgkQQWM7n+g3
9YFiLQ//U+ikUjo7LCEFwNtxYimlKZpJ2ZfAMX7dcikH4K3ZtYnGWn3tPuB6YYU5
LQCowpnNgTPLn9mmqciGyCdFfuBGFNGPBjrjlCWANaoMYu5hVcR1D1b/wQvWkftV
t0UWk+FrKsw1Ypa815Wx8B/W3z/qritUxPS6/6M/MQWYJ5Mj9ut0z8Q6WgtzHI7F
nMRiJWD+eK36F9P5P0V+ycvU6B/yQxwB6dutb1Jaq+21HFtbhjXQ7JU3mKDr3raS
JamoHnhf0JPvKdlohUn15ERF8ovCkz26qxGG1CmDWAfm3FM7pEXVPLtc+VRZJ7N5
p8E8dGXXpcLNIfJsRfI6h+RJVdqJ9i9zLeM49pJsGfq5I80xN1PAEghIy/wIzjPf
ftf8q/RVTN3ubXit9mlKEMOL72p5H5QdbWIJtGFwMTKB1Y3NaWU4VJKRm79EnhSZ
wtXNsyyk2kByRLHlfv4NUnZjtLxn7nOKbWsDnXyNiNh8x1Sza4QLL7xhSkcUgQ3u
BKriF3uGQ9Ww2WLmRafJNR3wghTt4MKv1oTD6iOE/lI765cpeMNwBxLtAd8JERyT
eRZzgO3Ob9O61mRZoHEn9vpnftiCACbwaBECcOHR5yJ0zhagnooZiFTY1kQh5R6k
dT/3XBwwRarALbLWdXqKyWoYxFiOwbo8uTwMLdHcCJMnkGilEiw=
=22vJ
-----END PGP SIGNATURE-----

--XdB552ohdiUDYlBq--