From: Szabolcs Nagy <szabolcs.nagy@arm.com>
To: Fangrui Song <maskray@google.com>
Cc: libc-alpha@sourceware.org, Florian Weimer <fweimer@redhat.com>
Subject: Re: [PATCH] elf: Simplify _dl_aux_init with inhibit_loop_to_libcall
Date: Thu, 31 Mar 2022 08:56:06 +0000 [thread overview]
Message-ID: <YkVspqyAYRm1H5jj@arm.com> (raw)
In-Reply-To: <20220330041104.931987-1-maskray@google.com>
The 03/29/2022 21:11, Fangrui Song wrote:
> +/* Inhibit memset for auxv_values initialization because memset may not
> + be available yet. */
> +inhibit_loop_to_libcall
> void
> _dl_aux_init (ElfW(auxv_t) *av)
> {
> @@ -254,11 +257,7 @@ _dl_aux_init (ElfW(auxv_t) *av)
> #endif
>
> _dl_auxv = av;
> - dl_parse_auxv_t auxv_values;
> - /* Use an explicit initialization loop here because memset may not
> - be available yet. */
> - for (int i = 0; i < array_length (auxv_values); ++i)
> - auxv_values[i] = 0;
> + dl_parse_auxv_t auxv_values = { 0 };
> _dl_parse_auxv (av, auxv_values);
this does not work for me
https://godbolt.org/z/s49TMP3z7
prev parent reply other threads:[~2022-03-31 8:57 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-03-30 4:11 Fangrui Song
2022-03-31 8:56 ` Szabolcs Nagy [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=YkVspqyAYRm1H5jj@arm.com \
--to=szabolcs.nagy@arm.com \
--cc=fweimer@redhat.com \
--cc=libc-alpha@sourceware.org \
--cc=maskray@google.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).