From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mail-pg1-x536.google.com (mail-pg1-x536.google.com [IPv6:2607:f8b0:4864:20::536]) by sourceware.org (Postfix) with ESMTPS id 358F83858C83 for ; Thu, 14 Apr 2022 00:34:04 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.4.1 sourceware.org 358F83858C83 Received: by mail-pg1-x536.google.com with SMTP id t13so3310648pgn.8 for ; Wed, 13 Apr 2022 17:34:04 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=x-gm-message-state:date:from:to:cc:subject:message-id:references :mime-version:content-disposition:in-reply-to; bh=i+dBPTyyYZ/3nLy4TeEd0P0xPbUBiuM/cBvZ1r+sZvM=; b=qA+d7Uoh9WxiTd94xgO+WbgcvjGh5sw75uP7GAjK0Xc6VTtvXqja0wL0+0NGtENaqd lu3nzGAvMsJieGKKbIuK7ubed/MmPoHIC6HwPRmHf+4cj0tPfF4ak07TzmqLX6Tu928Z j3G98Z2f/vrUrly7dng4JiUoAeI4dwVZ++vc6YdTpdRQMA2HB4X72LeRe63XTOEs3v5I ndsX4iX2eTmVdaOiXvxoKExu1BSvzYRjzBDlvJtNmIxvUD6YywqVjsfDnLvBm+TxUCKU 51pBYJW8Hi/cuNl+HwLgAPr5f33q7DDW3sBq7+nHg7QSVApg7Vf+iSwQtW9jiOcr03hN 5R1w== X-Gm-Message-State: AOAM53214qoJROp7r/UAma+zDQcyaJQfhtyWQ04ehQ9cIbcobEg62W9n IL4zIF8TSsevmAyZ8lHRv8tdQaqghg0= X-Google-Smtp-Source: ABdhPJzPRDAM9hVW9FrNna3ZyJfQnsrX8ZmTcohgQIX9GQE2HL4HKUVA+IkjORiNAx74FLBys1eQgA== X-Received: by 2002:a05:6a00:2444:b0:4fd:db81:cbdd with SMTP id d4-20020a056a00244400b004fddb81cbddmr12387710pfj.32.1649896443157; Wed, 13 Apr 2022 17:34:03 -0700 (PDT) Received: from squeak.grove.modra.org ([2406:3400:51d:8cc0:a6d4:68dc:d4c1:1be6]) by smtp.gmail.com with ESMTPSA id a67-20020a621a46000000b005060c73ef43sm231460pfa.195.2022.04.13.17.34.01 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Wed, 13 Apr 2022 17:34:02 -0700 (PDT) Received: by squeak.grove.modra.org (Postfix, from userid 1000) id 6EB9D1142F9D; Thu, 14 Apr 2022 10:03:59 +0930 (ACST) Date: Thu, 14 Apr 2022 10:03:59 +0930 From: Alan Modra To: Fangrui Song , "H.J. Lu" Cc: libc-alpha@sourceware.org, Tulio Magno Quites Machado Filho Subject: Re: [PATCH v2 0/4] PowerPC64 static-pie Message-ID: References: <20220228064052.3413334-1-amodra@gmail.com> <20220409001412.ezhmy7i2sqq7t256@google.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20220409001412.ezhmy7i2sqq7t256@google.com> X-Spam-Status: No, score=-3028.4 required=5.0 tests=BAYES_00, DKIM_SIGNED, DKIM_VALID, DKIM_VALID_AU, DKIM_VALID_EF, FREEMAIL_FROM, RCVD_IN_DNSWL_NONE, SPF_HELO_NONE, SPF_PASS, TXREP, T_SCC_BODY_TEXT_LINE, URIBL_BLACK autolearn=no autolearn_force=no version=3.4.4 X-Spam-Checker-Version: SpamAssassin 3.4.4 (2020-01-24) on server2.sourceware.org X-BeenThere: libc-alpha@sourceware.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Libc-alpha mailing list List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Thu, 14 Apr 2022 00:34:06 -0000 On Fri, Apr 08, 2022 at 05:14:12PM -0700, Fangrui Song wrote: > HJ's DT_RELR patch series has been upgraded to v7 > (https://patchwork.sourceware.org/project/glibc/list/?series=8295) > > git-pw series apply 8295 > # `Add --disable-default-dt-relr` does not apply cleanly > > If no regressions with default DT_RELR, that will be cool! I did find one error when testing a build of glibc using Ubuntu gcc-8. elf/filter fails with "error while loading shared libraries: .../elf/filtmod1.so: DT_RELR without GLIBC_ABI_DT_RELR dependency". A little analysis shows the problem occurs when filtmod1.so is linked with --as-needed and libc.so is not needed. filtmod1.so ends up with no .gnu.version or .gnu.version_r sections, and of course no GLIBC_ABI_DT_RELR version. The error check is not one that belongs in ld.so. If you have the error checking code, then you have DT_RELR support in ld.so and there is no reason at all to refuse to run the program! The check should be in the linker, if anywhere. -- Alan Modra Australia Development Lab, IBM