From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from EUR04-VI1-obe.outbound.protection.outlook.com (mail-eopbgr80057.outbound.protection.outlook.com [40.107.8.57]) by sourceware.org (Postfix) with ESMTPS id C88EE38582B4 for ; Thu, 30 Jun 2022 11:07:37 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.4.1 sourceware.org C88EE38582B4 ARC-Seal: i=2; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=pass; b=dJvGFJfn2yfMLmwedphi/LENhrZZwdaQYYU4rdd9EN7yGmJo6l8DwMy/1bqRq5w+P+CErgnn64d59FBidJmz5bO66mh0ouk6Y5XFWm9ys2o6Zczuf+rOi9RcLw4470KulXXS0jpZvl8OODpf88sCY5MRhOdbw23ftoOChfiTtTGPDf+WG7Zc0qg3a8DpQMVqmZSb/5EAKJeKn29sInny1wXrd3fdu30qXBv9kxbuQYOjKlRgQX16oSmsa6oZcubfh1vhes92St1LYWYZv/KSTsd5A3McvvsFx2fqalc7T03tFFPVlLu0Ogm4/ygVvyZeoBLPuGW6XV2D3lrw5wxlVQ== ARC-Message-Signature: i=2; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=U4ULZ/lXmeEoZw29Hye1XDhuK7iYeArqGFdaHQV28eQ=; b=D77hg0qlUYO4+rnHa6U5fo+B3dlQBKe/pveT/+LAE+etZoFpvujqU5gtdW1XGs1KQq9+HSWNC4pUJJ1twNM70ahYEqBk1FIsf/qWs5bneEtrQd34WUPj57hmxH67BsTjlYI66D46xPEN9ITISMfGmGFVNs3GKbpH2hkGs7V+MIV2ps70H5NqXvGCfK8fiYAJXAAUqNjxf7u0+8+j2oUI0w2tpu08VsfE9cbSxqR4vWfJUOTxLl/oLdQaG/9BEUpzWX/KCCCeVKe3JiRhVTWXwbPASiomkjuKPJOI27c+yx60SbFFhVNoYxRux7bLF8PAu/+AEvHXpgBAPWYilEeaew== ARC-Authentication-Results: i=2; mx.microsoft.com 1; spf=pass (sender ip is 63.35.35.123) smtp.rcpttodomain=sourceware.org smtp.mailfrom=arm.com; dmarc=pass (p=none sp=none pct=100) action=none header.from=arm.com; dkim=pass (signature was verified) header.d=armh.onmicrosoft.com; arc=pass (0 oda=1 ltdi=1 spf=[1,1,smtp.mailfrom=arm.com] dkim=[1,1,header.d=arm.com] dmarc=[1,1,header.from=arm.com]) Received: from DB6PR0301CA0079.eurprd03.prod.outlook.com (2603:10a6:6:30::26) by AM0PR08MB3841.eurprd08.prod.outlook.com (2603:10a6:208:106::21) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.5395.14; Thu, 30 Jun 2022 11:07:34 +0000 Received: from DBAEUR03FT030.eop-EUR03.prod.protection.outlook.com (2603:10a6:6:30:cafe::7d) by DB6PR0301CA0079.outlook.office365.com (2603:10a6:6:30::26) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.5395.15 via Frontend Transport; Thu, 30 Jun 2022 11:07:34 +0000 X-MS-Exchange-Authentication-Results: spf=pass (sender IP is 63.35.35.123) smtp.mailfrom=arm.com; dkim=pass (signature was verified) header.d=armh.onmicrosoft.com;dmarc=pass action=none header.from=arm.com; Received-SPF: Pass (protection.outlook.com: domain of arm.com designates 63.35.35.123 as permitted sender) receiver=protection.outlook.com; client-ip=63.35.35.123; helo=64aa7808-outbound-1.mta.getcheckrecipient.com; pr=C Received: from 64aa7808-outbound-1.mta.getcheckrecipient.com (63.35.35.123) by DBAEUR03FT030.mail.protection.outlook.com (100.127.142.197) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.5395.14 via Frontend Transport; Thu, 30 Jun 2022 11:07:34 +0000 Received: ("Tessian outbound d5fa056a5959:v121"); Thu, 30 Jun 2022 11:07:34 +0000 X-CheckRecipientChecked: true X-CR-MTA-CID: c87fef0e9d03bc0e X-CR-MTA-TID: 64aa7808 Received: from c87b29b212c2.2 by 64aa7808-outbound-1.mta.getcheckrecipient.com id 144CD21D-BD7C-4D01-A744-10F852E47578.1; Thu, 30 Jun 2022 11:07:27 +0000 Received: from EUR04-VI1-obe.outbound.protection.outlook.com by 64aa7808-outbound-1.mta.getcheckrecipient.com with ESMTPS id c87b29b212c2.2 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384); Thu, 30 Jun 2022 11:07:27 +0000 ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=kiBACqQeQMg0bjWAbnFk0UBiqDbWfbxkwENIYo8JvClEaqP+fQcB0NEVcs/ob02dKuNdBxSFxWihEC4sRzy1NX3RisqXToh4nj8eFjtdGlOP8It0+ml2uExHu51gILXVWEWEZDX7cmZOtm8Jf/vIPB5zZdpzAmC5dYFQWWfp7tcZ9gnRvtW12qMS0MYE+PuGFRGbIiFeJYh8PaWKx1rYf1gnJq16ygD1EXR5Kt5p1Eb0UnxHyMHF7soS5a/PlDZMK19bkJP4w3tETIlfRASOvXRfWMrBUOR14qYPgIb4HNBhWt9EjNcY9hS+RhA4y4C0MlrGtbTk5C692/SPziyNQg== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=U4ULZ/lXmeEoZw29Hye1XDhuK7iYeArqGFdaHQV28eQ=; b=SusCuJK5weQ0na24zJHmsQj2ShDX2nRdTMw5t6U8Y18UEvXgd3YiIyTCYgEq9lsI5UkWpDL7K6DsuAGPIvC1GO0RSLRYiE/8xX7AttVb5QHNRlFigEUJF07NmlF7hXptoEB6IKMXeXx9iFDBviyAkIhImAsrKHiG4yYsAxMXOMgbCn0hGKArv0GOGILtE5itA6yD7d9oLC2xyfzuMYpYRoKKvzRxaAJvOr8sUWb8rlSckmgOEKeYUDc1OrZnx2UEJmJUVXLXEFZaxREoYyoHxFMfGRgzXlcXrfqFVoMTKY9iDwMlGjMKJupwuiYH0fsU8lZfizjm3hI9ZtxNmgnqDQ== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=arm.com; dmarc=pass action=none header.from=arm.com; dkim=pass header.d=arm.com; arc=none Authentication-Results-Original: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=arm.com; Received: from DB9PR08MB7179.eurprd08.prod.outlook.com (2603:10a6:10:2cc::19) by AS8PR08MB7205.eurprd08.prod.outlook.com (2603:10a6:20b:404::23) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.5395.15; Thu, 30 Jun 2022 11:07:25 +0000 Received: from DB9PR08MB7179.eurprd08.prod.outlook.com ([fe80::7920:5d4b:d11d:d5e4]) by DB9PR08MB7179.eurprd08.prod.outlook.com ([fe80::7920:5d4b:d11d:d5e4%3]) with mapi id 15.20.5395.015; Thu, 30 Jun 2022 11:07:25 +0000 Date: Thu, 30 Jun 2022 12:07:07 +0100 From: Szabolcs Nagy To: Tejas Belagod Cc: "libc-alpha@sourceware.org" Subject: Re: [PATCH] AArch64: Add asymmetric faulting mode for tag violations in mem.tagging tunable Message-ID: References: Content-Type: text/plain; charset=utf-8 Content-Disposition: inline In-Reply-To: X-ClientProxiedBy: DS7PR03CA0293.namprd03.prod.outlook.com (2603:10b6:5:3ad::28) To DB9PR08MB7179.eurprd08.prod.outlook.com (2603:10a6:10:2cc::19) MIME-Version: 1.0 X-MS-Office365-Filtering-Correlation-Id: 8ccb851e-d3e6-4aee-b66f-08da5a88bc0e X-MS-TrafficTypeDiagnostic: AS8PR08MB7205:EE_|DBAEUR03FT030:EE_|AM0PR08MB3841:EE_ x-checkrecipientrouted: true NoDisclaimer: true X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam-Untrusted: BCL:0; X-Microsoft-Antispam-Message-Info-Original: WT585TcdumcVmm9nUlGK7XKrHoH22WeB8S8AVqm70b8873Gq4+U044BBaVQVAZKzmS5+NrDv9/wF6axxnzaKLsB1EMalb3kbHQSqYiZosZs0lAT/36GVoIUkDgeF08AW4K91bVAWneSM7JmEfXfneKOYk/ZZOpMrbYdE0YYCJ2XX1s34OHCQSAcScMng15qUjonPntlnZ8XQun4D6qK035LndPMM2cIAB/X6KAZiuup5noFbNmjx+81kUo54/g4WHulviuugyl0aY6eJW/rXQNW5X25pdKsKLHy02NIcNheZakLTH0eGk/kKygS7IsIxbiLIov5pH61clHMNrCtEUEncCWZSn8rJLkH5jtsL+nK6K9iWBbH0Wfg6wN0Y7HD+wY+r4ph22oF711HFuPn4yG/wYBmqnP0L2zUTyZcH3GfuZJAQYAxspa2JmbR6UbgPHMsp4JPr00eWFCysHXgXrAEHV8F5Rsw20xiJ3rlamtqAztiLyjwg8+5UgGrpfOyfsbFtw5GxAxyYDPmKaD0HhJcitDrnrYirWpZCctt9fBuspe7mAecK6478Qnr0SiYdCsjc5+76geGIVS5Q7cHZIvxlY2WI3VAewy4n6uKuhOidqVO/vObpZS7a2xIM2HhiiTZ2BxJM0KGFWdVjo7n3/FT56cX0SV8xkWmJ8eQIoDpc+BCfcmiLmXXgk9MRfSb/mikgfp0TrD72I0y4h/U4kFmzLvc/KmRQ6hb/nH13RBiuQHwfkdQd7CxblxA9Ch4nzUxxVOGo8u3gPMo4I/OabhXDaWcL7Z4TCX140eh0ONK9x06aMPag0TzXnRQBOW5d X-Forefront-Antispam-Report-Untrusted: CIP:255.255.255.255; CTRY:; LANG:en; SCL:1; SRV:; IPV:NLI; SFV:NSPM; H:DB9PR08MB7179.eurprd08.prod.outlook.com; PTR:; CAT:NONE; SFS:(13230016)(4636009)(346002)(136003)(39860400002)(396003)(366004)(376002)(186003)(66946007)(83380400001)(6666004)(6636002)(37006003)(66556008)(4326008)(316002)(86362001)(8676002)(36756003)(6862004)(26005)(8936002)(2616005)(5660300002)(6512007)(6506007)(2906002)(6486002)(478600001)(41300700001)(66476007)(38100700002)(67856001); DIR:OUT; SFP:1101; X-MS-Exchange-Transport-CrossTenantHeadersStamped: AS8PR08MB7205 Original-Authentication-Results: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=arm.com; X-EOPAttributedMessage: 0 X-MS-Exchange-Transport-CrossTenantHeadersStripped: DBAEUR03FT030.eop-EUR03.prod.protection.outlook.com X-MS-PublicTrafficType: Email X-MS-Office365-Filtering-Correlation-Id-Prvs: d477d0a8-528a-4995-9f79-08da5a88b65c X-Microsoft-Antispam: BCL:0; X-Microsoft-Antispam-Message-Info: 5ydzFoBmMf22JpA5/RmclDGQmg2Cw4tSBwORRcZ2GoPQS6EMgCXYbzmR5j2/Olh0UdmPeMxzd5AHHt5DY2pVVMb6LNYyt2Q0RoanOwSzoHvMOKKLWPozYy7+OJ09z0z2kHe96AwJq2HcPEfIrCR08JnbAU5eumihcaORzZmutKg+h7Wwvwr4DvgJ0o4u+mTw6NsnmU34nk0NK8VcpGIZTxXoIOVxc4vRrJnSel92Q6K9Y6R6CX4iayEYUIISU/UcYTcDtXzcsM/vAUQ0PvJmuttM2Kog61MeP+kDC8/JXQTB847AQ1a0HhZmw6oDfkazZHihMM/+sEhIxtKavoP0SBVP/xJuudgd7t3kpvFZNk7EjaF/tjZlidgyt+2oTZM3F+x7Wko5f8uEr+qe1lv6loEPnFepPLy7rIzZviecGR2W3/XBRELqreXCGCkhykB2/BEj+OeGeMMXhC6uVJM8GdVWRBnicFrp7r/Y+4v0GIJXcjSPdi9CJgbx4+eP7DwBXGiT23Nh6uOFQTEjLHwybzerdUJNGNSN/TrmMXciHYAt9oLoRG+q1RQeHU98gviwdlF2ftAnr7r/gM9SCRFpWxSggRiJh2D6YE7lBjQjRvYR/NPVbzLy4A975LHBjUo2X4rt0h/aWgGoBteFPD3xOq4VnopZvyoCHjiLaswb2jWcE801nE2k0uwGV/NimoL9sYncJ6mGB+j9PVXUlLW0HlVV2Hvgvdx0gfGshpi1X4R1N5D1RXRI3NI1400P6fG+9IEBZpD1ONjSzttqjW4MhX/qRYVKfEYs8d3g9fXJyucKMmHE6cnpnJKRZL2UY0/BV2/6cLaFqkY5+6H0x8Aja16G38Lg6iOQSsVKId1LiUE= X-Forefront-Antispam-Report: CIP:63.35.35.123; CTRY:IE; LANG:en; SCL:1; SRV:; IPV:CAL; SFV:NSPM; H:64aa7808-outbound-1.mta.getcheckrecipient.com; PTR:ec2-63-35-35-123.eu-west-1.compute.amazonaws.com; CAT:NONE; SFS:(13230016)(4636009)(396003)(376002)(39860400002)(136003)(346002)(46966006)(36840700001)(40470700004)(6506007)(86362001)(36860700001)(41300700001)(26005)(2906002)(82310400005)(6666004)(5660300002)(8936002)(40460700003)(6862004)(478600001)(4326008)(186003)(47076005)(356005)(6512007)(70586007)(36756003)(37006003)(2616005)(336012)(70206006)(6636002)(6486002)(83380400001)(81166007)(8676002)(316002)(82740400003)(40480700001)(67856001); DIR:OUT; SFP:1101; X-OriginatorOrg: arm.com X-MS-Exchange-CrossTenant-OriginalArrivalTime: 30 Jun 2022 11:07:34.3323 (UTC) X-MS-Exchange-CrossTenant-Network-Message-Id: 8ccb851e-d3e6-4aee-b66f-08da5a88bc0e X-MS-Exchange-CrossTenant-Id: f34e5979-57d9-4aaa-ad4d-b122a662184d X-MS-Exchange-CrossTenant-OriginalAttributedTenantConnectingIp: TenantId=f34e5979-57d9-4aaa-ad4d-b122a662184d; Ip=[63.35.35.123]; Helo=[64aa7808-outbound-1.mta.getcheckrecipient.com] X-MS-Exchange-CrossTenant-AuthSource: DBAEUR03FT030.eop-EUR03.prod.protection.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Anonymous X-MS-Exchange-CrossTenant-FromEntityHeader: HybridOnPrem X-MS-Exchange-Transport-CrossTenantHeadersStamped: AM0PR08MB3841 X-Spam-Status: No, score=-12.1 required=5.0 tests=BAYES_00, DKIM_SIGNED, DKIM_VALID, FORGED_SPF_HELO, GIT_PATCH_0, KAM_DMARC_NONE, RCVD_IN_DNSWL_NONE, RCVD_IN_MSPIKE_H2, SPF_HELO_PASS, SPF_NONE, TXREP, T_SCC_BODY_TEXT_LINE, UNPARSEABLE_RELAY autolearn=ham autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on server2.sourceware.org X-BeenThere: libc-alpha@sourceware.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Libc-alpha mailing list List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Thu, 30 Jun 2022 11:07:39 -0000 The 06/27/2022 18:00, Tejas Belagod wrote: > Hi, > > The new asymmetric mode is available when HWCAP2_MTE3 is set (support is > available), bit2 is set in the tunable (user request per application), > and the system is configured such that the asymmetric mode is preferred over > sync or async (per-cpu system-wide setting). > > OK for master? > > Thanks, > Tejas. This is ok. Reviewed-by: Szabolcs Nagy > diff --git a/manual/tunables.texi b/manual/tunables.texi > index 1482412078d21cc8da22a62ff4acac3e5297eff9..1d6befaf4a40865a4eee6a6a7a34fa39258f764b 100644 > --- a/manual/tunables.texi > +++ b/manual/tunables.texi > @@ -602,6 +602,9 @@ Bit 1 enables precise faulting mode for tag violations on systems that > support deferred tag violation reporting. This may cause programs > to run more slowly. > > +Bit 2 enables either precise or deferred faulting mode for tag violations > +whichever is preferred by the system. > + > Other bits are currently reserved. > > @Theglibc{} startup code will automatically enable memory tagging > diff --git a/sysdeps/unix/sysv/linux/aarch64/cpu-features.c b/sysdeps/unix/sysv/linux/aarch64/cpu-features.c > index 41dda8d00327e56b6c85a07eb68435de1dda5dae..d14c0f4e1f2905148ac55a4569fd3e12f9a1d7fe 100644 > --- a/sysdeps/unix/sysv/linux/aarch64/cpu-features.c > +++ b/sysdeps/unix/sysv/linux/aarch64/cpu-features.c > @@ -108,7 +108,13 @@ init_cpu_features (struct cpu_features *cpu_features) > TUNABLE_SET (glibc, mem, tagging, cpu_features->mte_state); > # endif > > - if (cpu_features->mte_state & 2) > + if (cpu_features->mte_state & 4) > + /* Enable choosing system-preferred faulting mode. */ > + __prctl (PR_SET_TAGGED_ADDR_CTRL, > + (PR_TAGGED_ADDR_ENABLE | PR_MTE_TCF_SYNC | PR_MTE_TCF_ASYNC > + | MTE_ALLOWED_TAGS), > + 0, 0, 0); > + else if (cpu_features->mte_state & 2) > __prctl (PR_SET_TAGGED_ADDR_CTRL, > (PR_TAGGED_ADDR_ENABLE | PR_MTE_TCF_SYNC | MTE_ALLOWED_TAGS), > 0, 0, 0);