From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from EUR04-HE1-obe.outbound.protection.outlook.com (mail-eopbgr70081.outbound.protection.outlook.com [40.107.7.81]) by sourceware.org (Postfix) with ESMTPS id 09602385800B for ; Thu, 28 Jul 2022 10:37:04 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.4.1 sourceware.org 09602385800B ARC-Seal: i=2; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=pass; b=oZ+Fm/oNsDEEAOKa1Z4Mr3tjiOIpASy4XyUp3agmWxjNH/PstLzixVQIkrDXHiJaBJdnrN5kFokKuaM9MZRdarAfhbZHaD8JDF14wxWVxY/gWiw8nrrW+IPK5c2Gyzv+q9WM7UvQ5pSB08HV5rLlpXQYFjaO2y1oFzXO1bKuwUTnQKZ8h6NeAEpyblfRvKxsAeFZZqUJRT5iH3tSacRUaookICKLkn7LOGZuu3FLrkde18LONh2bBx4TW6yoWmZgOzeuKvAYM7XHIJEh7zHnToJ46E4RJLJeraEbqzplULgd2VDU/hmLjtxe05HY3w6lGBb7TtnY6naLEgBo5EYrKQ== ARC-Message-Signature: i=2; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=/s4kWse1BMHTQqhr5HEVUptJYHB4WvzGtRTffyhUPdE=; b=QS6HA5HH5aeMYg4Yklq5zm7CLCwaKycyWLG0kGHDrooDU0AqA3nBjCsRzVjKvRroQ87rJX0FtQf1xNo9TQexZK/ZQQIuewIGkA4WCJ99UqBZkVnRD85SIRYnTv4pszwlFzgzpe1d1zXStO29s2JMs11qYGAGEWti8OHbwv5N1xU9FNWkLU9fEEzLzYtlynnD7TA2kH0+FAoWi6+gDzJjqLQMBGgOOAg2LopB2sRrzRW7OUOdDsD+TNOgYRAI/rWi68b+0pdaSV/licsJjI45zil5NkCpdk1+7dJGmOoz+pIJXy6Ik9ALN2HxSXdviLczkHWS1ou1f+6ymXSRlnD9/g== ARC-Authentication-Results: i=2; mx.microsoft.com 1; spf=pass (sender ip is 63.35.35.123) smtp.rcpttodomain=sourceware.org smtp.mailfrom=arm.com; dmarc=pass (p=none sp=none pct=100) action=none header.from=arm.com; dkim=pass (signature was verified) header.d=armh.onmicrosoft.com; arc=pass (0 oda=1 ltdi=1 spf=[1,1,smtp.mailfrom=arm.com] dkim=[1,1,header.d=arm.com] dmarc=[1,1,header.from=arm.com]) Received: from AM6PR10CA0010.EURPRD10.PROD.OUTLOOK.COM (2603:10a6:209:89::23) by AS8PR08MB6789.eurprd08.prod.outlook.com (2603:10a6:20b:38f::23) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.5458.19; Thu, 28 Jul 2022 10:37:00 +0000 Received: from VE1EUR03FT026.eop-EUR03.prod.protection.outlook.com (2603:10a6:209:89:cafe::fb) by AM6PR10CA0010.outlook.office365.com (2603:10a6:209:89::23) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.5482.10 via Frontend Transport; Thu, 28 Jul 2022 10:37:00 +0000 X-MS-Exchange-Authentication-Results: spf=pass (sender IP is 63.35.35.123) smtp.mailfrom=arm.com; dkim=pass (signature was verified) header.d=armh.onmicrosoft.com;dmarc=pass action=none header.from=arm.com; Received-SPF: Pass (protection.outlook.com: domain of arm.com designates 63.35.35.123 as permitted sender) receiver=protection.outlook.com; client-ip=63.35.35.123; helo=64aa7808-outbound-1.mta.getcheckrecipient.com; pr=C Received: from 64aa7808-outbound-1.mta.getcheckrecipient.com (63.35.35.123) by VE1EUR03FT026.mail.protection.outlook.com (10.152.18.148) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.5482.12 via Frontend Transport; Thu, 28 Jul 2022 10:37:00 +0000 Received: ("Tessian outbound 2af316122c7a:v123"); Thu, 28 Jul 2022 10:37:00 +0000 X-CheckRecipientChecked: true X-CR-MTA-CID: 369a0555cfc39863 X-CR-MTA-TID: 64aa7808 Received: from 03cc4cf737a1.1 by 64aa7808-outbound-1.mta.getcheckrecipient.com id 6D1236CD-1E3B-48D2-ACF9-8722DAFBC016.1; Thu, 28 Jul 2022 10:36:53 +0000 Received: from EUR05-VI1-obe.outbound.protection.outlook.com by 64aa7808-outbound-1.mta.getcheckrecipient.com with ESMTPS id 03cc4cf737a1.1 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384); Thu, 28 Jul 2022 10:36:53 +0000 ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=mQaVsP2zWneXrkGC0WenV/jzwSH/Qhl54O00EA3RRie3t/rx4f8+ZzjUB6MCyM4ZB9kdPJbdMQLsyYtwq9FcJmbPI23+EoWALWQ6wL5r9C2O0JVHRdDRkV9yctEnEJBjmQP6hBSCZmPoh+AuL5BkcVYkQxwBk0edTEhnVMZEhq0l7xDX4A/xhVId7nI06HpZe5mZRNdJNSU6F3RYDYnGLzXbVZLMxHS44tY2rAZVdX+p/kNZV/nD6M4mSU5gY5HX0VLW6Yz5UlNRr5AoSHDzcUVom+p0GayWuQSdUCTs8tERCSNyLyQ8C4W6OAE/ob/iW9FioqmQAPy4tL9XoQkA9g== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=/s4kWse1BMHTQqhr5HEVUptJYHB4WvzGtRTffyhUPdE=; b=YNf20XdEvM3Z3U8ilQCjEjv1Ni2btby02L+a78Z12WBcCsottUUP9BlZhL81fDWSmbh/2KWJm1LgT+zUUHyoqi6JwmEJJ1Pm9hyvRPjuvWUybuB0T4p1NWUsFE+HS3sZyb5P1bSFRLwlXJr+Z6X/7d/zOt4ztgVHcKd5mm66XFdxKQtpVxPy7CLzGfwaDyT+8bII/eDIX51mFK/xNxroDMBrNCc6U5ZTR8DHpHipfUONWfmZ8AZHjLoY2Kg15arSrTArEgaAWa4ed3lKezJTIQ0oyJghul839Hy7Ul1spV38QN9xajLBFB75jKhioxf1DTnt1hjJMIAN4ZWw/2KyYw== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=arm.com; dmarc=pass action=none header.from=arm.com; dkim=pass header.d=arm.com; arc=none Authentication-Results-Original: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=arm.com; Received: from DB9PR08MB7179.eurprd08.prod.outlook.com (2603:10a6:10:2cc::19) by VI1PR0801MB1904.eurprd08.prod.outlook.com (2603:10a6:800:81::12) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.5458.25; Thu, 28 Jul 2022 10:36:51 +0000 Received: from DB9PR08MB7179.eurprd08.prod.outlook.com ([fe80::7920:5d4b:d11d:d5e4]) by DB9PR08MB7179.eurprd08.prod.outlook.com ([fe80::7920:5d4b:d11d:d5e4%3]) with mapi id 15.20.5458.025; Thu, 28 Jul 2022 10:36:51 +0000 Date: Thu, 28 Jul 2022 11:36:37 +0100 From: Szabolcs Nagy To: "Jason A. Donenfeld" , Florian Weimer , Eric Biggers , libc-alpha@sourceware.org, linux-crypto@vger.kernel.org Subject: Re: [PATCH v6] arc4random: simplify design for better safety Message-ID: References: <20220726190830.1189339-1-Jason@zx2c4.com> <20220726195822.1223048-1-Jason@zx2c4.com> Content-Type: text/plain; charset=utf-8 Content-Disposition: inline In-Reply-To: X-ClientProxiedBy: LO4P123CA0282.GBRP123.PROD.OUTLOOK.COM (2603:10a6:600:195::17) To DB9PR08MB7179.eurprd08.prod.outlook.com (2603:10a6:10:2cc::19) MIME-Version: 1.0 X-MS-Office365-Filtering-Correlation-Id: 9b91a483-7002-441d-168a-08da70851aa1 X-MS-TrafficTypeDiagnostic: VI1PR0801MB1904:EE_|VE1EUR03FT026:EE_|AS8PR08MB6789:EE_ x-checkrecipientrouted: true NoDisclaimer: true X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam-Untrusted: BCL:0; X-Microsoft-Antispam-Message-Info-Original: LAaqm7cojCPmTqhNv6FgPD2hgrWGCxdv3uh8ThvqnUx/+CK7SBgiPt2v5Glv0ZdWBqccuH5B5m/71LZKr19MFtClt5oJK4wqzuZ71wjSyxn7AnQn4Fv+0JwskkDMHpiRQCw+pN8dGq88YuT4pnyw1F4+PXc6NzLYoWLfMV6s509GWxHQ56IQushL0YeDR53mjI4rqWomk1Jyw6TAW1hqcdDGWHjrJ1oYslV4jN6Zq2+TAyIXNXMejayu5gb+VwspJt70l31EQatR3xg0Zvyyx42nS/89YMhldHqxY1/MWLZCHuhppI7cEBjkDVJJfuovH/TiPcoJzpydt6WQlx6Ba9ssiN2pKVAMlIxmuAMMTvgdZiNKRxuM/vD7/X7AWFUmWMAb2dfssaLz3pOg5H9YxmeAFnrE+9pLffEK3qGeKkMACyIxLBCl3DhwHQ+mqmNleu7UlpmPeA69ivXO6rwOYesbsbN2xdZ5J50pGOVUT3QwqZnIDafk5wwNAhy0i4v4cCvTauNKH0NWe0wYWChdsgmhsZbiXsZbjVHvHo1WEsAUWMnMqPoo/6dDjkcmT5bXIDEaHNsUIB9KuOJZMfeSmJhjxEHwG/kgPFzqjPDji3lpHr5GSB5yLLTzZzQd2vmeFUXePQ8XFHX3nrigtL0USbKcTVlitVWj3iqrDpcuncdXkpXYiH78l9mwlqKm9cmgAY5MBuQZr2QgPubZu01Brq4ciu1NFrqQmj6oHmAcvFE+Vl5qyo2UkzbknM4VBKs6MF3h/ekjAMccuuoGsJpUrCY28HnXOwVt3PuZ2/jhRRg= X-Forefront-Antispam-Report-Untrusted: CIP:255.255.255.255; CTRY:; LANG:en; SCL:1; SRV:; IPV:NLI; SFV:NSPM; H:DB9PR08MB7179.eurprd08.prod.outlook.com; PTR:; CAT:NONE; SFS:(13230016)(4636009)(376002)(39860400002)(136003)(366004)(396003)(346002)(6486002)(86362001)(316002)(36756003)(26005)(6666004)(6506007)(41300700001)(38100700002)(478600001)(110136005)(6512007)(2616005)(66556008)(186003)(8936002)(5660300002)(66946007)(66476007)(2906002)(8676002)(4744005)(44832011)(32563001); DIR:OUT; SFP:1101; X-MS-Exchange-Transport-CrossTenantHeadersStamped: VI1PR0801MB1904 Original-Authentication-Results: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=arm.com; X-EOPAttributedMessage: 0 X-MS-Exchange-Transport-CrossTenantHeadersStripped: VE1EUR03FT026.eop-EUR03.prod.protection.outlook.com X-MS-PublicTrafficType: Email X-MS-Office365-Filtering-Correlation-Id-Prvs: 29603e65-383f-406f-9505-08da7085150b X-Microsoft-Antispam: BCL:0; X-Microsoft-Antispam-Message-Info: 8MDu30Qiel6NgAS3zAEFir6o06Shcal+EP/pXgRXGsnppc5/WWmF78gNOCUPw4/nuUUoCe4oggQKchE9J6D38I8/zkDeIesImjBy71pXE0288d4vms7OmGFMIKnwpDuVXaUUhxRRoEGnICSAYX/1HxHcbPAHM28bvynJrRn69aubulO6yDRgNh0H5vbclEOkLeXKsjNES9AOPptHNWIz0kkQf+7+CZwLiVwO4FgZxUK81QZtvZLE1uyfeTPENJteeXjFAXOx2MujPfO+glajpi7yfhHRW6eNGKVmDVdl8LD03fQHi0fSLd3o5RqENC4RnrXdkedQ155rJ+VVIJh63RsAtLgslrTRXe8WYBsv2tDNE4+yv88xbogQEjMZxiTKouZ4+lAih62jXQRldiZPFQ7kYAkRIK998Hl/rIlWjHkZrEb/zhjoGvHdsMktR2q/gFy2Bwns/uHpndRHRJvKgJr5AfngO/vrDhC9JwGPaLTcJBHSlMZdHSt0SsiAfQ1PWBI8PlxV8vkCV0EUWb1qexJNFWg0mi1Cj5YMAAkwbtFc1O07pWPeTmHL+quXuz6ZVzMslPx15VsqoBnZi2v0OzfCGUAogdOa6VqAmBTjksPlXKDM5/Q2DAcWfx2eW6VUWgXAxTscWYbceEoFWPqtwbeZomqePWxBXvrlHMxGo946KOgxs2boNWe4bUgowmJwXa1DpRNn4uVPUklgtttxvlHKL2c7tRBpCImi8ojk7U2RD5SHSBuEvYctV+R9/3Fm2I8AGivOA28QE2riGRlyXRgjYKqnNURVxfk1bnj3iOYa/jpX8yarGvNYIvVxp/Dy9lmdt7A/aThfnQUkx1rPLA== X-Forefront-Antispam-Report: CIP:63.35.35.123; CTRY:IE; LANG:en; SCL:1; SRV:; IPV:CAL; SFV:NSPM; H:64aa7808-outbound-1.mta.getcheckrecipient.com; PTR:ec2-63-35-35-123.eu-west-1.compute.amazonaws.com; CAT:NONE; SFS:(13230016)(4636009)(346002)(376002)(136003)(39860400002)(396003)(40470700004)(46966006)(36840700001)(2616005)(82310400005)(6666004)(41300700001)(186003)(47076005)(86362001)(316002)(36756003)(6506007)(44832011)(5660300002)(4744005)(40460700003)(336012)(356005)(2906002)(40480700001)(6486002)(81166007)(6512007)(8936002)(82740400003)(110136005)(26005)(70586007)(478600001)(8676002)(70206006)(36860700001)(32563001); DIR:OUT; SFP:1101; X-OriginatorOrg: arm.com X-MS-Exchange-CrossTenant-OriginalArrivalTime: 28 Jul 2022 10:37:00.4822 (UTC) X-MS-Exchange-CrossTenant-Network-Message-Id: 9b91a483-7002-441d-168a-08da70851aa1 X-MS-Exchange-CrossTenant-Id: f34e5979-57d9-4aaa-ad4d-b122a662184d X-MS-Exchange-CrossTenant-OriginalAttributedTenantConnectingIp: TenantId=f34e5979-57d9-4aaa-ad4d-b122a662184d; Ip=[63.35.35.123]; Helo=[64aa7808-outbound-1.mta.getcheckrecipient.com] X-MS-Exchange-CrossTenant-AuthSource: VE1EUR03FT026.eop-EUR03.prod.protection.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Anonymous X-MS-Exchange-CrossTenant-FromEntityHeader: HybridOnPrem X-MS-Exchange-Transport-CrossTenantHeadersStamped: AS8PR08MB6789 X-Spam-Status: No, score=-6.0 required=5.0 tests=BAYES_00, DKIM_SIGNED, DKIM_VALID, FORGED_SPF_HELO, KAM_DMARC_NONE, RCVD_IN_DNSWL_NONE, RCVD_IN_MSPIKE_H2, SPF_HELO_PASS, SPF_NONE, TXREP, UNPARSEABLE_RELAY autolearn=no autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on server2.sourceware.org X-BeenThere: libc-alpha@sourceware.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Libc-alpha mailing list List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Thu, 28 Jul 2022 10:37:05 -0000 The 07/28/2022 11:29, Szabolcs Nagy via Libc-alpha wrote: > The 07/26/2022 21:58, Jason A. Donenfeld via Libc-alpha wrote: ... > > fyi, after this patch i see > > FAIL: stdlib/tst-arc4random-thread > > with > > $ cat stdlib/tst-arc4random-thread.out > info: arc4random: minimum of 1750000 blob results expected > info: arc4random: 1750777 blob results observed > info: arc4random_buf: minimum of 1750000 blob results expected > info: arc4random_buf: 1750000 blob results observed > info: arc4random_uniform: minimum of 1750000 blob results expected > Timed out: killed the child process > Termination time: 2022-07-27T14:41:33.766791947 > Last write to standard output: 2022-07-27T14:41:22.522497854 > > on an arm and aarch64 builder. > > running it manually it takes >30s to complete. note that before the patch it was <5s on the same machine.