public inbox for libc-alpha@sourceware.org
 help / color / mirror / Atom feed
From: Mark Wielaard <mark@klomp.org>
To: Wilco Dijkstra <Wilco.Dijkstra@arm.com>
Cc: 'GNU C Library' <libc-alpha@sourceware.org>,
	Thomas Fitzsimmons <fitzsim@fitzsim.org>
Subject: Re: [PATCH] Improve performance of IO locks
Date: Tue, 16 Aug 2022 00:27:37 +0200	[thread overview]
Message-ID: <YvrIWdEpyBSh9prn@wildebeest.org> (raw)
In-Reply-To: <AM5PR0801MB1668FF146572E2069648B5F1839A9@AM5PR0801MB1668.eurprd08.prod.outlook.com>

Hi,

On Mon, Aug 01, 2022 at 11:06:07AM +0000, Wilco Dijkstra via Libc-alpha wrote:
> Improve performance of recursive IO locks by adding a fast path for
> the single-threaded case. To reduce the number of memory accesses for
> locking/unlocking, only increment the recursion counter if the lock
> is already taken. 
> 
> On Neoverse V1, a microbenchmark with many small freads improved by
> 2.9 times. Multithreaded performance improved by 2%.

Strangely this seems to have broken the glibc-debian-ppc64 buildbot:
https://builder.sourceware.org/buildbot/#/builders/glibc-debian-ppc64

I don't see how this commit can cause a failure just on debian-ppc64
(all other distro/arches are fine).

And the corresponding bunsen test results don't really show why.
https://builder.sourceware.org/testrun/498f51f327afdd7030516455b709a31a0038b432
Most of the .out files are empty, but some indicate an segmentation fault.

Comparing to the build before only shows test result diffs, no
configuration differences.
https://builder.sourceware.org/testrun-diffs?commitish=498f51f327afdd7030516455b709a31a0038b432&commitish=58fd9d63b078b6bbfdba45135c4021038f33534e

I don't have access to the buildbot, so cannot easily investigate more.

Tom, could you have a look and see if you can find out more? Does just
reverting commit c51c483d2b8ae66fe31a12509aedae02a6982ced make things
OK again? Or did something else on the buildbot worker change?

Note that the buildbot only does a make subdirs=elf check, not a full
make check.

Thanks,

Mark

  parent reply	other threads:[~2022-08-15 22:27 UTC|newest]

Thread overview: 16+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2022-06-08 16:32 Wilco Dijkstra
2022-08-01 11:06 ` Wilco Dijkstra
2022-08-07 12:51   ` Cristian Rodríguez
2022-08-15 22:27   ` Mark Wielaard [this message]
2022-08-16  3:07     ` Thomas Fitzsimmons
2022-08-16  7:31       ` Florian Weimer
2022-08-16 10:00         ` Mark Wielaard
2022-08-16 10:08           ` Florian Weimer
2022-08-17 13:45             ` Mark Wielaard
2022-08-22 10:25               ` Florian Weimer
2022-08-22 14:58                 ` Frank Ch. Eigler
2022-08-16 11:19           ` Andreas Schwab
2022-08-16 10:24         ` Wilco Dijkstra
2022-08-16 13:18           ` Thomas Fitzsimmons
2022-08-16 14:31             ` Thomas Fitzsimmons
2022-08-17 11:53               ` Mark Wielaard

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=YvrIWdEpyBSh9prn@wildebeest.org \
    --to=mark@klomp.org \
    --cc=Wilco.Dijkstra@arm.com \
    --cc=fitzsim@fitzsim.org \
    --cc=libc-alpha@sourceware.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).