From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [170.10.129.124]) by sourceware.org (Postfix) with ESMTPS id E3A433839DF8 for ; Tue, 13 Sep 2022 09:42:22 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.4.1 sourceware.org E3A433839DF8 Authentication-Results: sourceware.org; dmarc=pass (p=none dis=none) header.from=redhat.com Authentication-Results: sourceware.org; spf=pass smtp.mailfrom=redhat.com DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1663062142; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:mime-version:mime-version:content-type:content-type: in-reply-to:in-reply-to:references:references; bh=98tiv51b/6A6g7MjcJ0q+pbJ2G8QlKdcKVmWkDAZ7/8=; b=gZfXe99PpxG2zDVGfyuDa7+80UyXd8BnBMpPiXSAU9A4hqChNDMXs0lM6z9lPFVH/r50Zl dUL2QjEzIf1h0aeXJpMiAuimcYZk2NMPWNQFkRP0pnshP2nAbYj4nHIe1QsdhDcO6sV8ZF NABWakTKHsOzwvJm3bsY5cxPqBj/Xg0= Received: from mail-wm1-f70.google.com (mail-wm1-f70.google.com [209.85.128.70]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.3, cipher=TLS_AES_128_GCM_SHA256) id us-mta-159-pP9nEMe5OKaF4ywHazMyDw-1; Tue, 13 Sep 2022 05:42:21 -0400 X-MC-Unique: pP9nEMe5OKaF4ywHazMyDw-1 Received: by mail-wm1-f70.google.com with SMTP id c128-20020a1c3586000000b003b324bb08c5so8782289wma.9 for ; Tue, 13 Sep 2022 02:42:21 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=in-reply-to:content-disposition:mime-version:references:message-id :subject:to:from:date:x-gm-message-state:from:to:cc:subject:date; bh=98tiv51b/6A6g7MjcJ0q+pbJ2G8QlKdcKVmWkDAZ7/8=; b=Djy6yJssBUTtHDhcyNts+cRch/uF3al633LB0432r13GbyNAS3bZwSJzwQ5asZ8n+e kVfjKY/s2dOMsMsLKHJqrDjjgTEETvdPvXDrNdeKGM+clIiG0k+6ScrDbPZhNMRloFbQ xTPAHWV+XK1SnZqaVmdf60DHoIVBKaClvSoX15K5mNzT0O5s1ACDDMcVk43uvHzRUxWP wLfdAStRLPPGGwbwb6B70cgwodiZV2085d2GN2t7EDvxq8CKZQ91nVCLBBlzMkTCtHPx dffjyA6JtFRgJNqrF3iSepjfv+1Phci6RdA1e5Hv1cF/pN1Oj+ajLDZ9LmdTVinwnxYh r0VA== X-Gm-Message-State: ACgBeo0i94sUE43Jp1JS5XWs+KkIIkEdiuNoeukhIC8Vp1t1a1Pn6GOG BZc5kcevZP8J1ZxEp8yh9JhA622YyYIltY01fyZLHdB9qYE0ZA4j3RJCvwx6V2obHaRS7k3Co/V 5h9YrDqYV3/+tz51CJ+GE X-Received: by 2002:a05:6000:1a8a:b0:22a:33aa:a907 with SMTP id f10-20020a0560001a8a00b0022a33aaa907mr13744175wry.322.1663062140181; Tue, 13 Sep 2022 02:42:20 -0700 (PDT) X-Google-Smtp-Source: AA6agR7MiA8A7BKAZ88UdPmwurj5rK1I1O082AZj0hzJa+flknSLZ7BWXoQHjLKepVgCoGdKZf12eA== X-Received: by 2002:a05:6000:1a8a:b0:22a:33aa:a907 with SMTP id f10-20020a0560001a8a00b0022a33aaa907mr13744161wry.322.1663062139998; Tue, 13 Sep 2022 02:42:19 -0700 (PDT) Received: from fedora ([185.122.133.20]) by smtp.gmail.com with ESMTPSA id l10-20020adfe58a000000b0022863395912sm9762438wrm.53.2022.09.13.02.42.19 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Tue, 13 Sep 2022 02:42:19 -0700 (PDT) Date: Tue, 13 Sep 2022 05:42:18 -0400 From: Carlos O'Donell To: Xiaoming Ni , cltang@codesourcery.com, libc-alpha@sourceware.org, brooks@gcc.gnu.org, ppluzhnikov@google.com, neleai@seznam.cz, marat@slonopotamus.org Subject: Re: [PATCH] elf: Sort only uninitialized objects in _dl_map_object_deps() Message-ID: References: <20200725105205.103328-1-nixiaoming@huawei.com> <8a15102b-c461-23e2-21d4-f2f7b2b78682@redhat.com> <0e390002-1363-1c4a-fd55-cb5f12affd71@huawei.com> MIME-Version: 1.0 In-Reply-To: X-Mimecast-Spam-Score: 0 X-Mimecast-Originator: redhat.com Content-Type: text/plain; charset=us-ascii Content-Disposition: inline X-Spam-Status: No, score=-7.1 required=5.0 tests=BAYES_00,DKIMWL_WL_HIGH,DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,RCVD_IN_DNSWL_LOW,SPF_HELO_NONE,SPF_NONE,TXREP,T_SCC_BODY_TEXT_LINE autolearn=ham autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on server2.sourceware.org List-Id: On Mon, Aug 03, 2020 at 02:37:22PM -0400, Carlos O'Donell wrote: > On 7/29/20 9:56 AM, Xiaoming Ni wrote: > > I'm trying to automate my test cases, but it's going to take a while. > > Thank you for doing this. > > My reminder to everyone is that writing tests is one of the most important > things we can do as systems developers. > > The systems we are building are expected to be very reliable and we need > to write tests that encode our expectations and intent. > > Chung-Lin's patches provide an automated way to write such test cases for > the loader. Please try applying the patches and seeing if you can use the > special DSL to write a test that matches what you were previously testing. I'm walking out patch queue backwards in patchwork. I wanted to note here that this 2020 patch has been superseded by future work that improves the core DSO sorting algorithm. We have switched to the new DSO sorting algorithm by default. Please re-check the current glibc to see if it meeds your needs or if we need to improve things further. Cheers, Carlos. > -- > Cheers, > Carlos.