From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [170.10.129.124]) by sourceware.org (Postfix) with ESMTPS id 70B963857413 for ; Wed, 14 Sep 2022 09:42:15 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.4.1 sourceware.org 70B963857413 Authentication-Results: sourceware.org; dmarc=pass (p=none dis=none) header.from=redhat.com Authentication-Results: sourceware.org; spf=pass smtp.mailfrom=redhat.com DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1663148535; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: in-reply-to:in-reply-to:references:references; bh=ZXrhkz+wim2HjikOPvMEJDMXYv6/aI/jW6nqTGft2Gs=; b=C+MDJGIRIrNA2cFR9SFS26mN3TfSp0yyCUYq8QbjCSkN6xIzDQtotLLx46iGz5KILEFCGc kK6q60JU3DrHX/p05ZVrcWU7WNPGMAOy6IBQQzrYzdM3cUU0aDAy77PCK6YYhOnTQgMosm haji4TLAPV23YMYRWOPncb02eN0IqVU= Received: from mail-wr1-f71.google.com (mail-wr1-f71.google.com [209.85.221.71]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.3, cipher=TLS_AES_128_GCM_SHA256) id us-mta-383-Td5VZeTlPYuTSvFTjN-u7w-1; Wed, 14 Sep 2022 05:42:13 -0400 X-MC-Unique: Td5VZeTlPYuTSvFTjN-u7w-1 Received: by mail-wr1-f71.google.com with SMTP id g19-20020adfa493000000b0022a2ee64216so3832371wrb.14 for ; Wed, 14 Sep 2022 02:42:13 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=in-reply-to:content-disposition:mime-version:references:message-id :subject:cc:to:from:date:x-gm-message-state:from:to:cc:subject:date; bh=ZXrhkz+wim2HjikOPvMEJDMXYv6/aI/jW6nqTGft2Gs=; b=3XMGC8dPHH4z/aviPTphapWIbO8R8rDLvN1SpDgKliAypPHruvZPYg7dFCoUCn+W3K NFN6FJAoeOohGbuJeXaCufTvkW238Z1knW48bIT9WtgAAg0P2dUas1OFb6JLyGwD8IsR JLYQLkV1VqCV82SUQH/D046pBaJc/YRprbFxXmphlfoN3kNZbn5VVKomiKMJnPFlpXx/ uFnzzPB217MdRN/VhaZMbdqowhyUt9+7hEL76t90UTZsSUX7bCufemvQhFiFyFXypTM4 CGJiBwm0m+9IsP62QDYLe7vQiNem5kf7/KE2V6oEG+d89i0lbmEevZkWUU23po/Vl7Rh 9WRg== X-Gm-Message-State: ACgBeo1wfqY845kZe+plItjT3TJ1zs0fpEL9CrSqif/gXeW4M6FDz4ZH 4Qj0qxMHf8uZHfEOjsdulOU7tgY4UUoDBqGaMS+jgsYanQAF6S2oWtLsPDjvd+1X9prrPW1z621 DoVbVQFVZtNVrxEVRnIds X-Received: by 2002:adf:fa83:0:b0:205:c0cb:33c6 with SMTP id h3-20020adffa83000000b00205c0cb33c6mr22026056wrr.39.1663148532684; Wed, 14 Sep 2022 02:42:12 -0700 (PDT) X-Google-Smtp-Source: AA6agR6IZ4Lalsxmg322X2+CA/FHGY45OsN4L7iobIkfKo+bRiM7hBA65xgmWtZOqhDBGEASaZH9RA== X-Received: by 2002:adf:fa83:0:b0:205:c0cb:33c6 with SMTP id h3-20020adffa83000000b00205c0cb33c6mr22026042wrr.39.1663148532458; Wed, 14 Sep 2022 02:42:12 -0700 (PDT) Received: from fedora ([185.122.133.20]) by smtp.gmail.com with ESMTPSA id x8-20020a5d6b48000000b0022ac38fb20asm3094785wrw.111.2022.09.14.02.42.11 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Wed, 14 Sep 2022 02:42:11 -0700 (PDT) Date: Wed, 14 Sep 2022 05:42:10 -0400 From: Carlos O'Donell To: Florian Weimer Cc: libc-alpha@sourceware.org Subject: Re: [PATCH 0/2] Fix nss/tst-nss-files-hosts-long on single-stack hosts (bug 24816) Message-ID: References: MIME-Version: 1.0 In-Reply-To: X-Mimecast-Spam-Score: 0 X-Mimecast-Originator: redhat.com Content-Type: text/plain; charset=us-ascii Content-Disposition: inline X-Spam-Status: No, score=-6.7 required=5.0 tests=BAYES_00,DKIMWL_WL_HIGH,DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,RCVD_IN_DNSWL_LOW,SPF_HELO_NONE,SPF_NONE,TXREP,T_SCC_BODY_TEXT_LINE autolearn=ham autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on server2.sourceware.org List-Id: On Tue, Sep 13, 2022 at 04:35:39PM +0200, Florian Weimer via Libc-alpha wrote: > Our Fedora builders started running the container tests (after the > switch to systemd-nspawn), and we encountered this test failure as well. > Fix this by disabling address configuration in the getent tool. Two things I'd like to discuss. (1) Change the getent default and drop AI_ADDRCONFIG. I'm hesitant to add a new option to getent as a solution to a testing problem. The documented description for getent ahosts talks only about enumerating the host entries or calling getaddrinfo with AF_UNSPEC. Could we just change the default and ignore the host configuration? This is less conservative but logically it seems to me that we could just drop AI_ADDRCONFIG, and add a --addrconfig option to get back the old behaviour. What could we possibly break? (2) Fix the test. Alternatively the test should be checking to see if it is in a dual stack environment or single stack environment and only call getent for the specific case when such interfaces are enabled. Can we resolve this entirely in tst-nss-files-hosts-long? > Tested on x86_64-linux-gnu. > > Florian Weimer (2): > nss: Implement --no-addrconfig option for getent > nss: Fix tst-nss-files-hosts-long on single-stack hosts (bug 24816) > > NEWS | 5 ++++- > nss/getent.c | 11 ++++++++++- > nss/tst-nss-files-hosts-long.c | 9 +++++---- > 3 files changed, 19 insertions(+), 6 deletions(-) > > > base-commit: f278835f594740f5913001430641cf1da4878670 > -- > 2.37.2 >