From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [170.10.129.124]) by sourceware.org (Postfix) with ESMTPS id 808FD38582A4 for ; Wed, 14 Sep 2022 22:35:13 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.4.1 sourceware.org 808FD38582A4 Authentication-Results: sourceware.org; dmarc=pass (p=none dis=none) header.from=redhat.com Authentication-Results: sourceware.org; spf=pass smtp.mailfrom=redhat.com DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1663194913; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: in-reply-to:in-reply-to:references:references; bh=NdDwjmet9RAQsMTmVks45e2ydakpoJ04cw5YHRyLI8w=; b=F96KD+N3vXPj+yfXUWltLvzp9bprcAkF+2QAvgjButqayEdiro1wQzM8ldbM5ulKApXCtU fDIIO4ZEPIThzOnPWhdh9TQNHEnV31+FagE28UagnB7x9nT6ix7oE21f3CNPQZFqmHKLPR 82altEw81nZfUAkLrh8wk3HpjMGhOX4= Received: from mail-wm1-f69.google.com (mail-wm1-f69.google.com [209.85.128.69]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.3, cipher=TLS_AES_128_GCM_SHA256) id us-mta-657-_1bhtZVZOZi5B2E81aJajg-1; Wed, 14 Sep 2022 18:35:12 -0400 X-MC-Unique: _1bhtZVZOZi5B2E81aJajg-1 Received: by mail-wm1-f69.google.com with SMTP id i129-20020a1c3b87000000b003b33e6160bdso10017157wma.7 for ; Wed, 14 Sep 2022 15:35:11 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=in-reply-to:content-disposition:mime-version:references:message-id :subject:cc:to:from:date:x-gm-message-state:from:to:cc:subject:date; bh=NdDwjmet9RAQsMTmVks45e2ydakpoJ04cw5YHRyLI8w=; b=MvLocZ8p/IHfnHEpkDAGyF2AuNEcJXJyyDtGKEh31LGZaj30N8gqN9ICllcrGaQsY+ 4GGnWvIBivWVPzLync/vMzUNoHA9QMYnSMU3Bvgj8zXx5vVvmhVajpUc3VLEq3CnHTmS Vnj8gQFbmSH5qolX1HrGnKwIrr7SNAAfp9maUe81EDedP/lqG04EBXH6jvaDjYGPqruv 7WWzOtEGIvoWMNXINDKHFETgMTjyfEKBNExOqI2sGu15fpHkF4yC0Ryun9MvwOnVGNRx yQMhN8cwphtakjjgS8+2G/e6RB0Ad5o8hMJaVV2OyXIPfMLegopyiGMjBqTxucR9z7PX F/sg== X-Gm-Message-State: ACgBeo15ley4O+r/DBHe48UuUlDZigMzXlQk9AxhEXSyrMi12tQAKdIC 3IMmmDbXbgDhgxBvTXweyGu2Hq6RZF69G2uGFfbyI8pmSlycKeJQA0U1doSQGk1ZtJi7JDfqE2g Xek5AxodE/lBf2Ls1C8Au X-Received: by 2002:adf:ed41:0:b0:225:3fde:46ea with SMTP id u1-20020adfed41000000b002253fde46eamr22557465wro.345.1663194909940; Wed, 14 Sep 2022 15:35:09 -0700 (PDT) X-Google-Smtp-Source: AA6agR5oVlioRAjqefeqMe7Wt/SuKFQx5Vl+Eivi/ZME1WGKklZZiOmnjZaX4MHdJmiZj1rLxvoEyA== X-Received: by 2002:adf:ed41:0:b0:225:3fde:46ea with SMTP id u1-20020adfed41000000b002253fde46eamr22557461wro.345.1663194909736; Wed, 14 Sep 2022 15:35:09 -0700 (PDT) Received: from fedora ([62.209.192.211]) by smtp.gmail.com with ESMTPSA id m13-20020adffe4d000000b00228db6b9406sm555386wrs.45.2022.09.14.15.35.08 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Wed, 14 Sep 2022 15:35:09 -0700 (PDT) Date: Wed, 14 Sep 2022 18:35:07 -0400 From: Carlos O'Donell To: Florian Weimer Cc: libc-alpha@sourceware.org Subject: Re: [PATCH 2/2] nss: Fix tst-nss-files-hosts-long on single-stack hosts (bug 24816) Message-ID: References: <468dff5f8914e9db91785b32683ac0af1f4c731b.1663079342.git.fweimer@redhat.com> MIME-Version: 1.0 In-Reply-To: <468dff5f8914e9db91785b32683ac0af1f4c731b.1663079342.git.fweimer@redhat.com> X-Mimecast-Spam-Score: 0 X-Mimecast-Originator: redhat.com Content-Type: text/plain; charset=us-ascii Content-Disposition: inline X-Spam-Status: No, score=-13.3 required=5.0 tests=BAYES_00,DKIMWL_WL_HIGH,DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,GIT_PATCH_0,RCVD_IN_DNSWL_LOW,SPF_HELO_NONE,SPF_NONE,TXREP,T_SCC_BODY_TEXT_LINE autolearn=ham autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on server2.sourceware.org List-Id: On Tue, Sep 13, 2022 at 04:35:48PM +0200, Florian Weimer via Libc-alpha wrote: > getent implicitly passes AI_ADDRCONFIG to getaddrinfo by default. > Use --no-addrconfig to suppress that, so that both IPv4 and IPv6 > lookups succeed even if the address family is not supported by the > host. LGTM. Reviewed-by: Carlos O'Donell > --- > nss/tst-nss-files-hosts-long.c | 9 +++++---- > 1 file changed, 5 insertions(+), 4 deletions(-) > > diff --git a/nss/tst-nss-files-hosts-long.c b/nss/tst-nss-files-hosts-long.c > index 3942cf5fca..a7697e3143 100644 > --- a/nss/tst-nss-files-hosts-long.c > +++ b/nss/tst-nss-files-hosts-long.c > @@ -28,14 +28,15 @@ do_test (void) > { > int ret; > > - /* Run getent to fetch the IPv4 address for host test4. > - This forces /etc/hosts to be parsed. */ > - ret = system("getent ahostsv4 test4"); > + /* Run getent to fetch the IPv4 address for host test4. This forces > + /etc/hosts to be parsed. Use --no-addrconfig to return addresses > + even in an IPv6-only environment. */ > + ret = system("getent --no-addrconfig ahostsv4 test4"); OK. > if (ret != 0) > FAIL_EXIT1("ahostsv4 failed"); > > /* Likewise for IPv6. */ > - ret = system("getent ahostsv6 test6"); > + ret = system("getent --no-addrconfig ahostsv6 test6"); OK. > if (ret != 0) > FAIL_EXIT1("ahostsv6 failed"); > > -- > 2.37.2 >