From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [170.10.129.124]) by sourceware.org (Postfix) with ESMTPS id 813E03858D28 for ; Mon, 19 Sep 2022 19:46:30 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.4.1 sourceware.org 813E03858D28 Authentication-Results: sourceware.org; dmarc=pass (p=none dis=none) header.from=redhat.com Authentication-Results: sourceware.org; spf=pass smtp.mailfrom=redhat.com DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1663616790; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: in-reply-to:in-reply-to:references:references; bh=j/l9bc0gWb9TkRbLS16Fdsp5NMFsIVsi7QUc3297jaU=; b=XJlM4aslWVJwxvRYrxRZxMMD3YW4ZMgRuhyB5nSyWztr2xJGj+lztOGBI4dDdZNwgsujto /w4ywqZHt7n6cettrC9cN3iZaXpp/rfB2q06ns4GyUZ38weBkTmGC72HfZkRoTswUI8cZ0 AmxzXTraHdBGBwrSACmZgekAE+PwWYU= Received: from mail-il1-f199.google.com (mail-il1-f199.google.com [209.85.166.199]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.3, cipher=TLS_AES_128_GCM_SHA256) id us-mta-529-OAmyd8w1MAus6w7ZXBhyDA-1; Mon, 19 Sep 2022 15:46:28 -0400 X-MC-Unique: OAmyd8w1MAus6w7ZXBhyDA-1 Received: by mail-il1-f199.google.com with SMTP id k3-20020a056e02156300b002f5623faa62so257338ilu.0 for ; Mon, 19 Sep 2022 12:46:28 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=in-reply-to:content-disposition:mime-version:references:message-id :subject:cc:to:from:date:x-gm-message-state:from:to:cc:subject:date; bh=j/l9bc0gWb9TkRbLS16Fdsp5NMFsIVsi7QUc3297jaU=; b=uSCmSCMCrlZ6uFK7sR+Ba81ykJh3ODi8P22Lm0ricNbIZMSW7Jng3Vux54Pg9f+63J eY29KcyjCPsXWSEk1FnNNeCv0+lgeJHc+m3RzcZWFxiEEHhiwMBRXe6+RBI0xB6x3zar PjgYa7adenR4BuuCVr1tj06s72fgAzMJmLL1IQXcBVILvsD9CAqH/jq1VIs33lBkiskt IV0sKdeK7C5Mys7sw7U1q7xPkRED8Cbi77E/gDl6y72tvhFgjM2NE/jJZp9RbxrfN0eh 3dD3KDBhsevgOEFVUGozcP9ukuSToZFJvl0RrCMCWEwoENA68mcSySafJc46NsR3PUhP J6qg== X-Gm-Message-State: ACrzQf1dKDqT0wzoSqTjE4g7umQhBI0XUOiSZfILTgu2IAtjObuXE2g2 2+GrNQnWAYL6dVgPOhltVPu39/9I7kC5YYYQV+SWgrS09zmfDQwK/Ynvq4vJI0Y9nCAVqLIBpFi jH06hSLBw+BnqfGBBA+14 X-Received: by 2002:a05:6e02:156e:b0:2f5:e29a:a043 with SMTP id k14-20020a056e02156e00b002f5e29aa043mr2041102ilu.233.1663616788265; Mon, 19 Sep 2022 12:46:28 -0700 (PDT) X-Google-Smtp-Source: AMsMyM5sC/PzK4vQ2zNfdS/8zEFD51zgrQNKcyLRsl5ss+oHwgjsznV+uzsy+bD3/aSV9BJup5wHVQ== X-Received: by 2002:a05:6e02:156e:b0:2f5:e29a:a043 with SMTP id k14-20020a056e02156e00b002f5e29aa043mr2041090ilu.233.1663616788005; Mon, 19 Sep 2022 12:46:28 -0700 (PDT) Received: from fedora ([104.129.159.227]) by smtp.gmail.com with ESMTPSA id w26-20020a02b0da000000b0034c15d1269fsm5771371jah.100.2022.09.19.12.46.26 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Mon, 19 Sep 2022 12:46:27 -0700 (PDT) Date: Mon, 19 Sep 2022 15:46:24 -0400 From: Carlos O'Donell To: DJ Delorie Cc: Siddhesh Poyarekar , libc-alpha@sourceware.org Subject: Re: Run TryBot-apply_patch on the full queue? Message-ID: References: MIME-Version: 1.0 In-Reply-To: X-Mimecast-Spam-Score: 0 X-Mimecast-Originator: redhat.com Content-Type: text/plain; charset=us-ascii Content-Disposition: inline X-Spam-Status: No, score=-6.3 required=5.0 tests=BAYES_00,DKIMWL_WL_HIGH,DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,RCVD_IN_DNSWL_LOW,SPF_HELO_NONE,SPF_NONE,TXREP autolearn=ham autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on server2.sourceware.org List-Id: On Mon, Sep 19, 2022 at 12:49:11PM -0400, DJ Delorie via Libc-alpha wrote: > I'd have to write a whole new curator/runner to enqueue the jobs for the > trybot. So, not impossible, but not a tweak of existing software. The > existing system would end up doing a full build of every patch every > day. The curator/runners are a more advanced "patchwork bot" framework that can do very specific things. Currently the curator reads trusted sources for information. Then that information is processed and runners carry out the actions. Today the re-triggering CI due to an outage is going to require a developer or bot to send an email to the list saying "retry CI" (signed command) and then that will redo CI for thos failed jobs (for all curators and runners run by all ISVs/IHVs/users/etc that listen to such a command) We don't want to do this every day for all the patches currently in the list that apply. This would potentially cause all listeners to redo their patch application and builds. However, we do want to emulate the current best practice that if a series doesn't rebase then we need to mark it with failed CI. I think the best design is going to be: - Write a custom pre-commit CI patchwork bot whose job is *only* to apply patches and update the patches SWF with a fail. - Run this daily. - Write a patchwork bot whose job is only to mark F-fails as Failed CI. - Run this daily. - Write a dashboard where the bots can report that they ran? - This way we can track all of our bots? > As for notifications: > https://github.com/getpatchwork/patchwork/issues/425 I think we'll have to eventually implment notifications via a patchwork bot that trawls for state changes and emails developers. Cheers, Carlos.