From: Carlos O'Donell <carlos@redhat.com>
To: DJ Delorie <dj@redhat.com>
Cc: siddhesh@gotplt.org, libc-alpha@sourceware.org
Subject: Re: Run TryBot-apply_patch on the full queue?
Date: Tue, 20 Sep 2022 06:21:17 -0400 [thread overview]
Message-ID: <YymUHYNQ/p11btQU@fedora> (raw)
In-Reply-To: <xnzgevyw8o.fsf@greed.delorie.com>
On Mon, Sep 19, 2022 at 03:55:51PM -0400, DJ Delorie wrote:
> "Carlos O'Donell" <carlos@redhat.com> writes:
> > The curator/runners are a more advanced "patchwork bot" framework that
> > can do very specific things.
>
> I think it might be wise to keep the trybot API the same, though. I
> mean, if we have a "patch applies" trybot, it can be controlled by the
> current curator (once per patch seen) as well as by a patchwork bot that
> retries all patches once a day.
That makes sense.
My only concern had been "how do you authenticate this?"
However, after having slept a full night I realized that we need signed
emails, so the curator already needs to validate signatures.
The "injection" API could take signed messages too?
> Both systems just need to inject the right json into the trybot's queue,
> and that information comes mainly from patchwork anyway.
Right.
> The "do once per patch" case is still common (and important) enough to
> warrant a centralized curator though.
Yes. We should just accept a "signed message" API?
That would reuse all the same infrastructure we have for signed emails?
c.
next prev parent reply other threads:[~2022-09-20 10:21 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-09-19 13:31 Siddhesh Poyarekar
2022-09-19 13:38 ` Siddhesh Poyarekar
2022-09-19 16:49 ` DJ Delorie
2022-09-19 19:46 ` Carlos O'Donell
2022-09-19 19:55 ` DJ Delorie
2022-09-20 10:21 ` Carlos O'Donell [this message]
2022-09-20 14:26 ` DJ Delorie
2022-09-20 14:39 ` Siddhesh Poyarekar
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=YymUHYNQ/p11btQU@fedora \
--to=carlos@redhat.com \
--cc=dj@redhat.com \
--cc=libc-alpha@sourceware.org \
--cc=siddhesh@gotplt.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).