From: Carlos O'Donell <carlos@redhat.com>
To: Florian Weimer <fweimer@redhat.com>
Cc: libc-alpha@sourceware.org
Subject: Re: [PATCH v2] nss: Implement --no-addrconfig option for getent
Date: Tue, 20 Sep 2022 06:39:13 -0400 [thread overview]
Message-ID: <YymYUR8NOo/pNxkI@fedora> (raw)
In-Reply-To: <87mtb0keai.fsf@oldenburg.str.redhat.com>
On Thu, Sep 15, 2022 at 02:33:41PM +0200, Florian Weimer via Libc-alpha wrote:
> The ahosts, ahostsv4, ahostsv6 commands unconditionally pass
> AI_ADDRCONFIG to getaddrinfo, which is not always desired.
LGTM.
Reviewed-by: Carlos O'Donell <carlos@redhat.com>
> ---
> v2: Reword NEWS and --help output.
> NEWS | 5 ++++-
> nss/getent.c | 11 ++++++++++-
> 2 files changed, 14 insertions(+), 2 deletions(-)
>
> diff --git a/NEWS b/NEWS
> index ef274d1a42..a64d3eff26 100644
> --- a/NEWS
> +++ b/NEWS
> @@ -9,7 +9,10 @@ Version 2.37
>
> Major new features:
>
> - [Add new features here]
> +* The getent tool now supports the --no-addrconfig option. The output of
> + getent with --no-addrconfig may contain addresses of families not
> + configured on the current host i.e. as-if you had not passed
> + AI_ADDRCONFIG to getaddrinfo calls.
>
> Deprecated and removed features, and other changes affecting compatibility:
>
> diff --git a/nss/getent.c b/nss/getent.c
> index 8178b4b470..d2d2524b0c 100644
> --- a/nss/getent.c
> +++ b/nss/getent.c
> @@ -58,6 +58,8 @@ static const struct argp_option args_options[] =
> {
> { "service", 's', N_("CONFIG"), 0, N_("Service configuration to be used") },
> { "no-idn", 'i', NULL, 0, N_("disable IDN encoding") },
> + { "no-addrconfig", 'A', NULL, 0,
> + N_("do not filter out unsupported IPv4/IPv6 addresses (with ahosts*)") },
OK.
> { NULL, 0, NULL, 0, NULL },
> };
>
> @@ -79,6 +81,9 @@ static struct argp argp =
> /* Additional getaddrinfo flags for IDN encoding. */
> static int idn_flags = AI_IDN | AI_CANONIDN;
>
> +/* Set to 0 by --no-addrconfig. */
> +static int addrconfig_flags = AI_ADDRCONFIG;
OK. Default to AI_ADDRCONFIG.
> +
> /* Print the version information. */
> static void
> print_version (FILE *stream, struct argp_state *state)
> @@ -346,7 +351,7 @@ ahosts_keys_int (int af, int xflags, int number, char *key[])
>
> struct addrinfo hint;
> memset (&hint, '\0', sizeof (hint));
> - hint.ai_flags = (AI_V4MAPPED | AI_ADDRCONFIG | AI_CANONNAME
> + hint.ai_flags = (AI_V4MAPPED | addrconfig_flags | AI_CANONNAME
OK.
> | idn_flags | xflags);
> hint.ai_family = af;
>
> @@ -905,6 +910,10 @@ parse_option (int key, char *arg, struct argp_state *state)
> idn_flags = 0;
> break;
>
> + case 'A':
> + addrconfig_flags = 0;
OK. Zero it.
> + break;
> +
> default:
> return ARGP_ERR_UNKNOWN;
> }
>
> base-commit: 05967faf0e3df6aad07f0b05e138e86f82363deb
>
prev parent reply other threads:[~2022-09-20 10:39 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-09-15 12:33 Florian Weimer
2022-09-20 10:39 ` Carlos O'Donell [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=YymYUR8NOo/pNxkI@fedora \
--to=carlos@redhat.com \
--cc=fweimer@redhat.com \
--cc=libc-alpha@sourceware.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).