From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [170.10.133.124]) by sourceware.org (Postfix) with ESMTPS id 5A5CA3858C54 for ; Wed, 5 Oct 2022 13:51:15 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.4.1 sourceware.org 5A5CA3858C54 Authentication-Results: sourceware.org; dmarc=pass (p=none dis=none) header.from=redhat.com Authentication-Results: sourceware.org; spf=pass smtp.mailfrom=redhat.com DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1664977875; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: in-reply-to:in-reply-to:references:references; bh=jvU4VS/iE/UCPhQj4YQm1Sa1APjKIUAP9ME1yJgECkc=; b=a/FPm+GSNFeDIRz1u0rLpmQhENK0trWz+5dEXpsuc+cI/bC69mUIIprJvcGQCXpq9F0ZMp cQ0sVR3GTuXuAbUJG95YvOqnEKW+GgwuSVilS6PgeT6jCcjAp2m7kS8Nw7ov/nJxdXNwW7 Gt3n2u6Hcj8OJYqjLf7sg/rZxFFOaIc= Received: from mail-qk1-f198.google.com (mail-qk1-f198.google.com [209.85.222.198]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.3, cipher=TLS_AES_128_GCM_SHA256) id us-mta-426-4sBZDLWoNG6tQMbBb7ln9g-1; Wed, 05 Oct 2022 09:51:13 -0400 X-MC-Unique: 4sBZDLWoNG6tQMbBb7ln9g-1 Received: by mail-qk1-f198.google.com with SMTP id ay35-20020a05620a17a300b006cfc01b4436so14327342qkb.13 for ; Wed, 05 Oct 2022 06:51:13 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=in-reply-to:content-disposition:mime-version:references:message-id :subject:cc:to:from:date:x-gm-message-state:from:to:cc:subject:date; bh=jvU4VS/iE/UCPhQj4YQm1Sa1APjKIUAP9ME1yJgECkc=; b=yZngMMhgA4X+5wxl/I/ImJwCoQcG3ABiJvxHzJYCq9Iis2mET/3/T9qLmwUDtB9EOv Xw8MTEoduLwqEHkySsE70jsphOjR1PrOjRtU36njpztBxPyljHQPz4aE1lPPWfRev2SE wt7uipjZGzM38WHmlEsaQp2yHGa1uzLtf0oV6OxISXi5O+giYYUOtlhy5NSZhBUMBp58 SZAC1ZCgpDjSJQAml6rvoSdna/Tp8j+rqbii6OVjY2qMIDddy5F55UdXzOjTGFUMkDHL dy1t3NkQpwdun7gGKfB5/atRxWRJlVVU36ls4AS/ASu5e4vVuKJQ/Fu2t1N4AOkFUImD tJCA== X-Gm-Message-State: ACrzQf1q0q5uJeeovsdMImAeWVT3cOAsrRWxMwvHkryh/Rr3z6a1lA5n +OyTxKQ0DsK+qP7CJDPaoXB0k8D5u5ktf7lT7XPz+RFzUqSuj6w9oPYgRJ3yQmhpLjg2Dmb/E/j u6qEm5bjDx/SvBRQ4bz2V X-Received: by 2002:ac8:5ccd:0:b0:35c:e18b:2be3 with SMTP id s13-20020ac85ccd000000b0035ce18b2be3mr23182658qta.502.1664977873143; Wed, 05 Oct 2022 06:51:13 -0700 (PDT) X-Google-Smtp-Source: AMsMyM4Ijr7pVgy7DSt0+c7zXWoywl3B6rg+1exftz04fUVR2gFwZ9h7VZG6uilmP8r30LG2xlB44g== X-Received: by 2002:ac8:5ccd:0:b0:35c:e18b:2be3 with SMTP id s13-20020ac85ccd000000b0035ce18b2be3mr23182650qta.502.1664977872964; Wed, 05 Oct 2022 06:51:12 -0700 (PDT) Received: from fedora ([66.187.232.65]) by smtp.gmail.com with ESMTPSA id s22-20020ac85296000000b00338ae1f5421sm13825383qtn.0.2022.10.05.06.51.11 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Wed, 05 Oct 2022 06:51:12 -0700 (PDT) Date: Wed, 5 Oct 2022 09:51:10 -0400 From: Carlos O'Donell To: Adhemerval Zanella Cc: libc-alpha@sourceware.org Subject: Re: [PATCH 4/6] rt: Initialize mq_send input on tst-mqueue{5,6} Message-ID: References: <20220921135108.3324737-1-adhemerval.zanella@linaro.org> <20220921135108.3324737-5-adhemerval.zanella@linaro.org> MIME-Version: 1.0 In-Reply-To: <20220921135108.3324737-5-adhemerval.zanella@linaro.org> X-Mimecast-Spam-Score: 0 X-Mimecast-Originator: redhat.com Content-Type: text/plain; charset=us-ascii Content-Disposition: inline X-Spam-Status: No, score=-12.9 required=5.0 tests=BAYES_00,DKIMWL_WL_HIGH,DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,GIT_PATCH_0,RCVD_IN_DNSWL_NONE,SPF_HELO_NONE,SPF_NONE,TXREP autolearn=ham autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on server2.sourceware.org List-Id: On Wed, Sep 21, 2022 at 10:51:06AM -0300, Adhemerval Zanella via Libc-alpha wrote: > GCC with -Os warns that the mq_send input may be used uninitialized. > Although for the tests the data content sent is not important, since > both tests checks only if mq_notify was properly set, the warning is > correct and data is indeed uninitialized. LGTM. No regressions on x86_64. Pre-commit CI didn't run for these patches. Reviewed-by: Carlos O'Donell Tested-by: Carlos O'Donell > Checked on x86_64-linux-gnu and i686-linux-gnu. > --- > rt/tst-mqueue5.c | 2 +- > rt/tst-mqueue6.c | 2 +- > 2 files changed, 2 insertions(+), 2 deletions(-) > > diff --git a/rt/tst-mqueue5.c b/rt/tst-mqueue5.c > index 70d97a36c2..2b19b6a031 100644 > --- a/rt/tst-mqueue5.c > +++ b/rt/tst-mqueue5.c > @@ -58,7 +58,7 @@ rtmin_handler (int sig, siginfo_t *info, void *ctx) > static int > (mqsend) (mqd_t q, int line) > { > - char c; > + char c = 0; OK. Agreed. Data needs to be initialized. > if (mq_send (q, &c, 1, 1) != 0) > { > printf ("mq_send on line %d failed with: %m\n", line); > diff --git a/rt/tst-mqueue6.c b/rt/tst-mqueue6.c > index bc875f101e..a22ac05aca 100644 > --- a/rt/tst-mqueue6.c > +++ b/rt/tst-mqueue6.c > @@ -40,7 +40,7 @@ > static int > (mqsend) (mqd_t q, int line) > { > - char c; > + char c = 0; OK. Agreed. Data needs to be initialized. > if (mq_send (q, &c, 1, 1) != 0) > { > printf ("mq_send on line %d failed with: %m\n", line); > -- > 2.34.1 >