From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [170.10.133.124]) by sourceware.org (Postfix) with ESMTPS id 8701E3858C54 for ; Wed, 5 Oct 2022 14:10:20 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.4.1 sourceware.org 8701E3858C54 Authentication-Results: sourceware.org; dmarc=pass (p=none dis=none) header.from=redhat.com Authentication-Results: sourceware.org; spf=pass smtp.mailfrom=redhat.com DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1664979020; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: in-reply-to:in-reply-to:references:references; bh=B7Y/xyx8lI6ouIU+C2YvEwa0lhdEw0Qvoq/RUCI6CrY=; b=T3Wu2x6bd94PrB/mOtvbXdcvGruLfGikHtBo+pNJz0dPoxnJf4ARgI2XzGedAdVC9r/zzS uEmvnELFJBjhrKZZfkqdjZNAeVapyVbjFtuchdGHSXsTvQvHWdYH23NLKlmpRExWr2HmOd RoOJjaGQJBEUKpqqCUK5TiG4r4SAl1o= Received: from mail-qv1-f72.google.com (mail-qv1-f72.google.com [209.85.219.72]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.3, cipher=TLS_AES_128_GCM_SHA256) id us-mta-282-PSTVCBE2NeKha0jznKWOBQ-1; Wed, 05 Oct 2022 10:10:17 -0400 X-MC-Unique: PSTVCBE2NeKha0jznKWOBQ-1 Received: by mail-qv1-f72.google.com with SMTP id ly5-20020a0562145c0500b004af8e9c4d94so10430205qvb.0 for ; Wed, 05 Oct 2022 07:10:17 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=in-reply-to:content-disposition:mime-version:references:message-id :subject:cc:to:from:date:x-gm-message-state:from:to:cc:subject:date; bh=B7Y/xyx8lI6ouIU+C2YvEwa0lhdEw0Qvoq/RUCI6CrY=; b=QFDhJ5wDo71fY3dy+ejf7OwB8wKDvJ9l0jLUhnXrbVLTJm99Un7LXXoFFfSUlwjrmV PHQ3QC0KH2g1QIJtoGW+1BN0oPxFBt2PJjhHx4BJYcEYn4CFFwUWFbXaMD1Xy/F0loHl F1M7YjzlVzPZeR7aUCuRosmZMKLtmqvswU04GPzZSi+xgvod8u/Lb9d7i0gL53CbhMfL n9yOY2XXOTnTO3qdqSHwXCPWHEHhqMLroIy3qFhbKE9DE+TQgE9mkPwgbzfc+uu3SNjc VTrRCWUYreJVBOkSzXgUUHtMruBCugd4s0fzp2+tz5ClMQl0nl0/ISyTFCj/KMmLT1ur ndwg== X-Gm-Message-State: ACrzQf0d6QPQPlVgWG49V+ZLiTFv0OjeD/i7mkpsCmg7XJnUwrB+V5wM kmOQLl3uGC4ECpViE65ON4g5j6C0S3XANmTUiXYO9F/9dgr/nulL6iG+6fbZfvDFKv7nBQIGV2P /aG+FLizKj74durSYDHzB X-Received: by 2002:a05:622a:54d:b0:35d:535c:3450 with SMTP id m13-20020a05622a054d00b0035d535c3450mr23446604qtx.62.1664979016461; Wed, 05 Oct 2022 07:10:16 -0700 (PDT) X-Google-Smtp-Source: AMsMyM6XnDVUqyyqiF4XMVi+OG5E7SNpn4HKadBA/EwTildzp82+wBf/lJfmjms7Kuob/M/jcbb8qQ== X-Received: by 2002:a05:622a:54d:b0:35d:535c:3450 with SMTP id m13-20020a05622a054d00b0035d535c3450mr23446580qtx.62.1664979016235; Wed, 05 Oct 2022 07:10:16 -0700 (PDT) Received: from fedora ([66.187.232.65]) by smtp.gmail.com with ESMTPSA id b9-20020a05622a020900b0035d430d4315sm14796610qtx.19.2022.10.05.07.10.15 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Wed, 05 Oct 2022 07:10:15 -0700 (PDT) Date: Wed, 5 Oct 2022 10:10:13 -0400 From: Carlos O'Donell To: Adhemerval Zanella Cc: libc-alpha@sourceware.org, hjl.tools@gmail.com Subject: Re: [PATCH 6/6] x86: Fix -Os build (BZ #29576) Message-ID: References: <20220921135108.3324737-1-adhemerval.zanella@linaro.org> <20220921135108.3324737-7-adhemerval.zanella@linaro.org> MIME-Version: 1.0 In-Reply-To: <20220921135108.3324737-7-adhemerval.zanella@linaro.org> X-Mimecast-Spam-Score: 0 X-Mimecast-Originator: redhat.com Content-Type: text/plain; charset=us-ascii Content-Disposition: inline X-Spam-Status: No, score=-13.0 required=5.0 tests=BAYES_00,DKIMWL_WL_HIGH,DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,GIT_PATCH_0,KAM_SHORT,RCVD_IN_DNSWL_NONE,SPF_HELO_NONE,SPF_NONE,TXREP autolearn=ham autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on server2.sourceware.org List-Id: On Wed, Sep 21, 2022 at 10:51:08AM -0300, Adhemerval Zanella via Libc-alpha wrote: > The compiler might transform __stpcpy calls (which are routed to > __builtin_stpcpy as an optimization) to strcpy and x86_64 strcpy > multiarch implementation does not build any working symbol due > ISA_SHOULD_BUILD not being evaluated for IS_IN(rtld). Ohhhhhh... that is interesting. This changes the strcpy used in rtld for all x86_64 build options, and I'm going to ACK this, but we may need to revisit this if it shows up in a profile. CC'ing HJ here in case he wants to comment as a machine maintainer. LGTM. No regressions on x86_64. Reviewed-by: Carlos O'Donell Tested-by: Carlos O'Donell > Checked on x86_64-linux-gnu. > --- > sysdeps/x86_64/multiarch/rtld-strcpy.S | 18 ++++++++++++++++++ > 1 file changed, 18 insertions(+) > create mode 100644 sysdeps/x86_64/multiarch/rtld-strcpy.S > > diff --git a/sysdeps/x86_64/multiarch/rtld-strcpy.S b/sysdeps/x86_64/multiarch/rtld-strcpy.S > new file mode 100644 > index 0000000000..19439c553d > --- /dev/null > +++ b/sysdeps/x86_64/multiarch/rtld-strcpy.S > @@ -0,0 +1,18 @@ > +/* Copyright (C) 2022 Free Software Foundation, Inc. > + This file is part of the GNU C Library. > + > + The GNU C Library is free software; you can redistribute it and/or > + modify it under the terms of the GNU Lesser General Public > + License as published by the Free Software Foundation; either > + version 2.1 of the License, or (at your option) any later version. > + > + The GNU C Library is distributed in the hope that it will be useful, > + but WITHOUT ANY WARRANTY; without even the implied warranty of > + MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the GNU > + Lesser General Public License for more details. > + > + You should have received a copy of the GNU Lesser General Public > + License along with the GNU C Library; if not, see > + . */ > + > +#include "../strcpy.S" OK. Uses Makeconfig:sysd-rules-patterns to capture rtld-*. > -- > 2.34.1 >