From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from EUR01-DB5-obe.outbound.protection.outlook.com (mail-eopbgr150084.outbound.protection.outlook.com [40.107.15.84]) by sourceware.org (Postfix) with ESMTPS id A79B53858D38 for ; Fri, 30 Sep 2022 12:32:08 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.4.1 sourceware.org A79B53858D38 Authentication-Results: sourceware.org; dmarc=pass (p=none dis=none) header.from=arm.com Authentication-Results: sourceware.org; spf=pass smtp.mailfrom=arm.com ARC-Seal: i=2; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=pass; b=TbhGMvF2+/1s5vp385ghNYaIpD83NmK2IyMeI4QNXMEKgMm1VlXPT9WeveZryx6MmLRmM7d7r+T/lYTPnwOT4xL/fdgpb4QUCUiXLxU4wQilDyG4RutTN6hI+KAcgP5+MIQ1FqaV7Z4jcYZ/pLRGd2Ei53Axosszjmb8gMN/L4e+XGFetMUozMcl+qd9z3HSFDFGJ6AB5rNmlUQKnZtuDuj4dyy8QA5mGaovMhEimcQtVYjp8Yety8F6rQbx9zPzwSA2RcntkYhcJ0Pa0EP/8LCxuO2LJenrPNbhbNoC8DCVupvsUAfuL1rek1R73bEcKIMC+RgIJZ7HHiusksv5dQ== ARC-Message-Signature: i=2; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=E8DZGVoVnwC7ATV/P+if6t1Fk4KW++6q3RkT8QT+bE0=; b=gJzTMt3MbPQP2htG4dzlVep6up12afFr+6xfxq1GL5MbHmc8UTSAAYSf6h/zjpqncLx9u+JOXrQ619r7tkTPpsj3Bn3Z54K3zT8h58mCJRzSkjAY1giRj+PZpk3kirEMvTUtEdknwGD3rvILzNGeYG0IkSzq3qOV3B/0UQbk8fF9yt1VuMwPRDfSRwHZScM0r2/NDNl7tO31Dat26F/NMIWbhhg5a2oWfOHSh6FrnE10jnDksxpkbaUxHhITKMcdMG/6sES3IXKzXettf5heWiifSm/QI9eGEpXxca8tJtJl7h7TNctJXIhVKwDsA3gh1qSMC0E5txPfd4JOEk3lmQ== ARC-Authentication-Results: i=2; mx.microsoft.com 1; spf=pass (sender ip is 63.35.35.123) smtp.rcpttodomain=sourceware.org smtp.mailfrom=arm.com; dmarc=pass (p=none sp=none pct=100) action=none header.from=arm.com; dkim=pass (signature was verified) header.d=armh.onmicrosoft.com; arc=pass (0 oda=1 ltdi=1 spf=[1,1,smtp.mailfrom=arm.com] dkim=[1,1,header.d=arm.com] dmarc=[1,1,header.from=arm.com]) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=armh.onmicrosoft.com; s=selector2-armh-onmicrosoft-com; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=E8DZGVoVnwC7ATV/P+if6t1Fk4KW++6q3RkT8QT+bE0=; b=qKT/T4DT2h9ro+zYXq3r/YNHcjTkDqywc/3XYeCbubeqEw8yEnyDoSq19usSkBqoHXo2rO71U1igELv+r/z0gSJWukivaoikCA+6kAkfNaCqbQoBZ/fp03QwQN8WdXsySunLOTW5K6qRx4nAYkcCh0aNbFiYwLY3bA4IyHApYmY= Received: from AS9PR06CA0335.eurprd06.prod.outlook.com (2603:10a6:20b:466::34) by DU0PR08MB8882.eurprd08.prod.outlook.com (2603:10a6:10:47d::8) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.5676.17; Fri, 30 Sep 2022 12:32:04 +0000 Received: from AM7EUR03FT041.eop-EUR03.prod.protection.outlook.com (2603:10a6:20b:466:cafe::6) by AS9PR06CA0335.outlook.office365.com (2603:10a6:20b:466::34) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.5676.23 via Frontend Transport; Fri, 30 Sep 2022 12:32:04 +0000 X-MS-Exchange-Authentication-Results: spf=pass (sender IP is 63.35.35.123) smtp.mailfrom=arm.com; dkim=pass (signature was verified) header.d=armh.onmicrosoft.com;dmarc=pass action=none header.from=arm.com; Received-SPF: Pass (protection.outlook.com: domain of arm.com designates 63.35.35.123 as permitted sender) receiver=protection.outlook.com; client-ip=63.35.35.123; helo=64aa7808-outbound-1.mta.getcheckrecipient.com; pr=C Received: from 64aa7808-outbound-1.mta.getcheckrecipient.com (63.35.35.123) by AM7EUR03FT041.mail.protection.outlook.com (100.127.140.233) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.5676.17 via Frontend Transport; Fri, 30 Sep 2022 12:32:04 +0000 Received: ("Tessian outbound 7761be2ecf00:v128"); Fri, 30 Sep 2022 12:32:04 +0000 X-CheckRecipientChecked: true X-CR-MTA-CID: 01528d6afb508310 X-CR-MTA-TID: 64aa7808 Received: from 7ff7e81af460.1 by 64aa7808-outbound-1.mta.getcheckrecipient.com id F42CD3FD-E4E0-4C86-9403-3219A7E1F10C.1; Fri, 30 Sep 2022 12:31:57 +0000 Received: from EUR04-HE1-obe.outbound.protection.outlook.com by 64aa7808-outbound-1.mta.getcheckrecipient.com with ESMTPS id 7ff7e81af460.1 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384); Fri, 30 Sep 2022 12:31:57 +0000 ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=of5ZibnSwv1vpXIxZ3fHEyedYK7h0s6r3QhbAtyIJihy4RCo6R9jNcK8sEjQ5WMfcsLB//hEfuHt1T68RJnEI3rY42CtxYpbESqmSwS+Bohau1uJ3rZAZd5+wSaSOsEhRRIIl/fg8CJwFX2zXvxQA34FHXBRN9fAc9juUDXOsYzMlKubjcIiR1IQKwTyWJl5MpCiaMY3lzrGYayhHmRjoLq+Qc5ql/ImphXUxl1yymFnujmkacxj+M7cb/Acv0ieyJ/faIOeFvsyiUD/cs7/r3vX7M+moTxzKNo/gZGCm6yb4eEu+6kSoBTyps3L48NX0Hk+ENK+MpLL2ZBmH+Gh+w== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=E8DZGVoVnwC7ATV/P+if6t1Fk4KW++6q3RkT8QT+bE0=; b=aEtnu8dzqv6ZKBKBtEcV15ko1t3pmV68EcW26y9hBEM3ceM/zMYIiOexwWeW0MI8qz0u9CT7taXFNpG9oCuWqZR9/R1uGh722HHaRtpPvt6HyA/c/+RM4qplZ4jBOOSFD0qI/AOfuhCSEILDbHqSOejVwzVdMA0ph17WNxsqrwgKccPFrOrEBDOgkLrUZhMWWhwic7s+4d5z8F+Ur4O0+u18KuA+8MuLVmeJxazsA4HbV4KGqS6k9m0hKWrr3C1+pJbVDxf9i31pRJ6BbYdGdlyYby/M70wB1IMuwYFx1QL58WE4Rv9c6QofsgCX7Scg5KKngTyOCMXaYq1sfP4JrQ== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=arm.com; dmarc=pass action=none header.from=arm.com; dkim=pass header.d=arm.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=armh.onmicrosoft.com; s=selector2-armh-onmicrosoft-com; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=E8DZGVoVnwC7ATV/P+if6t1Fk4KW++6q3RkT8QT+bE0=; b=qKT/T4DT2h9ro+zYXq3r/YNHcjTkDqywc/3XYeCbubeqEw8yEnyDoSq19usSkBqoHXo2rO71U1igELv+r/z0gSJWukivaoikCA+6kAkfNaCqbQoBZ/fp03QwQN8WdXsySunLOTW5K6qRx4nAYkcCh0aNbFiYwLY3bA4IyHApYmY= Authentication-Results-Original: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=arm.com; Received: from DB9PR08MB7179.eurprd08.prod.outlook.com (2603:10a6:10:2cc::19) by AM0PR08MB5299.eurprd08.prod.outlook.com (2603:10a6:208:18d::21) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.5676.23; Fri, 30 Sep 2022 12:31:55 +0000 Received: from DB9PR08MB7179.eurprd08.prod.outlook.com ([fe80::d5df:4125:b701:4cd4]) by DB9PR08MB7179.eurprd08.prod.outlook.com ([fe80::d5df:4125:b701:4cd4%7]) with mapi id 15.20.5676.023; Fri, 30 Sep 2022 12:31:54 +0000 Date: Fri, 30 Sep 2022 13:31:36 +0100 From: Szabolcs Nagy To: Adhemerval Zanella Netto Cc: Florian Weimer , libc-alpha@sourceware.org Subject: Re: [PATCH v5 2/3] linux: Fix ancillary 64-bit time timestamp conversion (BZ #28349, BZ#28350) Message-ID: References: <20220127201542.2306657-1-adhemerval.zanella@linaro.org> <20220127201542.2306657-3-adhemerval.zanella@linaro.org> Content-Type: text/plain; charset=utf-8 Content-Disposition: inline In-Reply-To: X-ClientProxiedBy: LO4P123CA0297.GBRP123.PROD.OUTLOOK.COM (2603:10a6:600:196::14) To DB9PR08MB7179.eurprd08.prod.outlook.com (2603:10a6:10:2cc::19) MIME-Version: 1.0 X-MS-TrafficTypeDiagnostic: DB9PR08MB7179:EE_|AM0PR08MB5299:EE_|AM7EUR03FT041:EE_|DU0PR08MB8882:EE_ X-MS-Office365-Filtering-Correlation-Id: 76d97094-5d0f-431a-08dd-08daa2dfc84b x-checkrecipientrouted: true NoDisclaimer: true X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam-Untrusted: BCL:0; X-Microsoft-Antispam-Message-Info-Original: nOqbB0/0ZR6UYkj6fetXCFMNlTFSNzCje/ubzmhLVeeRDUpFc6OqimBD/HEWqtYFDCBMd7crTcBDzeV8EaxsgzZjHV3G+0stVJ1DaHp6Lgk2zrSEOBU37jReuXsjIg1TpDT1KLRi1u4jZCVYEUevNa5Xz8AnPuuuyiWwntI5GnUdb1kt0ohG9+MlxiBLwfhAhN5gvWLbT/U4RsFGhs2pH9yonH/sPvBtE3ALzhRI784nKM/abvlBrHMczaHfN8LcVEn7n36A3CU9jYr6Ot1uOZ70qhfAsdtRw1CfutVv6JsIzd4L+UgyZhxsuvsxs9vbQ6gxlJxmP2gPcCitsnKz3MQ0qxW/JZfXxu5nAhGFp6YnEdShgPxE+FhUdQx4kEPlP/QcX49ir8x/rdiVhevEMydSOAv85W1vY+tHY/zAX3z4lBs2bViJbSr9DP/CeTR2AiwphoQdDfuSLxa4Ha55S4sy3TyX1Ugj0UHLpXuXDTLC32RD17N3L0KluehnTd9pLHEtA/h1yONx4CifR1q0byHESdlWoMB+19ewuWguCrehs5zmn8rCuOWXdxY8iKkw+ko2HPVsAJxpELyml7h23edAxk2nrEJUZTo1d63ZOddBavUVa8bR0uVI5o7TxHOgSJt/D/NHJiUdGzaASSKKMaPEA7c/VghXy9xEebj/VW9hzwxNqSWx2uO15B80+BYo6z+K0nmkjLwpz/Bl6Rmo0A== X-Forefront-Antispam-Report-Untrusted: CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:DB9PR08MB7179.eurprd08.prod.outlook.com;PTR:;CAT:NONE;SFS:(13230022)(4636009)(346002)(366004)(396003)(136003)(376002)(39860400002)(451199015)(26005)(6512007)(186003)(5660300002)(83380400001)(2616005)(44832011)(66946007)(66476007)(66556008)(4326008)(2906002)(6486002)(6916009)(316002)(6506007)(8676002)(86362001)(6666004)(478600001)(53546011)(38100700002)(8936002)(36756003)(41300700001);DIR:OUT;SFP:1101; X-MS-Exchange-Transport-CrossTenantHeadersStamped: AM0PR08MB5299 Original-Authentication-Results: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=arm.com; X-EOPAttributedMessage: 0 X-MS-Exchange-Transport-CrossTenantHeadersStripped: AM7EUR03FT041.eop-EUR03.prod.protection.outlook.com X-MS-PublicTrafficType: Email X-MS-Office365-Filtering-Correlation-Id-Prvs: 41c85a01-14f5-4e88-3c88-08daa2dfc213 X-Microsoft-Antispam: BCL:0; X-Microsoft-Antispam-Message-Info: 5w18FixesZ2MiNDLNaWg09wt/Y+OfDvZII2FQPxw7mxPVBsLGrq9ViC8skA2Q6Iteo9jcAkvlSltZ+WTxmnLX/XzyyXSXUgvIJiwIUh7X7VSCp5stZfjvvUBHk+WCSwx+7vzo9PNuvZfUTaZ86QFU/IH7Ax4GODtXJokye0s6sOYS681jb811n8tXuHeyH7bU1ab/Mbvf0v/Pp1bvCJ9p2RZt20aoQjj+3ugRfdM89H0YFkzjgyYiNeMc0JAQn5FBDmuP8Etv0BhpS5C5BPu7J30MpdYcZCgAteCyfR+HiiGxBNuZd/HJl156XpuFXxTmUbLLnFtiJXS4Biyw1w9NAzombwMStTOecstNLaWLmAlHzo3zKXqVhkT+Wtx68zE7xso2WYYhP78wwF74OgpG5++MDWfVYrc4KYUOJds1TCeV+gxdiU11R7sQy0uSuLBdb91suJwYL+h1cTXNDV6r8oLWeQeUVIqoR+2R6uHO7H1lVrEqa4bfbvn9++H56txEHMU/ekjaHlYIxvTIbgLCaF9m1WrPheCjEHquyhFOOLb2DjqHVwyXjQaTDxaAQ/4YvASh0+UXYZ9uWF4ZQDIn+Dm4AFbNJqAAqbIGi6G47mnSTJtmwzCV8Frw7mYUgjxJDXMxmpeTZj8TQw5pF6SpYQyJej+GWFdBPdTtm4Jq7JLPe7MuQjKAZ9+tVaXSN9w35oYSOAaKV9ZIt7e3s2GI+HJZDXongtYyzANofQCB0qCEPsHaDpAv2fW7E7YhgoyJNn7sWtKzwq2MT27Ua+TVQ== X-Forefront-Antispam-Report: CIP:63.35.35.123;CTRY:IE;LANG:en;SCL:1;SRV:;IPV:CAL;SFV:NSPM;H:64aa7808-outbound-1.mta.getcheckrecipient.com;PTR:ec2-63-35-35-123.eu-west-1.compute.amazonaws.com;CAT:NONE;SFS:(13230022)(4636009)(396003)(39860400002)(376002)(346002)(136003)(451199015)(40470700004)(36840700001)(46966006)(47076005)(26005)(6512007)(336012)(2616005)(186003)(478600001)(36756003)(81166007)(6506007)(316002)(2906002)(82740400003)(83380400001)(36860700001)(53546011)(6486002)(40480700001)(6666004)(6862004)(70586007)(40460700003)(8936002)(5660300002)(41300700001)(70206006)(356005)(4326008)(8676002)(82310400005)(44832011)(86362001);DIR:OUT;SFP:1101; X-OriginatorOrg: arm.com X-MS-Exchange-CrossTenant-OriginalArrivalTime: 30 Sep 2022 12:32:04.7645 (UTC) X-MS-Exchange-CrossTenant-Network-Message-Id: 76d97094-5d0f-431a-08dd-08daa2dfc84b X-MS-Exchange-CrossTenant-Id: f34e5979-57d9-4aaa-ad4d-b122a662184d X-MS-Exchange-CrossTenant-OriginalAttributedTenantConnectingIp: TenantId=f34e5979-57d9-4aaa-ad4d-b122a662184d;Ip=[63.35.35.123];Helo=[64aa7808-outbound-1.mta.getcheckrecipient.com] X-MS-Exchange-CrossTenant-AuthSource: AM7EUR03FT041.eop-EUR03.prod.protection.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Anonymous X-MS-Exchange-CrossTenant-FromEntityHeader: HybridOnPrem X-MS-Exchange-Transport-CrossTenantHeadersStamped: DU0PR08MB8882 X-Spam-Status: No, score=-5.9 required=5.0 tests=BAYES_00,DKIM_SIGNED,DKIM_VALID,FORGED_SPF_HELO,KAM_DMARC_NONE,RCVD_IN_DNSWL_NONE,RCVD_IN_MSPIKE_H2,SPF_HELO_PASS,SPF_NONE,TXREP,UNPARSEABLE_RELAY autolearn=no autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on server2.sourceware.org List-Id: The 09/30/2022 08:24, Adhemerval Zanella Netto wrote: > On 30/09/22 08:05, Szabolcs Nagy wrote: > > The 09/30/2022 11:47, Szabolcs Nagy via Libc-alpha wrote: > >> The 01/27/2022 17:15, Adhemerval Zanella via Libc-alpha wrote: > >>> The __convert_scm_timestamps only updates the control message last > >>> pointer for SOL_SOCKET type, so if the message control buffer contains > >>> multiple ancillary message types the converted timestamp one might > >>> overwrite a valid message. > >>> > >>> The test checks if the extra ancillary space is correctly handled > >>> by recvmsg/recvmmsg, where if there is no extra space for the 64-bit > >>> time_t converted message the control buffer should be marked with > >>> MSG_TRUNC. It also check if recvmsg/recvmmsg handle correctly multiple > >>> ancillary data. > >>> > >>> Checked on x86_64-linux and on i686-linux-gnu on both 5.11 and > >>> 4.15 kernel. > >>> > >>> Co-authored-by: Fabian Vogt > >> > >> note: the time64 recvmsg test started to fail on 32bit > >> arm after i updated my aarch64 kernel to 5.18 > > > > sorry the kernel is > > Linux 8a7948402d35 5.15.0-48-generic #54~20.04.1-Ubuntu SMP Thu Sep 1 16:20:53 UTC 2022 aarch64 aarch64 aarch64 GNU/Linux > > I just check on exactly same kernel (ubuntu 22) on a aarch64 VM and I could not > reproduce it: > > $ uname -a > Linux ubuntu-aarch64 5.15.0-48-generic #54-Ubuntu SMP Fri Aug 26 13:31:33 UTC 2022 aarch64 aarch64 aarch64 GNU/Linux > $ file socket/tst-socket-timestamp > socket/tst-socket-timestamp: ELF 32-bit LSB pie executable, ARM, EABI5 version 1 (SYSV), dynamically linked, interpreter /lib/ld-linux-armhf.so.3, for GNU/Linux 3.2.0, with debug_info, not stripped > $ file socket/tst-socket-timestamp-time64 > socket/tst-socket-timestamp-time64: ELF 32-bit LSB pie executable, ARM, EABI5 version 1 (SYSV), dynamically linked, interpreter /lib/ld-linux-armhf.so.3, for GNU/Linux 3.2.0, with debug_info, not stripped > $ ./testrun.sh socket/tst-socket-timestamp > $ ./testrun.sh socket/tst-socket-timestamp-time64 > $ > > I used gcc 12.1.1, maybe it is a compiler issue? sorry it was my fault: old kernel headers.