From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from hall.aurel32.net (hall.aurel32.net [IPv6:2001:bc8:30d7:100::1]) by sourceware.org (Postfix) with ESMTPS id B634B385C402 for ; Mon, 3 Oct 2022 19:59:52 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.4.1 sourceware.org B634B385C402 Authentication-Results: sourceware.org; dmarc=none (p=none dis=none) header.from=aurel32.net Authentication-Results: sourceware.org; spf=none smtp.mailfrom=aurel32.net DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=aurel32.net ; s=202004.hall; h=In-Reply-To:Content-Type:MIME-Version:References: Message-ID:Subject:To:From:Date:Content-Transfer-Encoding:Cc:From:Reply-To: Subject:Content-ID:Content-Description:X-Debbugs-Cc; bh=rs87g1/e/R5uHCPUv8D10Yhr8nSdpEjNwmDcPFouejE=; b=rFFldu9SAl98mhDbCRCNy2PLd3 IYAssZMRMUA9ft0u7AD9IqndFTxiRWQo+DN38rx7cUrJXHDKlZmXr++DYl11U++NA4hXBOJXCWFZw 7AmECv+0XSILjcWnzdDttSU3L+oQCr7gn5Asul7VLlhT3Y/t6/26k2SEvEkFvtuScr7mAC7Vhe/vU IxHsD8WTkiT5W9eO4jBSuX9Wdw8/q0aAHMJAc69KoNKhwGu2pqgm0F6Smza4fuyuH5dOOHoAcCODh 2MjvW7kh1AXY+ZddEFLf10cjSjg1FA1TiNuKeD9iO/UxMWguQY7YbA0AZ+nEp16N9ERVrSHQ+91MX StVUnJZA==; Received: from [2a01:e34:ec5d:a741:8a4c:7c4e:dc4c:1787] (helo=ohm.rr44.fr) by hall.aurel32.net with esmtpsa (TLS1.3) tls TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384 (Exim 4.94.2) (envelope-from ) id 1ofRbS-00GHJH-MR; Mon, 03 Oct 2022 21:59:50 +0200 Received: from aurel32 by ohm.rr44.fr with local (Exim 4.96) (envelope-from ) id 1ofRbR-00Djwx-05; Mon, 03 Oct 2022 21:59:49 +0200 Date: Mon, 3 Oct 2022 21:59:49 +0200 From: Aurelien Jarno To: Sunil Pandey , Noah Goldstein , Hongjiu Lu , libc-alpha@sourceware.org Subject: Re: [PATCH v2 2/6] x86-64: Require BMI2 for AVX2 str*cmp and wcs(n)cmp implementations Message-ID: Mail-Followup-To: Sunil Pandey , Noah Goldstein , Hongjiu Lu , libc-alpha@sourceware.org References: <20221002123424.3079805-1-aurelien@aurel32.net> <20221002123424.3079805-3-aurelien@aurel32.net> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: User-Agent: Mutt/2.2.7 (2022-08-07) X-Spam-Status: No, score=-7.1 required=5.0 tests=BAYES_00,DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,SPF_HELO_PASS,SPF_NONE,TXREP autolearn=ham autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on server2.sourceware.org List-Id: On 2022-10-03 21:21, Aurelien Jarno wrote: > On 2022-10-03 11:43, Sunil Pandey wrote: > > On Mon, Oct 3, 2022 at 10:50 AM Noah Goldstein wrote: > > > > > > On Mon, Oct 3, 2022 at 10:35 AM Aurelien Jarno wrote: > > > > > > > > On 2022-10-03 09:19, Sunil Pandey via Libc-alpha wrote: > > > > > Please separate this patch into 4 separate patches. > > > > > > > > > > Patch1: sysdeps/x86_64/multiarch/strncmp.c > > > > > Patch2: sysdeps/x86_64/multiarch/strcmp.c > > > > > Patch3: sysdeps/x86_64/multiarch/ifunc-strcasecmp.h > > > > > Patch4: sysdeps/x86_64/multiarch/ifunc-impl-list.c > > > > > > > > > > Rest of them looks OK to me. > > > > > > > > I don't fully see the point of doing that, but i'll do it in the next > > > > version. > > > > > > I think to make backporting easier. > > > > Exactly. > > > > If you look closely, this patch combines 4 independent ifunc > > functionality in one single patch. > > It's partially true. I actually count 3 different functionalities. The > changes in ifunc-impl-list are all related to the other 3. I have just sent a v3 that split that patch in smaller pieces: - str(n)casecmp - strcmp - strncmp - wcs(n)cmp I do not see the point in separating the changes from ifunc-impl-list.c, as we should actually ensure that they are in sync with the ifunc selector so that the testing is done properly. -- Aurelien Jarno GPG: 4096R/1DDD8C9B aurelien@aurel32.net http://www.aurel32.net