From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from hall.aurel32.net (hall.aurel32.net [IPv6:2001:bc8:30d7:100::1]) by sourceware.org (Postfix) with ESMTPS id 2146D3858D1E for ; Mon, 3 Oct 2022 19:21:03 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.4.1 sourceware.org 2146D3858D1E Authentication-Results: sourceware.org; dmarc=none (p=none dis=none) header.from=aurel32.net Authentication-Results: sourceware.org; spf=none smtp.mailfrom=aurel32.net DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=aurel32.net ; s=202004.hall; h=In-Reply-To:Content-Type:MIME-Version:References: Message-ID:Subject:Cc:To:From:Date:Content-Transfer-Encoding:From:Reply-To: Subject:Content-ID:Content-Description:X-Debbugs-Cc; bh=XeUcnwhUURSkdSszBkilyRYBih675RMKP8YlJm7NCtg=; b=M01yM1U0aCzHI5wuyTOnOQO4uS Aiu8HTUC1/aNIuHoYN3ur72CAwENheqXZfmigy6X/FnKV/BMf91Vn/jP/hNljNnXhb9BbOO9H18xe cA/9bYUyCQ9qnEKEzboQXYc3pQlNEYl3q8ph5wn16w/+wqt1Wd05JSImMWzl+vN6eDKLhqo2lQWYs opzh8sGwq7f+n4b0GOY4KqMYRn3KmXrsX7JdgFMXsCJItSsihlPJRU5CzyVsAnaNwNhFmV9Zj2UAC 3rP7NYVnGL8Fhcuf+Nv6KP0mnc0X+S5AwuD2gzOpnC6r7UbfN0V1z8uA2/R3gD2luYLpWX9NhR0d/ 5e1Fj9Dg==; Received: from aurel32 by hall.aurel32.net with local (Exim 4.94.2) (envelope-from ) id 1ofQzs-00GGAp-Rc; Mon, 03 Oct 2022 21:21:00 +0200 Date: Mon, 3 Oct 2022 21:21:00 +0200 From: Aurelien Jarno To: Sunil Pandey Cc: Noah Goldstein , Hongjiu Lu , libc-alpha@sourceware.org Subject: Re: [PATCH v2 2/6] x86-64: Require BMI2 for AVX2 str*cmp and wcs(n)cmp implementations Message-ID: Mail-Followup-To: Sunil Pandey , Noah Goldstein , Hongjiu Lu , libc-alpha@sourceware.org References: <20221002123424.3079805-1-aurelien@aurel32.net> <20221002123424.3079805-3-aurelien@aurel32.net> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: User-Agent: Mutt/2.0.5 (2021-01-21) X-Spam-Status: No, score=-5.3 required=5.0 tests=BAYES_00,DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,SPF_HELO_PASS,SPF_NONE,TXREP autolearn=ham autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on server2.sourceware.org List-Id: On 2022-10-03 11:43, Sunil Pandey wrote: > On Mon, Oct 3, 2022 at 10:50 AM Noah Goldstein wrote: > > > > On Mon, Oct 3, 2022 at 10:35 AM Aurelien Jarno wrote: > > > > > > On 2022-10-03 09:19, Sunil Pandey via Libc-alpha wrote: > > > > Please separate this patch into 4 separate patches. > > > > > > > > Patch1: sysdeps/x86_64/multiarch/strncmp.c > > > > Patch2: sysdeps/x86_64/multiarch/strcmp.c > > > > Patch3: sysdeps/x86_64/multiarch/ifunc-strcasecmp.h > > > > Patch4: sysdeps/x86_64/multiarch/ifunc-impl-list.c > > > > > > > > Rest of them looks OK to me. > > > > > > I don't fully see the point of doing that, but i'll do it in the next > > > version. > > > > I think to make backporting easier. > > Exactly. > > If you look closely, this patch combines 4 independent ifunc > functionality in one single patch. It's partially true. I actually count 3 different functionalities. The changes in ifunc-impl-list are all related to the other 3. > As per latest backporting guideline, backport patches must apply > cleanly without any change. Having small independent patches > makes backporting a little easier. > I agree with that when we are talking about backporting improvements. In that case we have to backport the changes to fix the bug, even if they don't apply cleanly. -- Aurelien Jarno GPG: 4096R/1DDD8C9B aurelien@aurel32.net http://www.aurel32.net