From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from hall.aurel32.net (hall.aurel32.net [IPv6:2001:bc8:30d7:100::1]) by sourceware.org (Postfix) with ESMTPS id 5E3733857BB7 for ; Mon, 3 Oct 2022 17:35:07 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.4.1 sourceware.org 5E3733857BB7 Authentication-Results: sourceware.org; dmarc=none (p=none dis=none) header.from=aurel32.net Authentication-Results: sourceware.org; spf=none smtp.mailfrom=aurel32.net DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=aurel32.net ; s=202004.hall; h=In-Reply-To:Content-Type:MIME-Version:References: Message-ID:Subject:Cc:To:From:Date:Content-Transfer-Encoding:From:Reply-To: Subject:Content-ID:Content-Description:X-Debbugs-Cc; bh=UzCAnx6xdddpsayy+Z7C9ETyxWP3vJDd3eu91XVCiZI=; b=StO5vOQgR6LTRZhkpXTWbs4/Un weGeTyEyvEHp613m2mijHE9xctRDdGkC0bnXhjG2QJrKi4mTh6NGI6OW5lY4R7XD6CQS5u34M7Noz cW6HneN9wFkm9mXWu+IrKu1EmTWaIXTdOMNl70zPHtdi08HTSAsDncZY44klr05O3+iJa92dYOJRI Q5xUiOsfBeFuSCwMsUG7cvnTCe2JVU+FAJ7W/+UZFTFcZJJW6ZD7i+PoELu4agIt6WCf5DUFwXo6O ojHQMyu0JkDOspcfY1UDTzekopccRWKwbv2FvuClgZrRPaoG85TXnnmQlSVsnVHHCR5CHSI7EOr2z 1HFsIo6A==; Received: from [2a01:e34:ec5d:a741:8a4c:7c4e:dc4c:1787] (helo=ohm.rr44.fr) by hall.aurel32.net with esmtpsa (TLS1.3) tls TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384 (Exim 4.94.2) (envelope-from ) id 1ofPLN-00GCkv-S9; Mon, 03 Oct 2022 19:35:05 +0200 Received: from aurel32 by ohm.rr44.fr with local (Exim 4.96) (envelope-from ) id 1ofPLN-00DetX-1N; Mon, 03 Oct 2022 19:35:05 +0200 Date: Mon, 3 Oct 2022 19:35:05 +0200 From: Aurelien Jarno To: Sunil Pandey Cc: Noah Goldstein , libc-alpha@sourceware.org Subject: Re: [PATCH v2 2/6] x86-64: Require BMI2 for AVX2 str*cmp and wcs(n)cmp implementations Message-ID: Mail-Followup-To: Sunil Pandey , Noah Goldstein , libc-alpha@sourceware.org References: <20221002123424.3079805-1-aurelien@aurel32.net> <20221002123424.3079805-3-aurelien@aurel32.net> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: User-Agent: Mutt/2.2.7 (2022-08-07) X-Spam-Status: No, score=-7.1 required=5.0 tests=BAYES_00,DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,SPF_HELO_PASS,SPF_NONE,TXREP autolearn=ham autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on server2.sourceware.org List-Id: On 2022-10-03 09:19, Sunil Pandey via Libc-alpha wrote: > Please separate this patch into 4 separate patches. > > Patch1: sysdeps/x86_64/multiarch/strncmp.c > Patch2: sysdeps/x86_64/multiarch/strcmp.c > Patch3: sysdeps/x86_64/multiarch/ifunc-strcasecmp.h > Patch4: sysdeps/x86_64/multiarch/ifunc-impl-list.c > > Rest of them looks OK to me. I don't fully see the point of doing that, but i'll do it in the next version. -- Aurelien Jarno GPG: 4096R/1DDD8C9B aurelien@aurel32.net http://www.aurel32.net