From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from EUR05-AM6-obe.outbound.protection.outlook.com (mail-am6eur05on2054.outbound.protection.outlook.com [40.107.22.54]) by sourceware.org (Postfix) with ESMTPS id 104FC3858D39 for ; Mon, 13 Mar 2023 09:07:38 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.4.2 sourceware.org 104FC3858D39 Authentication-Results: sourceware.org; dmarc=pass (p=none dis=none) header.from=arm.com Authentication-Results: sourceware.org; spf=pass smtp.mailfrom=arm.com DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=armh.onmicrosoft.com; s=selector2-armh-onmicrosoft-com; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=ZZfc6MXFail4eh0Eish/o7FHggQ56BiEJuEuDIsxZT4=; b=Jm/SUNGtcaXu1ZDFbL85ApGwvcY4gIcMfNcHIsId8KSspz55RJKv82XYC8pKoCaJgfpOgZXbOwXzBptQLiIJ6tXuE6tg89mdm3rn5bVUu9UChVQ5vRTwXDJ0wxV6auyBvk1fQOzyf6cC2neKg5HqexWZnMWgi0O6PwB3myHpE4U= Received: from DUZPR01CA0173.eurprd01.prod.exchangelabs.com (2603:10a6:10:4b3::27) by PA4PR08MB6191.eurprd08.prod.outlook.com (2603:10a6:102:f3::12) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.6178.24; Mon, 13 Mar 2023 09:07:35 +0000 Received: from DBAEUR03FT038.eop-EUR03.prod.protection.outlook.com (2603:10a6:10:4b3:cafe::c2) by DUZPR01CA0173.outlook.office365.com (2603:10a6:10:4b3::27) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.6178.25 via Frontend Transport; Mon, 13 Mar 2023 09:07:35 +0000 X-MS-Exchange-Authentication-Results: spf=pass (sender IP is 63.35.35.123) smtp.mailfrom=arm.com; dkim=pass (signature was verified) header.d=armh.onmicrosoft.com;dmarc=pass action=none header.from=arm.com; Received-SPF: Pass (protection.outlook.com: domain of arm.com designates 63.35.35.123 as permitted sender) receiver=protection.outlook.com; client-ip=63.35.35.123; helo=64aa7808-outbound-1.mta.getcheckrecipient.com; pr=C Received: from 64aa7808-outbound-1.mta.getcheckrecipient.com (63.35.35.123) by DBAEUR03FT038.mail.protection.outlook.com (100.127.143.23) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.6199.11 via Frontend Transport; Mon, 13 Mar 2023 09:07:35 +0000 Received: ("Tessian outbound fcd8b5fba459:v135"); Mon, 13 Mar 2023 09:07:35 +0000 X-CheckRecipientChecked: true X-CR-MTA-CID: 41744428349bda70 X-CR-MTA-TID: 64aa7808 Received: from e576fb343d5c.1 by 64aa7808-outbound-1.mta.getcheckrecipient.com id 310FB80E-6111-4E22-80D4-4301EB34D6B2.1; Mon, 13 Mar 2023 09:07:25 +0000 Received: from EUR05-DB8-obe.outbound.protection.outlook.com by 64aa7808-outbound-1.mta.getcheckrecipient.com with ESMTPS id e576fb343d5c.1 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384); Mon, 13 Mar 2023 09:07:25 +0000 ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=LTMKDJj/U4yYRBelaUuLWnjKD679jrj7Hb6JUh31CjAPIGtKCYJWFehAdp2PMg3t8S15AhLpgYUUMX/gWwtucBIKpJifHtMKM//2iikwU/oO0UCnF1ReNBZ0dlegW6pwrdvj6AK7RrRhxei2U2xhhIf3TlAHmSHYw6nkQ/sNIFROzUIoN4WK9vVOLfm54LWze2LiTuyljkzPWkQPLfSlel3kiN7WFQi0FnmpBCBuCGX1C0TTx86CONm5JubD9FgrrmMAacW8PVffCO+KeT3EkxcOkxit9Pvx8Y0Mwhm3xqW5IJrJpFKPwytaWYcrVvtjOC1NVeGxdux0HApAVKpqeg== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=ZZfc6MXFail4eh0Eish/o7FHggQ56BiEJuEuDIsxZT4=; b=ddpwscgMSOPBy2RGcq5XYQe6guu1EeJP+0L9XzTSzMfSiq6ce8WvetauUV21BuDEimT9ldSrP8dygVuTE5S5Qpa6gC7qbHNy+VnAx0z/RsHgrUA3PHEsGKoDr+Rmne2fUoxodbMYnYiEV1ufbxttBGCUafXGJQLz0AHmQUEKOPaPtdnbuwL2aiF4EaX3VXlT1+NFbhvXDTZ7WFJaGcU1UIElV4iH0y75tUO+0gTulAbAluohtP1RNGiDyMPRnVcHJkkY8oJoG0guc8eeZUXxqSm23ti2UnjYB4WgwvppaEOa0/3b1Mt/HwlWE+VjDjyU5gqqjjThh270YQ+IDd/d8A== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=arm.com; dmarc=pass action=none header.from=arm.com; dkim=pass header.d=arm.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=armh.onmicrosoft.com; s=selector2-armh-onmicrosoft-com; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=ZZfc6MXFail4eh0Eish/o7FHggQ56BiEJuEuDIsxZT4=; b=Jm/SUNGtcaXu1ZDFbL85ApGwvcY4gIcMfNcHIsId8KSspz55RJKv82XYC8pKoCaJgfpOgZXbOwXzBptQLiIJ6tXuE6tg89mdm3rn5bVUu9UChVQ5vRTwXDJ0wxV6auyBvk1fQOzyf6cC2neKg5HqexWZnMWgi0O6PwB3myHpE4U= Authentication-Results-Original: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=arm.com; Received: from DB9PR08MB7179.eurprd08.prod.outlook.com (2603:10a6:10:2cc::19) by DU0PR08MB9679.eurprd08.prod.outlook.com (2603:10a6:10:445::11) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.6178.24; Mon, 13 Mar 2023 09:07:20 +0000 Received: from DB9PR08MB7179.eurprd08.prod.outlook.com ([fe80::e3d1:5a4:db0c:43cc]) by DB9PR08MB7179.eurprd08.prod.outlook.com ([fe80::e3d1:5a4:db0c:43cc%6]) with mapi id 15.20.6178.024; Mon, 13 Mar 2023 09:07:20 +0000 Date: Mon, 13 Mar 2023 09:07:01 +0000 From: Szabolcs Nagy To: caiyinyu , libc-alpha@sourceware.org Cc: adhemerval.zanella@linaro.org, marcus.shawcroft@arm.com, xry111@xry111.site Subject: Re: [PATCH] aarch64: Standardized codes by using macro __glibc_{un,}likely and AARCH64_R Message-ID: References: <20230313031830.3597032-1-caiyinyu@loongson.cn> Content-Type: text/plain; charset=utf-8 Content-Disposition: inline In-Reply-To: <20230313031830.3597032-1-caiyinyu@loongson.cn> X-ClientProxiedBy: SA0PR11CA0204.namprd11.prod.outlook.com (2603:10b6:806:1bc::29) To DB9PR08MB7179.eurprd08.prod.outlook.com (2603:10a6:10:2cc::19) MIME-Version: 1.0 X-MS-TrafficTypeDiagnostic: DB9PR08MB7179:EE_|DU0PR08MB9679:EE_|DBAEUR03FT038:EE_|PA4PR08MB6191:EE_ X-MS-Office365-Filtering-Correlation-Id: 2c61f323-c460-43a3-fc89-08db23a262e7 x-checkrecipientrouted: true NoDisclaimer: true X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam-Untrusted: BCL:0; X-Microsoft-Antispam-Message-Info-Original: iBiltlpl1wfXVPoVwMtmeMz7tIV6+P1AvdwEQGfLTsyuPq3t3iocq/knmpj75OWnMB5rCSDYOSITPORQSEgbGA5hqrTI1/io3ijjueD1XH7zKdW6j1rGPeLbCHppXj+0kvs60bMQ6Hdj09r4iU1PU5PpCXX/vTq25QYixA0tJg4d8BaMpK8kXxqq/RNNzn985a3ZZ7D5yL8KfrFkxeOzfBCflbx42nm1xHpbSPrZkjHMiJHnDEc2HT086WBEEI+9705CidROUFroKyMiVheTExnUAJMKQ1JahGiRe8LS3ObtfFormhLoWTLDtLcKjiZuKhl/igbwGqh93yCN+OKEkC4XMqIYsYPfGtE21Oe2Ut77LtOuJomDaglj1KkzcaBnl9hSECZzH8fbXHnAEk5/3Rx1j6AD7/IhxtyndyZ4sLZWU9xXdyE095Ky5MdiAImDjn4MfkCP8qNBCNxIa11K8s54k/C4qwOTysGkdtmf9SnA9pv906CWGIkiJwj/mZXrrywUhRKuEM9hxDrhotkeOXexBjPbWAYi5OflNdJpu1ItOFTiV4x/Uzaa2lbjYlM6yboD5jI91YxC6LCCuxpwXn/2McdW2HnoYbMGMvwTZF3jmfoeTOzjktYJaaTJTq/m3mj1Ey7G3CcVofM4j1My7Q== X-Forefront-Antispam-Report-Untrusted: CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:DB9PR08MB7179.eurprd08.prod.outlook.com;PTR:;CAT:NONE;SFS:(13230025)(4636009)(366004)(346002)(39860400002)(136003)(396003)(376002)(451199018)(86362001)(36756003)(38100700002)(8676002)(66946007)(4326008)(66556008)(66476007)(41300700001)(8936002)(478600001)(316002)(44832011)(4744005)(5660300002)(2906002)(2616005)(6486002)(83380400001)(6512007)(186003)(26005)(6666004)(6506007);DIR:OUT;SFP:1101; X-MS-Exchange-Transport-CrossTenantHeadersStamped: DU0PR08MB9679 Original-Authentication-Results: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=arm.com; X-EOPAttributedMessage: 0 X-MS-Exchange-Transport-CrossTenantHeadersStripped: DBAEUR03FT038.eop-EUR03.prod.protection.outlook.com X-MS-PublicTrafficType: Email X-MS-Office365-Filtering-Correlation-Id-Prvs: 5d87d67b-2803-4690-048d-08db23a259b2 X-Microsoft-Antispam: BCL:0; X-Microsoft-Antispam-Message-Info: SxbCbB2Cpzhglq3BKp8igRkpw/KlfQojABouRzetbIDHtMKVxSeAYsiex5Yw1+TAFt9WBW78IzRYx5gs2HKeG6hlHjOrk7tQrHq+7ibd3bz0t0LVEtzTZacFnbvdSZSfI1TlIudYTF6F88PBKJxTbrKGlUa9mVYGfQEVEZ1yy1YsUt0YeCM4x+Rjn8SKXLXSVfze/MAyeT7DKFLZxO8Age+oYujpQRrp4V5GTzXLfpH6II/5tPqYLjCydFWNAdW923XqjS+yWtoRiWIrib8oDxAKIuQGFAtP6fXuv1KBAuzVpMinZSvh4qB1H03+N1zx9IfcaynuQcQOYqUhK9Nm73mA0J4oTwnKtIVMKlj4K3lsU4Eoy0aF6sPTAO6p5eJXXOHhSwPmy0fPaoWGzDEVblQ2OzhyyDjNtZb1JyPuWJO4K+HUvbJAcIYaQfIH1SuZPJyMjQDkToyPBcyf/WPzV7jyIfYwrzId3fc8dOoP8BEfr1NbpAPjYphpW3FCknzam/InF4aCzo6e1sI7Iwr4kOQFus2YfNMiFucqzh5OFSIFclRf8r+j7fKt4PolxYB2jNT9ML5tO26LNHgrPh8faxX9K4F5bo4yIvWvNLrW1f77ccIrwAySZ8JX8bI7MZGX09l6skaNNnUnffuLuAzebzv/CF6eBXWDgTVne1SVYzaIQ3rpjLN5k9845z5idFQPIb0Ua0Qe2REbxpCHWznD9g== X-Forefront-Antispam-Report: CIP:63.35.35.123;CTRY:IE;LANG:en;SCL:1;SRV:;IPV:CAL;SFV:NSPM;H:64aa7808-outbound-1.mta.getcheckrecipient.com;PTR:ec2-63-35-35-123.eu-west-1.compute.amazonaws.com;CAT:NONE;SFS:(13230025)(4636009)(136003)(396003)(376002)(346002)(39860400002)(451199018)(36840700001)(40470700004)(46966006)(356005)(36860700001)(81166007)(82740400003)(36756003)(86362001)(41300700001)(2906002)(4744005)(44832011)(70206006)(5660300002)(4326008)(8676002)(8936002)(70586007)(82310400005)(40460700003)(2616005)(336012)(186003)(83380400001)(47076005)(107886003)(478600001)(316002)(40480700001)(6512007)(26005)(6506007)(6666004)(6486002);DIR:OUT;SFP:1101; X-OriginatorOrg: arm.com X-MS-Exchange-CrossTenant-OriginalArrivalTime: 13 Mar 2023 09:07:35.3164 (UTC) X-MS-Exchange-CrossTenant-Network-Message-Id: 2c61f323-c460-43a3-fc89-08db23a262e7 X-MS-Exchange-CrossTenant-Id: f34e5979-57d9-4aaa-ad4d-b122a662184d X-MS-Exchange-CrossTenant-OriginalAttributedTenantConnectingIp: TenantId=f34e5979-57d9-4aaa-ad4d-b122a662184d;Ip=[63.35.35.123];Helo=[64aa7808-outbound-1.mta.getcheckrecipient.com] X-MS-Exchange-CrossTenant-AuthSource: DBAEUR03FT038.eop-EUR03.prod.protection.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Anonymous X-MS-Exchange-CrossTenant-FromEntityHeader: HybridOnPrem X-MS-Exchange-Transport-CrossTenantHeadersStamped: PA4PR08MB6191 X-Spam-Status: No, score=-12.3 required=5.0 tests=BAYES_00,DKIM_SIGNED,DKIM_VALID,FORGED_SPF_HELO,GIT_PATCH_0,KAM_DMARC_NONE,RCVD_IN_DNSWL_NONE,RCVD_IN_MSPIKE_H2,SPF_HELO_PASS,SPF_NONE,TXREP,UNPARSEABLE_RELAY autolearn=ham autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on server2.sourceware.org List-Id: The 03/13/2023 11:18, caiyinyu wrote: > --- > sysdeps/aarch64/dl-machine.h | 10 +++++----- > 1 file changed, 5 insertions(+), 5 deletions(-) > > diff --git a/sysdeps/aarch64/dl-machine.h b/sysdeps/aarch64/dl-machine.h > index 4170b9269f..da4f08dec6 100644 > --- a/sysdeps/aarch64/dl-machine.h > +++ b/sysdeps/aarch64/dl-machine.h > @@ -83,7 +83,7 @@ elf_machine_runtime_setup (struct link_map *l, struct r_scope_elem *scope[], > to intercept the calls to collect information. In this case we > don't store the address in the GOT so that all future calls also > end in this function. */ > - if ( profile) > + if (__glibc_unlikely (profile)) > { profile is unlikely, but this check only runs once so i don't think this is useful. the rest looks ok... but is there a reason to clean this up now? there are many __builtin_expect in the codebase and fixing them likely makes backporting patches harder without much benefit.