From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from EUR05-AM6-obe.outbound.protection.outlook.com (mail-am6eur05on2083.outbound.protection.outlook.com [40.107.22.83]) by sourceware.org (Postfix) with ESMTPS id BE3F23858D32 for ; Tue, 11 Apr 2023 14:06:43 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.4.2 sourceware.org BE3F23858D32 Authentication-Results: sourceware.org; dmarc=pass (p=none dis=none) header.from=arm.com Authentication-Results: sourceware.org; spf=pass smtp.mailfrom=arm.com DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=armh.onmicrosoft.com; s=selector2-armh-onmicrosoft-com; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=rTiQ2ncq5lDy9uVaZmaK7QqifTit3N8TZLUfRucQzxI=; b=s3KHFeqP0B0TFJt5JtF3r2b97NGnBwoVF9r8oIpMe91ffhxaDprcGZ5h8H1L4Rj/ayETgUHIMYeSlCcbWf5WcTIfGcH6vj5UF1gJgw9pWuuNQpKNCM6E55fbk5jP4VtewGwDKN8lXYCCcEqvS47QQwXl/4pcKLw1RYla5fdtzfw= Received: from AM5PR0701CA0023.eurprd07.prod.outlook.com (2603:10a6:203:51::33) by AM7PR08MB5462.eurprd08.prod.outlook.com (2603:10a6:20b:10b::9) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.6277.38; Tue, 11 Apr 2023 14:06:41 +0000 Received: from AM7EUR03FT055.eop-EUR03.prod.protection.outlook.com (2603:10a6:203:51:cafe::68) by AM5PR0701CA0023.outlook.office365.com (2603:10a6:203:51::33) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.6298.21 via Frontend Transport; Tue, 11 Apr 2023 14:06:41 +0000 X-MS-Exchange-Authentication-Results: spf=pass (sender IP is 63.35.35.123) smtp.mailfrom=arm.com; dkim=pass (signature was verified) header.d=armh.onmicrosoft.com;dmarc=pass action=none header.from=arm.com; Received-SPF: Pass (protection.outlook.com: domain of arm.com designates 63.35.35.123 as permitted sender) receiver=protection.outlook.com; client-ip=63.35.35.123; helo=64aa7808-outbound-1.mta.getcheckrecipient.com; pr=C Received: from 64aa7808-outbound-1.mta.getcheckrecipient.com (63.35.35.123) by AM7EUR03FT055.mail.protection.outlook.com (100.127.141.28) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.6298.25 via Frontend Transport; Tue, 11 Apr 2023 14:06:40 +0000 Received: ("Tessian outbound 5154e9d36775:v136"); Tue, 11 Apr 2023 14:06:40 +0000 X-CheckRecipientChecked: true X-CR-MTA-CID: d05258a8e836bc5f X-CR-MTA-TID: 64aa7808 Received: from ef064094b69d.1 by 64aa7808-outbound-1.mta.getcheckrecipient.com id DE81AF2E-68FE-4195-BC9F-B303D8627F1F.1; Tue, 11 Apr 2023 14:06:30 +0000 Received: from EUR05-VI1-obe.outbound.protection.outlook.com by 64aa7808-outbound-1.mta.getcheckrecipient.com with ESMTPS id ef064094b69d.1 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384); Tue, 11 Apr 2023 14:06:30 +0000 ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=HJOxAy2BJ07s1YzycNzTicCdjNM1mwVoUfkm48v2+s6+t9O6r4n9x7+d0toDsS+Nk/8JKCO+kHhUBB/S2Ac156CqlCmDatrcCwx/zcABQOzJvmX7VPiz6w0Iw30FD5QxMYkPxxF/pIfZctWZyfq6kDzVVs71ycDiUSStBjeheg8fterbMD1pPqdi5Y2lwgPCS1SST702gFiT1C5S/vYibxxf4A19P82Od8cEyaJ6YoSB+3Lq/wh1EWPoeuAV5MDYiAOZFdoRV5r/JLM9E7Pu/H6FN8EfZSqrfpEJON4LR39oPtJKU5c/LU9DmrgMN+reIPSRBJDejNlWUTh0r1hdNw== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=rTiQ2ncq5lDy9uVaZmaK7QqifTit3N8TZLUfRucQzxI=; b=P9k0zWTgBonHnFZQd5OMo44cjvYcRp5ZC4ehLfrNtI1QRwt2Nt9t6ss1XezdpGffahcFkrYDm8JqPNCQ/RmEgdk3ftQ1HxQR5taCQfMhsIwVuhYembUV5APQQMGyIbcFOnfW2SIumqKceLAXDlw9/CcuLZEr6nBpZ8LvpO7fFZaCnOdTWCbAJJWEqFyHrkYRV91CSdRS1b2Ys2g1o4llcS+YqN/VdY610oNS6tPUbItWn3J1wLGRPMBYSRRSScsNFi6yYl6qyfZo7+LuBMHkwEpAn8Z1gzzrmBDS9QiASV4HG+j1zGMkdfT9O57IRiRXoqGMAI0el0r7yJdfiipl6g== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=arm.com; dmarc=pass action=none header.from=arm.com; dkim=pass header.d=arm.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=armh.onmicrosoft.com; s=selector2-armh-onmicrosoft-com; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=rTiQ2ncq5lDy9uVaZmaK7QqifTit3N8TZLUfRucQzxI=; b=s3KHFeqP0B0TFJt5JtF3r2b97NGnBwoVF9r8oIpMe91ffhxaDprcGZ5h8H1L4Rj/ayETgUHIMYeSlCcbWf5WcTIfGcH6vj5UF1gJgw9pWuuNQpKNCM6E55fbk5jP4VtewGwDKN8lXYCCcEqvS47QQwXl/4pcKLw1RYla5fdtzfw= Authentication-Results-Original: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=arm.com; Received: from DB9PR08MB7179.eurprd08.prod.outlook.com (2603:10a6:10:2cc::19) by PAXPR08MB6655.eurprd08.prod.outlook.com (2603:10a6:102:15d::22) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.6277.38; Tue, 11 Apr 2023 14:06:26 +0000 Received: from DB9PR08MB7179.eurprd08.prod.outlook.com ([fe80::242d:33fe:1c48:bd8]) by DB9PR08MB7179.eurprd08.prod.outlook.com ([fe80::242d:33fe:1c48:bd8%5]) with mapi id 15.20.6277.038; Tue, 11 Apr 2023 14:06:26 +0000 Date: Tue, 11 Apr 2023 15:06:12 +0100 From: Szabolcs Nagy To: Joe Ramsay , Subject: Re: [PATCH v2 2/2] Enable libmvec support for AArch64 Message-ID: References: <20230411095942.47790-1-Joe.Ramsay@arm.com> Content-Type: text/plain; charset=utf-8 Content-Disposition: inline In-Reply-To: <20230411095942.47790-1-Joe.Ramsay@arm.com> X-ClientProxiedBy: LO4P123CA0160.GBRP123.PROD.OUTLOOK.COM (2603:10a6:600:188::21) To DB9PR08MB7179.eurprd08.prod.outlook.com (2603:10a6:10:2cc::19) MIME-Version: 1.0 X-MS-TrafficTypeDiagnostic: DB9PR08MB7179:EE_|PAXPR08MB6655:EE_|AM7EUR03FT055:EE_|AM7PR08MB5462:EE_ X-MS-Office365-Filtering-Correlation-Id: 0bc2b552-7893-4545-419d-08db3a95f94f x-checkrecipientrouted: true NoDisclaimer: true X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam-Untrusted: BCL:0; X-Microsoft-Antispam-Message-Info-Original: m6588PatYL8vIL/Bc1QyASyVkltNUN8P96MoQNIu/5XkD2wb0anijtywu27RiDej9tDIEIMXByUgVAlC+V0VPLrIhnwYpeAHRG+vVd/RhwPh4GX3lkOP+oFSC+ZLdOKsyp0uLBzRVPANj+5LFQNk4umYFQwVWbdlZ+2K+FUTKFHTMWPBWvAcqD2JWpYzDGESBq1mqxFvDCYmfUjnhY18BTsn8O1wekYV89pR4qMcBCI4A4zH57OjjMohlyQC+aRSsPWplJh/YIhbYuNHrCuZ+Ak/N1lKUPnYtnMi1VblhJ2IN1qqOKRGwlUOPPRjRoCYni0Sg4BaIu5vX8dwL7aWoiw3k85mqWIrTuMxoCmyxEJ4rHeXxhgbQIgqKtg5knC9BnDO6L0PDefZEJLWQfay22YpPVJT50w8IgTZsCdX46AjvzmjbRbsyx0tBtMKtlzkuzne3GNIVq0aq4EV99BbkFwwgX+18xgUCQwGEyBaYGGz3idyfKiaFC6z7jgAsP12LH+tgoYJLe7EXFg/0xNojPwZkaWn53n0RLjVEzKRCvdaCn3oDPIR2box3c5vaNW2 X-Forefront-Antispam-Report-Untrusted: CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:DB9PR08MB7179.eurprd08.prod.outlook.com;PTR:;CAT:NONE;SFS:(13230028)(4636009)(396003)(39860400002)(346002)(376002)(366004)(136003)(451199021)(316002)(26005)(6512007)(6506007)(38100700002)(6486002)(2616005)(83380400001)(6666004)(186003)(44832011)(5660300002)(8676002)(8936002)(41300700001)(36756003)(2906002)(110136005)(86362001)(478600001)(66946007)(66476007)(66556008);DIR:OUT;SFP:1101; X-MS-Exchange-Transport-CrossTenantHeadersStamped: PAXPR08MB6655 Original-Authentication-Results: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=arm.com; X-EOPAttributedMessage: 0 X-MS-Exchange-Transport-CrossTenantHeadersStripped: AM7EUR03FT055.eop-EUR03.prod.protection.outlook.com X-MS-PublicTrafficType: Email X-MS-Office365-Filtering-Correlation-Id-Prvs: 03775697-b278-45ac-ec4b-08db3a95f084 X-Microsoft-Antispam: BCL:0; X-Microsoft-Antispam-Message-Info: Bh8AiuY11BED7zv13dsD+lOnGIABMXlTx3wsr2JsrqebnCKGujsOJYtu55iyzAlIUPhNPGfdp1xgqAhSLhEBxBjzo/xXkXenXbz8IMvDuvxEQP0H/+JlJz9xokdOXnhyQsLoOVFeHmWyDwNTf77JFWcT9mf+VRMoJNlxfRVAPmEsTMoULSpapRJOoSAahCkHJ9wBl8tMV1062xhh5qa0/x+qjrRviM0s/dtjAC/3yPvOdvzCqdmXW7IvQMDoD+N+LAo/8PecqbF4jFZOxsxtFdtxg56yVM3sP2JfgLYAqCMRBY3LZfXypPu+2hC7j2JfcGXV3I5GlVBBIwL0o6JdbvT66nnFioodWXCWGZrqn0nyJhjp4Or5OqT3zv7mGvFrm5sT0E0Xsr5u2Rn/u3/m1x8m7keU8zSfaH1kEqmnz3Otv8AisPyi40HCoClvjtePVObRG6GcxzGDeVAg6CNHNOZDWq9ubVLvZPpQhGIOfE17rn+9tplIUzEHDWnEmg+xypfvzs0egXTwiOAOfnESn0zBxbZA3v0eHYUY+FJfCpzy7dvyRzaztgo67c5R8sGPANgh37XHAq+U/yzSiwKsUgOKY2IqIkAqeKvX+3qQnrPIpxJwOECHrtLYdp1s6dNaivLiPkYWPiMOIzgddatgj8RLaa5uofL+CyanzAUpbG/qlldRaesCo8b+baPuEDIooMozR/I0D7M4hQZqlVup6Q== X-Forefront-Antispam-Report: CIP:63.35.35.123;CTRY:IE;LANG:en;SCL:1;SRV:;IPV:CAL;SFV:NSPM;H:64aa7808-outbound-1.mta.getcheckrecipient.com;PTR:ec2-63-35-35-123.eu-west-1.compute.amazonaws.com;CAT:NONE;SFS:(13230028)(4636009)(396003)(376002)(346002)(39850400004)(136003)(451199021)(36840700001)(40470700004)(46966006)(478600001)(6512007)(316002)(110136005)(26005)(6506007)(186003)(44832011)(6486002)(2906002)(5660300002)(70586007)(70206006)(41300700001)(8676002)(6666004)(82310400005)(8936002)(356005)(81166007)(82740400003)(40480700001)(86362001)(83380400001)(40460700003)(36756003)(47076005)(2616005)(336012)(36860700001);DIR:OUT;SFP:1101; X-OriginatorOrg: arm.com X-MS-Exchange-CrossTenant-OriginalArrivalTime: 11 Apr 2023 14:06:40.9847 (UTC) X-MS-Exchange-CrossTenant-Network-Message-Id: 0bc2b552-7893-4545-419d-08db3a95f94f X-MS-Exchange-CrossTenant-Id: f34e5979-57d9-4aaa-ad4d-b122a662184d X-MS-Exchange-CrossTenant-OriginalAttributedTenantConnectingIp: TenantId=f34e5979-57d9-4aaa-ad4d-b122a662184d;Ip=[63.35.35.123];Helo=[64aa7808-outbound-1.mta.getcheckrecipient.com] X-MS-Exchange-CrossTenant-AuthSource: AM7EUR03FT055.eop-EUR03.prod.protection.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Anonymous X-MS-Exchange-CrossTenant-FromEntityHeader: HybridOnPrem X-MS-Exchange-Transport-CrossTenantHeadersStamped: AM7PR08MB5462 X-Spam-Status: No, score=-11.5 required=5.0 tests=BAYES_00,DKIM_SIGNED,DKIM_VALID,FORGED_SPF_HELO,GIT_PATCH_0,KAM_DMARC_NONE,KAM_NUMSUBJECT,RCVD_IN_DNSWL_NONE,RCVD_IN_MSPIKE_H2,SPF_HELO_PASS,SPF_NONE,TXREP,UNPARSEABLE_RELAY autolearn=ham autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on server2.sourceware.org List-Id: The 04/11/2023 10:59, Joe Ramsay via Libc-alpha wrote: > This patch enables libmvec on AArch64. The proposed change is mainly > implementing build infrastructure to add the new routines to ABI, > tests and benchmarks. I have demonstrated how this all fits together > by adding implementations for vector cos, in both single and double > precision, targeting both Advanced SIMD and SVE. > > The implementations of the routines themselves are just loops over the > scalar routine from libm for now, as we are more concerned with > getting the plumbing right at this point. We plan to contribute vector > routines from the Arm Optimized Routines repo that are compliant with > requirements described in the libmvec wiki. > > Building libmvec requires minimum GCC 10 for SVE ACLE. To avoid raising > the minimum GCC by such a big jump, we allow users to disable libmvec > if their compiler is too old. > > Note that at this point users have to manually call the vector math > functions. This seems to be acceptable to some downstream users. > you can put the rest of the commit message bellow a --- and then patchwork and git am knows it's not part of the commit message. > Thanks, > Joe > > Changes to v1: > * Code formatting > * Refactor ARCH-specific checks in libmvec benchtests > * Always build SVE benchtests and exit early if unsupported > * Improve unsupported config error message > --- make check seems to use the new libm-test-ulps for all math tests, not just libmvec ones.. i think the updates should just go into the existing libm-test-ulps not into a new file. you can regenerate the file with make -j$(nproc) regen-ulps cp builddir/math/NewUlps srcdir/sysdeps/aarch64/libm-test-ulps and then review the git diff. > diff --git a/sysdeps/aarch64/fpu/libm-test-ulps b/sysdeps/aarch64/fpu/libm-test-ulps > new file mode 100644 > index 0000000000..3449c8dfbb > --- /dev/null > +++ b/sysdeps/aarch64/fpu/libm-test-ulps > @@ -0,0 +1,7 @@ > +Function: "cos_advsimd": > +double: 2 > +float: 2 > + > +Function: "cos_sve": > +double: 2 > +float: 2 > diff --git a/sysdeps/aarch64/fpu/libm-test-ulps-name b/sysdeps/aarch64/fpu/libm-test-ulps-name > new file mode 100644 > index 0000000000..1f66c5cda0 > --- /dev/null > +++ b/sysdeps/aarch64/fpu/libm-test-ulps-name > @@ -0,0 +1 @@ > +AArch64