From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from EUR04-HE1-obe.outbound.protection.outlook.com (mail-he1eur04on2042.outbound.protection.outlook.com [40.107.7.42]) by sourceware.org (Postfix) with ESMTPS id BC3C23858D28 for ; Tue, 11 Apr 2023 15:44:27 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.4.2 sourceware.org BC3C23858D28 Authentication-Results: sourceware.org; dmarc=pass (p=none dis=none) header.from=arm.com Authentication-Results: sourceware.org; spf=pass smtp.mailfrom=arm.com DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=armh.onmicrosoft.com; s=selector2-armh-onmicrosoft-com; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=G/QMqYIETOxtUz+NG1s4iCR/d3LCF2fj3MlXowfQcyI=; b=jKF0Gtx6Gh49BwHpKSUAwJzL7YfWI9oQCTOfmvCfS9kcn4he4HcqRIKoVzFnEKZSE6cOcwmeOluc4Lzd5UmKUnTg/+aTiAfSByI7H4kTTKWYCnprCMAeTixXGG0eWZWRn6RgvJFiom5wApZO0Wj7cdrRobBqkd0GG3AH5wk24xw= Received: from DUZPR01CA0067.eurprd01.prod.exchangelabs.com (2603:10a6:10:3c2::6) by AS1PR08MB7660.eurprd08.prod.outlook.com (2603:10a6:20b:47b::18) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.6277.35; Tue, 11 Apr 2023 15:44:25 +0000 Received: from DBAEUR03FT056.eop-EUR03.prod.protection.outlook.com (2603:10a6:10:3c2:cafe::70) by DUZPR01CA0067.outlook.office365.com (2603:10a6:10:3c2::6) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.6277.40 via Frontend Transport; Tue, 11 Apr 2023 15:44:25 +0000 X-MS-Exchange-Authentication-Results: spf=pass (sender IP is 63.35.35.123) smtp.mailfrom=arm.com; dkim=pass (signature was verified) header.d=armh.onmicrosoft.com;dmarc=pass action=none header.from=arm.com; Received-SPF: Pass (protection.outlook.com: domain of arm.com designates 63.35.35.123 as permitted sender) receiver=protection.outlook.com; client-ip=63.35.35.123; helo=64aa7808-outbound-1.mta.getcheckrecipient.com; pr=C Received: from 64aa7808-outbound-1.mta.getcheckrecipient.com (63.35.35.123) by DBAEUR03FT056.mail.protection.outlook.com (100.127.142.88) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.6298.28 via Frontend Transport; Tue, 11 Apr 2023 15:44:25 +0000 Received: ("Tessian outbound 3a01b65b5aad:v136"); Tue, 11 Apr 2023 15:44:24 +0000 X-CheckRecipientChecked: true X-CR-MTA-CID: f1f1247c1fcb41f1 X-CR-MTA-TID: 64aa7808 Received: from 5e38bbbed9df.1 by 64aa7808-outbound-1.mta.getcheckrecipient.com id EDC13600-E3A3-4436-BC14-000B26CF022F.1; Tue, 11 Apr 2023 15:44:18 +0000 Received: from EUR05-VI1-obe.outbound.protection.outlook.com by 64aa7808-outbound-1.mta.getcheckrecipient.com with ESMTPS id 5e38bbbed9df.1 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384); Tue, 11 Apr 2023 15:44:18 +0000 ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=FGwRha51vasA4EFxJXogVkYERSK3NnMDcsF4S+rHf1vU8qAbMfVP5SLn9aF5NJwSW6/Ycd3RegRYWMWuDjRohKf/AW98ZsY+susr4KcD+Zhbp80bLn4C5WdK8u1QwSSMfYN9vXW06qZuynPcdtDNsj+/j6abJbiwe5hJci73Gtdn25oWykj40jzq7Cx/RvW+2xd+bAktd5lhZOUGHyaGnVMIW+y9EVgm5p+3U/yQGKedx5RRszDW+A9ukCFK1VYhiqcrmGWZbsY0UqPISKf+fM5JtaITtcdtZejndsVARJohKJUjcE/x0Unl0Kqc7rSUW1TN4+sA9vs6Trf+AGkStg== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=G/QMqYIETOxtUz+NG1s4iCR/d3LCF2fj3MlXowfQcyI=; b=Tgk4qpe1hYwRG79vWw88Aj6JRUZJ6YdHGf7/sHeCPa2afTE/k7ADU7CvB4IooXsAlL+sZqY06/hxQtHy991J/jIqfYvz7/JW8e1T6ZBoj460mODQALi1l8vWhBu8abgc2Yz00TheGkNB0cfC6t3O1ZmZWwuDSEojPja9VBY/pM3xIWrO+wvX6G6UDmiFmD/Tqe21hUMfcRod9n82cLPjZwR8BYYKdmg2EnY8zjKMv5X501j+pnRgPE71bmmQrjLfPLrKfhb/3znaV2EtuKPBy7HJnmbd4UitTno/4JjYvvj5D9lNk+JU02rlh3TCBLzKU6JCD94TMnzmemVDr7aRSA== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=arm.com; dmarc=pass action=none header.from=arm.com; dkim=pass header.d=arm.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=armh.onmicrosoft.com; s=selector2-armh-onmicrosoft-com; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=G/QMqYIETOxtUz+NG1s4iCR/d3LCF2fj3MlXowfQcyI=; b=jKF0Gtx6Gh49BwHpKSUAwJzL7YfWI9oQCTOfmvCfS9kcn4he4HcqRIKoVzFnEKZSE6cOcwmeOluc4Lzd5UmKUnTg/+aTiAfSByI7H4kTTKWYCnprCMAeTixXGG0eWZWRn6RgvJFiom5wApZO0Wj7cdrRobBqkd0GG3AH5wk24xw= Authentication-Results-Original: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=arm.com; Received: from DB9PR08MB7179.eurprd08.prod.outlook.com (2603:10a6:10:2cc::19) by DU0PR08MB8347.eurprd08.prod.outlook.com (2603:10a6:10:409::10) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.6277.38; Tue, 11 Apr 2023 15:44:11 +0000 Received: from DB9PR08MB7179.eurprd08.prod.outlook.com ([fe80::242d:33fe:1c48:bd8]) by DB9PR08MB7179.eurprd08.prod.outlook.com ([fe80::242d:33fe:1c48:bd8%5]) with mapi id 15.20.6277.038; Tue, 11 Apr 2023 15:44:11 +0000 Date: Tue, 11 Apr 2023 16:43:53 +0100 From: Szabolcs Nagy To: Adhemerval Zanella Netto , Florian Weimer , Joe Simmons-Talbott via Libc-alpha Cc: Joe Simmons-Talbott Subject: Re: [PATCH 2/2] aarch64: Set the syscall register right before doing the syscall. Message-ID: References: <20230411133004.2268170-1-josimmon@redhat.com> <20230411133004.2268170-3-josimmon@redhat.com> <87h6tmil4j.fsf@oldenburg.str.redhat.com> Content-Type: text/plain; charset=utf-8 Content-Disposition: inline In-Reply-To: X-ClientProxiedBy: SA0PR11CA0007.namprd11.prod.outlook.com (2603:10b6:806:d3::12) To DB9PR08MB7179.eurprd08.prod.outlook.com (2603:10a6:10:2cc::19) MIME-Version: 1.0 X-MS-TrafficTypeDiagnostic: DB9PR08MB7179:EE_|DU0PR08MB8347:EE_|DBAEUR03FT056:EE_|AS1PR08MB7660:EE_ X-MS-Office365-Filtering-Correlation-Id: cd615f2b-f8a1-4cfe-a544-08db3aa3a08b x-checkrecipientrouted: true NoDisclaimer: true X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam-Untrusted: BCL:0; X-Microsoft-Antispam-Message-Info-Original: gVuwkpbANe0TfI0TIVeAKe2RvdiMQncZhUqrwK9GC3PnUUk9ChHrX/kZVIog/bg5Wkdqbl7otBaDy7MZom+fHI3ZykcqB0iLwWfJERGgBhA+jPFu9hM2l/6m5w2NbhACpSjvJQ/n3vHkBuKG1c3sxBHHUGUXh6+ww8zKCnpHjbpA4Q5/lHSfUaPPOo1NNYkzriy//0LL47k4iK4QgVrPEVOejdRFqud6eESNOgdokncuyPyr4JTYJPS+kmrGyzX2PK6Y673lLl8amS3OCs7Nzvc5rpXoq539Nr5e012XhNAnKxFtusGvWzZFuzd9QeY4sCyygGp0c2aG5cX2xoF4byZleJboupXNCEw3h3LFQtr0qC7e9ZnJEdbY57jftFDTj346Jeqwvg6QS3/9o81u929AveRFsizEctmub5bt10rpI4UTZPPtXjFeL98S3trFOl+R3qBJ/ZSYKMaTMqYWhobxteW/j9Lv1Uw3Gxate6OH5z9GRBMHw+FompBOE40bDq20sktyGVXPEmtEerC2X2M1qdD/16E3CsRiMplo/fde8W1BAW44TU+feT1SboZG X-Forefront-Antispam-Report-Untrusted: CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:DB9PR08MB7179.eurprd08.prod.outlook.com;PTR:;CAT:NONE;SFS:(13230028)(4636009)(39860400002)(396003)(346002)(366004)(136003)(376002)(451199021)(4326008)(6486002)(478600001)(86362001)(2616005)(8936002)(44832011)(5660300002)(66946007)(8676002)(66556008)(66476007)(83380400001)(2906002)(36756003)(316002)(186003)(38100700002)(6506007)(26005)(6512007)(110136005)(6666004)(53546011)(41300700001);DIR:OUT;SFP:1101; X-MS-Exchange-Transport-CrossTenantHeadersStamped: DU0PR08MB8347 Original-Authentication-Results: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=arm.com; X-EOPAttributedMessage: 0 X-MS-Exchange-Transport-CrossTenantHeadersStripped: DBAEUR03FT056.eop-EUR03.prod.protection.outlook.com X-MS-PublicTrafficType: Email X-MS-Office365-Filtering-Correlation-Id-Prvs: 19a6784a-3b71-4628-73f2-08db3aa39851 X-Microsoft-Antispam: BCL:0; X-Microsoft-Antispam-Message-Info: R9ZuHxxfRo9WZ3jFurky4Ce3IG+RHlYOzGMO7vQtWVppZyfnDghO71Ki106fqhtt9KcKD88YX5J6/KWMcUUjwQDebhbgQ9mzKr30BuGPMpXlLl+0ZoxbIQEEcggZRJzy1f/i1KMjXRVQ4u5ITiwuzOMKRKXBRktQB4ESRA+IZgdLukUuf/JIE+fCCtAoUG+hCwiybu4D4o51E0aFiwi95Niddk1NsQ2vjmlOgKY4mRLQcrKExFpI6Prbsld9tdUmHSFLQBSOj1MQ2zs98d9DBKGyKIC9PI2K2npF2UiOCKkMC3h9UDPbIChReFdfWZKuaRJMRRXC1ViUP4C9LPf+vG4fSjCoOxbuZ1uPQgE9RSeW7UgHgY8WoVO00j7F/++EL8Z6U/AidwtBh6Zj3z8DJHZwusalPHGyjqhGWcY5OUcDCfR7Bz+eLAYC10EEBgAtyWKSFFgXwxCbZ5hDJrV4VXt2ewYq9Glevl2s8jANeucExT30HYOLaAIlNzE/5DAOYFa+xG3PjO39Y2nK53n0YN696nkG/je10VVK3tBRXl6c4xCJVtAR3vOUhGqX2dNJaMf8GFVE2kqSbXSEbk2yWjSObXTiZocpGrRsNqtO/hY2GDg2HNJeX0HQQYRaZ3YC79gm6v2RIXXY6VVvV8fGhI0CldWXnPpLA5O0ALTYfMtKU9JZcqjYPuLl9kDEpT31xO5CPy/LGAPL4opo/sq4GA== X-Forefront-Antispam-Report: CIP:63.35.35.123;CTRY:IE;LANG:en;SCL:1;SRV:;IPV:CAL;SFV:NSPM;H:64aa7808-outbound-1.mta.getcheckrecipient.com;PTR:ec2-63-35-35-123.eu-west-1.compute.amazonaws.com;CAT:NONE;SFS:(13230028)(4636009)(376002)(346002)(39860400002)(136003)(396003)(451199021)(46966006)(36840700001)(40470700004)(6666004)(478600001)(110136005)(6512007)(6506007)(316002)(26005)(186003)(53546011)(6486002)(2906002)(336012)(44832011)(5660300002)(70586007)(70206006)(41300700001)(8676002)(4326008)(107886003)(8936002)(82310400005)(356005)(82740400003)(81166007)(47076005)(40480700001)(86362001)(40460700003)(36756003)(83380400001)(36860700001)(2616005);DIR:OUT;SFP:1101; X-OriginatorOrg: arm.com X-MS-Exchange-CrossTenant-OriginalArrivalTime: 11 Apr 2023 15:44:25.0487 (UTC) X-MS-Exchange-CrossTenant-Network-Message-Id: cd615f2b-f8a1-4cfe-a544-08db3aa3a08b X-MS-Exchange-CrossTenant-Id: f34e5979-57d9-4aaa-ad4d-b122a662184d X-MS-Exchange-CrossTenant-OriginalAttributedTenantConnectingIp: TenantId=f34e5979-57d9-4aaa-ad4d-b122a662184d;Ip=[63.35.35.123];Helo=[64aa7808-outbound-1.mta.getcheckrecipient.com] X-MS-Exchange-CrossTenant-AuthSource: DBAEUR03FT056.eop-EUR03.prod.protection.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Anonymous X-MS-Exchange-CrossTenant-FromEntityHeader: HybridOnPrem X-MS-Exchange-Transport-CrossTenantHeadersStamped: AS1PR08MB7660 X-Spam-Status: No, score=-5.7 required=5.0 tests=BAYES_00,DKIM_SIGNED,DKIM_VALID,FORGED_SPF_HELO,KAM_DMARC_NONE,RCVD_IN_DNSWL_NONE,RCVD_IN_MSPIKE_H2,SPF_HELO_PASS,SPF_NONE,TXREP,UNPARSEABLE_RELAY autolearn=no autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on server2.sourceware.org List-Id: The 04/11/2023 11:15, Adhemerval Zanella Netto via Libc-alpha wrote: > On 11/04/23 10:50, Florian Weimer via Libc-alpha wrote: > > * Joe Simmons-Talbott via Libc-alpha: > > > >> ({ long _sys_result; \ > >> { \ > >> LOAD_ARGS_##nr (args) \ > >> register long _x8 asm ("x8") = (name); \ > >> + if (__builtin_constant_p(name)) \ > >> + asm volatile ("mov x8, " MSTR(name) ";" \ > >> + : /* no output */ : "i" (name) : "x8"); \ > >> asm volatile ("svc 0 // syscall " # name \ > >> : "=r" (_x0) : "r"(_x8) ASM_ARGS_##nr : "memory"); \ > >> _sys_result = _x0; \ > > > > I think you should do this in a single assembler statement, load the > > constant only once. > > Is this required because compiler is free to reorganize the argument > list? I think it should me it clear on the commit message. > > Using a single assembler would require two inline asm, something like: i don't like the use of __builtin_constant_name_p here. if we want different behaviour for INTERNAL_SYSCALL_NCS and other inlined syscall things then we should do the dispatch there. and yes it has to be one asm block since the compiler is free to add random nops (or equivalent) anywhere. i'm not entirely sure why this change is needed, a bit more background would be useful.