From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from EUR05-VI1-obe.outbound.protection.outlook.com (mail-vi1eur05on20627.outbound.protection.outlook.com [IPv6:2a01:111:f400:7d00::627]) by sourceware.org (Postfix) with ESMTPS id 3A52F3858D28 for ; Wed, 12 Apr 2023 12:56:28 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.4.2 sourceware.org 3A52F3858D28 Authentication-Results: sourceware.org; dmarc=pass (p=none dis=none) header.from=arm.com Authentication-Results: sourceware.org; spf=pass smtp.mailfrom=arm.com DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=armh.onmicrosoft.com; s=selector2-armh-onmicrosoft-com; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=nDHd+7Td+QKLfZZxv401NBf6BcCOigGiIoba7p+Df7Y=; b=4iL517n7Z1clWlT+l4bWFoMwT8lxdPPB1+1fZV7vNIpTYAGhwo2Se/njEeiKsXVX8AYj3e5jq7XeRfvyt37UYEbmzSDUY9LLKvLBppfRn90aq99lLlzkpPJXCXxlnd0WA00CvoZkPorSeqE5tTjmpiU6rCQ07CYm9KijF42v7y0= Received: from DB6PR0402CA0013.eurprd04.prod.outlook.com (2603:10a6:4:91::23) by AS2PR08MB9000.eurprd08.prod.outlook.com (2603:10a6:20b:5fd::6) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.6298.30; Wed, 12 Apr 2023 12:56:20 +0000 Received: from DBAEUR03FT051.eop-EUR03.prod.protection.outlook.com (2603:10a6:4:91:cafe::9e) by DB6PR0402CA0013.outlook.office365.com (2603:10a6:4:91::23) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.6298.30 via Frontend Transport; Wed, 12 Apr 2023 12:56:20 +0000 X-MS-Exchange-Authentication-Results: spf=pass (sender IP is 63.35.35.123) smtp.mailfrom=arm.com; dkim=pass (signature was verified) header.d=armh.onmicrosoft.com;dmarc=pass action=none header.from=arm.com; Received-SPF: Pass (protection.outlook.com: domain of arm.com designates 63.35.35.123 as permitted sender) receiver=protection.outlook.com; client-ip=63.35.35.123; helo=64aa7808-outbound-1.mta.getcheckrecipient.com; pr=C Received: from 64aa7808-outbound-1.mta.getcheckrecipient.com (63.35.35.123) by DBAEUR03FT051.mail.protection.outlook.com (100.127.142.148) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.6298.30 via Frontend Transport; Wed, 12 Apr 2023 12:56:20 +0000 Received: ("Tessian outbound 945aec65ec65:v136"); Wed, 12 Apr 2023 12:56:20 +0000 X-CheckRecipientChecked: true X-CR-MTA-CID: 24edc2f0d54320d6 X-CR-MTA-TID: 64aa7808 Received: from 1755a2b0b7a1.1 by 64aa7808-outbound-1.mta.getcheckrecipient.com id 552C114A-045C-44EB-9894-7B3C3859CFFA.1; Wed, 12 Apr 2023 12:56:10 +0000 Received: from EUR01-DB5-obe.outbound.protection.outlook.com by 64aa7808-outbound-1.mta.getcheckrecipient.com with ESMTPS id 1755a2b0b7a1.1 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384); Wed, 12 Apr 2023 12:56:10 +0000 ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=ggl/POXFze15VaIzgsfHNbL2mAIZTNfpLRTJ9K8QNAH8/2p81aFGPbOjGhHizmaSGAP+T6S4C98HWA4W0xanOL5KY/YVBEXmuAtESTKfrm/t4NzYuOfvaRAtGkwijNJXF+JuQ9uY3S/NrffmA+oLFdRT9DHKKzoHHnSyInJ73hqhYxpmevI6l9RM5ij7KJ+7S5LqDWkPYjqRyhV0GcA5efnHnSg5Nw2RLWIV7qi+EysReFTQJZMH5ZSch7eaorFDPzFDfhlAaJRz899Weu7peRL2LBULgV+OF3s782kGt0jjy3Dxz5YpELptFQhgTHGnP7VBz2zJQu7l8ZDrqmEcQg== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=nDHd+7Td+QKLfZZxv401NBf6BcCOigGiIoba7p+Df7Y=; b=YCjTisherZw0F9OZczkPUpeVdo0AYU5oOK2+N582Kga7gpO5Rl+STozCBDs5VA5ZHIwCxaUiZCv0aRAAZ+J7SJhlMc8lBwW4Ig0vC57VTbuwQ3bI3/I4cqUF/RQoFIyRDt8xN5TrkG7xprfa4zT1Z+DGvLXHP9EoNfHAfv7Lq15QcUwWysoxKCBV2uX1KWmn0hU1MtIF3kEhAB6zooA3gy7pmP8saHZlPPxB87tNBkj8D6r9Y5pJzZQeUAYvRyMdDHq/jFLdyizGd3Xt3crfBpPXqH3C0AZvsr1iFaXqG6md48/SUEz2PM5HwG4zJnUo1Rlj8fwwKjmaaaZ5qjOyhA== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=arm.com; dmarc=pass action=none header.from=arm.com; dkim=pass header.d=arm.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=armh.onmicrosoft.com; s=selector2-armh-onmicrosoft-com; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=nDHd+7Td+QKLfZZxv401NBf6BcCOigGiIoba7p+Df7Y=; b=4iL517n7Z1clWlT+l4bWFoMwT8lxdPPB1+1fZV7vNIpTYAGhwo2Se/njEeiKsXVX8AYj3e5jq7XeRfvyt37UYEbmzSDUY9LLKvLBppfRn90aq99lLlzkpPJXCXxlnd0WA00CvoZkPorSeqE5tTjmpiU6rCQ07CYm9KijF42v7y0= Authentication-Results-Original: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=arm.com; Received: from DB9PR08MB7179.eurprd08.prod.outlook.com (2603:10a6:10:2cc::19) by AS4PR08MB8045.eurprd08.prod.outlook.com (2603:10a6:20b:585::20) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.6277.38; Wed, 12 Apr 2023 12:56:06 +0000 Received: from DB9PR08MB7179.eurprd08.prod.outlook.com ([fe80::242d:33fe:1c48:bd8]) by DB9PR08MB7179.eurprd08.prod.outlook.com ([fe80::242d:33fe:1c48:bd8%5]) with mapi id 15.20.6277.038; Wed, 12 Apr 2023 12:56:06 +0000 Date: Wed, 12 Apr 2023 13:55:53 +0100 From: Szabolcs Nagy To: Joe Ramsay , Subject: Re: [PATCH v4 2/2] Enable libmvec support for AArch64 Message-ID: References: <20230411160811.29198-1-Joe.Ramsay@arm.com> Content-Type: text/plain; charset=utf-8 Content-Disposition: inline In-Reply-To: <20230411160811.29198-1-Joe.Ramsay@arm.com> X-ClientProxiedBy: LNXP123CA0004.GBRP123.PROD.OUTLOOK.COM (2603:10a6:600:d2::16) To DB9PR08MB7179.eurprd08.prod.outlook.com (2603:10a6:10:2cc::19) MIME-Version: 1.0 X-MS-TrafficTypeDiagnostic: DB9PR08MB7179:EE_|AS4PR08MB8045:EE_|DBAEUR03FT051:EE_|AS2PR08MB9000:EE_ X-MS-Office365-Filtering-Correlation-Id: ff62c6c0-1673-4b6a-94bc-08db3b554fdf x-checkrecipientrouted: true NoDisclaimer: true X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam-Untrusted: BCL:0; X-Microsoft-Antispam-Message-Info-Original: 12nZpb+JuNu2uMZJToJ6eKEOBAxPBtUOK1G8kPqQb6JmaPg6Xkv/8xLTh41CrHN7lMzeyB0QrNO6ZSXizbXDX2qGJVmKv6uT6VQnrC6Nu80mFvbec6QVaKCw8A3IIKb2x1J+f/dCPHRqP+iMWklnqIMvh67ZbU12SVAWt04n/vys0W0VUh1YWTIX4xizCUSgHfLpq8NVhbyOyABO1/3qo4tdpicmM3J2MtcHFE7+ah0JVSm7TTTQ7zf5PZ308QKiAjAHRkDH6GbI3unZuI5z8dZ6rD1wYGSSd6i/Nv3kaj1GUKn8qTUcOk/UleshD+ARkxscCGsGOqtx2RU/D9ufJ6Yp1tVOA//1RxJLJx8l4uMNOIGO46vvDhG9eIjY997u6O7CkvF5O7x9/wvcdApgEoZLAPiiGh8i37JTnVWOsGLXwW+Eo9HYmhdecy0V//ZkUFXmV6ZnclR7teGbqFrYXCJAd6uqpOSpF7lpdxdVYbgtRW4nnyNIYTmwZ018AvP/VOG5UOlfS8j6lcWlTfKAwAsJyt8oKOJbSFAIYrxB92D21CbJrNN52baoj+lDV5Ba X-Forefront-Antispam-Report-Untrusted: CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:DB9PR08MB7179.eurprd08.prod.outlook.com;PTR:;CAT:NONE;SFS:(13230028)(4636009)(136003)(396003)(376002)(346002)(39860400002)(366004)(451199021)(6486002)(478600001)(86362001)(8936002)(2616005)(5660300002)(44832011)(83380400001)(66556008)(66476007)(8676002)(2906002)(6506007)(36756003)(6512007)(186003)(316002)(38100700002)(26005)(110136005)(66946007)(6666004)(41300700001);DIR:OUT;SFP:1101; X-MS-Exchange-Transport-CrossTenantHeadersStamped: AS4PR08MB8045 Original-Authentication-Results: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=arm.com; X-EOPAttributedMessage: 0 X-MS-Exchange-Transport-CrossTenantHeadersStripped: DBAEUR03FT051.eop-EUR03.prod.protection.outlook.com X-MS-PublicTrafficType: Email X-MS-Office365-Filtering-Correlation-Id-Prvs: 9b39943c-0b3c-400c-fbf4-08db3b5547d3 X-Microsoft-Antispam: BCL:0; X-Microsoft-Antispam-Message-Info: M2ND87rf8PB2Ii9omMrNmV6BHoHsw5R4yGKAKEUF/bYbEP9tFWmA3SwlwWYvtU5FbN0cH/GnWPerERIC+rnM9qzLtBPUewS0QY6i9NT9mg9mglqacGGM6oONPVD9t+CLKswFPQf5WZGtFKFCNIqNx3VShVo5saWQPNicIMdmr+cNbCDoaPZjFCYtsQ8QDHiBXdvA37RBprVL8xfUI/npX7CGIbQ5ZAzVnFyjF8RwP0CqPKQ7pp8aYUy03sd8wYdtZtMuhWpQdHs04+LAQ+TTJjZPqyHRCzgrogfVg+mVee6qq96Bun5VdLd10Z3cPgSVKTfVEX3d5ZZX+aSJJ5RH8JLp+N5VcFaFqs7vM5P5+nToe4u48BGwOswmHQ1OSRbDS3qQQNrdZuON2xHxuOlP5cpj1JQEtyKRFI5S3TpgU/tygwAupIkRIwYnnHtWUECiRQ7aYu8aiawg+0kcq3cA9oxMwyOa13edNAd/b/tzkITOlduoGIRuCmOLzjcQ+Wlhh0kQpdn+k8EEvOGUSosCmMV64n4eeH/alFaa9+plGsdYlMOgxBdrtVJWWRg11pI8em3TJNGCDagLZjRxztdrxpdWU2AiiFswJdfxkJjl2d/q7jkm2DdMp3Ny7XLQqcp7F6A3tU1fKKfzF4mdausiBf8l0ItDgoFhSQmadfzTQjLwKg5EEr/m1yyROwsYJ3DnuPo86kRgB2OI9CHP9CRBHQ== X-Forefront-Antispam-Report: CIP:63.35.35.123;CTRY:IE;LANG:en;SCL:1;SRV:;IPV:CAL;SFV:NSPM;H:64aa7808-outbound-1.mta.getcheckrecipient.com;PTR:ec2-63-35-35-123.eu-west-1.compute.amazonaws.com;CAT:NONE;SFS:(13230028)(4636009)(396003)(376002)(39860400002)(136003)(346002)(451199021)(40470700004)(36840700001)(46966006)(2906002)(8676002)(44832011)(356005)(81166007)(5660300002)(82740400003)(8936002)(36756003)(41300700001)(70586007)(40460700003)(70206006)(316002)(36860700001)(110136005)(336012)(83380400001)(47076005)(2616005)(82310400005)(6666004)(40480700001)(186003)(26005)(6512007)(6506007)(478600001)(86362001)(6486002);DIR:OUT;SFP:1101; X-OriginatorOrg: arm.com X-MS-Exchange-CrossTenant-OriginalArrivalTime: 12 Apr 2023 12:56:20.1212 (UTC) X-MS-Exchange-CrossTenant-Network-Message-Id: ff62c6c0-1673-4b6a-94bc-08db3b554fdf X-MS-Exchange-CrossTenant-Id: f34e5979-57d9-4aaa-ad4d-b122a662184d X-MS-Exchange-CrossTenant-OriginalAttributedTenantConnectingIp: TenantId=f34e5979-57d9-4aaa-ad4d-b122a662184d;Ip=[63.35.35.123];Helo=[64aa7808-outbound-1.mta.getcheckrecipient.com] X-MS-Exchange-CrossTenant-AuthSource: DBAEUR03FT051.eop-EUR03.prod.protection.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Anonymous X-MS-Exchange-CrossTenant-FromEntityHeader: HybridOnPrem X-MS-Exchange-Transport-CrossTenantHeadersStamped: AS2PR08MB9000 X-Spam-Status: No, score=-5.5 required=5.0 tests=BAYES_00,DKIM_SIGNED,DKIM_VALID,FORGED_SPF_HELO,KAM_DMARC_NONE,KAM_NUMSUBJECT,RCVD_IN_DNSWL_NONE,SPF_HELO_PASS,SPF_NONE,TXREP,UNPARSEABLE_RELAY autolearn=no autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on server2.sourceware.org List-Id: The 04/11/2023 17:08, Joe Ramsay via Libc-alpha wrote: > This patch enables libmvec on AArch64. The proposed change is mainly > implementing build infrastructure to add the new routines to ABI, > tests and benchmarks. I have demonstrated how this all fits together > by adding implementations for vector cos, in both single and double > precision, targeting both Advanced SIMD and SVE. > > The implementations of the routines themselves are just loops over the > scalar routine from libm for now, as we are more concerned with > getting the plumbing right at this point. We plan to contribute vector > routines from the Arm Optimized Routines repo that are compliant with > requirements described in the libmvec wiki. > > Building libmvec requires minimum GCC 10 for SVE ACLE. To avoid raising > the minimum GCC by such a big jump, we allow users to disable libmvec > if their compiler is too old. > > Note that at this point users have to manually call the vector math > functions. This seems to be acceptable to some downstream users. > > --- > > Changes from v3: > * Remove unused libm-test-ulps-name > > Thanks, > Joe this version looks good to me. but i think we should add a NEWS entry along the lines of * Added libmvec vector math library support to AArch64. It requires GCC version >= 10.1.0. It can be disabled via --disable-mathvec, however that is not a supported configuration as it changes the ABI. The symbol names follow the AArch64 vector ABI, they are declared in math.h and have to be called manually at this point. please prepare another patch with NEWS update. later on when we add new API/ABI symbols we should list them in this NEWS entry too. thanks.