public inbox for libc-alpha@sourceware.org
 help / color / mirror / Atom feed
From: Gavin Smith <gavinsmith0123@gmail.com>
To: Adhemerval Zanella Netto <adhemerval.zanella@linaro.org>
Cc: libc-alpha@sourceware.org
Subject: Re: [PATCH 1/1] document posix_openpt
Date: Sun, 23 Apr 2023 10:35:40 +0100	[thread overview]
Message-ID: <ZET77MEd6BKz7xu0@starmint> (raw)
In-Reply-To: <7f02fefd-374c-595b-e5f8-612f81c41bff@linaro.org>

On Wed, Apr 19, 2023 at 09:43:01AM -0300, Adhemerval Zanella Netto wrote:

> LGTM, I am just no sure which standard to use.
> 
> > 
> > diff --git a/manual/terminal.texi b/manual/terminal.texi
> > index 7293bfb393..bdaee56053 100644
> > --- a/manual/terminal.texi
> > +++ b/manual/terminal.texi
> > @@ -1947,6 +1947,33 @@ This subsection describes functions for allocating a pseudo-terminal,
> >  and for making this pseudo-terminal available for actual use.  These
> >  functions are declared in the header file @file{stdlib.h}.
> >  
> > +@deftypefun int posix_openpt (int @var{flags})
> > +@standards{POSIX.1, stdlib.h}
> 
> Shouldn't it be POSIX.2, since it is define for _XOPEN_SOURCE >= 600?

I got from the "feature_test_macros" manpage:

  (Since glibc 2.2) The value 600 or greater additionally  ex‐
  poses definitions for SUSv3 (UNIX 03; i.e., the POSIX.1-2001
  base specification plus the XSI extension) and  C99  defini‐
  tions.

This is why I thought "POSIX.1" was the most appropriate.

POSIX.2 is mentioned in the libc manual, but it doesn't appear to cover
pseudo-terminal functionality:

     Some facilities from ‘ISO/IEC 9945-2:1993, the POSIX Shell and
  Utilities standard’ (POSIX.2) are also implemented in the GNU C Library.
  These include utilities for dealing with regular expressions and other
  pattern matching facilities

Existing uses of @standards{POSIX.2, ...} in the manual are consistent
with this.

'./summary.pl --help' doesn't offer any further guidance.

  reply	other threads:[~2023-04-23  9:35 UTC|newest]

Thread overview: 5+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2023-04-12 12:45 Gavin Smith
2023-04-19 12:43 ` Adhemerval Zanella Netto
2023-04-23  9:35   ` Gavin Smith [this message]
2023-04-26 12:20     ` Adhemerval Zanella Netto
2023-04-26 19:19       ` Gavin Smith

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=ZET77MEd6BKz7xu0@starmint \
    --to=gavinsmith0123@gmail.com \
    --cc=adhemerval.zanella@linaro.org \
    --cc=libc-alpha@sourceware.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).