From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from EUR05-DB8-obe.outbound.protection.outlook.com (mail-db8eur05on2050.outbound.protection.outlook.com [40.107.20.50]) by sourceware.org (Postfix) with ESMTPS id A71423858C53 for ; Wed, 26 Apr 2023 09:47:04 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.4.2 sourceware.org A71423858C53 Authentication-Results: sourceware.org; dmarc=pass (p=none dis=none) header.from=arm.com Authentication-Results: sourceware.org; spf=pass smtp.mailfrom=arm.com DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=armh.onmicrosoft.com; s=selector2-armh-onmicrosoft-com; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=p6fIaM0swM9uz2eTQ1rI3Jyx1H/zvaSjykYPaB6x+Sc=; b=wjE7ILbZq4Xd+iKcSi53qLcksayc4SF3B/Wc6c/pp5czpmRkXtPQ/4RR45mYLODF6QfpeS3cDY859ndLyhbYJRHAgix50rGHWTTkxhg2WlSMQD5qFUh4tqXq3pxNXvYjnShRUXEkFMXo8iVL1/XM43GaTCnhY8KAmBX1ZSWLqMQ= Received: from AM6PR02CA0014.eurprd02.prod.outlook.com (2603:10a6:20b:6e::27) by DU0PR08MB8978.eurprd08.prod.outlook.com (2603:10a6:10:466::13) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.6319.32; Wed, 26 Apr 2023 09:47:02 +0000 Received: from AM7EUR03FT027.eop-EUR03.prod.protection.outlook.com (2603:10a6:20b:6e:cafe::72) by AM6PR02CA0014.outlook.office365.com (2603:10a6:20b:6e::27) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.6340.21 via Frontend Transport; Wed, 26 Apr 2023 09:47:02 +0000 X-MS-Exchange-Authentication-Results: spf=pass (sender IP is 63.35.35.123) smtp.mailfrom=arm.com; dkim=pass (signature was verified) header.d=armh.onmicrosoft.com;dmarc=pass action=none header.from=arm.com; Received-SPF: Pass (protection.outlook.com: domain of arm.com designates 63.35.35.123 as permitted sender) receiver=protection.outlook.com; client-ip=63.35.35.123; helo=64aa7808-outbound-1.mta.getcheckrecipient.com; pr=C Received: from 64aa7808-outbound-1.mta.getcheckrecipient.com (63.35.35.123) by AM7EUR03FT027.mail.protection.outlook.com (100.127.140.124) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.6340.21 via Frontend Transport; Wed, 26 Apr 2023 09:47:02 +0000 Received: ("Tessian outbound 3570909035da:v136"); Wed, 26 Apr 2023 09:47:02 +0000 X-CheckRecipientChecked: true X-CR-MTA-CID: 2ee40f5e935cbf63 X-CR-MTA-TID: 64aa7808 Received: from ec5ac45e2aa7.1 by 64aa7808-outbound-1.mta.getcheckrecipient.com id D7EB08BA-B7FB-4A52-A812-D9D2B1CC8A6D.1; Wed, 26 Apr 2023 09:46:55 +0000 Received: from EUR02-AM0-obe.outbound.protection.outlook.com by 64aa7808-outbound-1.mta.getcheckrecipient.com with ESMTPS id ec5ac45e2aa7.1 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384); Wed, 26 Apr 2023 09:46:55 +0000 ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=mZ9avaZN1GDVAKioxRCQlwgGdEpVd/b4tpYkeQoQmH6j6RU1x/BwNzn1HQ9ekqPHUAD2TqerB7aVDyq293X4LDvuKEY/QH1VQa+BdZ/9BtglVtah/F5or07/S1B6Nh+nDMZcKT28BfPdZZSw4u/+0WCshsG/zlOI9qpRra8uhu9diL5DCH6xOnOVdj6ZfiyJq/MjEc+3ioFtbSWEyvV6q+O6gmpCtD1KYSP32oCkauulwfrDhzMKdNkQC2xWRYA7bRCm3HRAzy5jfQoxYzPJ66F/mpBEFUypXim0K8CPaaBRcPXsoycIm9J/KQ0uqLbXXf/NBST1NnAa1F3eKifcFw== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=p6fIaM0swM9uz2eTQ1rI3Jyx1H/zvaSjykYPaB6x+Sc=; b=fooAKnItRTRhLhxqIwAxYNsnrQRfWUUHDikuhv97z9CI0ZRrAV1IvTQ18KjZwEVgUd5Dmr/T9zZeGkYCxvYT1mfm8pvHUOEMZ2sfqCBwy8Sw0Eh/ERfD/WBzu/q+h/WwGrBb1YcdX/tdWipszvbjQ2N8mB0WeBdlwjhGvCLOfHyAqbaXd7uPJkfLlupmOVf4CNZUZRhcfw6eQoq9D5b/R2WwgFhW07B81rcq2/b1biqj/KOWhhaqe7S/ernux1YmPESnkAVfWEezBMr6rtXObS46eM4sKZSNyjkD4U2kBie6j04gkkpRP8DuWuAA3I8mDp5+wFMIZAISSh+39tpOhw== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=arm.com; dmarc=pass action=none header.from=arm.com; dkim=pass header.d=arm.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=armh.onmicrosoft.com; s=selector2-armh-onmicrosoft-com; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=p6fIaM0swM9uz2eTQ1rI3Jyx1H/zvaSjykYPaB6x+Sc=; b=wjE7ILbZq4Xd+iKcSi53qLcksayc4SF3B/Wc6c/pp5czpmRkXtPQ/4RR45mYLODF6QfpeS3cDY859ndLyhbYJRHAgix50rGHWTTkxhg2WlSMQD5qFUh4tqXq3pxNXvYjnShRUXEkFMXo8iVL1/XM43GaTCnhY8KAmBX1ZSWLqMQ= Authentication-Results-Original: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=arm.com; Received: from DB9PR08MB7179.eurprd08.prod.outlook.com (2603:10a6:10:2cc::19) by DB5PR08MB10140.eurprd08.prod.outlook.com (2603:10a6:10:4a1::15) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.6340.21; Wed, 26 Apr 2023 09:46:53 +0000 Received: from DB9PR08MB7179.eurprd08.prod.outlook.com ([fe80::242d:33fe:1c48:bd8]) by DB9PR08MB7179.eurprd08.prod.outlook.com ([fe80::242d:33fe:1c48:bd8%6]) with mapi id 15.20.6340.021; Wed, 26 Apr 2023 09:46:53 +0000 Date: Wed, 26 Apr 2023 10:46:35 +0100 From: Szabolcs Nagy To: Xi Ruoyao , Joe Simmons-Talbott , libc-alpha@sourceware.org Subject: Re: [PATCH v6 3/3] nptl: Use direct syscall numbers in setxid Message-ID: References: <20230424150353.1469397-1-josimmon@redhat.com> <20230424150353.1469397-4-josimmon@redhat.com> Content-Type: text/plain; charset=utf-8 Content-Disposition: inline Content-Transfer-Encoding: 8bit In-Reply-To: X-ClientProxiedBy: SA0PR11CA0177.namprd11.prod.outlook.com (2603:10b6:806:1bb::32) To DB9PR08MB7179.eurprd08.prod.outlook.com (2603:10a6:10:2cc::19) MIME-Version: 1.0 X-MS-TrafficTypeDiagnostic: DB9PR08MB7179:EE_|DB5PR08MB10140:EE_|AM7EUR03FT027:EE_|DU0PR08MB8978:EE_ X-MS-Office365-Filtering-Correlation-Id: 672893a3-04c8-4d4d-e222-08db463b2fe8 x-checkrecipientrouted: true NoDisclaimer: true X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam-Untrusted: BCL:0; X-Microsoft-Antispam-Message-Info-Original: hVdQT1D5L4ffyRTiZMWtxrai7dRT5ELe0P/5FocHS4lv52DrZUvlaqelYBecPezJpJvRJX66cbtMacS4WGoQmAKXyIabKUnsb9VjR0A+ZhVifKdIYSm/0uyAOtyAQoZnkE/wN+GaTVkfppU4dTjT7x44qvG9ZMSYtdZFQzR//NLp+USYmJqPnIy/kIxDaixhjFum81jBbXb//yZ94vsXc1H+BSAIeoOBR+frE3vc2rIZ51D5oQ03a4WUcp/RPgTAR0I5MtOYExN8hK8uoEuqxN3lDtDaq3tJ/E3KpHkrugAsy7VZBwYjjMtzOUJayyKSXfImVj0Vf2uSlWxvgB80CDfW4VcFnt62VNbyerxPM/sWEoS4UzI8fybafhvv+m8wPaFTMZE8hzpXOQCC6LBqzm9eLvfpQ1KO/tiLQon+Wx+qLByw2fX5HGta8wiWbaCNnkHL0spBLFGO84D9macY8yhzNTpFtlMVdPhKf6mCxl0ugUpzfywxaG1JPN2lMOfVluQ83+5XnQBvSFAPkWFi3AEx69bNW0CHVVdWO1UNaRvl8oqosc3k4vYaNYC+nhe0 X-Forefront-Antispam-Report-Untrusted: CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:DB9PR08MB7179.eurprd08.prod.outlook.com;PTR:;CAT:NONE;SFS:(13230028)(4636009)(396003)(376002)(366004)(39860400002)(346002)(136003)(451199021)(83380400001)(2616005)(86362001)(36756003)(6512007)(6506007)(26005)(6486002)(6666004)(478600001)(316002)(66476007)(66556008)(66946007)(110136005)(8936002)(8676002)(41300700001)(38100700002)(186003)(2906002)(4744005)(5660300002)(44832011);DIR:OUT;SFP:1101; X-MS-Exchange-Transport-CrossTenantHeadersStamped: DB5PR08MB10140 Original-Authentication-Results: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=arm.com; X-EOPAttributedMessage: 0 X-MS-Exchange-Transport-CrossTenantHeadersStripped: AM7EUR03FT027.eop-EUR03.prod.protection.outlook.com X-MS-PublicTrafficType: Email X-MS-Office365-Filtering-Correlation-Id-Prvs: 7702cbe6-04ff-4591-7637-08db463b2a93 X-Microsoft-Antispam: BCL:0; X-Microsoft-Antispam-Message-Info: oT8gORP605hDNz9upeQoeNX09EQSNjX7saCopu/YJptrg7zbNhl0HIViXXhT/sNCAB8fbdzm38l7MuE3FhoIGQeDhMv0tMSwILk0Q7WtpVRtAz3hC5yRnDo0hlFAVKCm6XwNEf5SOXEGS4+UPCAwaS+FulLgQosrhy1lp8joR9WmVMtgnMU6pcJ1rYNkBrB3X6jPkYlzgjmISBrkLUne3Cs1Tt2r3Nlyrx4PxPtejBSlWeKefsjl76RXBzT0OFlQBwKB09QPtmHwAQto+SHol3sDGuh/e4g2LV4OOtS+ppYqjcn+wNfvLnsM5nVKNQUi112bXYroek5um1a/tbjibHgKY01LYNIxmXsKzoNQJd5xXOYwXHKIVLPQB0SWbOIn3PV0qHMXBsqu1hsmrXHTbQ+3u597Up/qCMYNA6dabRBqc7tlqcxr3iOxnHUWaHRvVgPJclNIOJcNlqN+d7dTa0AuSgDtla8QE+/liCrLjwRlGM6tTstGD04v1ard/BQOfk6C+1DfGzBViS10x0mLhZPowT2eKlDASuAnyHuQ0D+peJ0FLD7EY/6RO+Yr7mvcf0v51wRvcgYS70E2liHH5ovnGQHtw2P/K7cS3SRzT16gT4xy/2rf6n+IAobrX7rNcNS1mDnp5EO6WFC5JRc7lVLb9uy7UfYrFymRTekzOpD/DgL+KjQpgoFsqCPAWR/+CdTx2fPMwQXhYnE5RJn8DuD1jksUNKoJLphxvFyyCuI= X-Forefront-Antispam-Report: CIP:63.35.35.123;CTRY:IE;LANG:en;SCL:1;SRV:;IPV:CAL;SFV:NSPM;H:64aa7808-outbound-1.mta.getcheckrecipient.com;PTR:ec2-63-35-35-123.eu-west-1.compute.amazonaws.com;CAT:NONE;SFS:(13230028)(4636009)(396003)(39860400002)(376002)(346002)(136003)(451199021)(46966006)(40470700004)(36840700001)(186003)(478600001)(6666004)(34070700002)(6486002)(110136005)(316002)(26005)(6506007)(6512007)(356005)(82740400003)(70586007)(36860700001)(70206006)(83380400001)(41300700001)(336012)(81166007)(44832011)(5660300002)(2616005)(2906002)(36756003)(40460700003)(4744005)(47076005)(86362001)(82310400005)(8936002)(40480700001)(8676002);DIR:OUT;SFP:1101; X-OriginatorOrg: arm.com X-MS-Exchange-CrossTenant-OriginalArrivalTime: 26 Apr 2023 09:47:02.3394 (UTC) X-MS-Exchange-CrossTenant-Network-Message-Id: 672893a3-04c8-4d4d-e222-08db463b2fe8 X-MS-Exchange-CrossTenant-Id: f34e5979-57d9-4aaa-ad4d-b122a662184d X-MS-Exchange-CrossTenant-OriginalAttributedTenantConnectingIp: TenantId=f34e5979-57d9-4aaa-ad4d-b122a662184d;Ip=[63.35.35.123];Helo=[64aa7808-outbound-1.mta.getcheckrecipient.com] X-MS-Exchange-CrossTenant-AuthSource: AM7EUR03FT027.eop-EUR03.prod.protection.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Anonymous X-MS-Exchange-CrossTenant-FromEntityHeader: HybridOnPrem X-MS-Exchange-Transport-CrossTenantHeadersStamped: DU0PR08MB8978 X-Spam-Status: No, score=-5.7 required=5.0 tests=BAYES_00,DKIM_SIGNED,DKIM_VALID,FORGED_SPF_HELO,KAM_DMARC_NONE,RCVD_IN_DNSWL_NONE,RCVD_IN_MSPIKE_H2,SPF_HELO_PASS,SPF_NONE,TXREP,T_SCC_BODY_TEXT_LINE,UNPARSEABLE_RELAY autolearn=no autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on server2.sourceware.org List-Id: The 04/24/2023 23:17, Xi Ruoyao via Libc-alpha wrote: > On Mon, 2023-04-24 at 11:03 -0400, Joe Simmons-Talbott via Libc-alpha > wrote: > > Make all internal glibc syscalls use direct compile time numeric values > > rather than variables.  This will make the syscall number easier to > > identify during static analysis. > > This is making the code much more bloated and slower. Do we really want > to make everyone's system slower for some debug tools? the switch statement overhead is many orders of magnitude smaller than sending a signal to a thread and executing a syscall there (which is where the switch statement happens). i dont know if the change is justified, but from a target port perspective it's useful if inline syscalls are guaranteed to use a syscall name that can expand to an integer constant or named function.