From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from EUR03-DBA-obe.outbound.protection.outlook.com (mail-dbaeur03on2068.outbound.protection.outlook.com [40.107.104.68]) by sourceware.org (Postfix) with ESMTPS id 001A53858436 for ; Wed, 26 Apr 2023 13:24:58 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.4.2 sourceware.org 001A53858436 Authentication-Results: sourceware.org; dmarc=pass (p=none dis=none) header.from=arm.com Authentication-Results: sourceware.org; spf=pass smtp.mailfrom=arm.com DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=armh.onmicrosoft.com; s=selector2-armh-onmicrosoft-com; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=BhNRXieVR1lbSbLOMqO6wh7cQHPPDEENF0eZQVCDu/0=; b=hhcW4xRDsMS5f93iqa47YN3CJk8L/yLmprqI4f1N/09Z8fVS5qdG9Wk7KSxOwerpJiFUAUSQH+SnFsyWm0xHlvCSCNPvkKl4/IGC06EWAnJLh+0WGPKGkpk/iVReKNnMN/7kxveAj5Ka9P89KrZdS1/j+WowWJ1JeXW5whpVAZM= Received: from DB6PR1001CA0008.EURPRD10.PROD.OUTLOOK.COM (2603:10a6:4:b7::18) by PAWPR08MB8886.eurprd08.prod.outlook.com (2603:10a6:102:33a::18) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.6319.33; Wed, 26 Apr 2023 13:24:49 +0000 Received: from DBAEUR03FT014.eop-EUR03.prod.protection.outlook.com (2603:10a6:4:b7:cafe::d7) by DB6PR1001CA0008.outlook.office365.com (2603:10a6:4:b7::18) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.6319.33 via Frontend Transport; Wed, 26 Apr 2023 13:24:49 +0000 X-MS-Exchange-Authentication-Results: spf=pass (sender IP is 63.35.35.123) smtp.mailfrom=arm.com; dkim=pass (signature was verified) header.d=armh.onmicrosoft.com;dmarc=pass action=none header.from=arm.com; Received-SPF: Pass (protection.outlook.com: domain of arm.com designates 63.35.35.123 as permitted sender) receiver=protection.outlook.com; client-ip=63.35.35.123; helo=64aa7808-outbound-1.mta.getcheckrecipient.com; pr=C Received: from 64aa7808-outbound-1.mta.getcheckrecipient.com (63.35.35.123) by DBAEUR03FT014.mail.protection.outlook.com (100.127.143.22) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.6340.22 via Frontend Transport; Wed, 26 Apr 2023 13:24:48 +0000 Received: ("Tessian outbound 3a01b65b5aad:v136"); Wed, 26 Apr 2023 13:24:48 +0000 X-CheckRecipientChecked: true X-CR-MTA-CID: 44e979e52c1aa602 X-CR-MTA-TID: 64aa7808 Received: from e7c38e77ead3.1 by 64aa7808-outbound-1.mta.getcheckrecipient.com id 2353E82C-71C8-4FD0-A9DB-56BFD1B4A5B6.1; Wed, 26 Apr 2023 13:24:42 +0000 Received: from EUR05-VI1-obe.outbound.protection.outlook.com by 64aa7808-outbound-1.mta.getcheckrecipient.com with ESMTPS id e7c38e77ead3.1 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384); Wed, 26 Apr 2023 13:24:42 +0000 ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=Y7OPUooqgutUcnd4N0+DxJUyZgzwmiGCCesjkHi4xM0QOca/ur5Pw+ESh+VPZXZD4jpvCoAJ/DASVLzKU2AazopCFSeUSw5epU03l7ZXenHF6ii3i+FLwimYPoF9iHFlEWQk2op+j68Pp3BkhUrP9PDEzb3rIRwL/s0URiwQzfXkA/qx8WifTHWNr5ar88XrwVwi1McvjdduPmpB8LvpPeMy6blLpNa+rs8vSsjlrHypn8SSUdCZVcl/M80o0PfNmxsNwLPAZytB6yZrWzjqNjlcjl8RaO1a66skRwnLEN34DqlrBlHPYySnsnYqj8ZQqvIjzL1yUqEAF8lGeMQboQ== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=BhNRXieVR1lbSbLOMqO6wh7cQHPPDEENF0eZQVCDu/0=; b=mNs1bnSAqzUqEfn9pnwwamDMbptGABZc2pUWBJO5MVxuxyp57qz+hIKHIDK0O4JSGL95vbMxKkISPk3pzjczBjdxcTRMNvlhOXODu2XlfPGnCpr6CBbLjYqAlmGY9iEi0MvNxJBj+eI82oYlqonc2oVbzG2rhArp6WPwXfk6lZZ+hai0IqM/N5nMRGqONHhe5X6A90C/EXd6tOqjUdYLx/1FNKg68CPwRkuzWWIP3AzqRkXAPCk9CqOANIfgpRXhsaDdSpuFBVagieRsv3iLV4L3BX1bUqNCXe/BA6UL7Mn4yvV1pP6rc+3wDHaHC5UuP/Qa3/p3NwzoxafDHr+3kw== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=arm.com; dmarc=pass action=none header.from=arm.com; dkim=pass header.d=arm.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=armh.onmicrosoft.com; s=selector2-armh-onmicrosoft-com; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=BhNRXieVR1lbSbLOMqO6wh7cQHPPDEENF0eZQVCDu/0=; b=hhcW4xRDsMS5f93iqa47YN3CJk8L/yLmprqI4f1N/09Z8fVS5qdG9Wk7KSxOwerpJiFUAUSQH+SnFsyWm0xHlvCSCNPvkKl4/IGC06EWAnJLh+0WGPKGkpk/iVReKNnMN/7kxveAj5Ka9P89KrZdS1/j+WowWJ1JeXW5whpVAZM= Authentication-Results-Original: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=arm.com; Received: from DB9PR08MB7179.eurprd08.prod.outlook.com (2603:10a6:10:2cc::19) by AS4PR08MB8120.eurprd08.prod.outlook.com (2603:10a6:20b:58c::7) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.6340.21; Wed, 26 Apr 2023 13:24:39 +0000 Received: from DB9PR08MB7179.eurprd08.prod.outlook.com ([fe80::242d:33fe:1c48:bd8]) by DB9PR08MB7179.eurprd08.prod.outlook.com ([fe80::242d:33fe:1c48:bd8%6]) with mapi id 15.20.6340.021; Wed, 26 Apr 2023 13:24:39 +0000 Date: Wed, 26 Apr 2023 14:24:24 +0100 From: Szabolcs Nagy To: Cristian =?utf-8?Q?Rodr=C3=ADguez?= , Xi Ruoyao Cc: Joe Simmons-Talbott , libc-alpha@sourceware.org Subject: Re: [PATCH v6 3/3] nptl: Use direct syscall numbers in setxid Message-ID: References: <20230424150353.1469397-1-josimmon@redhat.com> <20230424150353.1469397-4-josimmon@redhat.com> Content-Type: text/plain; charset=utf-8 Content-Disposition: inline Content-Transfer-Encoding: 8bit In-Reply-To: X-ClientProxiedBy: LO4P123CA0347.GBRP123.PROD.OUTLOOK.COM (2603:10a6:600:18d::10) To DB9PR08MB7179.eurprd08.prod.outlook.com (2603:10a6:10:2cc::19) MIME-Version: 1.0 X-MS-TrafficTypeDiagnostic: DB9PR08MB7179:EE_|AS4PR08MB8120:EE_|DBAEUR03FT014:EE_|PAWPR08MB8886:EE_ X-MS-Office365-Filtering-Correlation-Id: 785984b6-882d-4527-18c8-08db46599c2f x-checkrecipientrouted: true NoDisclaimer: true X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam-Untrusted: BCL:0; X-Microsoft-Antispam-Message-Info-Original: /X8S8TdzmtxpLGJmp4eakn6CK7SFsmQ1JTppCzCLw2z3MadwWZ7Xsh0eohAa21wZeUQt4FODrXVu2b8EYJpQNdeED7cV7vCbuuBD8CWHSbSC5iO1A6juMzg18IuMHSBJu3gvy9RBMOyws7F1Z5DKuCzhLxuc1D7vkT6vyeGwPrQJA40fojs78C+V9HFucbmSQC0pDffenHXQswNGSi997jI87yCuKaM7ooGoAYQx42Z73FtncSwcxpwt5q59oPICzGc9oh2YA8q5D1t+uug0XBNe67SnfrCuMidv8LFGZN3WgelKCJ69DiOdew10gq4i5kvZU7Up90kJE7VuBFyE0iEyYHQkOmIGZTQo/6o9Q6ch34E62uDPBpIEKhDjxtfdpJUCHGxz4C5Zsl+ORAdgm1+FPvr+xl7oxIPZh4wv7kURUzH3jJ4NX091IpguM104pNhJSleyc0YAGy//dVviuJ84XQy1CkPlWBK4AaCIU+p31dZG6ZO4gsS/RnUS7HUH8SLZ3v1GfIaVn//fx/uBex3X9NxK8pmdw9G8htM5tjtjlmXdAnsNuG6DEo7ynzLg X-Forefront-Antispam-Report-Untrusted: CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:DB9PR08MB7179.eurprd08.prod.outlook.com;PTR:;CAT:NONE;SFS:(13230028)(4636009)(39860400002)(346002)(366004)(396003)(136003)(376002)(451199021)(38100700002)(2616005)(83380400001)(6506007)(6512007)(26005)(53546011)(44832011)(478600001)(86362001)(66574015)(8936002)(8676002)(5660300002)(41300700001)(110136005)(4744005)(2906002)(4326008)(36756003)(66476007)(186003)(66946007)(316002)(6666004)(6486002)(66556008);DIR:OUT;SFP:1101; X-MS-Exchange-Transport-CrossTenantHeadersStamped: AS4PR08MB8120 Original-Authentication-Results: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=arm.com; X-EOPAttributedMessage: 0 X-MS-Exchange-Transport-CrossTenantHeadersStripped: DBAEUR03FT014.eop-EUR03.prod.protection.outlook.com X-MS-PublicTrafficType: Email X-MS-Office365-Filtering-Correlation-Id-Prvs: 62fb8e20-307d-4212-3c82-08db4659964a X-Microsoft-Antispam: BCL:0; X-Microsoft-Antispam-Message-Info: RodwMBZPsB8DRqUdmYqcZBBuydppb3EBggyfm0FlZoa7SImjiKcYsr5Dj2/tTy1SDA/mECqy+FRX8N4tw5UVI+L6LqNfT1zR+s3BozD7YdguiisIF7FHiQYQ9+RHuIzdap+S1JER7CLl1Pfj7IRe+MROvQaOSw50+ep61SBvrUhM2Hu9YMP9Fr9elOE6rfB4MRMrGwnE4Q5f478rs4VS+v5dRbc4VLeIaL+gFf9IcmBcp7X5gA+9YLZe1bn5KfC464dBV+x6t892QiyxdmCGv66H4L3OUcUXU99vs0tDfIwb1aC26iIR/TkzVL5BTvXfFxVNjtlCSixUEMUt12KsnQNXRk8tm6T/V2OceXiksNVjeBvxw9hRPgiIStDn9xM7W/1fZjbIbn4G6k02hqIIMnv8Ac3J5slQQCuqE4EN3hZwHDqaM/3sZX90/0HPzrrcpH0VdEmbx0ex1zrLHbQmp77JC5a7N6dQQoiIVg4GCr6USSruo7Ae/n3bHPcZJEs/b8ONtBIXshA/qHjnVhv/t1OAThDkVUIR+LPoezm67UXL0i4Umn29sfZe0x/YHHbMkWFt7Gi0kuuRbD3qTTKU46cqhVuWm9XzK87TjYjtK8ncJX2gVZaNY0m8Glcnt2SAiSQbYamxBSfJBzhXGbaNDeBo1ZK7wWdukGbJ2f5DqjPnXQFzxZGqWOpZyENo+1fF8/z4eArXaryHnuAynYPuWOnQjahkOgr6/6sWMHX3mxu3S7F4YN3WaKZrrpyCQKH64OZwUXdV3wu7eHdC9VYMRkJOLAZwq/eGXS085OnK6GI= X-Forefront-Antispam-Report: CIP:63.35.35.123;CTRY:IE;LANG:en;SCL:1;SRV:;IPV:CAL;SFV:NSPM;H:64aa7808-outbound-1.mta.getcheckrecipient.com;PTR:ec2-63-35-35-123.eu-west-1.compute.amazonaws.com;CAT:NONE;SFS:(13230028)(4636009)(346002)(396003)(136003)(39860400002)(376002)(451199021)(40470700004)(46966006)(36840700001)(478600001)(66574015)(34070700002)(36860700001)(6666004)(6486002)(40480700001)(81166007)(356005)(26005)(6512007)(186003)(53546011)(110136005)(82740400003)(83380400001)(6506007)(336012)(2616005)(47076005)(5660300002)(8936002)(8676002)(41300700001)(70586007)(70206006)(4744005)(2906002)(316002)(4326008)(44832011)(86362001)(36756003)(40460700003)(82310400005);DIR:OUT;SFP:1101; X-OriginatorOrg: arm.com X-MS-Exchange-CrossTenant-OriginalArrivalTime: 26 Apr 2023 13:24:48.9423 (UTC) X-MS-Exchange-CrossTenant-Network-Message-Id: 785984b6-882d-4527-18c8-08db46599c2f X-MS-Exchange-CrossTenant-Id: f34e5979-57d9-4aaa-ad4d-b122a662184d X-MS-Exchange-CrossTenant-OriginalAttributedTenantConnectingIp: TenantId=f34e5979-57d9-4aaa-ad4d-b122a662184d;Ip=[63.35.35.123];Helo=[64aa7808-outbound-1.mta.getcheckrecipient.com] X-MS-Exchange-CrossTenant-AuthSource: DBAEUR03FT014.eop-EUR03.prod.protection.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Anonymous X-MS-Exchange-CrossTenant-FromEntityHeader: HybridOnPrem X-MS-Exchange-Transport-CrossTenantHeadersStamped: PAWPR08MB8886 X-Spam-Status: No, score=-6.2 required=5.0 tests=BAYES_00,DKIM_SIGNED,DKIM_VALID,KAM_DMARC_NONE,RCVD_IN_DNSWL_NONE,RCVD_IN_MSPIKE_H2,SPF_HELO_NONE,SPF_NONE,TXREP,T_SCC_BODY_TEXT_LINE,UNPARSEABLE_RELAY autolearn=no autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on server2.sourceware.org List-Id: The 04/26/2023 08:39, Cristian Rodríguez via Libc-alpha wrote: > On Mon, Apr 24, 2023 at 11:17 AM Xi Ruoyao via Libc-alpha < > libc-alpha@sourceware.org> wrote: > > > On Mon, 2023-04-24 at 11:03 -0400, Joe Simmons-Talbott via Libc-alpha > > wrote: > > > Make all internal glibc syscalls use direct compile time numeric values > > > rather than variables. This will make the syscall number easier to > > > identify during static analysis. > > > > This is making the code much more bloated and slower. Do we really want > > to make everyone's system slower for some debug tools? > > > > > The switch statement will add little overhead. my concern with this is that > it looks ugly and error prone for no other reason than help some > limited debug tool.. there must be a nicer, less verbose way to get what > you want.. it allows glibc to drop the INTERNAL_SYSCALL_NCS code. which can clean up some target code.