From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from EUR01-HE1-obe.outbound.protection.outlook.com (mail-he1eur01on2049.outbound.protection.outlook.com [40.107.13.49]) by sourceware.org (Postfix) with ESMTPS id 17CA53858D37 for ; Thu, 22 Jun 2023 14:16:59 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.4.2 sourceware.org 17CA53858D37 Authentication-Results: sourceware.org; dmarc=pass (p=none dis=none) header.from=arm.com Authentication-Results: sourceware.org; spf=pass smtp.mailfrom=arm.com DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=armh.onmicrosoft.com; s=selector2-armh-onmicrosoft-com; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=eHMzzb32HK1G/xLbLA8VSGQr6yd6RYL0uBBG4JlAH3M=; b=zBl/K+KJqSdAiirh69itDv03ApcTWm7Qsa5IGY+Sf2yRC3+twk+7M3xkd1qW1v3f48byvc+lLLXrbE8WmxfMORvdcgmra0VVuKdaB0Zg5+UjyuLfR/+V708LM0skH2ZfrUfnAFOgka5jWnuJbS/pdoBVuvzJT7PfOQAcst+UEJ4= Received: from AS9PR06CA0671.eurprd06.prod.outlook.com (2603:10a6:20b:49c::15) by DB3PR08MB8818.eurprd08.prod.outlook.com (2603:10a6:10:434::8) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.6521.24; Thu, 22 Jun 2023 14:16:56 +0000 Received: from AM7EUR03FT034.eop-EUR03.prod.protection.outlook.com (2603:10a6:20b:49c:cafe::e2) by AS9PR06CA0671.outlook.office365.com (2603:10a6:20b:49c::15) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.6521.24 via Frontend Transport; Thu, 22 Jun 2023 14:16:56 +0000 X-MS-Exchange-Authentication-Results: spf=pass (sender IP is 63.35.35.123) smtp.mailfrom=arm.com; dkim=pass (signature was verified) header.d=armh.onmicrosoft.com;dmarc=pass action=none header.from=arm.com; Received-SPF: Pass (protection.outlook.com: domain of arm.com designates 63.35.35.123 as permitted sender) receiver=protection.outlook.com; client-ip=63.35.35.123; helo=64aa7808-outbound-1.mta.getcheckrecipient.com; pr=C Received: from 64aa7808-outbound-1.mta.getcheckrecipient.com (63.35.35.123) by AM7EUR03FT034.mail.protection.outlook.com (100.127.140.87) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.6521.24 via Frontend Transport; Thu, 22 Jun 2023 14:16:56 +0000 Received: ("Tessian outbound e2424c13b707:v142"); Thu, 22 Jun 2023 14:16:56 +0000 X-CheckRecipientChecked: true X-CR-MTA-CID: 3852f77c7fbeec72 X-CR-MTA-TID: 64aa7808 Received: from a8f471609593.1 by 64aa7808-outbound-1.mta.getcheckrecipient.com id D69577F0-46BA-41A8-883A-35798CCA3B8D.1; Thu, 22 Jun 2023 14:16:49 +0000 Received: from EUR04-DB3-obe.outbound.protection.outlook.com by 64aa7808-outbound-1.mta.getcheckrecipient.com with ESMTPS id a8f471609593.1 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384); Thu, 22 Jun 2023 14:16:49 +0000 ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=O7+aQJ9gDySpOfoqbm7hTiG/FG1Ojw5EmT5lmbILA1Sl1lOTTwol4OVHdMy4a1NidkFSIOh6pnNtTRlIpD31ukw3RsRIb9diDdUdyTrDa2ouYWkniSLCm5/2jspRx5rnoGcN7W9Kj0XyEQAg41uX09U+Sez3cA9M7fp1gAJj2OkcvCOKcZm+x8oPWf7E9vWTNRAzxU6dsUAt75XRvuOePy/Oh7qRBLkcGg6KgqEtYG3aeptOFqbNmSV2+6EzIJiVBGT0vDm1iYbMY7YYkluvU8wG2zCoBc067fD200HjcKOwOMN5dkbObvYansJsRII5x0aMO9vR01kQAIzyaJGpBw== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=eHMzzb32HK1G/xLbLA8VSGQr6yd6RYL0uBBG4JlAH3M=; b=LuPM2npTSn8nJDZVn9H0n2hfGh8OdfJsvPtazTLzNjqUETWFnjjUhnb+TsjxPF1zA4KHKckalpmYeid3dArcSgMbxfuUPXy3k0JbwAaOjpImsu1ns7Ovn5FotLYAx3blTUKN7nV2bgHnJmgX/eqVhsWhZYpgFZQhZik7n5OOV0qLC6ClBmwG9OhFtcsQCm7g8AiDdiordUPKijyvPWH/yrgcA10cCymoGbQkdyvDUx9GlZxZiJ4RHkL/XlBaeacwVFqnqNQ5nmIR9dW+csHesaCyaG3mC2SY62fxugV1LBUQCCRdVrYOQJ/rdXx1a7nMU8O5ng2mutqODO5TnSC/Dg== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=arm.com; dmarc=pass action=none header.from=arm.com; dkim=pass header.d=arm.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=armh.onmicrosoft.com; s=selector2-armh-onmicrosoft-com; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=eHMzzb32HK1G/xLbLA8VSGQr6yd6RYL0uBBG4JlAH3M=; b=zBl/K+KJqSdAiirh69itDv03ApcTWm7Qsa5IGY+Sf2yRC3+twk+7M3xkd1qW1v3f48byvc+lLLXrbE8WmxfMORvdcgmra0VVuKdaB0Zg5+UjyuLfR/+V708LM0skH2ZfrUfnAFOgka5jWnuJbS/pdoBVuvzJT7PfOQAcst+UEJ4= Authentication-Results-Original: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=arm.com; Received: from DB9PR08MB7179.eurprd08.prod.outlook.com (2603:10a6:10:2cc::19) by DB9PR08MB7627.eurprd08.prod.outlook.com (2603:10a6:10:30b::18) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.6521.24; Thu, 22 Jun 2023 14:16:48 +0000 Received: from DB9PR08MB7179.eurprd08.prod.outlook.com ([fe80::43b7:3a83:5cbe:4559]) by DB9PR08MB7179.eurprd08.prod.outlook.com ([fe80::43b7:3a83:5cbe:4559%4]) with mapi id 15.20.6521.023; Thu, 22 Jun 2023 14:16:48 +0000 Date: Thu, 22 Jun 2023 15:16:28 +0100 From: Szabolcs Nagy To: Joe Ramsay , Richard Henderson , libc-alpha@sourceware.org Subject: Re: [PATCH v2 1/4] aarch64: Add vector implementations of cos routines Message-ID: References: <20230619145634.18801-1-Joe.Ramsay@arm.com> <96cc5d82-ccad-a3ce-5ec0-3a22d807c24a@linaro.org> Content-Type: text/plain; charset=utf-8 Content-Disposition: inline Content-Transfer-Encoding: 8bit In-Reply-To: X-ClientProxiedBy: BYAPR01CA0029.prod.exchangelabs.com (2603:10b6:a02:80::42) To DB9PR08MB7179.eurprd08.prod.outlook.com (2603:10a6:10:2cc::19) MIME-Version: 1.0 X-MS-TrafficTypeDiagnostic: DB9PR08MB7179:EE_|DB9PR08MB7627:EE_|AM7EUR03FT034:EE_|DB3PR08MB8818:EE_ X-MS-Office365-Filtering-Correlation-Id: d6d481ed-03ea-48c4-9329-08db732b55c9 x-checkrecipientrouted: true NoDisclaimer: true X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam-Untrusted: BCL:0; X-Microsoft-Antispam-Message-Info-Original: /WrPn4DEBE1LPanbXWWUbFWQPP3DaVdpZ98aJ7r4iIUDyFss560xwjZYUQXCEgwF58DIkQbvtumMYsHiqs2kve3FYE3IoNHZvIOgb3znjN64xfVI/VlP7x8Lg16AiXMObato+tkd2yD/3Mn4rxmnlZwWUn6vTl8BZDvSb2gOamq1YkH5/bk6UwU0OsQmRvMh7MsDwXpN2uT6DlRs3qbX01Us53VEzRBV1k/6rUNgxuiImCda2Ga1SzfNzeXHu/Aw7aAuzlEw3agq/cjvRTtCgR1yYiixMt+GVNG/r1xk0UvNYO5FeASLn/6rZ2c+j1a2oPSH8NYd8ZDAWip2bNg2pKDpDEmXo+op3Ve6UZyYWxVzbJsLw/y2RxHmklZIHT4v4ykllcivqIE1qv9+GnW4IGZpYmz0qS+E/UOXHQ8j0B6Y6/7Z/LNOGGotE4OP9meealTemVVE1RAMsR0pW1EdDhbqrDQcjRakprJul7QhjxL1L2qrGQgNp38o42QW7moLWAiYu0R7rwnOyvcNZ7gUDbldcUAdSxOrKpjNvpv9wE7gUz72z+6HUzhm+lkKz8mM X-Forefront-Antispam-Report-Untrusted: CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:DB9PR08MB7179.eurprd08.prod.outlook.com;PTR:;CAT:NONE;SFS:(13230028)(4636009)(366004)(396003)(346002)(136003)(39860400002)(376002)(451199021)(6512007)(186003)(53546011)(26005)(6506007)(8676002)(8936002)(36756003)(316002)(478600001)(38100700002)(6486002)(41300700001)(4744005)(2906002)(6666004)(86362001)(5660300002)(44832011)(2616005)(66946007)(66556008)(66476007)(110136005);DIR:OUT;SFP:1101; X-MS-Exchange-Transport-CrossTenantHeadersStamped: DB9PR08MB7627 Original-Authentication-Results: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=arm.com; X-EOPAttributedMessage: 0 X-MS-Exchange-Transport-CrossTenantHeadersStripped: AM7EUR03FT034.eop-EUR03.prod.protection.outlook.com X-MS-PublicTrafficType: Email X-MS-Office365-Filtering-Correlation-Id-Prvs: 749b7fe1-df51-4b6c-9213-08db732b50e9 X-Microsoft-Antispam: BCL:0; X-Microsoft-Antispam-Message-Info: C/5BSg2exrEp/yfdS6V37Ex8ZzI8l1ZXTJO/FpINtqT1URDvgZJuR14SXhLfpK7CIeS/fKnZZ7hVnpxPi7gug3IDjEk7m/MhL6lVFRk0rMhb4GqbleMhKH2+4wQWa7K3qM5IWe+2lhQTJcZ+Gj0mCsvqfY+IN/cVVIJPfaIe2euIkc5HcKY1jqowGb6i5c5cJjBP1NLYYrdSH7NAEr6YVQvuUj9D6VO99WFHbP76BlN21uN3Ox2IVwYMPjlf96KfEL+ocFpP84hOVcQ0EANgtyiYy6lnjSudL8AYrdLR5In4Z1OoJn4wLFBEJuLQ1rB7Nz6O3YS7OmfTLyBQYN0WD+5szwrh8wH8ABxcFKC/PMqVB07dVJ0HprAAe40FxJrac7grfrs4nQlEasCx06WmxB28C1wLYG2nUzn+t7oGdtrleOZp+arNM65YaNRLeUZjm3DGWS4MH/sDwGlSf+lhM1Di3RlykgcKe+/wL7wmXy8V72isdwVjYRRbH5eR/E7nvHNyCngXvODvY2y2cyeRxuSI0wb9fapkVAMpdIJd7xJJAGkObSs67pZj+bZoa4jsnhxIa5TDtHe6EyM5ujYCojyoUVyJ0dZlfeAkihMDLZNO5p8Nk99z/kk4cj8Q+9OeT7Z3t467xvr7Hvenx6ZRIDa649rFBXYeXof5G4+HwFFqvEc4ajN9xpMipzj2NgNYW8p0ZXYZqL1r8GoseC044VsOXMFOQCI7Fz5DZyCxE9O6m7gu4YhCUF59Kep15t/c X-Forefront-Antispam-Report: CIP:63.35.35.123;CTRY:IE;LANG:en;SCL:1;SRV:;IPV:CAL;SFV:NSPM;H:64aa7808-outbound-1.mta.getcheckrecipient.com;PTR:ec2-63-35-35-123.eu-west-1.compute.amazonaws.com;CAT:NONE;SFS:(13230028)(4636009)(376002)(39860400002)(346002)(396003)(136003)(451199021)(36840700001)(46966006)(40470700004)(53546011)(186003)(26005)(6512007)(6506007)(40460700003)(478600001)(4744005)(2906002)(44832011)(40480700001)(81166007)(86362001)(41300700001)(36860700001)(8936002)(8676002)(356005)(110136005)(47076005)(2616005)(336012)(36756003)(82310400005)(316002)(82740400003)(6486002)(6666004)(5660300002)(70586007)(70206006);DIR:OUT;SFP:1101; X-OriginatorOrg: arm.com X-MS-Exchange-CrossTenant-OriginalArrivalTime: 22 Jun 2023 14:16:56.2493 (UTC) X-MS-Exchange-CrossTenant-Network-Message-Id: d6d481ed-03ea-48c4-9329-08db732b55c9 X-MS-Exchange-CrossTenant-Id: f34e5979-57d9-4aaa-ad4d-b122a662184d X-MS-Exchange-CrossTenant-OriginalAttributedTenantConnectingIp: TenantId=f34e5979-57d9-4aaa-ad4d-b122a662184d;Ip=[63.35.35.123];Helo=[64aa7808-outbound-1.mta.getcheckrecipient.com] X-MS-Exchange-CrossTenant-AuthSource: AM7EUR03FT034.eop-EUR03.prod.protection.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Anonymous X-MS-Exchange-CrossTenant-FromEntityHeader: HybridOnPrem X-MS-Exchange-Transport-CrossTenantHeadersStamped: DB3PR08MB8818 X-Spam-Status: No, score=-5.6 required=5.0 tests=BAYES_00,DKIM_SIGNED,DKIM_VALID,FORGED_SPF_HELO,KAM_DMARC_NONE,RCVD_IN_DNSWL_NONE,RCVD_IN_MSPIKE_H2,SPF_HELO_PASS,SPF_NONE,TXREP,T_SCC_BODY_TEXT_LINE,UNPARSEABLE_RELAY autolearn=no autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on server2.sourceware.org List-Id: The 06/20/2023 15:25, Joe Ramsay via Libc-alpha wrote: > Hi Richard, > > On 19/06/2023 16:18, Richard Henderson wrote: > > Surely 'const' is always preferred. > > > > If you want to force the single adrp, then > > > >     __typeof (data) *d = &data; > >     asm ("" : "+r"(d)); > > > > may be a better solution.  Especially vs writable constants. > > Thanks for the suggestion. We observe slightly worse codegen this way - > something about this confuses the register allocator in GCC, to the extent > that in some routines (for example SVE sin) we see extra loads and stores to > preserve callee-saved registers. We would rather keep the existing, slightly > more performant, approach. we want the data to be in read-only section so the const is needed. the asm solution sounds good, we should see if gcc can be improved.