From: Szabolcs Nagy <szabolcs.nagy@arm.com>
To: Joe Ramsay <Joe.Ramsay@arm.com>, <libc-alpha@sourceware.org>
Subject: Re: [PATCH v3 1/4] aarch64: Add vector implementations of cos routines
Date: Wed, 28 Jun 2023 11:04:52 +0100 [thread overview]
Message-ID: <ZJwFxITXPubppXNe@arm.com> (raw)
In-Reply-To: <20230623152423.1683-1-Joe.Ramsay@arm.com>
The 06/23/2023 16:24, Joe Ramsay via Libc-alpha wrote:
> Replace the loop-over-scalar placeholder routines with optimised
> implementations from Arm Optimized Routines (AOR).
>
> Also add some headers containing utilities for aarch64 libmvec
> routines, and update libm-test-ulps.
>
> Data tables for new routines are either marked volatile (for AdvSIMD)
> or used via a pointer with a barrier on it, in order to prevent overly
> aggressive constant inlining in GCC. This allows a single adrp,
> combined with offset loads, to be used for every constant in the
> table.
i think the pointer barrier is a reasonable workaround.
we should do that for advsimd too to be consistent
(unless it causes big regression compared to volatile).
otherwise the patch looks good.
prev parent reply other threads:[~2023-06-28 10:05 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-06-23 15:24 Joe Ramsay
2023-06-23 15:24 ` [PATCH v3 2/4] aarch64: Add vector implementations of sin routines Joe Ramsay
2023-06-23 15:24 ` [PATCH v3 3/4] aarch64: Add vector implementations of log routines Joe Ramsay
2023-06-23 15:24 ` [PATCH v4 4/4] aarch64: Add vector implementations of exp routines Joe Ramsay
2023-06-28 10:04 ` Szabolcs Nagy [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=ZJwFxITXPubppXNe@arm.com \
--to=szabolcs.nagy@arm.com \
--cc=Joe.Ramsay@arm.com \
--cc=libc-alpha@sourceware.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).