From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from EUR04-DB3-obe.outbound.protection.outlook.com (mail-db3eur04on2085.outbound.protection.outlook.com [40.107.6.85]) by sourceware.org (Postfix) with ESMTPS id 77B383858CDB; Thu, 5 Oct 2023 08:19:38 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.4.2 sourceware.org 77B383858CDB Authentication-Results: sourceware.org; dmarc=pass (p=none dis=none) header.from=arm.com Authentication-Results: sourceware.org; spf=pass smtp.mailfrom=arm.com DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=armh.onmicrosoft.com; s=selector2-armh-onmicrosoft-com; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=rbXvZ8bcXacH4quYBvXu7E9C/p26kEQWtOelpri/S+A=; b=gZXJ9JO1KtkqYVmmvdTauBZLgwyXXBpL35f6flZ5Yhaof851RDQXmUl4F/PbAmyvX2qg/NpB6qAA4yk8jB1K7o4GtgYyywSb59wLRaEPuRnSThnz4gpeMzSZIdulKr3IAG7zroiYfIo9HjkbfQehmxJIWlK2Ui6ytaqA5jNLvNM= Received: from DUZPR01CA0100.eurprd01.prod.exchangelabs.com (2603:10a6:10:4bb::8) by AS2PR08MB9319.eurprd08.prod.outlook.com (2603:10a6:20b:599::17) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.6838.35; Thu, 5 Oct 2023 08:19:32 +0000 Received: from DBAEUR03FT034.eop-EUR03.prod.protection.outlook.com (2603:10a6:10:4bb:cafe::8c) by DUZPR01CA0100.outlook.office365.com (2603:10a6:10:4bb::8) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.6863.25 via Frontend Transport; Thu, 5 Oct 2023 08:19:32 +0000 X-MS-Exchange-Authentication-Results: spf=pass (sender IP is 63.35.35.123) smtp.mailfrom=arm.com; dkim=pass (signature was verified) header.d=armh.onmicrosoft.com;dmarc=pass action=none header.from=arm.com; Received-SPF: Pass (protection.outlook.com: domain of arm.com designates 63.35.35.123 as permitted sender) receiver=protection.outlook.com; client-ip=63.35.35.123; helo=64aa7808-outbound-1.mta.getcheckrecipient.com; pr=C Received: from 64aa7808-outbound-1.mta.getcheckrecipient.com (63.35.35.123) by DBAEUR03FT034.mail.protection.outlook.com (100.127.142.97) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.6863.26 via Frontend Transport; Thu, 5 Oct 2023 08:19:32 +0000 Received: ("Tessian outbound 0ae75d4034ba:v211"); Thu, 05 Oct 2023 08:19:32 +0000 X-CheckRecipientChecked: true X-CR-MTA-CID: ec42a15693cfbb2b X-CR-MTA-TID: 64aa7808 Received: from d39607686bb2.1 by 64aa7808-outbound-1.mta.getcheckrecipient.com id D4AA4807-A4AE-454B-86E6-2E6222953A87.1; Thu, 05 Oct 2023 08:19:25 +0000 Received: from EUR03-AM7-obe.outbound.protection.outlook.com by 64aa7808-outbound-1.mta.getcheckrecipient.com with ESMTPS id d39607686bb2.1 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384); Thu, 05 Oct 2023 08:19:25 +0000 ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=kS/3g9hqJK0mXWZh7+IH9h76NeEsK+iSJH90yVD8jvFwH7sAMwhrVwfw7BfKqB+7nYHSrh44Y5pPLunmPBbPIV2ljQcZwjWbFncBC4RQ7vMTnpdc0oRZtBzb4n4SHu9b9xoCqyKVhDb/uYVto80MEQAnM3Jbh6WAo0tiS+Jsv/0bFZgpAIz5xjoyhiPr0v+c+9EOEYL1kYUxSfA8ccmt/cxsd/ar8AUCuPmZ+urTHakDkydiE2AqjVlHKydV2Dy+nrQFqx8x5ZK8J7a+8G+6WjcBFNkxx3YUegfxpi3x7kb1mrxV/CcWPDNGcHJauuCSYXrEZJ5ep3LNpiNlD0F1og== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=rbXvZ8bcXacH4quYBvXu7E9C/p26kEQWtOelpri/S+A=; b=YOH748yLDJyyYwDp4SziRUIqn70RY2y5eHeBiso26v1H2jPfLYKz85+kkSfbxJzhjVEY1NIU4JP/8KdXZ9uJaYI8igUEmesBC/GbXY0wEycRaB2bo/FCSsUDDODc/75OEgeqRpKEMFS/X39D/1xkazYRzi60HTywDWeBMvkM29UPV9Kv6EgQY5ZWI9ttVXTQOLAuRLT/1q7C7Hmr+LF7k6jD1QTMsFwRfuCpDvF6XVhnMgcUKfPVqZjVdPIxQoRnmJGbKKwUq6ju1CmKLcQZuxWRxLaC9IF1m78CB6+lcm0ZhqWlbfOuof9VenoJvyuHnLIcpd0jIZWD6j9Ji8wEng== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=arm.com; dmarc=pass action=none header.from=arm.com; dkim=pass header.d=arm.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=armh.onmicrosoft.com; s=selector2-armh-onmicrosoft-com; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=rbXvZ8bcXacH4quYBvXu7E9C/p26kEQWtOelpri/S+A=; b=gZXJ9JO1KtkqYVmmvdTauBZLgwyXXBpL35f6flZ5Yhaof851RDQXmUl4F/PbAmyvX2qg/NpB6qAA4yk8jB1K7o4GtgYyywSb59wLRaEPuRnSThnz4gpeMzSZIdulKr3IAG7zroiYfIo9HjkbfQehmxJIWlK2Ui6ytaqA5jNLvNM= Authentication-Results-Original: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=arm.com; Received: from DB9PR08MB7179.eurprd08.prod.outlook.com (2603:10a6:10:2cc::19) by AS8PR08MB8224.eurprd08.prod.outlook.com (2603:10a6:20b:52b::14) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.6838.35; Thu, 5 Oct 2023 08:19:24 +0000 Received: from DB9PR08MB7179.eurprd08.prod.outlook.com ([fe80::e62:8b0f:9b88:39a1]) by DB9PR08MB7179.eurprd08.prod.outlook.com ([fe80::e62:8b0f:9b88:39a1%4]) with mapi id 15.20.6838.033; Thu, 5 Oct 2023 08:19:24 +0000 Date: Thu, 5 Oct 2023 09:19:09 +0100 From: Szabolcs Nagy To: Adhemerval Zanella Netto , Siddhesh Poyarekar , libc-alpha@sourceware.org Cc: fweimer@redhat.com, carlos@redhat.com Subject: Re: [PATCH 2/2] aarch64: Make glibc.mem.tagging SXID_ERASE Message-ID: References: Content-Type: text/plain; charset=utf-8 Content-Disposition: inline In-Reply-To: X-ClientProxiedBy: LO4P123CA0525.GBRP123.PROD.OUTLOOK.COM (2603:10a6:600:2c5::8) To DB9PR08MB7179.eurprd08.prod.outlook.com (2603:10a6:10:2cc::19) MIME-Version: 1.0 X-MS-TrafficTypeDiagnostic: DB9PR08MB7179:EE_|AS8PR08MB8224:EE_|DBAEUR03FT034:EE_|AS2PR08MB9319:EE_ X-MS-Office365-Filtering-Correlation-Id: 476e798e-602b-4007-6212-08dbc57bcd86 x-checkrecipientrouted: true NoDisclaimer: true X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam-Untrusted: BCL:0; X-Microsoft-Antispam-Message-Info-Original: Pd4Z8dlHoaUVaiNtLr0dBTlphhN+d9APyoz6BnEBZUQaosn39gWJ/TkCUjB6A9BSorMcd0G0L3PaJQKrO2E0Tvog9OtdNKWEZEtFTjsEYiUNwCFN66UgviJEzS17GMPDLMwpRhiSpHIhizPCi6lOmQhVzgjbvNzxTaGpcUEJyKbJ4jm46E/bqKCARlNwqv/aci9GaUWowu25C9hx/5WpV4peqdh4xfT69y8fRhaDobdr/zWcM2DaBARAcA0kSPOzJLw6hkQ+me1cxV9pDH7Vqv54/MxVv4K60OijG/pQAqxY52Qv7/CTPZzMiC8lm4rFEyRVf/WGQ2z9KWJPEcJz4scYQdG1usTFtXBw8ZiDQxa0pxxQxsXWsf12MjSLuIu1xzGOa6OBwrLQZf/OkkqaHyYtf6XcB/Ma4ktg86LBYejVQoQuQ5BkGbCivlKcgQXhatxMOiZ4dOmF/O+ta7rzrCIdnh7cmZKzQpcXeEUZX6gRxqdxHtk6YpcZyZdYRWnYBwSVo2zfyZvtsHxqAJphSJiKI5EOC/eNOGzT9DwJ4qPbk2Qwn4t+RKywvWVha8F8 X-Forefront-Antispam-Report-Untrusted: CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:DB9PR08MB7179.eurprd08.prod.outlook.com;PTR:;CAT:NONE;SFS:(13230031)(39860400002)(366004)(136003)(396003)(376002)(346002)(230922051799003)(186009)(64100799003)(451199024)(1800799009)(86362001)(4326008)(44832011)(5660300002)(8676002)(8936002)(53546011)(6666004)(36756003)(26005)(2616005)(6486002)(6506007)(6512007)(478600001)(2906002)(4744005)(38100700002)(110136005)(66946007)(41300700001)(316002)(66476007)(66556008);DIR:OUT;SFP:1101; X-MS-Exchange-Transport-CrossTenantHeadersStamped: AS8PR08MB8224 Original-Authentication-Results: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=arm.com; X-EOPAttributedMessage: 0 X-MS-Exchange-Transport-CrossTenantHeadersStripped: DBAEUR03FT034.eop-EUR03.prod.protection.outlook.com X-MS-PublicTrafficType: Email X-MS-Office365-Filtering-Correlation-Id-Prvs: c0cdcb0e-149b-4e95-8d60-08dbc57bc884 X-Microsoft-Antispam: BCL:0; X-Microsoft-Antispam-Message-Info: yFnl47lyI9iofKnumCFnP2V/aGhDOQf1AHKqVga9Hv8x4gUKBwv0cUq11VNXN8LOqp25mKe4w2Rq1/VY3VsyWRQdQVbMwrKKGx8l0WmAFtQbwjkCWAdgNjWoKVA4JwMbtAwe0kAkJmyR40S9rvon6GoTbncwSwY4xunmHA5SOhQ/zvbVUuIEqiCBFoXGXfGgxUJCXHrg2/su8cd0QKxNTHqbSVjherQTxtGYiVXhPa3n6/lfP27rLd/C6N5QjcqTfr2SN/sYP+NRxzXC1be7YaIufMtnWpT4b7pE/7/997hgJ4gU+QijzPtH7oQw2VFDhIbSO+oGYyfsM7MFhJOGWow6GAkbLWSDiE9B43wpt2KNWH0GxlovEwbhio+e0ffwDSpUmEjVoroHlBeXlyGifMiDB0IjHJXeB5LGwYpWyAOZrXUUxAQFIAGUtwVZ5CySFxqTmZMMj1uyjeLqvC+T2vYf3J0BafiMiu6qN5fyDTaMD/HwvkfsGXibg78PoeRXef4EMZvvYQwrO5POynyZ/8KxrsWHwN3QM7ikYAt50tGo1Y3FhXZtRaMuJeogg9jQRF4AZu6CMFtvZZ6b/7ckEskwLcf3bUxJkaM88aapcX1jUWY9TUXthcx07SDkd5HA0q9H8c6z+zP3f4MEP3IlJ0h/2wbRH7k3wbfkV4fZrb+ljnqkkmgI0vzKSoxdmvqhCgt8O35hFkkkQ0pREmRmxpe+1+G9ATTLCvr/ywEYqEbgMLebUjlyp6CYptDR4SAC X-Forefront-Antispam-Report: CIP:63.35.35.123;CTRY:IE;LANG:en;SCL:1;SRV:;IPV:CAL;SFV:NSPM;H:64aa7808-outbound-1.mta.getcheckrecipient.com;PTR:ec2-63-35-35-123.eu-west-1.compute.amazonaws.com;CAT:NONE;SFS:(13230031)(4636009)(346002)(396003)(136003)(39860400002)(376002)(230922051799003)(82310400011)(1800799009)(451199024)(64100799003)(186009)(36840700001)(40470700004)(46966006)(44832011)(40480700001)(4744005)(450100002)(5660300002)(8676002)(4326008)(8936002)(86362001)(40460700003)(2906002)(36756003)(2616005)(26005)(107886003)(6486002)(6512007)(6666004)(82740400003)(478600001)(81166007)(336012)(356005)(316002)(70206006)(70586007)(6506007)(47076005)(41300700001)(36860700001)(110136005)(53546011);DIR:OUT;SFP:1101; X-OriginatorOrg: arm.com X-MS-Exchange-CrossTenant-OriginalArrivalTime: 05 Oct 2023 08:19:32.2686 (UTC) X-MS-Exchange-CrossTenant-Network-Message-Id: 476e798e-602b-4007-6212-08dbc57bcd86 X-MS-Exchange-CrossTenant-Id: f34e5979-57d9-4aaa-ad4d-b122a662184d X-MS-Exchange-CrossTenant-OriginalAttributedTenantConnectingIp: TenantId=f34e5979-57d9-4aaa-ad4d-b122a662184d;Ip=[63.35.35.123];Helo=[64aa7808-outbound-1.mta.getcheckrecipient.com] X-MS-Exchange-CrossTenant-AuthSource: DBAEUR03FT034.eop-EUR03.prod.protection.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Anonymous X-MS-Exchange-CrossTenant-FromEntityHeader: HybridOnPrem X-MS-Exchange-Transport-CrossTenantHeadersStamped: AS2PR08MB9319 X-Spam-Status: No, score=-5.8 required=5.0 tests=BAYES_00,DKIM_SIGNED,DKIM_VALID,FORGED_SPF_HELO,KAM_DMARC_NONE,RCVD_IN_DNSWL_NONE,RCVD_IN_MSPIKE_H2,SPF_HELO_PASS,SPF_NONE,TXREP,UNPARSEABLE_RELAY autolearn=no autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on server2.sourceware.org List-Id: The 10/04/2023 14:01, Adhemerval Zanella Netto wrote: > On 04/10/23 11:51, Szabolcs Nagy wrote: > > > > personally i think setuid binaries should not touch the > > env, just ignore it, so everything SXID_IGNORE. > > Do you mean just drop unsecvars and not filter out glibc environment variables > for AT_SECURE? i'd fix this in one place that makes the behaviour easy to reason about: _dl_next_ld_env_entry in rtld should just return empty in secure mode and same for getenv, internally it should return empty. then we know that nothing in libc can depend on the env. (if something parses env directly that should be fixed) if anything, there should be a whitelist, not blacklist of env vars. of course this changes behaviour, so if we want to be bw compat then we have to live with the current unsetenv logic.