From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mail-ed1-x52a.google.com (mail-ed1-x52a.google.com [IPv6:2a00:1450:4864:20::52a]) by sourceware.org (Postfix) with ESMTPS id D57D43858D3C for ; Fri, 10 Nov 2023 05:47:43 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.4.2 sourceware.org D57D43858D3C Authentication-Results: sourceware.org; dmarc=pass (p=none dis=none) header.from=gmail.com Authentication-Results: sourceware.org; spf=pass smtp.mailfrom=gmail.com ARC-Filter: OpenARC Filter v1.0.0 sourceware.org D57D43858D3C Authentication-Results: server2.sourceware.org; arc=none smtp.remote-ip=2a00:1450:4864:20::52a ARC-Seal: i=1; a=rsa-sha256; d=sourceware.org; s=key; t=1699595265; cv=none; b=O5jBHiLzSxVcb6jsB8VWZD6Ml0mAgV+0RrBv/vi/HryBYdScoeSp0+oP59jc7UWJltDoxtY5dhH91D6npHIhk93IbE0hD5yhhVl8XmxMBsJTsgEX30nCW34ncx50KdjmdzY5fXZGCwJJDjH9Y9Z6b9ucslTaVtzAtE7NYxe90iY= ARC-Message-Signature: i=1; a=rsa-sha256; d=sourceware.org; s=key; t=1699595265; c=relaxed/simple; bh=6likXCc9P0p47L759fHdyKLyfUivsG7jKmJWI8dzDeM=; h=DKIM-Signature:Date:From:To:Subject:Message-ID:MIME-Version; b=S7xC6d3zbQtBWWkFFQsIM0RLXNPFYcqnlg78NTlWTkzTceW8GSIA/NmXTtHW/QftEntcm124tMdUCQ0LzQnH1vNSYzSvuwAnJw4JhGIZqiHx4IbBjSiBRwcVDVO56c0fEY6q3DTJb9TdlvNeWUI3ss2N4bXNDYnt8U6wZNlx7XE= ARC-Authentication-Results: i=1; server2.sourceware.org Received: by mail-ed1-x52a.google.com with SMTP id 4fb4d7f45d1cf-54553e4888bso2453862a12.2 for ; Thu, 09 Nov 2023 21:47:43 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20230601; t=1699595262; x=1700200062; darn=sourceware.org; h=in-reply-to:content-disposition:mime-version:references :mail-followup-to:message-id:subject:cc:to:from:date:from:to:cc :subject:date:message-id:reply-to; bh=ocKfxHY0kQsk7kDDV25CWbaI8xk1oBxgwxAa92KGYXs=; b=j4wFHY6kaxwquTrdM7+XJzBAispxN4yWc6wWI6yd9PS4fyFWwEKFDe5dcAq24Kfzuk bfdItKfxzbYQ3mxfMAF9KCzOv2qNiBZRuzwvteLyLBhdKzHVP5dKYys1wM13vN4EOOQr ErzplM5XUvqvDklUtGa5Psy0QdQmPl+BegUEHSYE0VlLDm0Yah2cC5lh7tOczXg4YI4E so2oGwX9lqaAP9wikVnNbtWjF5EQdIDTsYHt9DpuGPz02cPym7flsgnbA9E/gipfk+SX 6OM9ga01qnk9w41G69bI7QomBCGvqDsPy3Dg9FIq52YDDOxWEBy8VNmgSQUz4naCNLR9 c5SA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1699595262; x=1700200062; h=in-reply-to:content-disposition:mime-version:references :mail-followup-to:message-id:subject:cc:to:from:date :x-gm-message-state:from:to:cc:subject:date:message-id:reply-to; bh=ocKfxHY0kQsk7kDDV25CWbaI8xk1oBxgwxAa92KGYXs=; b=dy3AT7vraF4mAAsztMo5CeeG3kReQ3zGYQC89j/cSTjU8FZB2AhcPTrrZrNjjyMxaw KEhzVX11JReoQrY5pxTclM7GtN/5XXar/TrolxcUFkB/UacZ6GIcrL0OqSt2fX/rzDMW XvVaEWgxs3xyGT9r0i3KyEaNZFs/fObwTeGL6EY08YKFeQtK4ZVEEYiAaLYRmINi9mMS sxdLktOsGjDqpqaNF9j3Ng5MI3573VovQ6XOwxQ4dTZB2y1lW86SMhBSRx49C5DFLS5+ 9Aynfrl7Zw3I4kKaaX84iFs2C8Z7ftKmKfG1bPqZJzMdadFHj/dBNaJ5vmdgbYOLlYpA H5cQ== X-Gm-Message-State: AOJu0YwI0uYT5X7sDCWDIH7C8eRRGij/jdx2fJyvKPgPL+qG0sWg4qH8 dtVGnuyJlIGrmHW8JMFqpeg= X-Google-Smtp-Source: AGHT+IG38pDcgp6diJpVzwpiZCovN5wOW4EOG/VD4f8aTzs0i8O+zJuNCb5F1hKZCV376oN/JqL+8Q== X-Received: by 2002:a50:8d1a:0:b0:543:6828:f129 with SMTP id s26-20020a508d1a000000b005436828f129mr6539425eds.23.1699595262100; Thu, 09 Nov 2023 21:47:42 -0800 (PST) Received: from dj3ntoo (223.sub-72-107-196.myvzw.com. [72.107.196.223]) by smtp.gmail.com with ESMTPSA id q18-20020a50cc92000000b0052ff9bae873sm702098edi.5.2023.11.09.21.47.38 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Thu, 09 Nov 2023 21:47:41 -0800 (PST) Date: Thu, 9 Nov 2023 23:47:34 -0600 From: Oskari Pirhonen To: Alejandro Colomar Cc: linux-man@vger.kernel.org, libc-alpha@sourceware.org, Jonny Grant , DJ Delorie , Matthew House , Thorsten Kukuk , Adhemerval Zanella Netto , Zack Weinberg , "G. Branden Robinson" , Carlos O'Donell , Paul Eggert , Xi Ruoyao Subject: Re: [PATCH v2 2/2] stpncpy.3, string.3, string_copying.7: Clarify that st[rp]ncpy() pad with null bytes Message-ID: Mail-Followup-To: Alejandro Colomar , linux-man@vger.kernel.org, libc-alpha@sourceware.org, Jonny Grant , DJ Delorie , Matthew House , Thorsten Kukuk , Adhemerval Zanella Netto , Zack Weinberg , "G. Branden Robinson" , Carlos O'Donell , Paul Eggert , Xi Ruoyao References: <20231108221638.37101-2-alx@kernel.org> <20231109151947.11174-3-alx@kernel.org> MIME-Version: 1.0 Content-Type: multipart/signed; micalg=pgp-sha256; protocol="application/pgp-signature"; boundary="uON/DqL1fr2SURN/" Content-Disposition: inline In-Reply-To: <20231109151947.11174-3-alx@kernel.org> X-Spam-Status: No, score=-12.8 required=5.0 tests=BAYES_00,DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,FREEMAIL_FROM,GIT_PATCH_0,RCVD_IN_DNSWL_NONE,SPF_HELO_NONE,SPF_PASS,TXREP,T_SCC_BODY_TEXT_LINE autolearn=ham autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on server2.sourceware.org List-Id: --uON/DqL1fr2SURN/ Content-Type: text/plain; charset=utf-8 Content-Disposition: inline Content-Transfer-Encoding: quoted-printable On Thu, Nov 09, 2023 at 16:20:39 +0100, Alejandro Colomar wrote: > The previous wording could be interpreted as if the nulls were already > in place. Clarify that it's this function which pads with null bytes. >=20 > Also, it copies "characters" from the src string. That's a bit more > specific than copying "bytes", and makes it clearer that the terminating > null byte in src is not part of the copy. >=20 > Suggested-by: Jonny Grant > Cc: DJ Delorie > Cc: Jonny Grant > Cc: Matthew House > Cc: Oskari Pirhonen > Cc: Thorsten Kukuk > Cc: Adhemerval Zanella Netto > Cc: Zack Weinberg > Cc: "G. Branden Robinson" > Cc: Carlos O'Donell > Cc: Paul Eggert > Cc: Xi Ruoyao > Signed-off-by: Alejandro Colomar > --- > man3/stpncpy.3 | 10 ++++++---- > man3/string.3 | 11 ++--------- > man7/string_copying.7 | 3 ++- > 3 files changed, 10 insertions(+), 14 deletions(-) >=20 =2E.. snip ... > diff --git a/man3/string.3 b/man3/string.3 > index aba5efd2b..bd8b342a6 100644 > --- a/man3/string.3 > +++ b/man3/string.3 > @@ -179,21 +179,14 @@ .SH SYNOPSIS > .I n > bytes to > .IR dest . > -.SS Obsolete functions If you're removing this section ... > .TP > .nf > .BI "char *strncpy(char " dest "[restrict ." n "], \ > const char " src "[restrict ." n ], > .BI " size_t " n ); > .fi > -Copy at most > -.I n > -bytes from string > -.I src > -to > -.IR dest , > -returning a pointer to the start of > -.IR dest . > +Fill a fixed=E2=80=90width buffer with characters from a string > +and pad with null bytes. =2E.. shouldn't you also move the rest of this up to keep it alphabetized? - Oskari --uON/DqL1fr2SURN/ Content-Type: application/pgp-signature; name="signature.asc" -----BEGIN PGP SIGNATURE----- iHUEABYIAB0WIQQfOU+JeXjo4uxN6vCp8he9GGIfEQUCZU3D8QAKCRCp8he9GGIf EcrWAQDpOg+BkGyARWxMIrgLoi1VFmYZx9RfeOLzm9bao85QuAEAtOo41idaj+H8 LF425rfMWujmFhUUbyt+GoceIeJSEgY= =Mpii -----END PGP SIGNATURE----- --uON/DqL1fr2SURN/--