* [PATCH] debug/getwd_chk.c: warning should be emitted for the __getwd_chk symbol.
@ 2023-12-05 11:23 Frederic Cambus
2024-01-08 14:28 ` Frederic Cambus
2024-01-08 14:32 ` Adhemerval Zanella Netto
0 siblings, 2 replies; 4+ messages in thread
From: Frederic Cambus @ 2023-12-05 11:23 UTC (permalink / raw)
To: libc-alpha
Otherwise the warning message for the getwd symbol ends up being duplicated.
Signed-off-by: Frederic Cambus <fred@statdns.com>
---
debug/getwd_chk.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/debug/getwd_chk.c b/debug/getwd_chk.c
index 850aa1aa14..cf61d8d5a0 100644
--- a/debug/getwd_chk.c
+++ b/debug/getwd_chk.c
@@ -29,5 +29,5 @@ __getwd_chk (char *buf, size_t buflen)
return res;
}
-link_warning (getwd,
+link_warning (__getwd_chk,
"the `getwd' function is dangerous and should not be used.")
--
2.43.0
^ permalink raw reply [flat|nested] 4+ messages in thread
* Re: [PATCH] debug/getwd_chk.c: warning should be emitted for the __getwd_chk symbol.
2023-12-05 11:23 [PATCH] debug/getwd_chk.c: warning should be emitted for the __getwd_chk symbol Frederic Cambus
@ 2024-01-08 14:28 ` Frederic Cambus
2024-01-08 14:32 ` Adhemerval Zanella Netto
1 sibling, 0 replies; 4+ messages in thread
From: Frederic Cambus @ 2024-01-08 14:28 UTC (permalink / raw)
To: libc-alpha
On Tue, Dec 05, 2023 at 12:23:07PM +0100, Frederic Cambus wrote:
> Otherwise the warning message for the getwd symbol ends up being duplicated.
>
> Signed-off-by: Frederic Cambus <fred@statdns.com>
> ---
> debug/getwd_chk.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/debug/getwd_chk.c b/debug/getwd_chk.c
> index 850aa1aa14..cf61d8d5a0 100644
> --- a/debug/getwd_chk.c
> +++ b/debug/getwd_chk.c
> @@ -29,5 +29,5 @@ __getwd_chk (char *buf, size_t buflen)
> return res;
> }
>
> -link_warning (getwd,
> +link_warning (__getwd_chk,
> "the `getwd' function is dangerous and should not be used.")
> --
> 2.43.0
Ping. Anyone willing to look at this?
In case it was not clear, here is the output of objdump before applying
the patch:
objdump -s -j .gnu.warning.getwd libc.so
./libc.so: file format elf64-x86-64
Contents of section .gnu.warning.getwd:
0000 74686520 60676574 77642720 66756e63 the `getwd' func
0010 74696f6e 20697320 64616e67 65726f75 tion is dangerou
0020 7320616e 64207368 6f756c64 206e6f74 s and should not
0030 20626520 75736564 2e000000 00000000 be used........
0040 74686520 60676574 77642720 66756e63 the `getwd' func
0050 74696f6e 20697320 64616e67 65726f75 tion is dangerou
0060 7320616e 64207368 6f756c64 206e6f74 s and should not
0070 20626520 75736564 2e00 be used..
And after applying the patch:
objdump -s -j .gnu.warning.getwd libc.so
./libc.so: file format elf64-x86-64
Contents of section .gnu.warning.getwd:
0000 74686520 60676574 77642720 66756e63 the `getwd' func
0010 74696f6e 20697320 64616e67 65726f75 tion is dangerou
0020 7320616e 64207368 6f756c64 206e6f74 s and should not
0030 20626520 75736564 2e00 be used..
^ permalink raw reply [flat|nested] 4+ messages in thread
* Re: [PATCH] debug/getwd_chk.c: warning should be emitted for the __getwd_chk symbol.
2023-12-05 11:23 [PATCH] debug/getwd_chk.c: warning should be emitted for the __getwd_chk symbol Frederic Cambus
2024-01-08 14:28 ` Frederic Cambus
@ 2024-01-08 14:32 ` Adhemerval Zanella Netto
2024-01-11 21:34 ` Andreas K. Huettel
1 sibling, 1 reply; 4+ messages in thread
From: Adhemerval Zanella Netto @ 2024-01-08 14:32 UTC (permalink / raw)
To: Frederic Cambus, libc-alpha, Andreas K. Huettel
On 05/12/23 08:23, Frederic Cambus wrote:
> Otherwise the warning message for the getwd symbol ends up being duplicated.
>
> Signed-off-by: Frederic Cambus <fred@statdns.com>
LGTM, thanks. Andreas will need to ack for 2.39.
Reviewed-by: Adhemerval Zanella <adhemerval.zanella@linaro.org>
> ---
> debug/getwd_chk.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/debug/getwd_chk.c b/debug/getwd_chk.c
> index 850aa1aa14..cf61d8d5a0 100644
> --- a/debug/getwd_chk.c
> +++ b/debug/getwd_chk.c
> @@ -29,5 +29,5 @@ __getwd_chk (char *buf, size_t buflen)
> return res;
> }
>
> -link_warning (getwd,
> +link_warning (__getwd_chk,
> "the `getwd' function is dangerous and should not be used.")
^ permalink raw reply [flat|nested] 4+ messages in thread
* Re: [PATCH] debug/getwd_chk.c: warning should be emitted for the __getwd_chk symbol.
2024-01-08 14:32 ` Adhemerval Zanella Netto
@ 2024-01-11 21:34 ` Andreas K. Huettel
0 siblings, 0 replies; 4+ messages in thread
From: Andreas K. Huettel @ 2024-01-11 21:34 UTC (permalink / raw)
To: Frederic Cambus, libc-alpha; +Cc: Adhemerval Zanella Netto
[-- Attachment #1: Type: text/plain, Size: 1028 bytes --]
Am Montag, 8. Januar 2024, 15:32:07 CET schrieb Adhemerval Zanella Netto:
>
> On 05/12/23 08:23, Frederic Cambus wrote:
> > Otherwise the warning message for the getwd symbol ends up being duplicated.
> >
> > Signed-off-by: Frederic Cambus <fred@statdns.com>
>
> LGTM, thanks. Andreas will need to ack for 2.39.
OK imho.
>
> Reviewed-by: Adhemerval Zanella <adhemerval.zanella@linaro.org>
>
> > ---
> > debug/getwd_chk.c | 2 +-
> > 1 file changed, 1 insertion(+), 1 deletion(-)
> >
> > diff --git a/debug/getwd_chk.c b/debug/getwd_chk.c
> > index 850aa1aa14..cf61d8d5a0 100644
> > --- a/debug/getwd_chk.c
> > +++ b/debug/getwd_chk.c
> > @@ -29,5 +29,5 @@ __getwd_chk (char *buf, size_t buflen)
> > return res;
> > }
> >
> > -link_warning (getwd,
> > +link_warning (__getwd_chk,
> > "the `getwd' function is dangerous and should not be used.")
>
--
Andreas K. Hüttel
dilfridge@gentoo.org
Gentoo Linux developer
(council, toolchain, base-system, perl, libreoffice)
[-- Attachment #2: This is a digitally signed message part. --]
[-- Type: application/pgp-signature, Size: 981 bytes --]
^ permalink raw reply [flat|nested] 4+ messages in thread
end of thread, other threads:[~2024-01-11 21:34 UTC | newest]
Thread overview: 4+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2023-12-05 11:23 [PATCH] debug/getwd_chk.c: warning should be emitted for the __getwd_chk symbol Frederic Cambus
2024-01-08 14:28 ` Frederic Cambus
2024-01-08 14:32 ` Adhemerval Zanella Netto
2024-01-11 21:34 ` Andreas K. Huettel
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).