From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from EUR05-AM6-obe.outbound.protection.outlook.com (mail-am6eur05on2062.outbound.protection.outlook.com [40.107.22.62]) by sourceware.org (Postfix) with ESMTPS id C6C1A3858C74 for ; Tue, 16 Jan 2024 12:01:20 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.4.2 sourceware.org C6C1A3858C74 Authentication-Results: sourceware.org; dmarc=pass (p=none dis=none) header.from=arm.com Authentication-Results: sourceware.org; spf=pass smtp.mailfrom=arm.com ARC-Filter: OpenARC Filter v1.0.0 sourceware.org C6C1A3858C74 Authentication-Results: server2.sourceware.org; arc=pass smtp.remote-ip=40.107.22.62 ARC-Seal: i=3; a=rsa-sha256; d=sourceware.org; s=key; t=1705406491; cv=pass; b=PSgOxz4vYP11UyQrkIBalummSLh/74+dj2yQkqmmPL0tvRiFUYUVQsdg8PvGld0X1zQi6SBuRRnCoWhYcEJu4gxP8XEFGrbdezH2EFN2OhI8H4r8J7fiBqI+/w6JAeyKjm7QXUXMSAmq3OqUbcLUFAeWGwkPv0IXWP3tPwOimfo= ARC-Message-Signature: i=3; a=rsa-sha256; d=sourceware.org; s=key; t=1705406491; c=relaxed/simple; bh=MBdZnqNqnSbBJXDhbl3r+3pfvbxCChSBEsNgXBSIP8c=; h=DKIM-Signature:DKIM-Signature:Date:From:To:Subject:Message-ID: MIME-Version; b=dqKmXrgFjq4IlIpjikesLPmS/oq6GkJ49dSt/9grW5lPRE6dCeHzFtIZ9RNZjLrhOB8pI/4zw31M6789pnhGH96MH+PqOjxj7tXaeVEX89BbCBRXS+J0aq0AhPFIYzecHA2j6edObSE5DbsNaykAhfBZwVk5VMNm/n63++l/7ik= ARC-Authentication-Results: i=3; server2.sourceware.org ARC-Seal: i=2; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=pass; b=UhqyFnuz8zmZgosYC92GUKmXjqSzQ/bEjqWNCcU7ehFvNez/oWtY2tJPhw90w8cT+JTekFl6xx4lLZZakoXxG03Lqa35W3aTIlNYG6cBeXtIT9JeSboIOW5bZOR3A+PQh7Cq+DQDxoNK5mROsPxF/IdH5eL3J6Z4gHXHQs8KOeJgCe4JdfWYCBglfBotuBpzDao9HDrnQmY/STLwVFeXu5lIogfTI1n+bOaNL9h8z7V7k3IIecjBJzzK3D+J0Nvk7lqPrAeh5DQg7LluldU6I/4vAShL2la1QFFCfICWQFPwe2wV4uHzhzWAnDHa31AgFDudUIRfh534kc/0LGJsXA== ARC-Message-Signature: i=2; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=5mmk5xsDnB/LdbKN+o8mM48au2KIF02V/3zLu8atst8=; b=CXJCzQYCIyFVLFCVd94CR46nbx5zTI4dS4NxrIzOH/4HIEA5Mj5U5qggb6Y9IpbqMNEL1sYq7zY4VKSH8osflZ3K2Gih5IzpPxZe29Qbv1o9FwMxZBZqex8fu+MSUvuDZq1Vy4GHdlF2X3imnIF7Q2I9AeE1X/O3SJKJuLnffD5ToQ9k9VsBnkDI5+KMPByhg+RfBrgsDwrGxIxJm3qiQHDGJiJg+0I2SrCCPDTkWU4aKxa9UFZn7lepdUl7BQoG2k31Uyb5WeUY8izvWK12TAbYPjLI0gKFMkgcmyKAxvwsazG4BwEfX1X2Ax1Y/qkeiNWSD+GUS5rpmovQYqyjBA== ARC-Authentication-Results: i=2; mx.microsoft.com 1; spf=pass (sender ip is 63.35.35.123) smtp.rcpttodomain=sourceware.org smtp.mailfrom=arm.com; dmarc=pass (p=none sp=none pct=100) action=none header.from=arm.com; dkim=pass (signature was verified) header.d=armh.onmicrosoft.com; arc=pass (0 oda=1 ltdi=1 spf=[1,1,smtp.mailfrom=arm.com] dkim=[1,1,header.d=arm.com] dmarc=[1,1,header.from=arm.com]) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=armh.onmicrosoft.com; s=selector2-armh-onmicrosoft-com; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=5mmk5xsDnB/LdbKN+o8mM48au2KIF02V/3zLu8atst8=; b=Rehd/F2hbI+nodTaNJJxodtOXYTLELoJDOdp+LeKwxmfyiQXhH7S3yPXmD5xhnP63Jnw4G795RI9HkPv4W1xnTb6bTwJ3nk5XQxUvQkE5WbYKMujWzSDp8L/4pMsO6xOR++kvyMOLqwhEnCuIbC9ipVybaEbqQBAnhoHu+kJjDE= Received: from AM7PR04CA0006.eurprd04.prod.outlook.com (2603:10a6:20b:110::16) by GV2PR08MB8194.eurprd08.prod.outlook.com (2603:10a6:150:74::18) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.7181.28; Tue, 16 Jan 2024 12:01:10 +0000 Received: from AM3PEPF00009B9D.eurprd04.prod.outlook.com (2603:10a6:20b:110:cafe::a9) by AM7PR04CA0006.outlook.office365.com (2603:10a6:20b:110::16) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.7181.23 via Frontend Transport; Tue, 16 Jan 2024 12:01:09 +0000 X-MS-Exchange-Authentication-Results: spf=pass (sender IP is 63.35.35.123) smtp.mailfrom=arm.com; dkim=pass (signature was verified) header.d=armh.onmicrosoft.com;dmarc=pass action=none header.from=arm.com; Received-SPF: Pass (protection.outlook.com: domain of arm.com designates 63.35.35.123 as permitted sender) receiver=protection.outlook.com; client-ip=63.35.35.123; helo=64aa7808-outbound-1.mta.getcheckrecipient.com; pr=C Received: from 64aa7808-outbound-1.mta.getcheckrecipient.com (63.35.35.123) by AM3PEPF00009B9D.mail.protection.outlook.com (10.167.16.22) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.7202.16 via Frontend Transport; Tue, 16 Jan 2024 12:01:09 +0000 Received: ("Tessian outbound a297577ee0df:v228"); Tue, 16 Jan 2024 12:01:09 +0000 X-CheckRecipientChecked: true X-CR-MTA-CID: 541ea4d416e0630f X-CR-MTA-TID: 64aa7808 Received: from b69f045b6a83.2 by 64aa7808-outbound-1.mta.getcheckrecipient.com id 7D0C01B3-424A-47A6-946C-69448E9E3E93.1; Tue, 16 Jan 2024 12:00:58 +0000 Received: from EUR04-HE1-obe.outbound.protection.outlook.com by 64aa7808-outbound-1.mta.getcheckrecipient.com with ESMTPS id b69f045b6a83.2 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384); Tue, 16 Jan 2024 12:00:58 +0000 ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=NNK7hzIHMv/QcFWkGEPFmrB8JVCQtm/TyjStmLW0w6i8SFVEMX3dE/nQjnq7qUftkcm/hqtEkPQuhlNJi9ixpeCJyTvRugz5m3f+V9IsaI/fS/2tEy4W3YIfz/GoZCwRnjZVt9tdD9cgmChw6ojyuJPPLNciL08e1f7UVKyOG8cmROtbmEXx2YpLP1PBbYBHH0C+B4Fx/gGZj/GQAjTcsGBUWedqBPFOAwZYwYYTkKKfi8TjXh9DWe4VUgT+CQ5ZmeLHo9Ve+v4D/aTNHGVwUmVSmBcuzcwibZ/aNgOJI0JKSHO3XHx7j4RR+NRK6qOuAMGYxaonQ70mHv9sAQS+pA== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=5mmk5xsDnB/LdbKN+o8mM48au2KIF02V/3zLu8atst8=; b=c4yGzqvediobOOWmMk0hiVQwCuo1G4RVknfaBGS1h39tAA9G/tYG1E5ENiCoai7Il5pNw76oYFIwLebJJJAJ3qtmip+1cOUKVAgWjx8CYDoVrBucm9CoS1sybMfwOV15uhXch8feBs85aiVWvUuH9FazjkY+NGswWAj+uwmbu40p71Vq5uQ/9sTgi3bk7BodBeSkql9gxERD+8l48rsyNyR2GlaeNxg7X4wAShA3jc4eVrZ+dxCE3BsoM6ElgJkKhJs9OBFkLRPtTlUO6lfpFtQJ2GazWJmf0h2WY0wejIVW3HOW5yj8gTrXhOlIQ00xRjcV5XODSY2bCah3vn37Tw== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=arm.com; dmarc=pass action=none header.from=arm.com; dkim=pass header.d=arm.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=armh.onmicrosoft.com; s=selector2-armh-onmicrosoft-com; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=5mmk5xsDnB/LdbKN+o8mM48au2KIF02V/3zLu8atst8=; b=Rehd/F2hbI+nodTaNJJxodtOXYTLELoJDOdp+LeKwxmfyiQXhH7S3yPXmD5xhnP63Jnw4G795RI9HkPv4W1xnTb6bTwJ3nk5XQxUvQkE5WbYKMujWzSDp8L/4pMsO6xOR++kvyMOLqwhEnCuIbC9ipVybaEbqQBAnhoHu+kJjDE= Authentication-Results-Original: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=arm.com; Received: from DB9PR08MB7179.eurprd08.prod.outlook.com (2603:10a6:10:2cc::19) by PAWPR08MB9065.eurprd08.prod.outlook.com (2603:10a6:102:332::22) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.7181.28; Tue, 16 Jan 2024 12:00:56 +0000 Received: from DB9PR08MB7179.eurprd08.prod.outlook.com ([fe80::bc19:813c:34d3:758]) by DB9PR08MB7179.eurprd08.prod.outlook.com ([fe80::bc19:813c:34d3:758%7]) with mapi id 15.20.7181.027; Tue, 16 Jan 2024 12:00:56 +0000 Date: Tue, 16 Jan 2024 12:00:42 +0000 From: Szabolcs Nagy To: Adhemerval Zanella , libc-alpha@sourceware.org, Zack Weinberg Cc: daniel.fellows@arm.com Subject: Re: [PATCH v2 2/2] crypt: Remove libcrypt support Message-ID: References: <20231002121149.2325402-1-adhemerval.zanella@linaro.org> <20231002121149.2325402-3-adhemerval.zanella@linaro.org> Content-Type: text/plain; charset=utf-8 Content-Disposition: inline In-Reply-To: <20231002121149.2325402-3-adhemerval.zanella@linaro.org> X-ClientProxiedBy: LO4P123CA0008.GBRP123.PROD.OUTLOOK.COM (2603:10a6:600:150::13) To DB9PR08MB7179.eurprd08.prod.outlook.com (2603:10a6:10:2cc::19) MIME-Version: 1.0 X-MS-TrafficTypeDiagnostic: DB9PR08MB7179:EE_|PAWPR08MB9065:EE_|AM3PEPF00009B9D:EE_|GV2PR08MB8194:EE_ X-MS-Office365-Filtering-Correlation-Id: c984d68e-3694-4237-587e-08dc168ad404 x-checkrecipientrouted: true NoDisclaimer: true X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam-Untrusted: BCL:0; X-Microsoft-Antispam-Message-Info-Original: 12zQp5clwshUVpbhDxtFbkAYZ5FwpxPI5TGpL/xaOR9NbhunyCiwgzpBq4ve1CnK2h3Dkeh4OUyDDrPQmwlPURepkzi2A3EqrdFjiRGIK3PEFLfER4Hfq/YRd/Ga4magxq2jaxRMfUaWhvO5jsYkd+gWQU3Y3D31SgqwIkLIbRjUqN2AGENSLjW5N6f0g3EnWL6YIYo/TgVm07327ReO3wMfXkC3Q4PfZ739lh1UnshUWBdN2sWbi4dTG+Siw+t+bNQEKEL10CNhzWMn/MuZ57BZg63w0gqD0RHtklGAQRUfApi+OCFGGr8hZZqt5ByQpMGbnPidlhVjhDBID1+XLCKQZ0KA9DVGxhOh3jfg+l+yXugjYO4lfYEeFF0LwbMR3WxltZ/xjqDmvdlSGb1U56Q3b7FtBarJ1V+sTYuOtFpmn13BPD1//653P8IevElchzXuWYy/LzyzQvylZwi8QKu5i7wgcYOu68OKqY6KZp0B/LYmLsnAKGRiJQt+ThxAebnZgP1f0df3EIIEHT5iROJqKPF/0cVjZenNrHTMvk1brbw2XbGapJ2hoK+xcPB0 X-Forefront-Antispam-Report-Untrusted: CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:DB9PR08MB7179.eurprd08.prod.outlook.com;PTR:;CAT:NONE;SFS:(13230031)(376002)(396003)(366004)(136003)(39860400002)(346002)(230922051799003)(64100799003)(451199024)(186009)(1800799012)(2906002)(41300700001)(36756003)(86362001)(38100700002)(6506007)(66946007)(66556008)(8676002)(66476007)(6512007)(316002)(8936002)(6486002)(6666004)(478600001)(5660300002)(4326008)(2616005)(44832011)(26005)(110136005);DIR:OUT;SFP:1101; X-MS-Exchange-Transport-CrossTenantHeadersStamped: PAWPR08MB9065 Original-Authentication-Results: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=arm.com; X-EOPAttributedMessage: 0 X-MS-Exchange-Transport-CrossTenantHeadersStripped: AM3PEPF00009B9D.eurprd04.prod.outlook.com X-MS-PublicTrafficType: Email X-MS-Office365-Filtering-Correlation-Id-Prvs: 3f744d06-af35-4e28-051d-08dc168acbcf X-Microsoft-Antispam: BCL:0; X-Microsoft-Antispam-Message-Info: n+uKBoG++qQGzQiG4F0OG4S53+VYSEo9Q2j39IBwYzcLqIVK55ajIem2frzGIAgyo0CUJvor84IcqyBbIeyoDcCHYjNsjpDlwC84Pdp5jncVreoSIU3FqvvvgrfOtQPWWZvumnAbUy46+dEBow1Db9VKmngYOxbg88yqD04QkGjdRdrM5tQf95p/WaPM5fUyMD3IlaIZYtmfDF99gOY/4YHhvK+mwwXDDxDVgTXBcfGZRQ1okeMJu/5ldr+Gzh11Xd9fdGg5OART6vRASBlQAuOuUz78WsKxjc9xvS/rPAYMTqBzl6kGMoi5qt9GdY5Uv9XdtaCnde2g8jS//zTbQMQk9pjep+Vn64z+6mpMtLp8+Zm+uXkbGGiAfFVIkqC38G2EBx70xZlBkfoQg5JalKAos7wxlIDpU2X19Uq6aajOfZFmuMEZUbjGZIj2P5Wq/dz9kudhwiPcpt2D2zrNPkV8ti5cwQ3D6MzVoW7chp9FPC/I/WHTDyrZzOdExxzNxh+g6NEVJFJTWH2y8MjiYI7M3n8n5dqgRE97+M2aITEEXOYSEI0towZMH3LE6SNT/0ETF28DiVvDE8z7/sF3GdzwILkYrerlwy0QlTqAmgTdFAG9f2XRlQBB7xGee3Oc692NgxarQpoYSwXeWaK1cbxBh1J1au/tctYWEAvz9QKUI7bBB7nKlojgTU8/XQuZ6aVr7nA7EV6oqZpq21NSZIY1KNULtFXo7Jt0UDqQ8pvQ89vj2bvP+55lHknssaI9 X-Forefront-Antispam-Report: CIP:63.35.35.123;CTRY:IE;LANG:en;SCL:1;SRV:;IPV:CAL;SFV:NSPM;H:64aa7808-outbound-1.mta.getcheckrecipient.com;PTR:ec2-63-35-35-123.eu-west-1.compute.amazonaws.com;CAT:NONE;SFS:(13230031)(4636009)(346002)(396003)(376002)(136003)(39860400002)(230922051799003)(186009)(1800799012)(64100799003)(451199024)(82310400011)(46966006)(36840700001)(40470700004)(356005)(81166007)(82740400003)(86362001)(6486002)(36756003)(316002)(70206006)(70586007)(110136005)(478600001)(6512007)(44832011)(6666004)(6506007)(2906002)(5660300002)(8936002)(8676002)(4326008)(47076005)(41300700001)(36860700001)(336012)(40460700003)(40480700001)(2616005)(26005);DIR:OUT;SFP:1101; X-OriginatorOrg: arm.com X-MS-Exchange-CrossTenant-OriginalArrivalTime: 16 Jan 2024 12:01:09.5932 (UTC) X-MS-Exchange-CrossTenant-Network-Message-Id: c984d68e-3694-4237-587e-08dc168ad404 X-MS-Exchange-CrossTenant-Id: f34e5979-57d9-4aaa-ad4d-b122a662184d X-MS-Exchange-CrossTenant-OriginalAttributedTenantConnectingIp: TenantId=f34e5979-57d9-4aaa-ad4d-b122a662184d;Ip=[63.35.35.123];Helo=[64aa7808-outbound-1.mta.getcheckrecipient.com] X-MS-Exchange-CrossTenant-AuthSource: AM3PEPF00009B9D.eurprd04.prod.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Anonymous X-MS-Exchange-CrossTenant-FromEntityHeader: HybridOnPrem X-MS-Exchange-Transport-CrossTenantHeadersStamped: GV2PR08MB8194 X-Spam-Status: No, score=-11.4 required=5.0 tests=BAYES_00,DKIM_SIGNED,DKIM_VALID,FORGED_SPF_HELO,GIT_PATCH_0,KAM_DMARC_NONE,RCVD_IN_DNSWL_NONE,RCVD_IN_MSPIKE_H2,SPF_HELO_PASS,SPF_NONE,TXREP,T_SCC_BODY_TEXT_LINE,UNPARSEABLE_RELAY autolearn=ham autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on server2.sourceware.org List-Id: The 10/02/2023 09:11, Adhemerval Zanella wrote: > All the crypt related functions, cryptographic algorithms, and > make requirements are removed, with only the exception of md5 > implementation which is moved to locale folder since it is > required by localedef for integrity protection (libc's > locale-reading code does not check these, but localedef does > generate them). > > Besides thec code itself, both internal documentation and the > manual is also adjusted. This allows to remove both --enable-crypt > and --enable-nss-crypt configure options. > > Checked with a build for all affected ABIs. > > Co-authored-by: Zack Weinberg ... > diff --git a/stdio-common/Versions b/stdio-common/Versions > index 4bcfc3fb41..8e1cbf8559 100644 > --- a/stdio-common/Versions > +++ b/stdio-common/Versions > @@ -74,7 +74,5 @@ libc { > GLIBC_PRIVATE { > # global variables > _itoa_lower_digits; > - # Used in libcrypt. > - __snprintf; > } fyi, this means that if you copy new glibc over an old system the old libcrypt.so.1 will stop working because of missing __snprintf@GLIBC_PRIVATE symbol. e.g. this breaks some of our native glibc test setups, unless we carefully rebuild a libcrypt to be compatible with both the new glibc and the native system (old systems don't have compat libxcrypt packaged). what is the recommended solution for this problem? can we keep the __snprintf symbol around (the alias is still there we just no longer export it from libc.so)?