public inbox for libc-alpha@sourceware.org
 help / color / mirror / Atom feed
From: Alejandro Colomar <alx@kernel.org>
To: Xi Ruoyao <xry111@xry111.site>
Cc: Russ Allbery <eagle@eyrie.org>, libc-alpha@sourceware.org
Subject: Re: free(3) const void *
Date: Fri, 26 Jan 2024 19:57:20 +0100	[thread overview]
Message-ID: <ZbQAkJ-_cv3AJqBV@debian> (raw)
In-Reply-To: <0f059f2602e72f848a3f7acf27c937c7d63e2288.camel@xry111.site>

[-- Attachment #1: Type: text/plain, Size: 1363 bytes --]

Hi Xi,

On Sat, Jan 27, 2024 at 02:49:42AM +0800, Xi Ruoyao wrote:
> Back on the topic, IMO you may tell others to create wrappers like
> 
> [[gnu::access(none, 1)]] static inline void
> aggressive_free (const void *p)
> {
>   (free) ((void *)p);
> }
> #define free(x) aggressive_free (x)
> 
> with some texts to explain all the caveats (like `free ("string
> literal");` will be incorrectly accepted, and the glibc.malloc.perturb
> or similar facilities in other malloc implementations, etc) in the man
> page...  But for the standard and/or the libc header it's a different
> story.  Anyway if such a wrapper is adopted widely it will be easier to
> raise it to WG14 and Austin.

Sure!  I'll play with that in the following days, and will write
something in the manual page about it.  I raised the topic because for
fixing a const-correctness warning in shadow-utils, I had to make a
pointer non-const for its entire lifetime, and the only call that
required non-const was free(3), which was awkward.  So, I'll definitely
write a free(3) wrapper in shadow utils.  I also had similar problems
about const in Nginx last week.  Let's see if this catches up.  :)

I'll ask you about it if I have any doubts.

Have a lovely night,
Alex

-- 
<https://www.alejandro-colomar.es/>
Looking for a remote C programming job at the moment.

[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 833 bytes --]

  reply	other threads:[~2024-01-26 18:57 UTC|newest]

Thread overview: 33+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2024-01-26 13:21 Alejandro Colomar
2024-01-26 14:24 ` Arsen Arsenović
2024-01-26 15:35   ` Alejandro Colomar
2024-01-26 17:22     ` Arsen Arsenović
2024-01-26 17:55       ` Xi Ruoyao
2024-01-26 18:11         ` Alejandro Colomar
2024-01-26 20:04           ` Arsen Arsenović
2024-01-26 20:07         ` Arsen Arsenović
2024-01-26 17:40     ` Andreas Schwab
2024-01-26 19:45     ` Florian Weimer
2024-01-26 15:13 ` Andreas Schwab
2024-01-26 15:33   ` Alejandro Colomar
2024-01-26 18:09 ` Russ Allbery
2024-01-26 18:23   ` Alejandro Colomar
2024-01-26 18:36     ` Xi Ruoyao
2024-01-26 18:40       ` Alejandro Colomar
2024-01-26 18:49         ` Xi Ruoyao
2024-01-26 18:57           ` Alejandro Colomar [this message]
2024-01-26 18:40     ` Russ Allbery
2024-01-26 18:45       ` Alejandro Colomar
2024-01-26 19:41   ` Florian Weimer
2024-01-26 18:39 ` [PATCH] Use [[gnu::access(none)]] on free(3) Alejandro Colomar
2024-01-26 18:41   ` Alejandro Colomar
2024-01-26 21:23     ` Paul Eggert
2024-01-26 23:19       ` Alejandro Colomar
2024-01-27 13:21       ` Cristian Rodríguez
2024-02-13 15:19         ` Gabriel Ravier
2024-02-13 15:28           ` Alejandro Colomar
2024-01-26 21:11 ` free(3) const void * DJ Delorie
2024-01-26 21:30   ` Andreas Schwab
2024-01-26 21:47     ` DJ Delorie
2024-01-26 22:07       ` Andreas Schwab
2024-01-26 23:25       ` Alejandro Colomar

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=ZbQAkJ-_cv3AJqBV@debian \
    --to=alx@kernel.org \
    --cc=eagle@eyrie.org \
    --cc=libc-alpha@sourceware.org \
    --cc=xry111@xry111.site \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).