From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from EUR04-HE1-obe.outbound.protection.outlook.com (mail-he1eur04on2051.outbound.protection.outlook.com [40.107.7.51]) by sourceware.org (Postfix) with ESMTPS id F0E903858D1E for ; Mon, 5 Feb 2024 17:06:52 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.4.2 sourceware.org F0E903858D1E Authentication-Results: sourceware.org; dmarc=pass (p=none dis=none) header.from=arm.com Authentication-Results: sourceware.org; spf=pass smtp.mailfrom=arm.com ARC-Filter: OpenARC Filter v1.0.0 sourceware.org F0E903858D1E Authentication-Results: server2.sourceware.org; arc=pass smtp.remote-ip=40.107.7.51 ARC-Seal: i=3; a=rsa-sha256; d=sourceware.org; s=key; t=1707152817; cv=pass; b=pYaf0fRyXGgo9jM7PPoJiM68SiXs2EtsXT4zWdbxRW6KN1ZxhDs0gv7NMxaVd9i7PggNTLUBZDJikHfnUAdxfK68sVEQrfEgauN2z3z8QAb20Z9dWz86meVBI6BPNLFYZ/9kM6e77+5FGU59gtPbRNHnxBrkz3mfm01kIvP3Wxs= ARC-Message-Signature: i=3; a=rsa-sha256; d=sourceware.org; s=key; t=1707152817; c=relaxed/simple; bh=fskoVUM4w/vXAB8DznVvE3DOIe95LNgkPl9/bErpPHs=; h=DKIM-Signature:DKIM-Signature:Date:From:To:Subject:Message-ID: MIME-Version; b=F/bGn+R5fOtHwG7AL9isfONuZQnbaVL/IB+/9h6YRGeoLxSo+PaQl6SEtLQRX1fSaIIVq5w8Hxp+8z9aMoeTnZcfAZVr0xic5kLFU6UD8B7Sym1+8OenIwKKlPcohHPKSfArT2tkthTJmkZITqqy0j6WynP9tB32hguMALRPXWU= ARC-Authentication-Results: i=3; server2.sourceware.org ARC-Seal: i=2; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=pass; b=k11NyQdK3Y5/ZBs2QKqHkvT339B5Dm4Lq0yEp4K3UcSjZ+rruWwl+zReqD8zPHD6p0cH+A9b0iM2EAq5Ayyk/QII9hzxB7zImmr85tUrOdfaNeG16FY6P4yOIS/WpSvUjHAvYsIt44bROeoPvL8kBPGWiiZW5ilZIjuLKWs6RYpoeA84heR8aLDAKj9uY3vIx6B5HVw6aYa7F6WSeRrthBjoswCoXN0sWHyesDq55IlGX0p/8ewrDvs94c0eAAzqJqXAlAxp6yQ8fbW2Wr6ju/gLAOObwv1VPCgFHkFyou7x2QgeRlqwmqE3AVslAM/jnxbo1jGAJ913ts30PbXVsQ== ARC-Message-Signature: i=2; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=obeCfs9Tbrow4/lBt6rq83UnbUNordzna4G2qx4n1Go=; b=Za63XHpcdrPQ23r5lWV2/gcpG6sLYqXyMsCyTVw2CULGTdz3OdSS8qcnueJwtxd3d4fQZteHkIaPoxzUTFxnGZ5QHqk9NWmCybvHAlaUque74+iyL6CGFc+NgUa9kMq1p2aqqey7u3UobH8hoyR9S5CHho4eciAx9zrE5BcifoG186dQWkooU+io0LYslAiI8uoCik08ROw4PpDK5GSixbLufmBAuqEnfdm0nbz1xA/Q5IBSZukjnN7pxEsk8JKxwYP00TMmND9hhREftCXtw+OwPeYfRolwEalNWKQR06TW8/X2wb6PevjlXZ1oFHYONmtTOHOHU+Bk6iOEEsq1hw== ARC-Authentication-Results: i=2; mx.microsoft.com 1; spf=pass (sender ip is 63.35.35.123) smtp.rcpttodomain=sourceware.org smtp.mailfrom=arm.com; dmarc=pass (p=none sp=none pct=100) action=none header.from=arm.com; dkim=pass (signature was verified) header.d=armh.onmicrosoft.com; arc=pass (0 oda=1 ltdi=1 spf=[1,1,smtp.mailfrom=arm.com] dkim=[1,1,header.d=arm.com] dmarc=[1,1,header.from=arm.com]) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=armh.onmicrosoft.com; s=selector2-armh-onmicrosoft-com; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=obeCfs9Tbrow4/lBt6rq83UnbUNordzna4G2qx4n1Go=; b=w5XZxWPGfjbU5Xe5ufGJdiwkODrFrf4eAv1kQxCEAEenoBPzI0+NsXAr5ncxCsusKSe1YZ8P5noVCc16HhOSLgoLhEE5VtYBId5Lc+aAUdjV75ReBVRZwqlmBpsyOq2Iqzz24M+09lAWjHNftxIm5DfYYILirYA/sCJ0f9FCQxM= Received: from AM6PR02CA0022.eurprd02.prod.outlook.com (2603:10a6:20b:6e::35) by DU0PR08MB7762.eurprd08.prod.outlook.com (2603:10a6:10:3ba::13) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.7249.34; Mon, 5 Feb 2024 17:06:47 +0000 Received: from AMS0EPF00000197.eurprd05.prod.outlook.com (2603:10a6:20b:6e:cafe::27) by AM6PR02CA0022.outlook.office365.com (2603:10a6:20b:6e::35) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.7249.34 via Frontend Transport; Mon, 5 Feb 2024 17:06:47 +0000 X-MS-Exchange-Authentication-Results: spf=pass (sender IP is 63.35.35.123) smtp.mailfrom=arm.com; dkim=pass (signature was verified) header.d=armh.onmicrosoft.com;dmarc=pass action=none header.from=arm.com; Received-SPF: Pass (protection.outlook.com: domain of arm.com designates 63.35.35.123 as permitted sender) receiver=protection.outlook.com; client-ip=63.35.35.123; helo=64aa7808-outbound-1.mta.getcheckrecipient.com; pr=C Received: from 64aa7808-outbound-1.mta.getcheckrecipient.com (63.35.35.123) by AMS0EPF00000197.mail.protection.outlook.com (10.167.16.219) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.7249.19 via Frontend Transport; Mon, 5 Feb 2024 17:06:47 +0000 Received: ("Tessian outbound c4f080b252bb:v228"); Mon, 05 Feb 2024 17:06:47 +0000 X-CheckRecipientChecked: true X-CR-MTA-CID: 4197ef21c3081cf7 X-CR-MTA-TID: 64aa7808 Received: from c961ad203201.1 by 64aa7808-outbound-1.mta.getcheckrecipient.com id BBCC87C6-0503-4130-A5FB-A3DF67FBE368.1; Mon, 05 Feb 2024 17:06:41 +0000 Received: from EUR01-DB5-obe.outbound.protection.outlook.com by 64aa7808-outbound-1.mta.getcheckrecipient.com with ESMTPS id c961ad203201.1 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384); Mon, 05 Feb 2024 17:06:41 +0000 ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=d0h/0l1YalAmi+5N66AWR4c+454mWKZGVNcESuP7M9SLdSEzXTXxq7zeZMqu7JcUfJYh0Utw/6ftqVQoOTO6DNqbGTFdH5MfrYR2sI7RfIKGrPRjgfrwfV0CstdyNcBZ489JYIQMEvbIStGU6DYb3ZJYRHpP0ytpek9YQh/UKz+o9ab5UayFoN8Df8+qd6sSRVBOdgwgY1wto/exIT2otQ0EsFhLahFo0wATevuCCiVDdq7cFfRlbACsGumFaKGY8u7F+QcAoWCWtwjatfK21FHrPaccpyK77rErTnh3KGVdrvowQtKZytVWgEVkNGzPEBzzotiIrPsw6IxretVsWw== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=obeCfs9Tbrow4/lBt6rq83UnbUNordzna4G2qx4n1Go=; b=e01gv5qPNrx+svMnHoyaPg26O9sc4hVOxgi+zDck5lzLCIhb0G7S73HkIk+rWtwNfi+/F2lyI95vabCTSgZR0RgHZpxvRGIHv+yxqJPwtJerfhqZYl0F0RGjF3SUoGwYCbRiPq/kjN3/cTTu9Us3Evlhc48GrpQ+bVby+s+pCor3B1WGt9ezTHbaajIevEdC/i9wmY3V2JsOZ0go4Wl9C7ksrsH1ItNlH17fRM95WVm2yDKh5JxJxUO8Gth2FH8JHCeJ9YePjMNBLnqFX89D8ilrMmQuZ7M/31EsVL6ilxjPE4QPJen0wAi8dl+tDEm06tu1tq1rwxx1qtnIyz+/pA== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=arm.com; dmarc=pass action=none header.from=arm.com; dkim=pass header.d=arm.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=armh.onmicrosoft.com; s=selector2-armh-onmicrosoft-com; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=obeCfs9Tbrow4/lBt6rq83UnbUNordzna4G2qx4n1Go=; b=w5XZxWPGfjbU5Xe5ufGJdiwkODrFrf4eAv1kQxCEAEenoBPzI0+NsXAr5ncxCsusKSe1YZ8P5noVCc16HhOSLgoLhEE5VtYBId5Lc+aAUdjV75ReBVRZwqlmBpsyOq2Iqzz24M+09lAWjHNftxIm5DfYYILirYA/sCJ0f9FCQxM= Authentication-Results-Original: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=arm.com; Received: from DB9PR08MB7179.eurprd08.prod.outlook.com (2603:10a6:10:2cc::19) by GV2PR08MB8725.eurprd08.prod.outlook.com (2603:10a6:150:b4::20) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.7249.34; Mon, 5 Feb 2024 17:06:39 +0000 Received: from DB9PR08MB7179.eurprd08.prod.outlook.com ([fe80::12b2:a3ec:f016:df6f]) by DB9PR08MB7179.eurprd08.prod.outlook.com ([fe80::12b2:a3ec:f016:df6f%3]) with mapi id 15.20.7249.032; Mon, 5 Feb 2024 17:06:39 +0000 Date: Mon, 5 Feb 2024 17:06:25 +0000 From: Szabolcs Nagy To: Adhemerval Zanella , libc-alpha@sourceware.org Cc: Adrian Ratiu Subject: Re: [PATCH] arm: Remove unused ldr _dl_start_user Message-ID: References: <20240205161808.1316432-1-adhemerval.zanella@linaro.org> Content-Type: text/plain; charset=utf-8 Content-Disposition: inline In-Reply-To: <20240205161808.1316432-1-adhemerval.zanella@linaro.org> X-ClientProxiedBy: LO4P123CA0307.GBRP123.PROD.OUTLOOK.COM (2603:10a6:600:197::6) To DB9PR08MB7179.eurprd08.prod.outlook.com (2603:10a6:10:2cc::19) MIME-Version: 1.0 X-MS-TrafficTypeDiagnostic: DB9PR08MB7179:EE_|GV2PR08MB8725:EE_|AMS0EPF00000197:EE_|DU0PR08MB7762:EE_ X-MS-Office365-Filtering-Correlation-Id: 92675784-be46-472f-7831-08dc266cd688 x-checkrecipientrouted: true NoDisclaimer: true X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam-Untrusted: BCL:0; X-Microsoft-Antispam-Message-Info-Original: WOp+AqniDrI9XNjUf5/hhBPB38cpQb3t4ULO7UvbEaGwFkv+vdoSYxZWNy/+UQ3OBeKW1awpwTafE9K1Jt9FqlIIFuu2wbXdGuxgIWdTU2ZUxkDrj2c2J3LmAKH1IshZ0c56l+m1fr1kK4YCtYHDzE0OKlXyJT2tcT33cSoF+W3HXXeY46kS2cjnanOQVuHz3IOAOpWxTUfrchrC8V8lKj5nG8L+QjvYKEW2GUeHhTz6kFScJO91zlJTr8OzPvWOfQYR9PrnJk2WsaM5QKa1VMNWzcExw35IffbMndb2uFKx+qKTVHqWE+ajMQhweUk+Day89He6wZXgm1teN2mVzF8bBHEGbsq8SLA8XHlhQmzTmLuD1RvI/Lv6bBT5ra3K8JsJK6UJTJyvtLIrIuvcnpD+n4SLIF5KJTs+/pnYipD8IwAdhXUymEw2chzpZPjrfZR0PfVNb9fyiQDNWWYkZbAG4AdUwaebXTCfYxOJDcCscQX43VVFF6CHU1bxrDFOypDDYYPbmoPmDHtiyQlZX5zghisaPPM18y1QGMAaIDtHIccM826z5iCzIzFdrVI3 X-Forefront-Antispam-Report-Untrusted: CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:DB9PR08MB7179.eurprd08.prod.outlook.com;PTR:;CAT:NONE;SFS:(13230031)(346002)(136003)(376002)(396003)(39860400002)(366004)(230922051799003)(1800799012)(186009)(64100799003)(451199024)(26005)(83380400001)(41300700001)(5660300002)(44832011)(86362001)(66476007)(66946007)(66556008)(2906002)(2616005)(478600001)(6506007)(6666004)(6512007)(38100700002)(4326008)(316002)(6486002)(36756003)(8676002)(8936002);DIR:OUT;SFP:1101; X-MS-Exchange-Transport-CrossTenantHeadersStamped: GV2PR08MB8725 Original-Authentication-Results: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=arm.com; X-EOPAttributedMessage: 0 X-MS-Exchange-Transport-CrossTenantHeadersStripped: AMS0EPF00000197.eurprd05.prod.outlook.com X-MS-PublicTrafficType: Email X-MS-Office365-Filtering-Correlation-Id-Prvs: f041fe90-93f3-448c-4c57-08dc266cd157 X-Microsoft-Antispam: BCL:0; X-Microsoft-Antispam-Message-Info: DVRZDudrgmi0z19iUGC6o4ZWaNBopyYhDAJNaQnjATQTvHS+WF4Uje2SUKWWFkKBMTcv0bbHmyKuU1fEhXY9T/Tb8D1m7A2YYYRODrDwkAU99rUL1mLYr61xF7oTPt7IGpCzKUtDjgc6TvvVOkuLx+rgrHb14cOi09euFSdm3/iSOCxvGDCQ31n11LFU8ZDoOQcWxqzsiY3Kgd3upq7/b/SQ4xv4CWN5vmdDPu+FK8SseHZE74DrwsxswRFyZS43neKHPsb5hKJoquGrVixQ4augm3eS/HybEmuj1w1YPZo1JoWpyxIXHZj42Gw5ywuNs9woHjtBUa4MeHIENPxvh551/nJkSmd7+fZjjpMoPJ8DyBm05OnZNgGYqoV/cuUzNQohcm1KpgQ7rFoBXM8tJLyH7ik4Dn08KGo7G60zjr19OlPC2DlCGSd1m33lYMrUqPXU4VNrVGlOzetpin7hut0Rj2U7KxHJGCOV8wtXIo/dWvi92foUvZWOBGT/0rHoypNDUnr0wd0egOp//wZTWritffICiuguD+OX5b5wmGGSU+0ZoAZYS49TCrekDF6wotf3riwDeBw5qAXzkfnJfWqs1xXfs6TutByg+cYoZtXxlGu5VW2gFHptfH+n1YwKahfcPq6BfYv1rMx+mbewyNY3zjEoQkyi+eIiLjX7zfBUSTqBAcq8Unuou+5fObVn7YbdU4D/LFeA0YcngteqxFJ5gMbXNioB5RDtEPnujg1UQps1jYkmfNbjxpXo/91H X-Forefront-Antispam-Report: CIP:63.35.35.123;CTRY:IE;LANG:en;SCL:1;SRV:;IPV:CAL;SFV:NSPM;H:64aa7808-outbound-1.mta.getcheckrecipient.com;PTR:ec2-63-35-35-123.eu-west-1.compute.amazonaws.com;CAT:NONE;SFS:(13230031)(4636009)(346002)(376002)(39860400002)(136003)(396003)(230922051799003)(1800799012)(64100799003)(186009)(82310400011)(451199024)(36840700001)(46966006)(40470700004)(2616005)(41300700001)(107886003)(26005)(336012)(86362001)(36756003)(6486002)(5660300002)(2906002)(478600001)(70206006)(44832011)(70586007)(4326008)(8676002)(8936002)(6512007)(6506007)(6666004)(40480700001)(40460700003)(36860700001)(82740400003)(81166007)(356005)(83380400001)(316002)(47076005);DIR:OUT;SFP:1101; X-OriginatorOrg: arm.com X-MS-Exchange-CrossTenant-OriginalArrivalTime: 05 Feb 2024 17:06:47.6734 (UTC) X-MS-Exchange-CrossTenant-Network-Message-Id: 92675784-be46-472f-7831-08dc266cd688 X-MS-Exchange-CrossTenant-Id: f34e5979-57d9-4aaa-ad4d-b122a662184d X-MS-Exchange-CrossTenant-OriginalAttributedTenantConnectingIp: TenantId=f34e5979-57d9-4aaa-ad4d-b122a662184d;Ip=[63.35.35.123];Helo=[64aa7808-outbound-1.mta.getcheckrecipient.com] X-MS-Exchange-CrossTenant-AuthSource: AMS0EPF00000197.eurprd05.prod.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Anonymous X-MS-Exchange-CrossTenant-FromEntityHeader: HybridOnPrem X-MS-Exchange-Transport-CrossTenantHeadersStamped: DU0PR08MB7762 X-Spam-Status: No, score=-11.4 required=5.0 tests=BAYES_00,DKIM_SIGNED,DKIM_VALID,FORGED_SPF_HELO,GIT_PATCH_0,KAM_DMARC_NONE,RCVD_IN_DNSWL_NONE,RCVD_IN_MSPIKE_H2,SPF_HELO_PASS,SPF_NONE,TXREP,T_SCC_BODY_TEXT_LINE,UNPARSEABLE_RELAY autolearn=ham autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on server2.sourceware.org List-Id: The 02/05/2024 16:18, Adhemerval Zanella wrote: > The commit 49d877a80b29d3002887b084eec6676d9f5fec18 (arm: Remove > _dl_skip_args usage) removed the _SKIP_ARGS literal, which was > previously loader to r4 on loader _start. However, the cleanup did not > remove the following 'ldr r4, [sl, r4]' on _dl_start_user, used to check > to skip the arguments after ld self-relocations. > > In my testing, the kernel initially set r4 to 0, which makes the > ldr instruction just read the _GLOBAL_OFFSET_TABLE_. However, since r4 > is a caller-saved register; a different runtime might not zero ^^^^^^ it's callee-saved (preserved by calls) > initialize it and thus trigger an invalid memory access. > > Checked on arm-linux-gnu. patch looks good. Reviewed-by: Szabolcs Nagy > > Reported-by: Adrian Ratiu > --- > sysdeps/arm/dl-machine.h | 1 - > 1 file changed, 1 deletion(-) > > diff --git a/sysdeps/arm/dl-machine.h b/sysdeps/arm/dl-machine.h > index b857bbc868..dd1a0f6b6e 100644 > --- a/sysdeps/arm/dl-machine.h > +++ b/sysdeps/arm/dl-machine.h > @@ -139,7 +139,6 @@ _start:\n\ > _dl_start_user:\n\ > adr r6, .L_GET_GOT\n\ > add sl, sl, r6\n\ > - ldr r4, [sl, r4]\n\ > @ save the entry point in another register\n\ > mov r6, r0\n\ > @ get the original arg count\n\ > -- > 2.34.1 >