From: Szabolcs Nagy <szabolcs.nagy@arm.com>
To: Askar Safin <safinaskar@zohomail.com>,
libc-alpha@sourceware.org, adhemerval.zanella@linaro.org,
carlos@redhat.com
Cc: dalias@libc.org
Subject: Re: [PATCH v2] Add public function syscall_no_errno
Date: Thu, 8 Feb 2024 17:48:10 +0000 [thread overview]
Message-ID: <ZcUT2l6PsQBEl8rj@arm.com> (raw)
In-Reply-To: <20240208152224.11031-2-safinaskar@zohomail.com>
The 02/08/2024 18:02, Askar Safin wrote:
> Add public function syscall_no_errno. Linux-specific. It is the same as syscall,
> but it doesn't interpret value, returned by Linux. So it is
> okay for issuing syscalls, such as SYS_getuid. Example:
>
> #define _GNU_SOURCE
> #include <stdio.h>
> #include <unistd.h>
> #include <sys/syscall.h>
>
> int
> main ()
> {
> long int rc;
> rc = syscall_no_errno(SYS_getuid);
> printf("uid = %ld\n", rc);
> }
>
the commit message has to explain why this is added
and how do we expect users to use this api.
it has to address why do we care about this use-case
more than the long list of other cases on linux that
don't work with the existing syscall api.
the patch needs tests for the new api.
i think the variadic nature of syscall and the libc vs
linux type differences are problematic enough that we
should discourage its use with or without errno.
next prev parent reply other threads:[~2024-02-08 17:48 UTC|newest]
Thread overview: 23+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-01-28 16:39 [PATCH, RFC] " Askar Safin
2024-02-01 17:53 ` Adhemerval Zanella Netto
2024-02-01 18:18 ` Rich Felker
2024-02-01 19:32 ` Askar Safin
2024-02-01 20:16 ` dalias
2024-02-01 20:57 ` Adhemerval Zanella Netto
2024-02-08 15:02 ` [PATCH v2] " Askar Safin
2024-02-08 17:48 ` Szabolcs Nagy [this message]
2024-02-12 14:24 ` Florian Weimer
2024-02-12 14:44 ` Rich Felker
2024-02-12 16:16 ` Askar Safin
2024-02-12 17:25 ` Zack Weinberg
2024-02-12 17:43 ` Andreas Schwab
2024-02-12 18:22 ` Zack Weinberg
2024-02-13 9:10 ` Andreas Schwab
2024-02-13 11:57 ` Adhemerval Zanella Netto
2024-02-12 17:55 ` Adhemerval Zanella Netto
2024-02-12 18:34 ` Askar Safin
2024-02-07 0:59 ` [PATCH, RFC] " Askar Safin
2024-02-07 20:59 ` dalias
2024-02-08 17:08 ` Askar Safin
2024-02-07 1:57 ` Mike Frysinger
2024-02-07 12:55 ` Askar Safin
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=ZcUT2l6PsQBEl8rj@arm.com \
--to=szabolcs.nagy@arm.com \
--cc=adhemerval.zanella@linaro.org \
--cc=carlos@redhat.com \
--cc=dalias@libc.org \
--cc=libc-alpha@sourceware.org \
--cc=safinaskar@zohomail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).