public inbox for libc-alpha@sourceware.org
 help / color / mirror / Atom feed
From: Darius Rad <darius@bluespec.com>
To: libc-alpha@sourceware.org
Subject: Re: [PATCH v2] riscv: Update nofpu libm test ulps
Date: Mon, 11 Mar 2024 14:56:07 -0400	[thread overview]
Message-ID: <Ze9Tx9mA4VHudkye@localhost.localdomain> (raw)
In-Reply-To: <87v85soqig.fsf@oldenburg.str.redhat.com>

On Mon, Mar 11, 2024 at 02:19:03PM +0100, Florian Weimer wrote:
> * Darius Rad:
> 
> > Fix two test failures.
> > ---
> > Changes since v1:
> >   - Rebase to master
> >   - Fix corrupted diff line in patch
> >
> >  sysdeps/riscv/nofpu/libm-test-ulps | 1 +
> >  1 file changed, 1 insertion(+)
> >
> > diff --git a/sysdeps/riscv/nofpu/libm-test-ulps b/sysdeps/riscv/nofpu/libm-test-ulps
> > index 16106f10b0..bc7e615177 100644
> > --- a/sysdeps/riscv/nofpu/libm-test-ulps
> > +++ b/sysdeps/riscv/nofpu/libm-test-ulps
> > @@ -1043,6 +1043,7 @@ ldouble: 8
> >  
> >  Function: "hypot":
> >  double: 1
> > +float: 1
> >  ldouble: 1
> >  
> >  Function: "hypot_downward":
> 
> Looks okay.
> 
> Reviewed-by: Florian Weimer <fweimer@redhat.com>
> 
> Do you have sourceware commit access?  If not, I can push the change for
> you.

I do not.  If you could commit it, I would appreciate it.

> 
> (ULP updates like this can also be pushed without review as obvious, I
> think.)
> 
> Thanks,
> Florian
> 

  reply	other threads:[~2024-03-11 18:56 UTC|newest]

Thread overview: 6+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2024-03-06 18:08 Darius Rad
2024-03-11 13:19 ` Florian Weimer
2024-03-11 18:56   ` Darius Rad [this message]
2024-03-18 10:29     ` Florian Weimer
2025-01-08 20:03 Darius Rad
2025-01-09 13:00 ` Andreas K. Huettel

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=Ze9Tx9mA4VHudkye@localhost.localdomain \
    --to=darius@bluespec.com \
    --cc=libc-alpha@sourceware.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).