From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mail-pl1-x62d.google.com (mail-pl1-x62d.google.com [IPv6:2607:f8b0:4864:20::62d]) by sourceware.org (Postfix) with ESMTPS id DED3B3858CDB for ; Mon, 18 Mar 2024 23:01:19 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.4.2 sourceware.org DED3B3858CDB Authentication-Results: sourceware.org; dmarc=pass (p=reject dis=none) header.from=fastly.com Authentication-Results: sourceware.org; spf=pass smtp.mailfrom=fastly.com ARC-Filter: OpenARC Filter v1.0.0 sourceware.org DED3B3858CDB Authentication-Results: server2.sourceware.org; arc=none smtp.remote-ip=2607:f8b0:4864:20::62d ARC-Seal: i=1; a=rsa-sha256; d=sourceware.org; s=key; t=1710802881; cv=none; b=g7LaeYTJJ7GQPvlwq8dl8HriPgqbUitHfy0qk+gpfTDrfQ4feMtnr2ObTs85VUQz1/pD64QQfv01zS1LFRhSrLlshRXZr4kC0rNq4rpD4908rA/xSSpCGCw0BY4dueHcjIU7IeAl4WC/JiPIqyZfPPQjMUwVA/pPVkM4yRCvcQU= ARC-Message-Signature: i=1; a=rsa-sha256; d=sourceware.org; s=key; t=1710802881; c=relaxed/simple; bh=f8zga+zbcsXVz9CMVP4FuHrl6+w6S52cpE7MiD6omvk=; h=DKIM-Signature:Date:From:To:Subject:Message-ID:MIME-Version; b=Vz5MvoRlKTaNmysfKg/wtvZ85ZNtciw4qGGBREGG1HVO6hB5cHSprNESyKX5AyDY8cz072GJm9quTix9MBbjiJ9mraVHbFI6TH8jzZNd2u1TVnB9wsk9mGwxDrEtlQ0AN3MLn8ltc/wKvfWlpR+t4wBUfZV+zAYD+FCbNgeW7ZE= ARC-Authentication-Results: i=1; server2.sourceware.org Received: by mail-pl1-x62d.google.com with SMTP id d9443c01a7336-1e0000cdf99so17875885ad.0 for ; Mon, 18 Mar 2024 16:01:19 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=fastly.com; s=google; t=1710802879; x=1711407679; darn=sourceware.org; h=in-reply-to:content-transfer-encoding:content-disposition :mime-version:references:message-id:subject:cc:to:from:date:from:to :cc:subject:date:message-id:reply-to; bh=Aof2UPD8VnPGzAKDXvKN2UHGWLNzYWztNyVDDxVgVqI=; b=ZL1QyLv9ekZdFzRzcjwlWXbIar79qEI9tH/exl3mDNhn92mRrtuaU4zG4j2cpXcEEg /QsODAENtZXaLQOcKWKvt89e8ftx6WQayYQ8OrWPi5OryKUYhxmx+YuEkr4K1NKZ+d3R PKJgzMHTj7s/5JEcjBgffDrVums4qnjELO59A= X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1710802879; x=1711407679; h=in-reply-to:content-transfer-encoding:content-disposition :mime-version:references:message-id:subject:cc:to:from:date :x-gm-message-state:from:to:cc:subject:date:message-id:reply-to; bh=Aof2UPD8VnPGzAKDXvKN2UHGWLNzYWztNyVDDxVgVqI=; b=EJsoVHPSyqdvyz3yIMd7A+n3fsWqANfuMZmH4Fc3btuc+2MJx8n1JFgrdnja6lMsRg BFwWyHiIKlPlwFcCKvMxSq+kKJ3RfW52x+pb+tLHZJ9R4AfAd2GEGqOkInoDu7mRhKNJ iq1wLr5T0ExrzTde23SXmgFUcTULm0FqbG86M5U+H2OTkmHmKMK/6ubhWfSWqj5xNjZZ 9/SIhtwKvycu6UZsiLWaM7oZ2QeZDmSR7/rsk8JeUZsLLoUvZe0q9+jnaA9Pzk5ziNlq tdFjXHDqWosNX2kg6NcndW6GO2YLNzUZeeKu2pzLrxEyYjxQoKKlPnrE7GVpNT4tX7LN O6GQ== X-Forwarded-Encrypted: i=1; AJvYcCXXzyI94b7Ka0gEqOtD+51enKM+8g4XGzfWvGYfbZuOavXV8HGcdKi23ByWdJOEtb1bIPGCXq+pUPuzEU/i5ingvYUeLEtc/v06 X-Gm-Message-State: AOJu0Yy1cvFK8wDGjW3qR2fJfonNX53RMHxZptPP0bO6AbhE8FcM+VS/ SIrCsuKwYf+UfjHHaMISdblu2KNY2MGcZUvdWtBC69mqpwTS1XXHrpfYbh3hH/M= X-Google-Smtp-Source: AGHT+IGSdI24SFLWLG2Zo23rVWaIvatvIRW1gYvqKWk9NlU6NCc49bwV427Z0bv/1TYDzNsn/Zfbkw== X-Received: by 2002:a17:902:ee84:b0:1dd:8d11:73d2 with SMTP id a4-20020a170902ee8400b001dd8d1173d2mr13984038pld.40.1710802878164; Mon, 18 Mar 2024 16:01:18 -0700 (PDT) Received: from feather.sobornost.net (dhcp-930b.meeting.ietf.org. [31.133.147.11]) by smtp.gmail.com with ESMTPSA id z7-20020a170903018700b001def777afc5sm6922373plg.77.2024.03.18.16.01.16 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Mon, 18 Mar 2024 16:01:17 -0700 (PDT) Date: Mon, 18 Mar 2024 23:01:14 +0000 From: Job Snijders To: Andreas Schwab Cc: Florian Weimer , libc-alpha@sourceware.org Subject: Re: [PATCH] resolv: add IPv6 support to inet_net_pton() Message-ID: References: <87zfuxcdjd.fsf@oldenburg.str.redhat.com> MIME-Version: 1.0 Content-Type: text/plain; charset=iso-8859-1 Content-Disposition: inline Content-Transfer-Encoding: 8bit In-Reply-To: X-Spam-Status: No, score=4.5 required=5.0 tests=BAYES_00,DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,RCVD_IN_DNSWL_NONE,SPAM_FROM,SPF_HELO_NONE,SPF_NONE,TXREP,T_SCC_BODY_TEXT_LINE autolearn=no autolearn_force=no version=3.4.6 X-Spam-Level: **** X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on server2.sourceware.org List-Id: On Mon, Mar 18, 2024 at 10:23:27AM +0100, Andreas Schwab wrote: > On Mär 18 2024, Job Snijders wrote: > > + __set_errno (0); > > + lbits = strtol(sep, &ep, 10); > > + if (sep[0] == '\0' || *ep != '\0') { > > + __set_errno (ENOENT); > > + return (-1); > > + } > > + if ((errno == ERANGE && (lbits == LONG_MAX || lbits == LONG_MIN)) > > + || (lbits > 128 || lbits < 0)) { > > + __set_errno (EMSGSIZE); > > + return (-1); > > I think the first half of the error check is redundant since we only > accept values in the range [0,128] anyway. This is an idiomatic error check. The compiler can optimize parts of it, if the compiler feels they are not not neccessary. An argument in support of idiomatic checks is that someone can visually inspect, recognize, and know no checks were missed. I'd like it if this libc implementation had strtonum() support like described here: https://flak.tedunangst.com/post/the-design-of-strtonum Would the project appreciate a patch? Kind regards, Job