From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mail-wr1-x42f.google.com (mail-wr1-x42f.google.com [IPv6:2a00:1450:4864:20::42f]) by sourceware.org (Postfix) with ESMTPS id 094883858D37 for ; Tue, 16 Apr 2024 20:37:11 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.4.2 sourceware.org 094883858D37 Authentication-Results: sourceware.org; dmarc=pass (p=none dis=none) header.from=gmail.com Authentication-Results: sourceware.org; spf=pass smtp.mailfrom=gmail.com ARC-Filter: OpenARC Filter v1.0.0 sourceware.org 094883858D37 Authentication-Results: server2.sourceware.org; arc=none smtp.remote-ip=2a00:1450:4864:20::42f ARC-Seal: i=1; a=rsa-sha256; d=sourceware.org; s=key; t=1713299832; cv=none; b=Boc9/6wrWj46EQakp8Sdz2PPhHoZLDNQ3cuXg46F3S4fzxWVP982sKFZllCxbJoDKw/zMZfpalhmvXwQ2dv94wpSpoqojSeAMDwCyNwIee6DszQVZDED+GOOWIXyJgW9hlWZZeXFbY87O/XEfkqcJDkielg1LKK8lpDDXB2lGpg= ARC-Message-Signature: i=1; a=rsa-sha256; d=sourceware.org; s=key; t=1713299832; c=relaxed/simple; bh=m6IyhsJuOXtOgIlo1iRx7fNL0Xmwo4GPSslczGQio6c=; h=DKIM-Signature:Date:From:To:Subject:Message-ID:MIME-Version; b=gpQsxUuJ7zcpDAGYsSmtbjs6PbNhTMsVJrGutZgj4M7iCM6Axsn0/7NCg4/TCjyUcKfEaJsgbrQktcMPuhFt0onMgxPQLEsufQPxieTX5OUprklrXNMCLNSWYTwY0nEQz3DaHI19zbaD63j3ztJtzYS0GPSzxSlrTV4ij/ajh50= ARC-Authentication-Results: i=1; server2.sourceware.org Received: by mail-wr1-x42f.google.com with SMTP id ffacd0b85a97d-343f1957ffcso86492f8f.0 for ; Tue, 16 Apr 2024 13:37:10 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20230601; t=1713299830; x=1713904630; darn=sourceware.org; h=in-reply-to:content-disposition:mime-version:references:message-id :subject:cc:to:from:date:from:to:cc:subject:date:message-id:reply-to; bh=cCQCfz07+wOX3FHSZEC0Mo0q80E3mOKT/qEMyPAHrtQ=; b=CK3tg2KswufZpQNAklWVyz/UbFO0rMo1ffp+LE3kxv0cUPGGf6BTrFQNaheS6l9jWV nPHJTRNwE5GqU8DMMiajHeC0Pm2vOoIFk1ohPkyD/2gbar6BTEsIHdEX2axEF+Bn6/v1 ddnW7fPe7oGJjjlvzRWFuZFTQbTuQpGYQK6W/9HM93YG3m5sHcZdR/yFSyCJ+uI7Pto2 674rebTnkfSdesbSnPtP7m3nNtR2QjQ0+zNvJi0VvvfLJpqSIRrF8rE7ZKMnPPQQZCIx vJyrsn0TZ3GcQXBamZQBw4+4lupMenrb8uxXyMyAiIOV9GpkbNJbDFp8EMYeCSb/PICC Ii5Q== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1713299830; x=1713904630; h=in-reply-to:content-disposition:mime-version:references:message-id :subject:cc:to:from:date:x-gm-message-state:from:to:cc:subject:date :message-id:reply-to; bh=cCQCfz07+wOX3FHSZEC0Mo0q80E3mOKT/qEMyPAHrtQ=; b=jg4PjAGA9K8NJHeMVQjWxlNlESGN7pEW/Kn2tLLa1ojI22HCNiA0IP7WIHylxvEsN2 FKi9EukG3ppO8TrUUICGdnU9sFadtq9bNle2TKf3dfvcL39t0oOQGzlpn6oWVgzMV31O n2N2R8124ACSTNw/XZKmt9c2z9rVkHdCNLlnr1RxpxFqGKyoR5kxpz9zCegdVL5V/R0g VvCoo77zdrmW1FNv5xRVsp3ADgKtQA02SMNhin/l213saqR3AZj8clfthCXpgQ8TDiMB 6+H/WnD5mx/5LTckRlj4tvvFzzQpstCQwr+YN/A773PfEFNzvvHsrJykIr9IKvTrPWak TKEQ== X-Forwarded-Encrypted: i=1; AJvYcCX0jRRYKhdP+F+BcBjFJ+2ZNRJ4O5qt8MElkFhhaQB736OkQgJBrAFKJcpAMYDb76uXDvG+Tn9A988izNd8Wx8TsJ2bghj9ejiX X-Gm-Message-State: AOJu0YyuakKigcBqpkaqWIj498lLFr5BtILXuj1kOcX0puVMonxSpdBX aJn+NZ4KDyKItbY+sHmExXOdJMaHupzolCZ2JHCEd2HOafxtzC9pVwoRXw== X-Google-Smtp-Source: AGHT+IGvZHz9s3N7Jr/Wsjn8SkKj3IW5o2/tDBxiB9FtC9cLaexrDwVqOELLWtFBfx5QUkdT3H6sxQ== X-Received: by 2002:adf:fa11:0:b0:346:4e74:819a with SMTP id m17-20020adffa11000000b003464e74819amr2764346wrr.14.1713299829350; Tue, 16 Apr 2024 13:37:09 -0700 (PDT) Received: from localhost (cpc1-brnt4-2-0-cust862.4-2.cable.virginm.net. [86.9.131.95]) by smtp.gmail.com with ESMTPSA id f12-20020a0560001a8c00b0034744966ff0sm11121004wry.59.2024.04.16.13.37.07 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Tue, 16 Apr 2024 13:37:07 -0700 (PDT) Date: Tue, 16 Apr 2024 21:37:06 +0100 From: Stafford Horne To: Richard Henderson Cc: Adhemerval Zanella Netto , GLIBC patches , Linux OpenRISC Subject: Re: [PATCH 1/2] or1k: Add hard float support Message-ID: References: <20240329074044.1961252-1-shorne@gmail.com> <20240329074044.1961252-2-shorne@gmail.com> <4fca2ce2-2a45-4021-b91c-3e0c9dd8f6e2@linaro.org> <9870848e-0b2e-423f-8dd1-4bed6968aeda@linaro.org> <1cd9db5c-fd3a-45d8-96d5-227ea720dab3@linaro.org> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <1cd9db5c-fd3a-45d8-96d5-227ea720dab3@linaro.org> X-Spam-Status: No, score=-4.7 required=5.0 tests=BAYES_00,DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,FREEMAIL_FROM,RCVD_IN_DNSWL_NONE,SPF_HELO_NONE,SPF_PASS,TXREP autolearn=ham autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on server2.sourceware.org List-Id: On Tue, Apr 16, 2024 at 12:56:11PM -0700, Richard Henderson wrote: > On 4/16/24 09:20, Adhemerval Zanella Netto wrote: > > Right, it was not clear from patch without dig into the ABI documen > > itself. So the only thing I am not sure is the mcontext_t change. > > Other ABIs added a symbol version to proper handle it, so maybe > > OpenRISC would need something similar. > > Yes, I think some compat symbols are needed for getcontext et al, since the > size of ucontext_t changes. Just to re-iterate, the size of ucontext_t provided by the kernel never changed. But the change of ucontext_t in glibc changing causes issues. With the glibc ucontext_t size change there will be a problem with running old compiled applications on new versions of glibc if this hard-float series is added as is. I will see if we can add some versioning to ensure binaries will not break when running on new glibc versions after this series. > I think softfloat glibc should populate the same field (with zero, since > neither exceptions nor rounding are supported). Let me double check this is the case. -Stafford