From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from EUR02-DB5-obe.outbound.protection.outlook.com (mail-db5eur02on2084.outbound.protection.outlook.com [40.107.249.84]) by sourceware.org (Postfix) with ESMTPS id 6CF343858C52 for ; Fri, 5 Apr 2024 14:58:45 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.4.2 sourceware.org 6CF343858C52 Authentication-Results: sourceware.org; dmarc=pass (p=none dis=none) header.from=arm.com Authentication-Results: sourceware.org; spf=pass smtp.mailfrom=arm.com ARC-Filter: OpenARC Filter v1.0.0 sourceware.org 6CF343858C52 Authentication-Results: server2.sourceware.org; arc=pass smtp.remote-ip=40.107.249.84 ARC-Seal: i=3; a=rsa-sha256; d=sourceware.org; s=key; t=1712329128; cv=pass; b=W+JxshiTS9e7tpXDreuKv6F1f/6N6swpVEC/oIKpppIbKqZoKPvLDR28/HB+vo4j364/Df108JgXlWNL5NhWnTGESw8AGLQwY6S+1iKxf/7h/0egFYFODm3HS8EmW/fDQ9JvaXg7JoFoxEWRg614+N5fymcbqDpRJnWoAcC5aas= ARC-Message-Signature: i=3; a=rsa-sha256; d=sourceware.org; s=key; t=1712329128; c=relaxed/simple; bh=qcR1/OtPHAsi7xc0IhX1VVZfL1TZHr/YxXmWVr4GqI4=; h=DKIM-Signature:DKIM-Signature:Date:From:To:Subject:Message-ID: MIME-Version; b=uGjik2vIZvQ5u8V+oz7TfOfLEiV4Vg73rUtO13IQ46Jh2u5lYoTn8idzHZgVSB0nGa2j+m2ZcG+f4lIUP7b6WXye1w2C9CAV6+zI46WQMVTUd2Vg3LYkYn9y1wUlvdqwG2vny1BNyP9/kbXrx7RXcs6Pmd3gz5d1L1LjC8wP77g= ARC-Authentication-Results: i=3; server2.sourceware.org ARC-Seal: i=2; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=pass; b=ZYFP8awfqpS7b/kaYeMvO/j83pQK+w+GvMgeAz2Oo990m4IxZPObTxGJANAtZVT3cI5ocHGsHNCp98AS+1W5U+nP1d2SC1zNsxO2Za5djw9XLFddGYA+gL7+Wu8NgjhXiI3sD+OwB4Nbp1IWqJXRFCmpqd6C0nvLzmNPWNajWcRS2dAd2fqgNlQZqwT6PdeKBFBA16c5SHxQScZei7SOor18MHj4W/6i4N7JZ2kBoP3hXqTrXU8mqRbAp8SOff83ZEwcArl72RTBa8gnbQ6Z37GrHUj3tLCGyV7ZFVyO6ugHjFjwrVC5bVUNjnkjB+JNWUIhy3TO3hezzxzN33RDcg== ARC-Message-Signature: i=2; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=zjiyASbWb9HecDzHq8C9JEYvesiXkCF8zpSPp8j4dAQ=; b=iQW2LsrgCCAq2QUmvBi7QNzqAJS+Jck3sV3dMn/r1BCe6i/lfYsU7aKUaVEKwVhbOIAhTbaBiz+IQ3r77i0M2/bG1JeCCTyjaFqadAqszdMvGZ54hgWdfGQmctiarsLJgHuraX7iN5aABlAfEfstg3NlU5CASG3SckpmeA88G0I3dKUzy9iNGEdPBwCAQEgBl1gw/TjJsQHdRcl6Sx9qh2PJ6JXAJBJJXe37orO3sI47j/pdLMIjiQK1k0yvo/lsIGzAEO8HNLinqpqe/JTrEE6q6phNGejrc1y3XUOS/vBjjIRNYq0anXxYWYvLNnQPOywL6sC1UrdtjGrvEG8Tnw== ARC-Authentication-Results: i=2; mx.microsoft.com 1; spf=pass (sender ip is 63.35.35.123) smtp.rcpttodomain=sourceware.org smtp.mailfrom=arm.com; dmarc=pass (p=none sp=none pct=100) action=none header.from=arm.com; dkim=pass (signature was verified) header.d=armh.onmicrosoft.com; arc=pass (0 oda=1 ltdi=1 spf=[1,1,smtp.mailfrom=arm.com] dkim=[1,1,header.d=arm.com] dmarc=[1,1,header.from=arm.com]) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=armh.onmicrosoft.com; s=selector2-armh-onmicrosoft-com; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=zjiyASbWb9HecDzHq8C9JEYvesiXkCF8zpSPp8j4dAQ=; b=W5dOsboYjnevNWIsbbplTXQtTegsOumla6i3Koz7egJQkxkm8d6VIGyr3k6p681lE2lxM+O5IqtioYdqQdnxrKGyQ0anLiQklzZWJfNJTjcgymfVIENYA16y9WcjxxUupWapRyiPmOkte8DjUiZ4wLAhTd9r31+ewgMudmAAy38= Received: from DB7PR02CA0004.eurprd02.prod.outlook.com (2603:10a6:10:52::17) by PAXPR08MB7318.eurprd08.prod.outlook.com (2603:10a6:102:231::20) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.7409.46; Fri, 5 Apr 2024 14:58:41 +0000 Received: from DU2PEPF00028D0F.eurprd03.prod.outlook.com (2603:10a6:10:52:cafe::33) by DB7PR02CA0004.outlook.office365.com (2603:10a6:10:52::17) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.7452.30 via Frontend Transport; Fri, 5 Apr 2024 14:58:41 +0000 X-MS-Exchange-Authentication-Results: spf=pass (sender IP is 63.35.35.123) smtp.mailfrom=arm.com; dkim=pass (signature was verified) header.d=armh.onmicrosoft.com;dmarc=pass action=none header.from=arm.com; Received-SPF: Pass (protection.outlook.com: domain of arm.com designates 63.35.35.123 as permitted sender) receiver=protection.outlook.com; client-ip=63.35.35.123; helo=64aa7808-outbound-1.mta.getcheckrecipient.com; pr=C Received: from 64aa7808-outbound-1.mta.getcheckrecipient.com (63.35.35.123) by DU2PEPF00028D0F.mail.protection.outlook.com (10.167.242.23) with Microsoft SMTP Server (version=TLS1_3, cipher=TLS_AES_256_GCM_SHA384) id 15.20.7452.22 via Frontend Transport; Fri, 5 Apr 2024 14:58:41 +0000 Received: ("Tessian outbound ff4e98f65004:v300"); Fri, 05 Apr 2024 14:58:41 +0000 X-CheckRecipientChecked: true X-CR-MTA-CID: 39812b932d224a38 X-CR-MTA-TID: 64aa7808 Received: from b0b60bf33e5b.1 by 64aa7808-outbound-1.mta.getcheckrecipient.com id 5061BB9E-684D-42CE-9017-565551B342D7.1; Fri, 05 Apr 2024 14:58:34 +0000 Received: from EUR04-HE1-obe.outbound.protection.outlook.com by 64aa7808-outbound-1.mta.getcheckrecipient.com with ESMTPS id b0b60bf33e5b.1 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384); Fri, 05 Apr 2024 14:58:34 +0000 ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=djsF7Rn16f5fC1+r6RxbLhnUv7O2DRGxw/wlzL3v0FIOXFC6/zAL0IEn+Tpy4MKAnDIbnYB6Ri41cFOAw3RaDZ0dgkmDo/YjAkFBm+vA81OWP11JqptWCXWcnsesMpe0Tt/gC+pkSWOz2j7LItAaJZPYkp++vqmN/Jlt6ZtAo3JLNXuSKg+qHokIGP7CYgOHJcyc+AnqHQZqI7x+Stakobt92AoOfaLKlTzupkswQPmw21Qr0bUPPCv6K45MFTbyvMOkb9/Eba7ppj70uTAq1HTmRck2Co6Jx2yb5+J9JpkJFv1KW7emUrlwc6iopJ45iYu6I791Ny2zKp5eUaHRjw== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=zjiyASbWb9HecDzHq8C9JEYvesiXkCF8zpSPp8j4dAQ=; b=IHN1bVB3S+qsCnuwTFJP1r4NKQdm16OckPjnJiUhZLVid9E7M9BVmNzWaDj47YahnhaPJ3pcmrX3VxOEg1uFTLtqWMHMlPkN7mXq40AuDPui8t7aZk7TzhMm7IiMeDnsia5BGAWsldQLVJFGRmzg+ULe5wqsSsqvHp2Bfd6Utw/VXrhfceBBCId3PI567amX3ZecQyR/LOjEAXn+4vqKq3HFdgP9xGM7j6UhHtpwJqhA+8bDRd5CPkLUAywfdAaY2IQhwHXF73erVvEr9mOhuu7mOA0rSL7EOmTW6p62gLGsWsoKoGIbEVFhFW+yMP0TSZtk6zt2gBfTeK2cmvCUiw== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=arm.com; dmarc=pass action=none header.from=arm.com; dkim=pass header.d=arm.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=armh.onmicrosoft.com; s=selector2-armh-onmicrosoft-com; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=zjiyASbWb9HecDzHq8C9JEYvesiXkCF8zpSPp8j4dAQ=; b=W5dOsboYjnevNWIsbbplTXQtTegsOumla6i3Koz7egJQkxkm8d6VIGyr3k6p681lE2lxM+O5IqtioYdqQdnxrKGyQ0anLiQklzZWJfNJTjcgymfVIENYA16y9WcjxxUupWapRyiPmOkte8DjUiZ4wLAhTd9r31+ewgMudmAAy38= Received: from DB9PR08MB7179.eurprd08.prod.outlook.com (2603:10a6:10:2cc::19) by DB8PR08MB5452.eurprd08.prod.outlook.com (2603:10a6:10:111::10) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.7409.46; Fri, 5 Apr 2024 14:58:31 +0000 Received: from DB9PR08MB7179.eurprd08.prod.outlook.com ([fe80::8c23:46ef:c2c9:ea91]) by DB9PR08MB7179.eurprd08.prod.outlook.com ([fe80::8c23:46ef:c2c9:ea91%4]) with mapi id 15.20.7409.042; Fri, 5 Apr 2024 14:58:31 +0000 Date: Fri, 5 Apr 2024 15:58:17 +0100 From: Szabolcs Nagy To: Adhemerval Zanella , libc-alpha@sourceware.org Subject: Re: [PATCH] aarch64: Remove ld.so __tls_get_addr plt usage Message-ID: References: <20240405123550.1748641-1-adhemerval.zanella@linaro.org> Content-Type: text/plain; charset=utf-8 Content-Disposition: inline In-Reply-To: <20240405123550.1748641-1-adhemerval.zanella@linaro.org> X-ClientProxiedBy: LO4P123CA0297.GBRP123.PROD.OUTLOOK.COM (2603:10a6:600:196::14) To DB9PR08MB7179.eurprd08.prod.outlook.com (2603:10a6:10:2cc::19) MIME-Version: 1.0 X-MS-TrafficTypeDiagnostic: DB9PR08MB7179:EE_|DB8PR08MB5452:EE_|DU2PEPF00028D0F:EE_|PAXPR08MB7318:EE_ x-checkrecipientrouted: true NoDisclaimer: true X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam-Untrusted: BCL:0; X-Microsoft-Antispam-Message-Info-Original: O2di252HKqkJWFPy6yFs1ylHWcnxzlyVBE1Ncc++V62NwZR1TbtNCvjLWwz+bz8EXpxHLurB4w+3wssC1bTBvg70BAfX2R+7vIXtnriSBIhY37Mwf8hkyedZR7HCPhHay3NlsCYpdWa7W9ak8fbKnYIq929RMhhRG6oTwZIUHQxfcVuvHs73oRDZPRIODbRRJpEXi2WF/bTeKke9Ckcw5NIEqAFSLA1YvGSuqVIaycXgaHmvFONgq86NWclc9UiaiNUFR/xtg1U8cqeTG3MH+wId/Ws05ldItForFmvKe3c7GVPgVr+7QhdNDv8ytql0uUWsvolYjcNkF06fJyldeG2Dz4Fyu9fjOeAmt1bJNuPqc7mSKzPmuYPCg+fQ09sfN17rZJ1tMGjBsmXTzVjlZsq6KrC+agg2MmfYBVr2g+UhOK7BmTsPvST5UnwG51tV4DTqXJKzx88k3KywAMnFUij04iN3xH6UV1B+i0KhEHj+rOc2ol+zkVzqMlCCkPunnbgnrvAMrWd9wyvLTDrAMY8r6u1ibyWJAYyVNjiSnWSDc8M2W2pPpN3WNHGQ01+FSxad2IVsqipuBMnNnwwQqZJv3DuyS2ljZSMZgAM2CRBHLYyYzTASyHaW18Rc0UPsj3K9JJgwhiA+nOaZDcsZ1V4CEVFjMLrTMQ7OjYbCexU= X-Forefront-Antispam-Report-Untrusted: CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:DB9PR08MB7179.eurprd08.prod.outlook.com;PTR:;CAT:NONE;SFS:(13230031)(376005)(1800799015)(366007);DIR:OUT;SFP:1102; X-MS-Exchange-Transport-CrossTenantHeadersStamped: DB8PR08MB5452 X-EOPAttributedMessage: 0 X-MS-Exchange-Transport-CrossTenantHeadersStripped: DU2PEPF00028D0F.eurprd03.prod.outlook.com X-MS-PublicTrafficType: Email X-MS-Office365-Filtering-Correlation-Id: 6b8765b8-7fc8-4587-af68-08dc5580e1fb X-Microsoft-Antispam: BCL:0; X-Microsoft-Antispam-Message-Info: +FWIFzaprdoOrwAym9zr8R1ggxWb6F36vKpuzeh2a5wcS1/kDd+PwKCp87UkQMVeUGlrA1YoDDTE5mgKMurXMdli3Kc8R0vkjkK8l5/3BdrE7M86FtCMKhxyS8PFn558IzqFuStBNqoWtotN+M0PwBIJZPoRVhrwnSrBYx2JPfx04aCUxXr6XXLkcgQStR++9hB9//dpz0LjLqWiIasbwGbNIH08raIVfPuodqyOHKy+3wZM6B3VdlznR9LDAz7mJkOkU4zUZwxJVSnuFCRkuDg71R4109/zOGweHjalFviCArhm1+AmrquYYH1JirNdAmW24T3ySL627pqTLGoAEuO11RSRJ5d89pdjdvQ0kwzd0w4l9zfwkaWe8votOndCon1YR+NirjFAjT9aN/oyFP/rQo/5W5Cj9tHM+YGdR5sMUhTLBwVypw+LFSp/deN+zopyz0Y/P2xT1HGKRo2xusNj4RzvtgbLogQw0E8rC+BEhECyV148q33n22dsB6dWmW6F61e6L4Leohoc3vRZLflMhY9+OziryjSbF/mh2HLF35ez10gNZNMAW5TEljlrhW2AzaX9UA+lIWgAlZmMHvZHliBj+Xjs0TLWnujlp4Zf7AbhScC+jqGfozlpXBl0T7Rmwy8g7OjiupSUcUcrsZdb4baW/jMhxTPE+zMv4lK9coDoftRq8NqbYkRnw1xnaJUHofuS941X8Rxyc8fNieKnJ41z/joAynD2beCEF1wiCJL8SvuNcUFv/IuKZSn6 X-Forefront-Antispam-Report: CIP:63.35.35.123;CTRY:IE;LANG:en;SCL:1;SRV:;IPV:CAL;SFV:NSPM;H:64aa7808-outbound-1.mta.getcheckrecipient.com;PTR:ec2-63-35-35-123.eu-west-1.compute.amazonaws.com;CAT:NONE;SFS:(13230031)(82310400014)(36860700004)(376005)(1800799015);DIR:OUT;SFP:1101; X-OriginatorOrg: arm.com X-MS-Exchange-CrossTenant-OriginalArrivalTime: 05 Apr 2024 14:58:41.4998 (UTC) X-MS-Exchange-CrossTenant-Network-Message-Id: 6b8765b8-7fc8-4587-af68-08dc5580e1fb X-MS-Exchange-CrossTenant-Id: f34e5979-57d9-4aaa-ad4d-b122a662184d X-MS-Exchange-CrossTenant-OriginalAttributedTenantConnectingIp: TenantId=f34e5979-57d9-4aaa-ad4d-b122a662184d;Ip=[63.35.35.123];Helo=[64aa7808-outbound-1.mta.getcheckrecipient.com] X-MS-Exchange-CrossTenant-AuthSource: DU2PEPF00028D0F.eurprd03.prod.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Anonymous X-MS-Exchange-CrossTenant-FromEntityHeader: HybridOnPrem X-MS-Exchange-Transport-CrossTenantHeadersStamped: PAXPR08MB7318 X-Spam-Status: No, score=-11.4 required=5.0 tests=BAYES_00,DKIM_SIGNED,DKIM_VALID,FORGED_SPF_HELO,GIT_PATCH_0,KAM_DMARC_NONE,RCVD_IN_MSPIKE_H2,SPF_HELO_PASS,SPF_NONE,TXREP,UNPARSEABLE_RELAY autolearn=ham autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on server2.sourceware.org List-Id: The 04/05/2024 09:35, Adhemerval Zanella wrote: > Use the hidden alias instead. > > Checked on aarch64-linux-gnu. does this change behaviour in case __tls_get_addr is interposed? > --- > sysdeps/aarch64/dl-tlsdesc.S | 3 ++- > sysdeps/unix/sysv/linux/aarch64/localplt.data | 2 -- > 2 files changed, 2 insertions(+), 3 deletions(-) > > diff --git a/sysdeps/aarch64/dl-tlsdesc.S b/sysdeps/aarch64/dl-tlsdesc.S > index 9b253b39dd..4febf2ad21 100644 > --- a/sysdeps/aarch64/dl-tlsdesc.S > +++ b/sysdeps/aarch64/dl-tlsdesc.S > @@ -220,7 +220,7 @@ _dl_tlsdesc_dynamic: > SAVE_Q_REGISTERS > > mov x0, x1 > - bl __tls_get_addr > + bl HIDDEN_JUMPTARGET(__tls_get_addr) > > mrs x1, tpidr_el0 > sub PTR_REG (0), PTR_REG (0), PTR_REG (1) > @@ -246,5 +246,6 @@ _dl_tlsdesc_dynamic: > b 1b > cfi_endproc > .size _dl_tlsdesc_dynamic, .-_dl_tlsdesc_dynamic > + .hidden HIDDEN_JUMPTARGET(__tls_get_addr) > # undef NSAVEXREGPAIRS > #endif > diff --git a/sysdeps/unix/sysv/linux/aarch64/localplt.data b/sysdeps/unix/sysv/linux/aarch64/localplt.data > index 5d217cc50d..5dd07472df 100644 > --- a/sysdeps/unix/sysv/linux/aarch64/localplt.data > +++ b/sysdeps/unix/sysv/linux/aarch64/localplt.data > @@ -9,5 +9,3 @@ libm.so: matherr > # If outline atomics are used, libgcc (built outside of glibc) may > # call __getauxval using the PLT. > libc.so: __getauxval ? > -# The dynamic loader needs __tls_get_addr for TLS. > -ld.so: __tls_get_addr > -- > 2.34.1 >