From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from hall.aurel32.net (hall.aurel32.net [IPv6:2001:bc8:30d7:100::1]) by sourceware.org (Postfix) with ESMTPS id 32C403858C41 for ; Sat, 11 May 2024 09:59:07 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.4.2 sourceware.org 32C403858C41 Authentication-Results: sourceware.org; dmarc=pass (p=none dis=none) header.from=aurel32.net Authentication-Results: sourceware.org; spf=pass smtp.mailfrom=aurel32.net ARC-Filter: OpenARC Filter v1.0.0 sourceware.org 32C403858C41 Authentication-Results: server2.sourceware.org; arc=none smtp.remote-ip=2001:bc8:30d7:100::1 ARC-Seal: i=1; a=rsa-sha256; d=sourceware.org; s=key; t=1715421548; cv=none; b=qNX95kfuRKLM/jHJ60n8TycJYJmWE+cFkeU6RCBTXG9BF731Wr1lyjwlh6Wat0wMiA0Rz/7/Mu2eixUQa4NTHIDRcsxNZ1etOVfBQH38iCCE78Lj4Wi9Q546ZqkKbm7XONq8nVqbfjdVckELPfn3/ZSC+hP+qzBfwcCI56pNioM= ARC-Message-Signature: i=1; a=rsa-sha256; d=sourceware.org; s=key; t=1715421548; c=relaxed/simple; bh=HuM4Nc7H1p8GQf89VWHONpH9syc/t2C1as8dOAGtcC8=; h=DKIM-Signature:Date:From:To:Subject:Message-ID:MIME-Version; b=UVMqsaPhHASWNGSxTJSJd1ySWjy4JERZ3kVUeLm0vxrxyjc8fpV4WUcVWJ2ADkMObOQ93U1RuWc3b7iX6j5qCq6t+F5au7Pw+a7qLgQVAAdT0G90PnRSCxaXCP99S47iM50rdP5zgTg7ImUmHrvq9VSRg9SO96Y7OA9OZRsTtzg= ARC-Authentication-Results: i=1; server2.sourceware.org DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=aurel32.net ; s=202004.hall; h=In-Reply-To:Content-Type:MIME-Version:References: Message-ID:Subject:Cc:To:From:Date:Content-Transfer-Encoding:From:Reply-To: Subject:Content-ID:Content-Description:X-Debbugs-Cc; bh=cep5ycmva4cXAZuk5ff8MkOJYHLPmtMDbEhdZQzju4A=; b=qkEQk3uxJQK6W3b4UJe9cZ0jFH 3wEfJrtcYUoDerYBHQ92aAWsM2+eOIJJVNwwC251WbcdOkmoIRuXJF8WBaIEF+Dky2zYry0bO4fBo ZzBaBA1L8MsqF7u4QiB45fhvdK+1LqDUp/I1g5tZuPUwB8Xnt1TfZwisfH8Drx8HixtQp84Dnuu83 NDAOY4MCU7dh08f8WOmInd+WIMTS0UMWmBPCYce72nyv9GqQDODXTleUtZQT/GWyLg4uGvytNjje0 hbPH2mUasP6HvcsNykbSnnUGbcPNbmGF2+1C5odmb1aZif4/PEBGCXoPe8qVJZC93H9SFLnW9wZc6 WdFd+4Ow==; Received: from [2a01:e34:ec5d:a741:1ee1:92ff:feb4:5ec0] (helo=ohm.rr44.fr) by hall.aurel32.net with esmtpsa (TLS1.3) tls TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384 (Exim 4.96) (envelope-from ) id 1s5jVR-000kvs-1d; Sat, 11 May 2024 11:59:05 +0200 Date: Sat, 11 May 2024 11:59:05 +0200 From: Aurelien Jarno To: Adhemerval Zanella Cc: libc-alpha@sourceware.org, Joseph Myers , Florian Weimer , "H . J . Lu" Subject: Re: [PATCH v3 2/7] math: Fix i386 and m68k fmod/fmodf on static build (BZ 31488) Message-ID: Mail-Followup-To: Adhemerval Zanella , libc-alpha@sourceware.org, Joseph Myers , Florian Weimer , "H . J . Lu" References: <20240402140644.2172819-1-adhemerval.zanella@linaro.org> <20240402140644.2172819-3-adhemerval.zanella@linaro.org> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20240402140644.2172819-3-adhemerval.zanella@linaro.org> User-Agent: Mutt/2.2.12 (2023-09-09) X-Spam-Status: No, score=-6.9 required=5.0 tests=BAYES_00,DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,SPF_HELO_PASS,SPF_PASS,TXREP autolearn=ham autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on server2.sourceware.org List-Id: On 2024-04-02 11:06, Adhemerval Zanella wrote: > The commit 16439f419b removed the static fmod/fmodf on i386 and m68k > with and empty w_fmod.c (required for the ABIs that uses the newly > implementation). This patch fixes by adding the required symbols on > the arch-specific w_fmod{f}_compat.c implementation. > > To statically build fmod fails on some ABI (alpha, s390, sparc) because > it does not export the ldexpf128, this is also fixed by this patch. > > Checked on i686-linux-gnu and with a build for m68k-linux-gnu with > 'make test t=math/test-{float,double}-modf-static build-math-static-tests=yes'. > --- > sysdeps/i386/fpu/w_fmod_compat.c | 7 ++++--- > sysdeps/i386/fpu/w_fmodf_compat.c | 7 ++++--- > sysdeps/ieee754/ldbl-opt/s_ldexpl.c | 4 ++-- > sysdeps/m68k/m680x0/fpu/w_fmod_compat.c | 5 +++-- > sysdeps/m68k/m680x0/fpu/w_fmodf_compat.c | 7 ++++--- > 5 files changed, 17 insertions(+), 13 deletions(-) Reviewed-by: Aurelien Jarno Tested-by: Aurelien Jarno -- Aurelien Jarno GPG: 4096R/1DDD8C9B aurelien@aurel32.net http://aurel32.net