public inbox for libc-alpha@sourceware.org
 help / color / mirror / Atom feed
From: Jakub Jelinek <jakub@redhat.com>
To: Florian Weimer <fweimer@redhat.com>
Cc: libc-alpha@sourceware.org, Marek Polacek <polacek@redhat.com>,
	Sam James <sam@gentoo.org>
Subject: Re: [PATCH v2] socket: Use may_alias on sockaddr structs (bug 19622)
Date: Tue, 7 May 2024 21:57:31 +0200	[thread overview]
Message-ID: <ZjqHqxJli3q6jyXW@tucnak> (raw)
In-Reply-To: <87h6f95rfd.fsf@oldenburg.str.redhat.com>

On Tue, May 07, 2024 at 09:54:14PM +0200, Florian Weimer wrote:
> --- a/misc/sys/cdefs.h
> +++ b/misc/sys/cdefs.h
> @@ -874,4 +874,13 @@ _Static_assert (0, "IEEE 128-bits long double requires redirection on this platf
>  # define __attribute_returns_twice__ /* Ignore.  */
>  #endif
>  
> +/* Mark struct types as aliasable.  Restricted to compilers that
> +   support forward declarations of structs in the presence of the
> +   attribute.  */
> +#if __GNUC_PREREQ (7, 0) || defined __clang__

I'd use (7, 1) here, because pedantically there were some 7.0.0 snapshots
which didn't support it.
7.1.0 and later do support it though.

Otherwise LGTM.

Thanks.

	Jakub


      reply	other threads:[~2024-05-07 19:57 UTC|newest]

Thread overview: 2+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2024-05-07 19:54 Florian Weimer
2024-05-07 19:57 ` Jakub Jelinek [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=ZjqHqxJli3q6jyXW@tucnak \
    --to=jakub@redhat.com \
    --cc=fweimer@redhat.com \
    --cc=libc-alpha@sourceware.org \
    --cc=polacek@redhat.com \
    --cc=sam@gentoo.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).