* [PATCH] signal/Makefile: Split and sort tests
@ 2024-06-14 13:45 Michel Lind
2024-07-01 11:45 ` Arjun Shankar
0 siblings, 1 reply; 2+ messages in thread
From: Michel Lind @ 2024-06-14 13:45 UTC (permalink / raw)
To: libc-alpha; +Cc: Arjun Shankar
[-- Attachment #1.1: Type: text/plain, Size: 424 bytes --]
This will make it easier to add tests later; see also the test section
in malloc/Makefile that inspires this.
Signed-off-by: Michel Lind <salimma@fedoraproject.org>
Suggested-by: Arjun Shankar <arjun@redhat.com>
---
signal/Makefile | 21 ++++++++++++++++-----
1 file changed, 16 insertions(+), 5 deletions(-)
--
_o) Michel Lind
_( ) identities: https://keyoxide.org/5dce2e7e9c3b1cffd335c1d78b229d2f7ccc04f2
[-- Attachment #1.2: 0001-signal-Makefile-Split-and-sort-tests.patch --]
[-- Type: text/plain, Size: 1507 bytes --]
From e6d37f761df90d97fa9ae7ffa629fa91ca0ee072 Mon Sep 17 00:00:00 2001
From: Michel Lind <salimma@fedoraproject.org>
Date: Fri, 14 Jun 2024 15:38:08 +0200
Subject: [PATCH 1/1] signal/Makefile: Split and sort tests
To: libc-alpha@sourceware.org
Cc: arjun@redhat.com
This will make it easier to add tests later; see also the test section
in malloc/Makefile that inspires this.
Signed-off-by: Michel Lind <salimma@fedoraproject.org>
Suggested-by: Arjun Shankar <arjun@redhat.com>
---
signal/Makefile | 21 ++++++++++++++++-----
1 file changed, 16 insertions(+), 5 deletions(-)
diff --git a/signal/Makefile b/signal/Makefile
index e8e3dce0cf..7cddbc3c65 100644
--- a/signal/Makefile
+++ b/signal/Makefile
@@ -46,11 +46,22 @@ routines := signal raise killpg \
allocrtsig sigtimedwait sigwaitinfo sigqueue \
sighold sigrelse sigignore sigset
-tests := tst-signal tst-sigset tst-sigsimple tst-raise tst-sigset2 \
- tst-sigwait-eintr tst-sigaction \
- tst-minsigstksz-1 tst-minsigstksz-2 tst-minsigstksz-3 \
- tst-minsigstksz-3a tst-minsigstksz-4 tst-minsigstksz-5 \
- tst-sigisemptyset
+tests := \
+ tst-minsigstksz-1 \
+ tst-minsigstksz-2 \
+ tst-minsigstksz-3 \
+ tst-minsigstksz-3a \
+ tst-minsigstksz-4 \
+ tst-minsigstksz-5 \
+ tst-raise \
+ tst-sigaction \
+ tst-sigisemptyset \
+ tst-signal \
+ tst-sigset \
+ tst-sigset2 \
+ tst-sigsimple \
+ tst-sigwait-eintr \
+# tests
include ../Rules
--
2.45.2
[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 228 bytes --]
^ permalink raw reply [flat|nested] 2+ messages in thread
* Re: [PATCH] signal/Makefile: Split and sort tests
2024-06-14 13:45 [PATCH] signal/Makefile: Split and sort tests Michel Lind
@ 2024-07-01 11:45 ` Arjun Shankar
0 siblings, 0 replies; 2+ messages in thread
From: Arjun Shankar @ 2024-07-01 11:45 UTC (permalink / raw)
To: Michel Lind; +Cc: libc-alpha
Hi Michel,
Thanks for the patch! This looks good to me.
Reviewed-by: Arjun Shankar <arjun@redhat.com>
I'll push it in a bit.
> From e6d37f761df90d97fa9ae7ffa629fa91ca0ee072 Mon Sep 17 00:00:00 2001
> From: Michel Lind <salimma@fedoraproject.org>
> Date: Fri, 14 Jun 2024 15:38:08 +0200
> Subject: [PATCH 1/1] signal/Makefile: Split and sort tests
> To: libc-alpha@sourceware.org
> Cc: arjun@redhat.com
>
> This will make it easier to add tests later; see also the test section
> in malloc/Makefile that inspires this.
>
> Signed-off-by: Michel Lind <salimma@fedoraproject.org>
> Suggested-by: Arjun Shankar <arjun@redhat.com>
OK.
> diff --git a/signal/Makefile b/signal/Makefile
> index e8e3dce0cf..7cddbc3c65 100644
> --- a/signal/Makefile
> +++ b/signal/Makefile
> @@ -46,11 +46,22 @@ routines := signal raise killpg \
> allocrtsig sigtimedwait sigwaitinfo sigqueue \
> sighold sigrelse sigignore sigset
>
> -tests := tst-signal tst-sigset tst-sigsimple tst-raise tst-sigset2 \
> - tst-sigwait-eintr tst-sigaction \
> - tst-minsigstksz-1 tst-minsigstksz-2 tst-minsigstksz-3 \
> - tst-minsigstksz-3a tst-minsigstksz-4 tst-minsigstksz-5 \
> - tst-sigisemptyset
> +tests := \
> + tst-minsigstksz-1 \
> + tst-minsigstksz-2 \
> + tst-minsigstksz-3 \
> + tst-minsigstksz-3a \
> + tst-minsigstksz-4 \
> + tst-minsigstksz-5 \
> + tst-raise \
> + tst-sigaction \
> + tst-sigisemptyset \
> + tst-signal \
> + tst-sigset \
> + tst-sigset2 \
> + tst-sigsimple \
> + tst-sigwait-eintr \
> +# tests
OK.
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2024-07-01 11:45 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2024-06-14 13:45 [PATCH] signal/Makefile: Split and sort tests Michel Lind
2024-07-01 11:45 ` Arjun Shankar
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).