From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mail-oa1-x30.google.com (mail-oa1-x30.google.com [IPv6:2001:4860:4864:20::30]) by sourceware.org (Postfix) with ESMTPS id EF9773858D3C for ; Mon, 16 May 2022 18:49:31 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.4.1 sourceware.org EF9773858D3C Received: by mail-oa1-x30.google.com with SMTP id 586e51a60fabf-f16a3e0529so11030504fac.2 for ; Mon, 16 May 2022 11:49:31 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=x-gm-message-state:message-id:date:mime-version:user-agent:subject :content-language:to:references:from:in-reply-to :content-transfer-encoding; bh=b2RJ90WFJZ5T1TwZLUurA8whNoQp2VGKQuJUSqjpUtQ=; b=l+fX5DbjePnmPzStUqYGd3sBksG1o1sRyo5tUG6d8kskxTgl5C9nKjHam7dD4sv3+6 PBHlfVg+LI15/LBB/dH5GXKWpBabRVJKuD9nCmDyt/V3GQzi9hepow5kBz0zLJUc0RF3 E5NPPH2rnMgiMx6Vh54nGQIVbk9q4k2J0GyBtZokqtVipxzTtEoROvagepsVrHLbFbUT dRHi0k/sTkpvb/NrE5g6+eKEjK11LahwpnPVWJl4e+0EgN0DWTMyNbwKwg1l6AMsR+Y2 E1S+XB7GF/+Rm6mraGK5/CYLMj2swmWb9Hqf236Pv1ABgeM5b6Z6fZA0IvEfitkxLcID 2mqw== X-Gm-Message-State: AOAM532p+5jme6mg1/tr/e6PDu13xLwNuBfOVQhjaAf8mdX6h+/N1f9z QjutCRcFHfQNmbJk2avcxFWK3rT+vwSq7g== X-Google-Smtp-Source: ABdhPJw9xYXf9eMw71gSIPXw2lYvkFbPn5We0WQXAdqM26bfzZzS3hUagqFElp13eEeOqDJEVIzOrA== X-Received: by 2002:a05:6871:887:b0:f1:8dac:ef40 with SMTP id r7-20020a056871088700b000f18dacef40mr5128916oaq.48.1652726970942; Mon, 16 May 2022 11:49:30 -0700 (PDT) Received: from ?IPV6:2804:431:c7cb:cdd6:545a:8832:b9c2:3a47? ([2804:431:c7cb:cdd6:545a:8832:b9c2:3a47]) by smtp.gmail.com with ESMTPSA id y195-20020aca4bcc000000b0032617532120sm4099903oia.48.2022.05.16.11.49.29 for (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Mon, 16 May 2022 11:49:30 -0700 (PDT) Message-ID: Date: Mon, 16 May 2022 15:49:28 -0300 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:91.0) Gecko/20100101 Thunderbird/91.9.0 Subject: Re: [PATCH v4 09/13] LoongArch: Linux ABI Content-Language: en-US To: libc-alpha@sourceware.org References: <20220509022611.1248063-1-caiyinyu@loongson.cn> <20220509022611.1248063-10-caiyinyu@loongson.cn> From: Adhemerval Zanella In-Reply-To: Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit X-Spam-Status: No, score=-5.1 required=5.0 tests=BAYES_00, BODY_8BITS, DKIM_SIGNED, DKIM_VALID, DKIM_VALID_AU, DKIM_VALID_EF, NICE_REPLY_A, RCVD_IN_DNSWL_NONE, SPF_HELO_NONE, SPF_PASS, TXREP, T_SCC_BODY_TEXT_LINE autolearn=ham autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on server2.sourceware.org X-BeenThere: libc-alpha@sourceware.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Libc-alpha mailing list List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Mon, 16 May 2022 18:49:33 -0000 On 15/05/2022 00:32, caiyinyu wrote: > > 在 2022/5/11 下午3:08, Arnd Bergmann 写道: >> On Mon, May 9, 2022 at 4:26 AM caiyinyu wrote: >>> + >>> +#include >>> + >>> +/* In 64-bit ISA files are always with 64bit off_t and F_*LK64 are the same as >>> +   non-64-bit versions.  It will need to be revised for 128-bit.  */ >>> +#if __WORDSIZE == 64 >>> +#define __O_LARGEFILE 0 >>> + >>> +#define F_GETLK64 5  /* Get record locking info.  */ >>> +#define F_SETLK64 6  /* Set record locking info (non-blocking).  */ >>> +#define F_SETLKW64 7 /* Set record locking info (blocking).  */ >>> +#endif >>> + >>> +struct flock >>> +{ >>> +  short int l_type;   /* Type of lock: F_RDLCK, F_WRLCK, or F_UNLCK.  */ >>> +  short int l_whence; /* Where `l_start' is relative to (like `lseek').  */ >>> +#ifndef __USE_FILE_OFFSET64 >>> +  __off_t l_start; /* Offset where the lock begins.  */ >>> +  __off_t l_len;   /* Size of the locked area; zero means until EOF.  */ >>> +#else >>> +  __off64_t l_start; /* Offset where the lock begins.  */ >>> +  __off64_t l_len;   /* Size of the locked area; zero means until EOF.  */ >>> +#endif >>> +  __pid_t l_pid; /* Process holding the lock.  */ >>> +}; >>> + >>> +#ifdef __USE_LARGEFILE64 >>> +struct flock64 >>> +{ >>> +  short int l_type;   /* Type of lock: F_RDLCK, F_WRLCK, or F_UNLCK.  */ >>> +  short int l_whence; /* Where `l_start' is relative to (like `lseek').  */ >>> +  __off64_t l_start;  /* Offset where the lock begins.  */ >>> +  __off64_t l_len;    /* Size of the locked area; zero means until EOF.  */ >>> +  __pid_t l_pid;      /* Process holding the lock.  */ >>> +}; >>> +#endif >> Not sure why these are provided here, the kernel has no loongarch64 specific >> interface for flock in the current version, so either this refers to >> an older version >> of the kernel port, or it is something that could be generalized into an >> architecture-independent file in glibc. >> >>          Arnd > > > There are struct flock and flock64 we need in glibc bits/fcntl.h, but > the macro F_GETLK64 F_SETLK64 F_SETLKW64 in > sysdeps/unix/sysv/linux/bits/fcntl-linux.h are: > > ... > # define F_GETLK64      12      /* Get record locking info.  */ > # define F_SETLK64      13      /* Set record locking info (non-blocking).  */ > # define F_SETLKW64     14      /* Set record locking info (blocking).  */ > ... > > what we need: > > +#define F_GETLK64 5  /* Get record locking info.  */ > +#define F_SETLK64 6  /* Set record locking info (non-blocking). */ > +#define F_SETLKW64 7 /* Set record locking info (blocking).  */ > > x86 ia64 s390 and aarch64 have the same problem and they all use their own fcntl.h. > > Define new value of these macro in sysdeps/unix/sysv/linux/bits/fcntl-linux.h or > add fcntl-linux.h in loongarch port or keep the status quo?? Ideally I would like to have sysdeps/unix/sysv/linux/bits/fcntl.h with the common fcntl.h definitions (including flock/flock64 definitions) and move any arch-specific bits to sysdeps/unix/sysv/linux//bits/fcntl-arch.h and have a generic fcntl-arch.h with current linux UAPI definition (so newer ports won't need to add anything, assuming its uses the expected Linux definitions). It would require to change some non loongarch code, so I don't expect you do push for this to get the loongarch code. Having a loonarch fcntl.h should be fine for now.