From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mail-oi1-x22c.google.com (mail-oi1-x22c.google.com [IPv6:2607:f8b0:4864:20::22c]) by sourceware.org (Postfix) with ESMTPS id 168C23851160 for ; Wed, 8 Mar 2023 15:19:39 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.4.2 sourceware.org 168C23851160 Authentication-Results: sourceware.org; dmarc=pass (p=none dis=none) header.from=linaro.org Authentication-Results: sourceware.org; spf=pass smtp.mailfrom=linaro.org Received: by mail-oi1-x22c.google.com with SMTP id bm20so12410115oib.7 for ; Wed, 08 Mar 2023 07:19:39 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; t=1678288778; h=content-transfer-encoding:in-reply-to:organization:from:references :to:content-language:subject:user-agent:mime-version:date:message-id :from:to:cc:subject:date:message-id:reply-to; bh=Va3LbBXPps6CktoLwqQBGToo1gFTTSby5P+Viw/FODs=; b=RCFc/56Bg9ECvXXDwrRUfC5ZMGsP3FyP7WPSQ1UHj6TsybkzCKkAydBAQssxJZXATL YjcsOOladx0RDRdr0qRAjpGPxNOvizw1RNXGYQTKlAt9CpcFzt3qyY+GciOmAuMkS29B 2IusdxWOhrshzvAPfPW5l4J4AKl7jMJQlQKPiOMutlSv4qmbIGa7cn9TgPuImjGLpnDI BnktetJsX6ySrMDLVxQm1zjkxo3T4ccLCEoHHg7cyRsEPr/su8eiD4LxlW8xT6NlLeSQ 0Yvoj16yzy3aNVX1OeOX4dZ6cVzjoLkTAEj+H6rWJK0shIo/f5r0DbeQVr96MJIds3Hv rVng== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; t=1678288778; h=content-transfer-encoding:in-reply-to:organization:from:references :to:content-language:subject:user-agent:mime-version:date:message-id :x-gm-message-state:from:to:cc:subject:date:message-id:reply-to; bh=Va3LbBXPps6CktoLwqQBGToo1gFTTSby5P+Viw/FODs=; b=H6P2BqofysjbUlHpM7MeYu2b2SYqeYdayqtkaEsZX3RE0Paeo0kvbhwX4fyLeg14gt c7/pmimaM5Glai3t4xdvugWha7VLU2Zq4fII0OzDQZgDaXysAp7ItXrkaXgLllwAglDE i/rehgcqCtbuDL+SDGs22E5Lyow+gOQj/J2ExZRLXUpf2K6gi8Zi5exLyZF7p+ykIzz0 xn8y8sn3ygYgq1PP+dGZdUrkBiJQOS4BTFwEylakzYlm893PA0vqHTsfV1fzGjB03kkl 556oNAQAKMYcTV5R/BasxghmnNH5IuKWn+EUfK8bgftBOEjVaXyIxXC3C1Y122s49SAP C7+w== X-Gm-Message-State: AO0yUKWqY36rCONoOxw0EuLqMcS/y76xwry3uvDLpdAUpW/0B+seVh9+ G0DQJp5TKxduuSOFJPL5jmzswbY/nQddLjIMuL7mbw== X-Google-Smtp-Source: AK7set9ASe4B/TWPVO2gPaJ+4Rd8Hj3Ep7GuyfRjsTMPvleUmB/WFPjUUZANB8v2MJqG8cQNxnUzdQ== X-Received: by 2002:a05:6808:b:b0:384:356a:a260 with SMTP id u11-20020a056808000b00b00384356aa260mr8124753oic.57.1678288778320; Wed, 08 Mar 2023 07:19:38 -0800 (PST) Received: from ?IPV6:2804:1b3:a7c0:544b:655d:5559:758d:90f7? ([2804:1b3:a7c0:544b:655d:5559:758d:90f7]) by smtp.gmail.com with ESMTPSA id y205-20020aca32d6000000b00383eaf88e75sm6451605oiy.39.2023.03.08.07.19.36 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Wed, 08 Mar 2023 07:19:37 -0800 (PST) Message-ID: Date: Wed, 8 Mar 2023 12:19:35 -0300 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (Macintosh; Intel Mac OS X 10.15; rv:102.0) Gecko/20100101 Thunderbird/102.8.0 Subject: Re: [PATCH] Benchtests: Remove simple_strcpy_chk Content-Language: en-US To: Wilco Dijkstra , 'GNU C Library' References: From: Adhemerval Zanella Netto Organization: Linaro In-Reply-To: Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 7bit X-Spam-Status: No, score=-12.5 required=5.0 tests=BAYES_00,DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,GIT_PATCH_0,NICE_REPLY_A,RCVD_IN_DNSWL_NONE,SPF_HELO_NONE,SPF_PASS,TXREP autolearn=ham autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on server2.sourceware.org List-Id: On 08/03/23 07:53, Wilco Dijkstra via Libc-alpha wrote: > > Remove the slow byte oriented simple_strcpy_chk and simple_stpcpy_chk. > Adjust iteration count to increase benchmark time. LGTM, thanks. Reviewed-by: Adhemerval Zanella > > --- > > diff --git a/benchtests/bench-stpcpy_chk.c b/benchtests/bench-stpcpy_chk.c > index aaacd336bad6e5f5f4f420773480749ed05ee9ac..85d5a5e9240110533ca7b25103c2e5e64bc0e948 100644 > --- a/benchtests/bench-stpcpy_chk.c > +++ b/benchtests/bench-stpcpy_chk.c > @@ -22,24 +22,11 @@ > #include "bench-string.h" > > extern void __attribute__ ((noreturn)) __chk_fail (void); > -char *simple_stpcpy_chk (char *, const char *, size_t); > extern char *normal_stpcpy (char *, const char *, size_t) > __asm ("stpcpy"); > extern char *__stpcpy_chk (char *, const char *, size_t); > > -IMPL (simple_stpcpy_chk, 0) > IMPL (normal_stpcpy, 1) > IMPL (__stpcpy_chk, 2) > > -char * > -simple_stpcpy_chk (char *dst, const char *src, size_t len) > -{ > - if (! len) > - __chk_fail (); > - while ((*dst++ = *src++) != '\0') > - if (--len == 0) > - __chk_fail (); > - return dst - 1; > -} > - > #include "bench-strcpy_chk.c" > diff --git a/benchtests/bench-strcpy_chk.c b/benchtests/bench-strcpy_chk.c > index 6fce90cc9879d7b9bdc5b13a84eaaaadbde97a5b..48ecaaf392201cbce41a6f1520c630d68b59aacb 100644 > --- a/benchtests/bench-strcpy_chk.c > +++ b/benchtests/bench-strcpy_chk.c > @@ -26,26 +26,13 @@ > symbol, which is part of the public ABI and may be used > externally. */ > extern void __attribute__ ((noreturn)) __chk_fail (void); > -char *simple_strcpy_chk (char *, const char *, size_t); > extern char *normal_strcpy (char *, const char *, size_t) > __asm ("strcpy"); > extern char *__strcpy_chk (char *, const char *, size_t); > > -IMPL (simple_strcpy_chk, 0) > IMPL (normal_strcpy, 1) > IMPL (__strcpy_chk, 2) > > -char * > -simple_strcpy_chk (char *dst, const char *src, size_t len) > -{ > - char *ret = dst; > - if (! len) > - __chk_fail (); > - while ((*dst++ = *src++) != '\0') > - if (--len == 0) > - __chk_fail (); > - return ret; > -} > #endif > > #include > @@ -77,7 +64,7 @@ do_one_test (impl_t *impl, char *dst, const char *src, > size_t len, size_t dlen) > { > char *res; > - size_t i, iters = INNER_LOOP_ITERS8; > + size_t i, iters = INNER_LOOP_ITERS_LARGE; > timing_t start, stop, cur; > > if (dlen <= len) >