From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from black.elm.relay.mailchannels.net (black.elm.relay.mailchannels.net [23.83.212.19]) by sourceware.org (Postfix) with ESMTPS id 53B323858C53 for ; Wed, 26 Apr 2023 12:17:04 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.4.2 sourceware.org 53B323858C53 Authentication-Results: sourceware.org; dmarc=none (p=none dis=none) header.from=gotplt.org Authentication-Results: sourceware.org; spf=pass smtp.mailfrom=gotplt.org X-Sender-Id: dreamhost|x-authsender|siddhesh@gotplt.org Received: from relay.mailchannels.net (localhost [127.0.0.1]) by relay.mailchannels.net (Postfix) with ESMTP id 7F81C760E30; Wed, 26 Apr 2023 12:17:02 +0000 (UTC) Received: from pdx1-sub0-mail-a304.dreamhost.com (unknown [127.0.0.6]) (Authenticated sender: dreamhost) by relay.mailchannels.net (Postfix) with ESMTPA id 0E6F1760B7F; Wed, 26 Apr 2023 12:17:02 +0000 (UTC) ARC-Seal: i=1; s=arc-2022; d=mailchannels.net; t=1682511422; a=rsa-sha256; cv=none; b=f0KvrMoabdmoJ3/u8ZpkWFUrIMEbJMeuim+tJ8i4PMl3Xukj3ZTIfp/7YeAxxRKKgokLAE F51DlYPN2BnVm3IOvdbJnoV/ooBDveddHrwWQnaepaECf4uplBI5ttHUTRDrKjFvFqymmT 72BNw9mgvvtYIS5dM632jV3NfxIoIZKWmxcYJVO+aLXe3D1r2O/gi8aF8V/j5fTrt++r62 +6s98uwr9/0BdAdEQ8AcHjPqKOENJvYOikjgPbrcIRaAqHOSkjE4eTb/VmPyE/FNeAJdSp jNaQdBCpcCq1J3JhGnjQHH3vHxQL/lwkYZzEKE5PErXIJQvYild/ZT0GZaObqg== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=mailchannels.net; s=arc-2022; t=1682511422; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=T/fJoDSBhHs4GScUPnAcddWk+7iiwOeuVl0GwN9UO+I=; b=tWy5OiWiYQJJ2Ahglhs4WlqXIdXIcsHuNCsAkm97uza4o/D+1uW1sONZRcqkwSzS9xZ19n T6ZF6HnYJY0lUnG1CTnEvMpS4HjZdNh8wPNhwVo9/BjSb/282f6rfu8aA8nd8rUtLY4W5n tJKkXnVSpWK1Wv746PDWvHHAs+RahdcuG0SmXURBBGENjOoAtM3KAKtRTrNMt+25qvBPRI xOSZctrtQvgXkCMqi+TurGEt1pN2VdktB1b0w+OCtq+HfwLJd3jnQh1OrF5ePTyBPojCtN k89lOH/F5JpZ7bkJzLcA3yOMZa2Kr8ustpsclLGkNzeHDFMBrcXU7leQNHdk4Q== ARC-Authentication-Results: i=1; rspamd-7f66b7b68c-pvrlf; auth=pass smtp.auth=dreamhost smtp.mailfrom=siddhesh@gotplt.org X-Sender-Id: dreamhost|x-authsender|siddhesh@gotplt.org X-MC-Relay: Neutral X-MailChannels-SenderId: dreamhost|x-authsender|siddhesh@gotplt.org X-MailChannels-Auth-Id: dreamhost X-Stop-Lettuce: 7be546174c2350d0_1682511422289_2772000542 X-MC-Loop-Signature: 1682511422289:76954520 X-MC-Ingress-Time: 1682511422288 Received: from pdx1-sub0-mail-a304.dreamhost.com (pop.dreamhost.com [64.90.62.162]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384) by 100.116.217.236 (trex/6.7.2); Wed, 26 Apr 2023 12:17:02 +0000 Received: from [192.168.0.182] (bras-vprn-toroon4834w-lp130-09-174-91-45-80.dsl.bell.ca [174.91.45.80]) (using TLSv1.3 with cipher TLS_AES_128_GCM_SHA256 (128/128 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits)) (No client certificate requested) (Authenticated sender: siddhesh@gotplt.org) by pdx1-sub0-mail-a304.dreamhost.com (Postfix) with ESMTPSA id 4Q5yXs3VjlzL9; Wed, 26 Apr 2023 05:17:01 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gotplt.org; s=dreamhost; t=1682511421; bh=T/fJoDSBhHs4GScUPnAcddWk+7iiwOeuVl0GwN9UO+I=; h=Date:Subject:From:To:Content-Type:Content-Transfer-Encoding; b=VK0y2FzZY1VNDdULGNT3FQ8xWf+C9nY9vr29bxG/GcYmZKQE2sJNzdO6tZ8sJS+hn XMFEJ3Tuo/7Wy0ZDO67+avYVXBX71WgsCIGRMSlqD6EfcEaTyDUCgAjS1wjjdKxh6w ER3pL1QYnYsLdqPDBF8uAHvu5dlGvwv27mLMMmZw07htYRPUxvzigHEJAWKqOHrgGU O0Wf7vguioiWpEy4VsDEzPVt9LxnEs9+eLWBJ8ZkJagk7sqgAEIQMBXHNZhTNx2WE9 IVpiELcm643YRnRBN8V1LXMa1/9Eowd9WiAjPmlxgy6OW47iS6qIKS/G1fVOhcOyOc AuaDnIfqf2Ncg== Message-ID: Date: Wed, 26 Apr 2023 08:17:00 -0400 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:102.0) Gecko/20100101 Thunderbird/102.10.0 Subject: Re: [PATCH] locale/programs/locarchive.c: Remove unnecessary check in add_locale_archive Content-Language: en-US From: Siddhesh Poyarekar To: =?UTF-8?B?RnLDqWTDqXJpYyBCw6lyYXQ=?= , libc-alpha@sourceware.org References: <20230426121033.921725-1-fberat@redhat.com> <2165c42e-f316-eae8-d26c-87b11ec071fd@gotplt.org> In-Reply-To: <2165c42e-f316-eae8-d26c-87b11ec071fd@gotplt.org> Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 8bit X-Spam-Status: No, score=-3036.4 required=5.0 tests=BAYES_00,BODY_8BITS,DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,GIT_PATCH_0,NICE_REPLY_A,RCVD_IN_DNSWL_NONE,RCVD_IN_MSPIKE_H2,SPF_HELO_NONE,SPF_PASS,TXREP,T_SCC_BODY_TEXT_LINE autolearn=ham autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on server2.sourceware.org List-Id: On 2023-04-26 08:12, Siddhesh Poyarekar wrote: > On 2023-04-26 08:10, Frédéric Bérat wrote: >> Since asprintf is called "if (mask & XPG_NORM_CODESET)" there is no point >> in checking the mask again within the asprintf call. >> --- > > LGTM. > > Reviewed-by: Siddhesh Poyarekar Sorry, it doesn't apply, like you mentioned to me off-list. Please send a v2. Thanks, Sid >>   locale/programs/locarchive.c | 2 +- >>   1 file changed, 1 insertion(+), 1 deletion(-) >> >> diff --git a/locale/programs/locarchive.c b/locale/programs/locarchive.c >> index f8c6f79afa..71fd9f34fa 100644 >> --- a/locale/programs/locarchive.c >> +++ b/locale/programs/locarchive.c >> @@ -1156,7 +1156,7 @@ add_locale_to_archive (struct locarhandle *ah, >> const char *name, >>          We will store it in the archive with a normalized name.  */ >>       if (asprintf (&normalized_name, "%s%s%s.%s%s%s", >>             language, territory == NULL ? "" : "_", territory ?: "", >> -          (mask & XPG_NORM_CODESET) ? normalized_codeset : codeset, >> +          normalized_codeset, >>             modifier == NULL ? "" : "@", modifier ?: "") < 0) >>         { >>       free ((char *) normalized_codeset); >