public inbox for libc-alpha@sourceware.org
 help / color / mirror / Atom feed
From: Florian Weimer <fweimer@redhat.com>
To: Christian Brauner <christian.brauner@ubuntu.com>,
	libc-alpha@sourceware.org, stgraber@stgraber.org,
	serge@hallyn.com
Subject: Re: [PATCH 1/2] openpty: close slave pty fd on error
Date: Tue, 29 Aug 2017 09:07:00 -0000	[thread overview]
Message-ID: <a05d5603-c074-966d-f75e-cb268d0dc249@redhat.com> (raw)
In-Reply-To: <20170826134449.26527-1-christian.brauner@ubuntu.com>

On 08/26/2017 03:44 PM, Christian Brauner wrote:
>   fail:
>    close (master);
> +  if (slave != -1)
> +    close(slave);
>    return -1;

This is inconsistent with how the code frees buf if there is an error:
For buf, the free operation happens before the fail tail.  I think we
should keep this consistent: either free exactly what is needed, or have
a single function exit which checks for initialization and frees what
has been allocated.

Thanks,
Florian

  parent reply	other threads:[~2017-08-29  9:07 UTC|newest]

Thread overview: 18+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2017-08-26 14:21 Christian Brauner
2017-08-26 14:21 ` [PATCH 2/2] openpty: use TIOCGPTPEER to open slave side fd Christian Brauner
2017-08-28  7:34   ` Florian Weimer
2017-08-28 11:14     ` Christian Brauner
2017-08-28 11:39     ` Joseph Myers
2017-08-28 12:11     ` [PATCH 2/2 v2] " Christian Brauner
2017-08-28 12:22       ` Joseph Myers
2017-08-28 12:34       ` Andreas Schwab
2017-08-28 12:51         ` [PATCH 2/2 v3] " Christian Brauner
2017-08-29  9:07 ` Florian Weimer [this message]
2017-08-29 13:46   ` [PATCH 1/2 v4] openpty: close slave pty fd on error Christian Brauner
2017-08-29 13:46     ` [PATCH 2/2 v4] openpty: use TIOCGPTPEER to open slave side fd Christian Brauner
2017-08-29 14:00     ` [PATCH 1/2 v4] openpty: close slave pty fd on error Andreas Schwab
2017-08-29 14:12       ` Christian Brauner
2017-08-29 14:31       ` [PATCH 1/2 v5] " Christian Brauner
2017-08-29 14:31         ` [PATCH 2/2 v5] openpty: use TIOCGPTPEER to open slave side fd Christian Brauner
2017-09-10 17:45         ` [PATCH 1/2 v5] openpty: close slave pty fd on error Christian Brauner
2017-09-20 10:53           ` Christian Brauner

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=a05d5603-c074-966d-f75e-cb268d0dc249@redhat.com \
    --to=fweimer@redhat.com \
    --cc=christian.brauner@ubuntu.com \
    --cc=libc-alpha@sourceware.org \
    --cc=serge@hallyn.com \
    --cc=stgraber@stgraber.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).