From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mail-oi1-x232.google.com (mail-oi1-x232.google.com [IPv6:2607:f8b0:4864:20::232]) by sourceware.org (Postfix) with ESMTPS id 9A28E3858D3C for ; Tue, 8 Feb 2022 22:56:32 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.4.1 sourceware.org 9A28E3858D3C Received: by mail-oi1-x232.google.com with SMTP id ay7so665194oib.8 for ; Tue, 08 Feb 2022 14:56:32 -0800 (PST) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=x-gm-message-state:message-id:date:mime-version:user-agent:subject :content-language:to:references:from:in-reply-to :content-transfer-encoding; bh=aAuPQ5gyoz+sp9GmxnEXVhwjmEqDFJZ/gwL7cNvQrrY=; b=W7IV0SdthrppUQ2U4zaIW4ktJzDpzafzXPzNJVmBvm87xwBUmVm7jy3+2qsceG8MI6 aAYC5h60mV4hcQt88gXEuZRLp2nA28FXTJ1Gb71DqrlfOQW5f1USdf9DdQTLAL6YSpFj HStHPBvg7mByp/8M3Xs7JUvgPK+pVniD84UcGqSOK+pjBDLtfHNVQnX9NE2hBz/maDJ8 8kGj+1imQmDqaD4gmXwJnxV+xQP6YoIgZcjgoKblcqTuJMv/qvdWt/ZAdLkvRu6iu3/M tCh5qXfJ9WYbrZ4pHrHUWPCLm3bEVUQqbRQ1jmdPaawLhWGM1ywFYCXIalNilbjNptrH FJBA== X-Gm-Message-State: AOAM530aYvIN3uvrfiTwzCbAIMTSR0rYJQOKlZZKWfChOkX8Yrac88re eEPDaLNbCvyYjHTp7ucLHJ8nrg== X-Google-Smtp-Source: ABdhPJyr7FBObag1lLoKPg7lMt1QZJqbur1JlVXWOsSv2ldSNcra/D5PyW6q7wbeIMR9ULIVfOAl9A== X-Received: by 2002:a05:6808:651:: with SMTP id z17mr108598oih.100.1644360991863; Tue, 08 Feb 2022 14:56:31 -0800 (PST) Received: from ?IPV6:2804:431:c7ca:733:86a9:ad5:adef:2f3e? ([2804:431:c7ca:733:86a9:ad5:adef:2f3e]) by smtp.gmail.com with ESMTPSA id r186sm6049914oie.23.2022.02.08.14.56.30 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Tue, 08 Feb 2022 14:56:31 -0800 (PST) Message-ID: Date: Tue, 8 Feb 2022 19:56:29 -0300 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:91.0) Gecko/20100101 Thunderbird/91.6.0 Subject: Re: [PATCH] elf: Fix DFS sorting algorithm for LD_TRACE_LOADED_OBJECTS with missing libraries (BZ #28868) Content-Language: en-US To: "Dmitry V. Levin" , libc-alpha@sourceware.org References: <20220208183639.2262680-1-adhemerval.zanella@linaro.org> <20220208224838.GB21338@altlinux.org> From: Adhemerval Zanella In-Reply-To: <20220208224838.GB21338@altlinux.org> Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 7bit X-Spam-Status: No, score=-12.9 required=5.0 tests=BAYES_00, DKIM_SIGNED, DKIM_VALID, DKIM_VALID_AU, DKIM_VALID_EF, GIT_PATCH_0, NICE_REPLY_A, RCVD_IN_DNSWL_NONE, SPF_HELO_NONE, SPF_PASS, TXREP, T_SCC_BODY_TEXT_LINE autolearn=ham autolearn_force=no version=3.4.4 X-Spam-Checker-Version: SpamAssassin 3.4.4 (2020-01-24) on server2.sourceware.org X-BeenThere: libc-alpha@sourceware.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Libc-alpha mailing list List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Tue, 08 Feb 2022 22:56:34 -0000 On 08/02/2022 19:48, Dmitry V. Levin wrote: > On Tue, Feb 08, 2022 at 03:36:39PM -0300, Adhemerval Zanella via Libc-alpha wrote: > [...] >> diff --git a/elf/libtracemod1.c b/elf/libtracemod1.c >> new file mode 100644 >> index 0000000000..7c89c9a5a4 >> --- /dev/null >> +++ b/elf/libtracemod1.c >> @@ -0,0 +1 @@ >> +/* Empty */ >> diff --git a/elf/libtracemod2.c b/elf/libtracemod2.c >> new file mode 100644 >> index 0000000000..7c89c9a5a4 >> --- /dev/null >> +++ b/elf/libtracemod2.c >> @@ -0,0 +1 @@ >> +/* Empty */ >> diff --git a/elf/libtracemod3.c b/elf/libtracemod3.c >> new file mode 100644 >> index 0000000000..7c89c9a5a4 >> --- /dev/null >> +++ b/elf/libtracemod3.c >> @@ -0,0 +1 @@ >> +/* Empty */ >> diff --git a/elf/libtracemod4.c b/elf/libtracemod4.c >> new file mode 100644 >> index 0000000000..7c89c9a5a4 >> --- /dev/null >> +++ b/elf/libtracemod4.c >> @@ -0,0 +1 @@ >> +/* Empty */ >> diff --git a/elf/libtracemod5.c b/elf/libtracemod5.c >> new file mode 100644 >> index 0000000000..7c89c9a5a4 >> --- /dev/null >> +++ b/elf/libtracemod5.c >> @@ -0,0 +1 @@ >> +/* Empty */ >> diff --git a/elf/libtracemod6.c b/elf/libtracemod6.c >> new file mode 100644 >> index 0000000000..7c89c9a5a4 >> --- /dev/null >> +++ b/elf/libtracemod6.c >> @@ -0,0 +1 @@ >> +/* Empty */ > > I wonder why do you need these empty files. > > In the reproducer included in the bug report empty shared libraries > are created without any input files at all: > > $ gcc -shared -o missing/libmissing1.so -Wl,-soname,libmissing1.so > $ gcc -shared -o missing/libmissing2.so -Wl,-soname,libmissing2.so Maybe because without a file it would require more Makefile tinkering to add specific rules to build the modules. Not sure if this would really be simpler than add the files.