From: Paul Eggert <eggert@cs.ucla.edu>
To: Fangrui Song <maskray@google.com>
Cc: libc-alpha@sourceware.org
Subject: Re: [PATCH] regex: Unnest nested functions in regcomp.c
Date: Wed, 27 Oct 2021 02:35:34 -0700 [thread overview]
Message-ID: <a1322a3b-070b-a79d-23ff-fd607f5cc87b@cs.ucla.edu> (raw)
In-Reply-To: <20211027052959.2549214-1-maskray@google.com>
On 10/26/21 22:29, Fangrui Song wrote:
> collseqwc, table_size, symb_table, extra are now initialized to appease
> GCC -Werror=maybe-uninitialized false positive.
Are the diagnostics really false positives? As I understand it, the
modified code would have undefined behavior if these variables were not
initialized.
Can you comment on the efficiency of the modified code compared to the
original, when compiled with recent GCC?
next prev parent reply other threads:[~2021-10-27 9:35 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-10-27 5:29 Fangrui Song
2021-10-27 9:35 ` Paul Eggert [this message]
2021-10-27 16:10 ` Joseph Myers
2021-10-28 4:12 ` Fāng-ruì Sòng
2021-11-02 2:40 ` Carlos O'Donell
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=a1322a3b-070b-a79d-23ff-fd607f5cc87b@cs.ucla.edu \
--to=eggert@cs.ucla.edu \
--cc=libc-alpha@sourceware.org \
--cc=maskray@google.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).