From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [170.10.129.124]) by sourceware.org (Postfix) with ESMTPS id 868FE385F015 for ; Thu, 25 Aug 2022 18:52:38 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.4.1 sourceware.org 868FE385F015 Authentication-Results: sourceware.org; dmarc=pass (p=none dis=none) header.from=redhat.com Authentication-Results: sourceware.org; spf=pass smtp.mailfrom=redhat.com DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1661453558; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=HpMWNOcBYjJN5nKyaRwwguMlRiaxqN1ZxGj3xa06kWs=; b=V1UnXUqUg3kKLOzSugZzn2+LN7H+sHZnuK2CxQqXNOL7ZLztNGosq51pcot2gaIFmintyz K9GRUHXMW+5w858RKFDFWb1qG3BtLbpGZyG9PTNRhij4rITOQ3o28AZDjAYZTBE7nJNNsu pBQY0yoPUocOY/i6I6ar0+3Wdw0l/+M= Received: from mail-qv1-f71.google.com (mail-qv1-f71.google.com [209.85.219.71]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.3, cipher=TLS_AES_128_GCM_SHA256) id us-mta-255-kCSlbRUhNhWZZANziAeWHg-1; Thu, 25 Aug 2022 14:52:37 -0400 X-MC-Unique: kCSlbRUhNhWZZANziAeWHg-1 Received: by mail-qv1-f71.google.com with SMTP id o20-20020a0ccb14000000b00496d08db3beso8881386qvk.8 for ; Thu, 25 Aug 2022 11:52:37 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=content-transfer-encoding:in-reply-to:organization:from:references :to:content-language:subject:user-agent:mime-version:date:message-id :x-gm-message-state:from:to:cc; bh=HpMWNOcBYjJN5nKyaRwwguMlRiaxqN1ZxGj3xa06kWs=; b=S0uGRmKiVCxg3SubLbiF9MsrDZAmEXDqnxll+XXhgTXfo1hSxteU3rVRNC9kOp7QH6 UdasBCZF+ed5mLw627mg/VX7oRRKKRZySSjN3otMTZhHMBUnmVLXUvOmYOxyZvWiBonJ cqIRvdbFBIawpDmmH3vFLvaom9LWw2QyiRIxYw8nUZe+OvPRkmLWclRAbhkV2uyEKrau 5Wt7iwSkjhuhqYYiSdkJxjw65bnrx1YnFtDk9Cv9eMtxFRj7xBfKCJiUFX1EGXvK66qv GrgGX/dTHt6PGlULR6CcDTJsGdaDZNvq4kWuxBRG5uTDj9SBAsn4VwziVuoy8aX+GpFG LsAQ== X-Gm-Message-State: ACgBeo31WvZOK4qcgcMmlrbVQfNt3DD6HCjl/aEr2U/kOGGAvOVM8HQk sncZW7p2BrR6AOzPwZCsNjl/mTVJaNkU8YX+pfH6ncyeQSJAxmddmk8mr5xny4UrRrzJ2k5HTDe SPHouCDsR8c01ApTEiQh6 X-Received: by 2002:ac8:5b90:0:b0:344:85bd:9e79 with SMTP id a16-20020ac85b90000000b0034485bd9e79mr4879800qta.320.1661453556178; Thu, 25 Aug 2022 11:52:36 -0700 (PDT) X-Google-Smtp-Source: AA6agR58d4YEkAy/qT0K/hrv5ajNYvgvnx5EXkN7shSwjV4LeVdTpZGtz7blWM69J6n+dsFBJB2mMA== X-Received: by 2002:ac8:5b90:0:b0:344:85bd:9e79 with SMTP id a16-20020ac85b90000000b0034485bd9e79mr4879790qta.320.1661453555878; Thu, 25 Aug 2022 11:52:35 -0700 (PDT) Received: from [192.168.0.241] (192-0-145-146.cpe.teksavvy.com. [192.0.145.146]) by smtp.gmail.com with ESMTPSA id u14-20020a05620a454e00b006bb6c63114fsm173028qkp.110.2022.08.25.11.52.35 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Thu, 25 Aug 2022 11:52:35 -0700 (PDT) Message-ID: Date: Thu, 25 Aug 2022 14:52:34 -0400 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:91.0) Gecko/20100101 Thunderbird/91.11.0 Subject: Re: [PATCH] csu: Change start code license to have link exception To: Szabolcs Nagy , libc-alpha@sourceware.org References: <20220825122301.2415978-1-szabolcs.nagy@arm.com> From: Carlos O'Donell Organization: Red Hat In-Reply-To: <20220825122301.2415978-1-szabolcs.nagy@arm.com> X-Mimecast-Spam-Score: 0 X-Mimecast-Originator: redhat.com Content-Language: en-US Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 7bit X-Spam-Status: No, score=-13.2 required=5.0 tests=BAYES_00,DKIMWL_WL_HIGH,DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,GIT_PATCH_0,KAM_SHORT,NICE_REPLY_A,RCVD_IN_DNSWL_LOW,SPF_HELO_NONE,SPF_NONE,TXREP,T_SCC_BODY_TEXT_LINE autolearn=ham autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on server2.sourceware.org List-Id: On 8/25/22 08:23, Szabolcs Nagy via Libc-alpha wrote: > The start code can get linked into dynamic linked executables where > LGPL would require shipping the source or linkable binaries when the > executable is distributed. > > On some targets the license exception was missing in start.S (which > is compiled into crt1.o and Scrt1.o which may end up linked into PDE > and PIE binaries). > > I did not review what other code may end up in executables, just > fixed the start.S license inconsistency across targets. This code was always intended to be under the exception and always treated and interpreted by the maintainers as if it had the exception. I've reviewed this in my capacity as a glibc steward, and I see this as the correct change to make for these files. Please commit this to master branch. Reviewed-by: Carlos O'Donell > --- > sysdeps/aarch64/start.S | 25 +++++++++++++++++++++---- > sysdeps/arc/start.S | 19 ++++++++++++++++++- > sysdeps/loongarch/start.S | 20 ++++++++++++++++++-- > sysdeps/or1k/start.S | 22 +++++++++++++++++++--- > 4 files changed, 76 insertions(+), 10 deletions(-) > > diff --git a/sysdeps/aarch64/start.S b/sysdeps/aarch64/start.S > index 2fb52535ba..dddbdcdd06 100644 > --- a/sysdeps/aarch64/start.S > +++ b/sysdeps/aarch64/start.S > @@ -3,9 +3,26 @@ > This file is part of the GNU C Library. > > The GNU C Library is free software; you can redistribute it and/or > - modify it under the terms of the GNU Lesser General Public License as > - published by the Free Software Foundation; either version 2.1 of the > - License, or (at your option) any later version. > + modify it under the terms of the GNU Lesser General Public > + License as published by the Free Software Foundation; either > + version 2.1 of the License, or (at your option) any later version. > + > + In addition to the permissions in the GNU Lesser General Public > + License, the Free Software Foundation gives you unlimited > + permission to link the compiled version of this file with other > + programs, and to distribute those programs without any restriction > + coming from the use of this file. (The GNU Lesser General Public > + License restrictions do apply in other respects; for example, they > + cover modification of the file, and distribution when not linked > + into another program.) > + > + Note that people who make modified versions of this file are not > + obligated to grant this special exception for their modified > + versions; it is their choice whether to do so. The GNU Lesser > + General Public License gives permission to release a modified > + version without this exception; this exception also makes it > + possible to release a modified version which carries forward this > + exception. > > The GNU C Library is distributed in the hope that it will be useful, > but WITHOUT ANY WARRANTY; without even the implied warranty of > @@ -13,7 +30,7 @@ > Lesser General Public License for more details. > > You should have received a copy of the GNU Lesser General Public > - License along with the GNU C Library. If not, see > + License along with the GNU C Library; if not, see > . */ > > #include > diff --git a/sysdeps/arc/start.S b/sysdeps/arc/start.S > index bf01366973..152d6e13ed 100644 > --- a/sysdeps/arc/start.S > +++ b/sysdeps/arc/start.S > @@ -7,13 +7,30 @@ > License as published by the Free Software Foundation; either > version 2.1 of the License, or (at your option) any later version. > > + In addition to the permissions in the GNU Lesser General Public > + License, the Free Software Foundation gives you unlimited > + permission to link the compiled version of this file with other > + programs, and to distribute those programs without any restriction > + coming from the use of this file. (The GNU Lesser General Public > + License restrictions do apply in other respects; for example, they > + cover modification of the file, and distribution when not linked > + into another program.) > + > + Note that people who make modified versions of this file are not > + obligated to grant this special exception for their modified > + versions; it is their choice whether to do so. The GNU Lesser > + General Public License gives permission to release a modified > + version without this exception; this exception also makes it > + possible to release a modified version which carries forward this > + exception. > + > The GNU C Library is distributed in the hope that it will be useful, > but WITHOUT ANY WARRANTY; without even the implied warranty of > MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the GNU > Lesser General Public License for more details. > > You should have received a copy of the GNU Lesser General Public > - License along with the GNU C Library. If not, see > + License along with the GNU C Library; if not, see > . */ > > #define __ASSEMBLY__ 1 > diff --git a/sysdeps/loongarch/start.S b/sysdeps/loongarch/start.S > index bf5728b3ae..e66af16d57 100644 > --- a/sysdeps/loongarch/start.S > +++ b/sysdeps/loongarch/start.S > @@ -2,19 +2,35 @@ > Copyright (C) 2022 Free Software Foundation, Inc. > This file is part of the GNU C Library. > > - > The GNU C Library is free software; you can redistribute it and/or > modify it under the terms of the GNU Lesser General Public > License as published by the Free Software Foundation; either > version 2.1 of the License, or (at your option) any later version. > > + In addition to the permissions in the GNU Lesser General Public > + License, the Free Software Foundation gives you unlimited > + permission to link the compiled version of this file with other > + programs, and to distribute those programs without any restriction > + coming from the use of this file. (The GNU Lesser General Public > + License restrictions do apply in other respects; for example, they > + cover modification of the file, and distribution when not linked > + into another program.) > + > + Note that people who make modified versions of this file are not > + obligated to grant this special exception for their modified > + versions; it is their choice whether to do so. The GNU Lesser > + General Public License gives permission to release a modified > + version without this exception; this exception also makes it > + possible to release a modified version which carries forward this > + exception. > + > The GNU C Library is distributed in the hope that it will be useful, > but WITHOUT ANY WARRANTY; without even the implied warranty of > MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the GNU > Lesser General Public License for more details. > > You should have received a copy of the GNU Lesser General Public > - License along with the GNU C Library. If not, see > + License along with the GNU C Library; if not, see > . */ > > #define __ASSEMBLY__ 1 > diff --git a/sysdeps/or1k/start.S b/sysdeps/or1k/start.S > index 3577fc93e8..e9cc1958ad 100644 > --- a/sysdeps/or1k/start.S > +++ b/sysdeps/or1k/start.S > @@ -7,15 +7,31 @@ > License as published by the Free Software Foundation; either > version 2.1 of the License, or (at your option) any later version. > > + In addition to the permissions in the GNU Lesser General Public > + License, the Free Software Foundation gives you unlimited > + permission to link the compiled version of this file with other > + programs, and to distribute those programs without any restriction > + coming from the use of this file. (The GNU Lesser General Public > + License restrictions do apply in other respects; for example, they > + cover modification of the file, and distribution when not linked > + into another program.) > + > + Note that people who make modified versions of this file are not > + obligated to grant this special exception for their modified > + versions; it is their choice whether to do so. The GNU Lesser > + General Public License gives permission to release a modified > + version without this exception; this exception also makes it > + possible to release a modified version which carries forward this > + exception. > + > The GNU C Library is distributed in the hope that it will be useful, > but WITHOUT ANY WARRANTY; without even the implied warranty of > MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the GNU > Lesser General Public License for more details. > > You should have received a copy of the GNU Lesser General Public > - License along with the GNU C Library; if not, write to the Free > - Software Foundation, Inc., 59 Temple Place, Suite 330, Boston, MA > - 02111-1307 USA. */ > + License along with the GNU C Library; if not, see > + . */ > > /* This is the canonical entry point, usually the first thing in the text > segment. -- Cheers, Carlos.